René's URL Explorer Experiment


Title: fix(security): cap KB document download size to prevent memory-exhaustion DoS by waleedlatif1 · Pull Request #5240 · simstudioai/sim · GitHub

Open Graph Title: fix(security): cap KB document download size to prevent memory-exhaustion DoS by waleedlatif1 · Pull Request #5240 · simstudioai/sim

X Title: fix(security): cap KB document download size to prevent memory-exhaustion DoS by waleedlatif1 · Pull Request #5240 · simstudioai/sim

Description: Summary Knowledge-base document ingestion downloaded an attacker-controlled external fileUrl server-side with no byte cap: downloadFileWithTimeout → downloadFileFromUrl was called without maxBytes, which defaults to Number.MAX_SAFE_INTEGER, so the entire response body was buffered into the processing worker's memory uncapped. Any authenticated user with a KB they own could OOM the worker by pointing fileUrl at a server that streams an unbounded body (memory-exhaustion DoS, CWE-400/CWE-770). Fix: wire the documented 100MB file-size limit (MAX_FILE_SIZE, the same constant the KB upload path enforces) into the single ingestion download helper. All four KB download call sites route through it. The existing stream limiter rejects up front on an oversized Content-Length and aborts the read mid-stream once the cap is exceeded, so the body is never fully buffered. Type of Change Bug fix (security) Testing tsc clean (only pre-existing unrelated tailwind.config.ts error), biome clean, bun run check:api-validation passed. Reviewed all KB ingestion download paths (PDF page-count check, cloud-upload-for-OCR, base64-for-OCR, parseHttpFile) — all funnel through the capped helper. Notes Scoped to the reported KB ingestion vuln. The same DoS class exists in two executor callers (lib/execution/files.ts post-buffer check, executor/utils/file-tool-processor.ts no cap) plus the unbounded default in downloadFileFromUrl — tracked for a separate follow-up PR. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Knowledge-base document ingestion downloaded an attacker-controlled external fileUrl server-side with no byte cap: downloadFileWithTimeout → downloadFileFromUrl was called without maxBytes...

X Description: Summary Knowledge-base document ingestion downloaded an attacker-controlled external fileUrl server-side with no byte cap: downloadFileWithTimeout → downloadFileFromUrl was called without maxBytes...

Opengraph URL: https://github.com/simstudioai/sim/pull/5240

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3aab04ac-a592-1918-6892-6c2555908f28
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8DD2:3FAE84:B11219:F352B7:6AFB52C0
html-safe-nonce69c552bbed32ce6a030fb927678687882dc72c157b891ee40d4f599f9583454e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4REQyOjNGQUU4NDpCMTEyMTk6RjM1MkI3OjZBRkI1MkMwIiwidmlzaXRvcl9pZCI6IjQ2MTI5OTEzMDgwMjgxMzgxNzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3ee00f248b0280c6197b819fe38c15e2a920559c46d428eb01c7f2e7ea6a629b
hovercard-subject-tagpull_request:3948673586
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5240/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Knowledge-base document ingestion downloaded an attacker-controlled external fileUrl server-side with no byte cap: downloadFileWithTimeout → downloadFileFromUrl was called without maxBytes...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5240/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5240%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5240%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5240/files
Reloadhttps://github.com/simstudioai/sim/pull/5240/files
Reloadhttps://github.com/simstudioai/sim/pull/5240/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
worktree-kb-download-maxbyteshttps://github.com/simstudioai/sim/tree/worktree-kb-download-maxbytes
Conversation 3 https://github.com/simstudioai/sim/pull/5240
Commits 1 https://github.com/simstudioai/sim/pull/5240/commits
Checks 15 https://github.com/simstudioai/sim/pull/5240/checks
Files changed https://github.com/simstudioai/sim/pull/5240/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5240/files
fix(security): cap KB document download size to prevent memory-exhaustion DoS https://github.com/simstudioai/sim/pull/5240/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/5240/files
6d1237a fix(security): cap KB document download size to prevent memory-exhaus… waleedlatif1 Jun 27, 2026 https://github.com/simstudioai/sim/pull/5240/commits/6d1237aac3903686e8c8f55b108b1665757c0f25
Clear filters https://github.com/simstudioai/sim/pull/5240/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5240/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5240/files
apps/sim/lib/knowledge/documents/document-processor.tshttps://github.com/simstudioai/sim/pull/5240/files#diff-caef18c7f5680f8ad0ec1e40b90e7635fe8f182b55d4fd20ef78fbe881f11205
View file https://github.com/simstudioai/sim/blob/6d1237aac3903686e8c8f55b108b1665757c0f25/apps/sim/lib/knowledge/documents/document-processor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5240/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5240/files#diff-caef18c7f5680f8ad0ec1e40b90e7635fe8f182b55d4fd20ef78fbe881f11205
https://github.com/simstudioai/sim/pull/5240/files#diff-caef18c7f5680f8ad0ec1e40b90e7635fe8f182b55d4fd20ef78fbe881f11205
https://github.com/simstudioai/sim/pull/5240/files#diff-caef18c7f5680f8ad0ec1e40b90e7635fe8f182b55d4fd20ef78fbe881f11205
https://github.com/simstudioai/sim/pull/5240/files#diff-caef18c7f5680f8ad0ec1e40b90e7635fe8f182b55d4fd20ef78fbe881f11205
Please reload this pagehttps://github.com/simstudioai/sim/pull/5240/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.