René's URL Explorer Experiment


Title: fix(connectors): harden Zendesk connector against SSRF by waleedlatif1 · Pull Request #5237 · simstudioai/sim · GitHub

Open Graph Title: fix(connectors): harden Zendesk connector against SSRF by waleedlatif1 · Pull Request #5237 · simstudioai/sim

X Title: fix(connectors): harden Zendesk connector against SSRF by waleedlatif1 · Pull Request #5237 · simstudioai/sim

Description: Summary The Zendesk knowledge connector built its base URL from a fully user-controlled subdomain and fetched it with the plain fetchWithRetry wrapper, which performs no SSRF validation and follows redirects by default. An authenticated user could coerce the backend into issuing arbitrary outbound requests (and chain an open redirect toward internal/link-local targets). Routed the connector through the existing SSRF-safe secureFetchWithRetry (DNS-resolve + IP-pin + per-redirect revalidation), matching the GitLab/Sentry/Obsidian/S3 connectors. Added strict subdomain validation: subdomain is normalized and checked against a single DNS-label pattern before interpolation, so it can't smuggle a scheme, host, path, port, or fragment into the base URL. Added unit tests covering both legitimate subdomains and rejected SSRF payloads. Type of Change Bug fix (security) Testing bunx vitest run connectors/zendesk/zendesk.test.ts — 24 passing (7 legitimate-request cases, 17 SSRF-payload rejections) Typecheck and biome clean Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The Zendesk knowledge connector built its base URL from a fully user-controlled subdomain and fetched it with the plain fetchWithRetry wrapper, which performs no SSRF validation and follow...

X Description: Summary The Zendesk knowledge connector built its base URL from a fully user-controlled subdomain and fetched it with the plain fetchWithRetry wrapper, which performs no SSRF validation and follow...

Opengraph URL: https://github.com/simstudioai/sim/pull/5237

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:19ca4d63-cf5a-52a0-5842-57c15b1abd87
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9EC4:870C9:92EF2D:D067D6:6AFB5136
html-safe-nonceb4b44dc37baa60f9c20d057b749a640959585e80dc2f3d639ad14136555415c4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUM0Ojg3MEM5OjkyRUYyRDpEMDY3RDY6NkFGQjUxMzYiLCJ2aXNpdG9yX2lkIjoiNTMwMzk0ODQ1ODE0OTQ5OTE5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf665ab2b2e6ad2445ae2cef90917b97e15881ee6dbb22bd265a3d3e9f4647b61
hovercard-subject-tagpull_request:3948622790
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5237/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The Zendesk knowledge connector built its base URL from a fully user-controlled subdomain and fetched it with the plain fetchWithRetry wrapper, which performs no SSRF validation and follow...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5237/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5237%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5237%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5237/files
Reloadhttps://github.com/simstudioai/sim/pull/5237/files
Reloadhttps://github.com/simstudioai/sim/pull/5237/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
staging-work-3c6c6b1515https://github.com/simstudioai/sim/tree/staging-work-3c6c6b1515
Conversation 7 https://github.com/simstudioai/sim/pull/5237
Commits 2 https://github.com/simstudioai/sim/pull/5237/commits
Checks 15 https://github.com/simstudioai/sim/pull/5237/checks
Files changed https://github.com/simstudioai/sim/pull/5237/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5237/files
fix(connectors): harden Zendesk connector against SSRF https://github.com/simstudioai/sim/pull/5237/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/5237/files
46401b8 fix(connectors): harden Zendesk connector against SSRF waleedlatif1 Jun 27, 2026 https://github.com/simstudioai/sim/pull/5237/commits/46401b8fd28cd92370e3a740f48356db28ecd344
19e6c6c fix(connectors): retry transient DNS failures in secureFetchWithRetry waleedlatif1 Jun 27, 2026 https://github.com/simstudioai/sim/pull/5237/commits/19e6c6cc175674d62d92f65dddab8aba0e9ab5fc
Clear filters https://github.com/simstudioai/sim/pull/5237/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5237/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5237/files
zendesk.test.ts https://github.com/simstudioai/sim/pull/5237/files#diff-6311671622e961d2bede3c5dc07d873fa4c2d85d2236503f2fe794473fe68d15
zendesk.ts https://github.com/simstudioai/sim/pull/5237/files#diff-706627a7bb9b2c01d4a799135b75af53a2231449abd5b5e9bb1b55ecde3e9e7e
utils.test.ts https://github.com/simstudioai/sim/pull/5237/files#diff-9c304be25623200be4e947db1907c03c79b289adaf4cb34e57b7c80d2aae5b0b
utils.ts https://github.com/simstudioai/sim/pull/5237/files#diff-94a5318c859361a50ad73b5ea07e35e594a315dd6be5288b97489301c434addb
apps/sim/connectors/zendesk/zendesk.test.tshttps://github.com/simstudioai/sim/pull/5237/files#diff-6311671622e961d2bede3c5dc07d873fa4c2d85d2236503f2fe794473fe68d15
View file https://github.com/simstudioai/sim/blob/19e6c6cc175674d62d92f65dddab8aba0e9ab5fc/apps/sim/connectors/zendesk/zendesk.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5237/{{ revealButtonHref }}
apps/sim/connectors/zendesk/zendesk.tshttps://github.com/simstudioai/sim/pull/5237/files#diff-706627a7bb9b2c01d4a799135b75af53a2231449abd5b5e9bb1b55ecde3e9e7e
View file https://github.com/simstudioai/sim/blob/19e6c6cc175674d62d92f65dddab8aba0e9ab5fc/apps/sim/connectors/zendesk/zendesk.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5237/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5237/files#diff-706627a7bb9b2c01d4a799135b75af53a2231449abd5b5e9bb1b55ecde3e9e7e
https://github.com/simstudioai/sim/pull/5237/files#diff-706627a7bb9b2c01d4a799135b75af53a2231449abd5b5e9bb1b55ecde3e9e7e
https://github.com/simstudioai/sim/pull/5237/files#diff-706627a7bb9b2c01d4a799135b75af53a2231449abd5b5e9bb1b55ecde3e9e7e
Please reload this pagehttps://github.com/simstudioai/sim/pull/5237/files
https://github.com/simstudioai/sim/pull/5237/files#diff-706627a7bb9b2c01d4a799135b75af53a2231449abd5b5e9bb1b55ecde3e9e7e
apps/sim/lib/knowledge/documents/utils.test.tshttps://github.com/simstudioai/sim/pull/5237/files#diff-9c304be25623200be4e947db1907c03c79b289adaf4cb34e57b7c80d2aae5b0b
View file https://github.com/simstudioai/sim/blob/19e6c6cc175674d62d92f65dddab8aba0e9ab5fc/apps/sim/lib/knowledge/documents/utils.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5237/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5237/files#diff-9c304be25623200be4e947db1907c03c79b289adaf4cb34e57b7c80d2aae5b0b
https://github.com/simstudioai/sim/pull/5237/files#diff-9c304be25623200be4e947db1907c03c79b289adaf4cb34e57b7c80d2aae5b0b
https://github.com/simstudioai/sim/pull/5237/files#diff-9c304be25623200be4e947db1907c03c79b289adaf4cb34e57b7c80d2aae5b0b
https://github.com/simstudioai/sim/pull/5237/files#diff-9c304be25623200be4e947db1907c03c79b289adaf4cb34e57b7c80d2aae5b0b
apps/sim/lib/knowledge/documents/utils.tshttps://github.com/simstudioai/sim/pull/5237/files#diff-94a5318c859361a50ad73b5ea07e35e594a315dd6be5288b97489301c434addb
View file https://github.com/simstudioai/sim/blob/19e6c6cc175674d62d92f65dddab8aba0e9ab5fc/apps/sim/lib/knowledge/documents/utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5237/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5237/files#diff-94a5318c859361a50ad73b5ea07e35e594a315dd6be5288b97489301c434addb
https://github.com/simstudioai/sim/pull/5237/files#diff-94a5318c859361a50ad73b5ea07e35e594a315dd6be5288b97489301c434addb
Please reload this pagehttps://github.com/simstudioai/sim/pull/5237/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.