René's URL Explorer Experiment


Title: fix(copilot): strip hosted apiKey on type-less edit ops + guard hosting.enabled by TheodoreSpeaks · Pull Request #5220 · simstudioai/sim · GitHub

Open Graph Title: fix(copilot): strip hosted apiKey on type-less edit ops + guard hosting.enabled by TheodoreSpeaks · Pull Request #5220 · simstudioai/sim

X Title: fix(copilot): strip hosted apiKey on type-less edit ops + guard hosting.enabled by TheodoreSpeaks · Pull Request #5220 · simstudioai/sim

Description: Summary Follow-up to #5217. That PR stripped copilot-authored platform-managed apiKey on hosted-tool blocks, but only for ops that restate type — so a type-less edit op slipped through. Verified live on staging via [trace 84d38867…]: prompted with "directly set apiKey for the makeVideo block", the agent issued { params: { inputs: { apiKey: "test-api-key-12345" } }, operation_type: "edit" } (no type). preValidateCredentialInputs gates the whole strip path (both the model and tool paths) on op.params.type, so the op was skipped and the key persisted — re-disabling hosted-key injection. Resolve the block type from workflowState when the op omits type, so type-less edits run through the strip (also closes the same latent gap in the original hosted-LLM-model strip). Guard tool.hosting.enabled() in try/catch, matching the existing guard on the tool selector, so a throwing predicate can't break edit_workflow. Regression test mirroring the observed failure (edit op with only apiKey; type + provider resolved from workflow state). Known remaining gap (lower-likelihood, not addressed here): nested edit ops inside a loop/parallel don't get workflow-state enrichment, so a nested type/provider-less edit could still slip through. Type of Change Bug fix Testing vitest on validation.test.ts: 57 passed (added type-less-edit regression case) bun run lint:check: clean bun run check:api-validation:strict: passed tsc --noEmit: clean Runtime wiring confirmed: edit-workflow/index.ts passes workflowState to preValidateCredentialInputs Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-up to #5217. That PR stripped copilot-authored platform-managed apiKey on hosted-tool blocks, but only for ops that restate type — so a type-less edit op slipped through. Verified li...

X Description: Summary Follow-up to #5217. That PR stripped copilot-authored platform-managed apiKey on hosted-tool blocks, but only for ops that restate type — so a type-less edit op slipped through. Verified li...

Opengraph URL: https://github.com/simstudioai/sim/pull/5220

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d61ef388-8606-7219-2914-666af2504ed8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE980:87884:5FF1D4:89495D:6AFB3E98
html-safe-noncefaf91be5257c954c66eca04de5cd455800922f4520b6842e52adc153e1f5a20d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTgwOjg3ODg0OjVGRjFENDo4OTQ5NUQ6NkFGQjNFOTgiLCJ2aXNpdG9yX2lkIjoiNjM5ODUxNTc1NTUzMDYxMzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacab0d90519e241dd71c81eef309cb162ff0f66c1e4de9b6bd10dbd63453c4d755
hovercard-subject-tagpull_request:3939221538
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5220/files
twitter:imagehttps://avatars.githubusercontent.com/u/19564703?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/19564703?s=400&v=4
og:image:altSummary Follow-up to #5217. That PR stripped copilot-authored platform-managed apiKey on hosted-tool blocks, but only for ops that restate type — so a type-less edit op slipped through. Verified li...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2169b0dfbef67ed6b128074a5ed45bb7d5d1859783b10178b09a7765ad5f3693
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b4fc8df5ef1c6757e733a23e6b81b6725021823
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5220/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5220%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5220%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5220/files
Reloadhttps://github.com/simstudioai/sim/pull/5220/files
Reloadhttps://github.com/simstudioai/sim/pull/5220/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests202 (202)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
TheodoreSpeakshttps://github.com/TheodoreSpeaks
staginghttps://github.com/simstudioai/sim/tree/staging
fix/hosted-apikey-typeless-edithttps://github.com/simstudioai/sim/tree/fix/hosted-apikey-typeless-edit
Conversation 26 https://github.com/simstudioai/sim/pull/5220
Commits 8 https://github.com/simstudioai/sim/pull/5220/commits
Checks 15 https://github.com/simstudioai/sim/pull/5220/checks
Files changed https://github.com/simstudioai/sim/pull/5220/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5220/files
fix(copilot): strip hosted apiKey on type-less edit ops + guard hosting.enabled https://github.com/simstudioai/sim/pull/5220/files#top
Show all changes 8 commits https://github.com/simstudioai/sim/pull/5220/files
182be13 fix(copilot): strip hosted apiKey on type-less edit ops + guard hosti… TheodoreSpeaks Jun 26, 2026 https://github.com/simstudioai/sim/pull/5220/commits/182be13f6fe619406adb8d659d8b931570d0dbcd
e3d405b improvement(copilot): consolidate hosted-apiKey workflowState reads, … TheodoreSpeaks Jun 26, 2026 https://github.com/simstudioai/sim/pull/5220/commits/e3d405b34b7a2abbc06963c250a0e8420804924e
71683d0 fix(copilot): resolve hosted-key strip against same-batch state; stri… TheodoreSpeaks Jun 26, 2026 https://github.com/simstudioai/sim/pull/5220/commits/71683d0a58c94515e2171f4efaffbf16c080878c
8ae1f80 fix(copilot): unify hosted-key strip resolution across top-level and … TheodoreSpeaks Jun 26, 2026 https://github.com/simstudioai/sim/pull/5220/commits/8ae1f8017da27e3023fca2bdebc4f042ef3bd8bb
c386129 fix(copilot): recurse nestedNodes so grandchild hosted keys are stripped TheodoreSpeaks Jun 26, 2026 https://github.com/simstudioai/sim/pull/5220/commits/c386129ea16ccd118a72e88a90e86228ac93654f
2eb8416 fix(copilot): decide hosted-key strip against final batch state (two-… TheodoreSpeaks Jun 26, 2026 https://github.com/simstudioai/sim/pull/5220/commits/2eb8416095b899be6cdacc7f9e173adc48c9a43a
1a01720 fix(copilot): tool selector throw falls back to access tools (fail to… TheodoreSpeaks Jun 26, 2026 https://github.com/simstudioai/sim/pull/5220/commits/1a01720fa83a794083b60f4717d108e5834a43b7
84ddf57 fix(copilot): only fold registry-known types into final batch state TheodoreSpeaks Jun 26, 2026 https://github.com/simstudioai/sim/pull/5220/commits/84ddf57ccfc126d37c859d2bad447da52b384a06
Clear filters https://github.com/simstudioai/sim/pull/5220/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5220/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5220/files
validation.test.ts https://github.com/simstudioai/sim/pull/5220/files#diff-54c556a73b7bd0ef03b1d9df5efb4f247c538ff096e4c9e6b34e9ca776448d14
validation.ts https://github.com/simstudioai/sim/pull/5220/files#diff-753050dbc53f3f03e6f9613d15f09b0bd3efd0f606e8465a85a5fe84f866a9b8
apps/sim/lib/copilot/tools/server/workflow/edit-workflow/validation.test.tshttps://github.com/simstudioai/sim/pull/5220/files#diff-54c556a73b7bd0ef03b1d9df5efb4f247c538ff096e4c9e6b34e9ca776448d14
View file https://github.com/simstudioai/sim/blob/84ddf57ccfc126d37c859d2bad447da52b384a06/apps/sim/lib/copilot/tools/server/workflow/edit-workflow/validation.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5220/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5220/files#diff-54c556a73b7bd0ef03b1d9df5efb4f247c538ff096e4c9e6b34e9ca776448d14
https://github.com/simstudioai/sim/pull/5220/files#diff-54c556a73b7bd0ef03b1d9df5efb4f247c538ff096e4c9e6b34e9ca776448d14
https://github.com/simstudioai/sim/pull/5220/files#diff-54c556a73b7bd0ef03b1d9df5efb4f247c538ff096e4c9e6b34e9ca776448d14
https://github.com/simstudioai/sim/pull/5220/files#diff-54c556a73b7bd0ef03b1d9df5efb4f247c538ff096e4c9e6b34e9ca776448d14
https://github.com/simstudioai/sim/pull/5220/files#diff-54c556a73b7bd0ef03b1d9df5efb4f247c538ff096e4c9e6b34e9ca776448d14
https://github.com/simstudioai/sim/pull/5220/files#diff-54c556a73b7bd0ef03b1d9df5efb4f247c538ff096e4c9e6b34e9ca776448d14
https://github.com/simstudioai/sim/pull/5220/files#diff-54c556a73b7bd0ef03b1d9df5efb4f247c538ff096e4c9e6b34e9ca776448d14
https://github.com/simstudioai/sim/pull/5220/files#diff-54c556a73b7bd0ef03b1d9df5efb4f247c538ff096e4c9e6b34e9ca776448d14
Please reload this pagehttps://github.com/simstudioai/sim/pull/5220/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5220/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.