Title: fix(trigger): mark cpu-features external to fix deploy build by TheodoreSpeaks · Pull Request #5185 · simstudioai/sim · GitHub
Open Graph Title: fix(trigger): mark cpu-features external to fix deploy build by TheodoreSpeaks · Pull Request #5185 · simstudioai/sim
X Title: fix(trigger): mark cpu-features external to fix deploy build by TheodoreSpeaks · Pull Request #5185 · simstudioai/sim
Description: Summary Trigger.dev deploy build was failing: Could not resolve "../build/Release/cpufeatures.node" from cpu-features/lib/index.js. Root cause: ssh2 became reachable from the trigger background bundle via the Pi local SSH backend (#5178 wired executor/handlers/pi/ssh-tools.ts → app/api/tools/ssh/utils → ssh2). ssh2 was previously only used in API routes, which the trigger build never bundles. esbuild then tried to bundle ssh2's optional native dep cpu-features and choked on the missing compiled .node binary. Fix: add cpu-features to build.external in trigger.config.ts. ssh2 requires it inside a try/catch purely as a crypto-acceleration optimization, so externalizing it has no runtime impact. Type of Change Bug fix Testing Verified locally with trigger.dev deploy --dry-run --local-build → "Successfully built code" (build failed on the same step without the change). Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Trigger.dev deploy build was failing: Could not resolve "../build/Release/cpufeatures.node" from cpu-features/lib/index.js. Root cause: ssh2 became reachable from the trigger bac...
X Description: Summary Trigger.dev deploy build was failing: Could not resolve "../build/Release/cpufeatures.node" from cpu-features/lib/index.js. Root cause: ssh2 became reachable from the tri...
Opengraph URL: https://github.com/simstudioai/sim/pull/5185
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:fcc0c2d1-e9db-023b-6ab6-138732997df6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 83EA:15DE28:3B383:527A0:6AFB43F4 |
| html-safe-nonce | 744caf2adfbd6ed4c2d96132e90e08b9064e0bde9890018333b3eda05d2e6429 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4M0VBOjE1REUyODozQjM4Mzo1MjdBMDo2QUZCNDNGNCIsInZpc2l0b3JfaWQiOiI2Njc4NjM5MTM0NTAxNDU0ODM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 73914e9f134dc57d959a9cd52235ce60c15cdf2fbccd4cae16050132b348a855 |
| hovercard-subject-tag | pull_request:3921874503 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5185/files |
| twitter:image | https://avatars.githubusercontent.com/u/19564703?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/19564703?s=400&v=4 |
| og:image:alt | Summary Trigger.dev deploy build was failing: Could not resolve "../build/Release/cpufeatures.node" from cpu-features/lib/index.js. Root cause: ssh2 became reachable from the trigger bac... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | d849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a6c2f87cbcb6414452377b4967858ed6a66f1109 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width