René's URL Explorer Experiment


Title: improvement(auth): make Microsoft emailVerified derivation total by waleedlatif1 · Pull Request #5157 · simstudioai/sim · GitHub

Open Graph Title: improvement(auth): make Microsoft emailVerified derivation total by waleedlatif1 · Pull Request #5157 · simstudioai/sim

X Title: improvement(auth): make Microsoft emailVerified derivation total by waleedlatif1 · Pull Request #5157 · simstudioai/sim

Description: Summary Follow-up hardening to the nOAuth account-linking fix (#5156, already merged). deriveMicrosoftEmailVerified cast the verified-email claims to string[] and called .includes via optional chaining, which only guards null/undefined. If a claim ever arrived as a non-array, non-string value (e.g. a number or object), .includes would throw and fail the OAuth getUserInfo flow. Replaced the unchecked as string[] cast with proper Array.isArray guards, so any claim shape resolves to unverified instead of throwing. No behavior change for real Microsoft tokens — purely defensive robustness on a security-relevant helper. Type of Change Improvement Testing Extended microsoft.test.ts with non-array claim shapes (string, number, object, null) asserting no throw + unverified. bunx vitest run lib/oauth/microsoft.test.ts — 11 passing. bunx tsc --noEmit — 0 errors. bun run lint — clean. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-up hardening to the nOAuth account-linking fix (#5156, already merged). deriveMicrosoftEmailVerified cast the verified-email claims to string[] and called .includes via optional cha...

X Description: Summary Follow-up hardening to the nOAuth account-linking fix (#5156, already merged). deriveMicrosoftEmailVerified cast the verified-email claims to string[] and called .includes via optional cha...

Opengraph URL: https://github.com/simstudioai/sim/pull/5157

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e49c02c5-f3fb-11c2-32f5-8dc27b4b425e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB564:2C34A2:26FBE3:36A0B7:6AFB5274
html-safe-nonceaa8d517547b148c5fa3530fc4e7b93c4590700e80d9bd25842b02c450f243a8c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTY0OjJDMzRBMjoyNkZCRTM6MzZBMEI3OjZBRkI1Mjc0IiwidmlzaXRvcl9pZCI6Ijg1OTQ0MTQ1OTI1NzY5MzQ1MTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca70a9ed0b86030dd14ed3c43b16f4ff2f8e68ce8c7593821a458f2bdee4ccb10
hovercard-subject-tagpull_request:3905167139
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5157/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up hardening to the nOAuth account-linking fix (#5156, already merged). deriveMicrosoftEmailVerified cast the verified-email claims to string[] and called .includes via optional cha...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5157/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5157%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5157%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5157/files
Reloadhttps://github.com/simstudioai/sim/pull/5157/files
Reloadhttps://github.com/simstudioai/sim/pull/5157/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/microsoft-emailverified-totalhttps://github.com/simstudioai/sim/tree/fix/microsoft-emailverified-total
Conversation 9 https://github.com/simstudioai/sim/pull/5157
Commits 2 https://github.com/simstudioai/sim/pull/5157/commits
Checks 15 https://github.com/simstudioai/sim/pull/5157/checks
Files changed https://github.com/simstudioai/sim/pull/5157/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5157/files
improvement(auth): make Microsoft emailVerified derivation total https://github.com/simstudioai/sim/pull/5157/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/5157/files
ac8b583 improvement(auth): make Microsoft emailVerified derivation total waleedlatif1 Jun 20, 2026 https://github.com/simstudioai/sim/pull/5157/commits/ac8b583c9329f97ea46664cdc8a4b7262d9efeab
035b81f test(auth): lock in unverified for a string verified-email claim waleedlatif1 Jun 20, 2026 https://github.com/simstudioai/sim/pull/5157/commits/035b81fa1a08a9d16587c61a9b3992911f938118
Clear filters https://github.com/simstudioai/sim/pull/5157/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5157/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5157/files
microsoft.test.ts https://github.com/simstudioai/sim/pull/5157/files#diff-15c9038adb7239c0337670a13378ed1f588822376fcb23562bbfc010ea0bf310
microsoft.ts https://github.com/simstudioai/sim/pull/5157/files#diff-dcebc020f7a8c296fa0da4371ee554d7a75a1483e9978c4250a7185018f736c6
apps/sim/lib/oauth/microsoft.test.tshttps://github.com/simstudioai/sim/pull/5157/files#diff-15c9038adb7239c0337670a13378ed1f588822376fcb23562bbfc010ea0bf310
View file https://github.com/simstudioai/sim/blob/035b81fa1a08a9d16587c61a9b3992911f938118/apps/sim/lib/oauth/microsoft.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5157/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5157/files#diff-15c9038adb7239c0337670a13378ed1f588822376fcb23562bbfc010ea0bf310
Please reload this pagehttps://github.com/simstudioai/sim/pull/5157/files
https://github.com/simstudioai/sim/pull/5157/files#diff-15c9038adb7239c0337670a13378ed1f588822376fcb23562bbfc010ea0bf310
apps/sim/lib/oauth/microsoft.tshttps://github.com/simstudioai/sim/pull/5157/files#diff-dcebc020f7a8c296fa0da4371ee554d7a75a1483e9978c4250a7185018f736c6
View file https://github.com/simstudioai/sim/blob/035b81fa1a08a9d16587c61a9b3992911f938118/apps/sim/lib/oauth/microsoft.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5157/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5157/files#diff-dcebc020f7a8c296fa0da4371ee554d7a75a1483e9978c4250a7185018f736c6
Please reload this pagehttps://github.com/simstudioai/sim/pull/5157/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.