René's URL Explorer Experiment


Title: fix(auth): close nOAuth account takeover via email-based OAuth linking by waleedlatif1 · Pull Request #5156 · simstudioai/sim · GitHub

Open Graph Title: fix(auth): close nOAuth account takeover via email-based OAuth linking by waleedlatif1 · Pull Request #5156 · simstudioai/sim

X Title: fix(auth): close nOAuth account takeover via email-based OAuth linking by waleedlatif1 · Pull Request #5156 · simstudioai/sim

Description: Summary Hardens OAuth account-linking so integration connectors can't be used as sign-in methods. Better Auth registers every generic-OAuth connector (microsoft-ad, salesforce, jira, and the rest) as a social provider, which made them reachable through POST /api/auth/sign-in/oauth2 and POST /api/auth/sign-in/social. Combined with trustedProviders + requireLocalEmailVerified: false, an OAuth login whose email matched an existing account could auto-link to it — undesirable for connectors that authenticate against multi-tenant IdPs where the email claim isn't a proof of ownership. Chokepoint: restrict the sign-in endpoints (/sign-in/social, /sign-in/oauth2) to a first-party login allowlist (google, github, microsoft). Connectors are now only connectable through the authenticated /oauth2/link flow, which binds to the current session user and never mints a session. Trust scope: trim trustedProviders to providers that verify email ownership (google, github, email-password, SSO). microsoft is dropped from the trusted set since it authenticates against the multi-tenant /common/ endpoint — unverified emails no longer auto-link, while verified Microsoft sign-in still links and new signups still work. Defense in depth: stop hardcoding emailVerified: true; honor the real verification claims for the Microsoft id-token connectors and Salesforce. Type of Change Bug fix Testing Added apps/sim/lib/auth/constants.test.ts covering the sign-in provider allowlist. bunx vitest run lib/auth/ — 43 passing. bunx tsc --noEmit — 0 errors. bun run check:api-validation — passing. bun run lint — clean. Verified the legitimate flows stay intact: google/github/microsoft login, email + SSO sign-in (separate endpoints, ungated), and integration connect via /oauth2/link (uses the link callback branch, which doesn't consult trustedProviders/emailVerified). Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Hardens OAuth account-linking so integration connectors can't be used as sign-in methods. Better Auth registers every generic-OAuth connector (microsoft-ad, salesforce, jira, and the r...

X Description: Summary Hardens OAuth account-linking so integration connectors can't be used as sign-in methods. Better Auth registers every generic-OAuth connector (microsoft-ad, salesforce, jira, and t...

Opengraph URL: https://github.com/simstudioai/sim/pull/5156

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:979f09d0-16a2-fc13-285f-0de2dc82356e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB488:2C34A2:2648CF:359D8C:6AFB5240
html-safe-nonce455353c031ea028748fe2d8edfd285e41f8f1b1adf76916733ed37ab28e77531
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDg4OjJDMzRBMjoyNjQ4Q0Y6MzU5RDhDOjZBRkI1MjQwIiwidmlzaXRvcl9pZCI6IjQ5MDE3NzU5MDY3NTk3MjU2MzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac244e2d7c8c1172f04c97eb1d7561463ba46ced9473956ad9811b94ba3f4d3905
hovercard-subject-tagpull_request:3905084406
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5156/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Hardens OAuth account-linking so integration connectors can't be used as sign-in methods. Better Auth registers every generic-OAuth connector (microsoft-ad, salesforce, jira, and the r...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5156/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5156%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5156%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5156/files
Reloadhttps://github.com/simstudioai/sim/pull/5156/files
Reloadhttps://github.com/simstudioai/sim/pull/5156/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
worktree-fix+noauth-account-linkinghttps://github.com/simstudioai/sim/tree/worktree-fix%2Bnoauth-account-linking
Conversation 10 https://github.com/simstudioai/sim/pull/5156
Commits 3 https://github.com/simstudioai/sim/pull/5156/commits
Checks 15 https://github.com/simstudioai/sim/pull/5156/checks
Files changed https://github.com/simstudioai/sim/pull/5156/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5156/files
fix(auth): close nOAuth account takeover via email-based OAuth linking https://github.com/simstudioai/sim/pull/5156/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/5156/files
d6c816d fix(auth): close nOAuth account takeover via email-based OAuth linking waleedlatif1 Jun 20, 2026 https://github.com/simstudioai/sim/pull/5156/commits/d6c816d9054c88863c2733ead7470af942188287
82a1d17 test(auth): cover Microsoft id-token emailVerified derivation waleedlatif1 Jun 20, 2026 https://github.com/simstudioai/sim/pull/5156/commits/82a1d17fe3a43da91efda5c6dad331832292058b
dc5cf93 fix(auth): check the provider field the sign-in handler actually uses waleedlatif1 Jun 20, 2026 https://github.com/simstudioai/sim/pull/5156/commits/dc5cf93ac865edc237eda910b3386f79771f0e91
Clear filters https://github.com/simstudioai/sim/pull/5156/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5156/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5156/files
auth.ts https://github.com/simstudioai/sim/pull/5156/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
constants.test.ts https://github.com/simstudioai/sim/pull/5156/files#diff-3b734f133ee12cc2f7b1549ce5a7364b2769f269e24715eca7c7e9fd5ffbc35e
constants.ts https://github.com/simstudioai/sim/pull/5156/files#diff-389891c87e220468c74927655483f910e0724387899fb316f05a5be1fd1bace2
microsoft.test.ts https://github.com/simstudioai/sim/pull/5156/files#diff-15c9038adb7239c0337670a13378ed1f588822376fcb23562bbfc010ea0bf310
microsoft.ts https://github.com/simstudioai/sim/pull/5156/files#diff-dcebc020f7a8c296fa0da4371ee554d7a75a1483e9978c4250a7185018f736c6
apps/sim/lib/auth/auth.tshttps://github.com/simstudioai/sim/pull/5156/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
View file https://github.com/simstudioai/sim/blob/dc5cf93ac865edc237eda910b3386f79771f0e91/apps/sim/lib/auth/auth.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5156/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5156/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/5156/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/5156/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/5156/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/5156/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/5156/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/5156/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
Please reload this pagehttps://github.com/simstudioai/sim/pull/5156/files
https://github.com/simstudioai/sim/pull/5156/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/5156/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/5156/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
apps/sim/lib/auth/constants.test.tshttps://github.com/simstudioai/sim/pull/5156/files#diff-3b734f133ee12cc2f7b1549ce5a7364b2769f269e24715eca7c7e9fd5ffbc35e
View file https://github.com/simstudioai/sim/blob/dc5cf93ac865edc237eda910b3386f79771f0e91/apps/sim/lib/auth/constants.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5156/{{ revealButtonHref }}
apps/sim/lib/auth/constants.tshttps://github.com/simstudioai/sim/pull/5156/files#diff-389891c87e220468c74927655483f910e0724387899fb316f05a5be1fd1bace2
View file https://github.com/simstudioai/sim/blob/dc5cf93ac865edc237eda910b3386f79771f0e91/apps/sim/lib/auth/constants.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5156/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5156/files#diff-389891c87e220468c74927655483f910e0724387899fb316f05a5be1fd1bace2
apps/sim/lib/oauth/microsoft.test.tshttps://github.com/simstudioai/sim/pull/5156/files#diff-15c9038adb7239c0337670a13378ed1f588822376fcb23562bbfc010ea0bf310
View file https://github.com/simstudioai/sim/blob/dc5cf93ac865edc237eda910b3386f79771f0e91/apps/sim/lib/oauth/microsoft.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5156/{{ revealButtonHref }}
apps/sim/lib/oauth/microsoft.tshttps://github.com/simstudioai/sim/pull/5156/files#diff-dcebc020f7a8c296fa0da4371ee554d7a75a1483e9978c4250a7185018f736c6
View file https://github.com/simstudioai/sim/blob/dc5cf93ac865edc237eda910b3386f79771f0e91/apps/sim/lib/oauth/microsoft.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5156/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5156/files#diff-dcebc020f7a8c296fa0da4371ee554d7a75a1483e9978c4250a7185018f736c6
Please reload this pagehttps://github.com/simstudioai/sim/pull/5156/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.