René's URL Explorer Experiment


Title: fix(uploads): close multipart storage-quota bypass via quota-exempt contexts by waleedlatif1 · Pull Request #5155 · simstudioai/sim · GitHub

Open Graph Title: fix(uploads): close multipart storage-quota bypass via quota-exempt contexts by waleedlatif1 · Pull Request #5155 · simstudioai/sim

X Title: fix(uploads): close multipart storage-quota bypass via quota-exempt contexts by waleedlatif1 · Pull Request #5155 · simstudioai/sim

Description: Summary The multipart upload endpoint (POST /api/files/multipart) accepted the quota-exempt public-asset contexts og-images, profile-pictures, and workspace-logos, which skip checkStorageQuota. Any authenticated writer — including a free-tier account — could open arbitrarily large upload sessions (100 GB+ confirmed) that never counted against their plan limit, causing unbounded untracked storage cost (CWE-770). Fix: remove those three contexts from ALLOWED_UPLOAD_CONTEXTS (joining logs), so every context the multipart endpoint serves is quota-enforced. The bypass is now structurally impossible. Why this is the right (and backwards-compatible) fix These contexts have no legitimate multipart flow: their client hooks hard-cap uploads at 5 MB (image-only), and the direct-upload strategy only switches to multipart above 50 MB — so they always route through the single-part presigned endpoint (which already enforces admin/image-type policy). og-images has neither a client nor a server multipart write path. No change to workspace / mothership / knowledge-base / chat / copilot / execution behavior; workspace/mothership keep their existing MAX_WORKSPACE_FILE_SIZE cap. Type of Change Bug fix (security) Testing Updated route.test.ts: every quota-exempt context (og-images, profile-pictures, workspace-logos, logs) now returns 400 Invalid storage context before any session/quota call; quota-enforced contexts still pass the quota check and initiate. bunx tsc --noEmit — 0 errors; vitest multipart suite — 11/11 pass; bun run check:api-validation — passes. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The multipart upload endpoint (POST /api/files/multipart) accepted the quota-exempt public-asset contexts og-images, profile-pictures, and workspace-logos, which skip checkStorageQuota. An...

X Description: Summary The multipart upload endpoint (POST /api/files/multipart) accepted the quota-exempt public-asset contexts og-images, profile-pictures, and workspace-logos, which skip checkStorageQuota. An...

Opengraph URL: https://github.com/simstudioai/sim/pull/5155

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4c008c13-9634-b027-6c55-5675605dd11e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id914E:2E7BAB:9688A5:CF820D:6AFB4DC3
html-safe-nonce3a49276da9bee578a48094dfad5351453b6304d4f6894865b7d33f770fa46cdb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTRFOjJFN0JBQjo5Njg4QTU6Q0Y4MjBEOjZBRkI0REMzIiwidmlzaXRvcl9pZCI6IjM5MTQxNjcwNDA1NDA4ODg1MTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5a28d95ca989cd28603a5fb20befdfa62b86fb4241dce94459cca8f39e4103dc
hovercard-subject-tagpull_request:3905039093
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5155/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The multipart upload endpoint (POST /api/files/multipart) accepted the quota-exempt public-asset contexts og-images, profile-pictures, and workspace-logos, which skip checkStorageQuota. An...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5155/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5155%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5155%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5155/files
Reloadhttps://github.com/simstudioai/sim/pull/5155/files
Reloadhttps://github.com/simstudioai/sim/pull/5155/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
worktree-fix+multipart-quota-bypasshttps://github.com/simstudioai/sim/tree/worktree-fix%2Bmultipart-quota-bypass
Conversation 5 https://github.com/simstudioai/sim/pull/5155
Commits 1 https://github.com/simstudioai/sim/pull/5155/commits
Checks 15 https://github.com/simstudioai/sim/pull/5155/checks
Files changed https://github.com/simstudioai/sim/pull/5155/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5155/files
fix(uploads): close multipart storage-quota bypass via quota-exempt contexts https://github.com/simstudioai/sim/pull/5155/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/5155/files
e8ffb15 fix(uploads): close multipart storage-quota bypass via quota-exempt c… waleedlatif1 Jun 20, 2026 https://github.com/simstudioai/sim/pull/5155/commits/e8ffb1516b828ce77f6232758746f8e8ae94ea4e
Clear filters https://github.com/simstudioai/sim/pull/5155/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5155/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5155/files
route.test.ts https://github.com/simstudioai/sim/pull/5155/files#diff-b39e964f54253c6e64504afd2e9387f9ad197ddb93e525f793e2efdb464f1e47
route.ts https://github.com/simstudioai/sim/pull/5155/files#diff-61eee923cf18262c36f17f4ee5c06c6b1880fc4f13111c58fc629bb47b766b25
types.ts https://github.com/simstudioai/sim/pull/5155/files#diff-9fe4883673f33f33785c7e6e3f5757e9329f88d2d6207a9dc82289b5acd3492b
apps/sim/app/api/files/multipart/route.test.tshttps://github.com/simstudioai/sim/pull/5155/files#diff-b39e964f54253c6e64504afd2e9387f9ad197ddb93e525f793e2efdb464f1e47
View file https://github.com/simstudioai/sim/blob/e8ffb1516b828ce77f6232758746f8e8ae94ea4e/apps/sim/app/api/files/multipart/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5155/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5155/files#diff-b39e964f54253c6e64504afd2e9387f9ad197ddb93e525f793e2efdb464f1e47
https://github.com/simstudioai/sim/pull/5155/files#diff-b39e964f54253c6e64504afd2e9387f9ad197ddb93e525f793e2efdb464f1e47
https://github.com/simstudioai/sim/pull/5155/files#diff-b39e964f54253c6e64504afd2e9387f9ad197ddb93e525f793e2efdb464f1e47
apps/sim/app/api/files/multipart/route.tshttps://github.com/simstudioai/sim/pull/5155/files#diff-61eee923cf18262c36f17f4ee5c06c6b1880fc4f13111c58fc629bb47b766b25
View file https://github.com/simstudioai/sim/blob/e8ffb1516b828ce77f6232758746f8e8ae94ea4e/apps/sim/app/api/files/multipart/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5155/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5155/files#diff-61eee923cf18262c36f17f4ee5c06c6b1880fc4f13111c58fc629bb47b766b25
https://github.com/simstudioai/sim/pull/5155/files#diff-61eee923cf18262c36f17f4ee5c06c6b1880fc4f13111c58fc629bb47b766b25
https://github.com/simstudioai/sim/pull/5155/files#diff-61eee923cf18262c36f17f4ee5c06c6b1880fc4f13111c58fc629bb47b766b25
https://github.com/simstudioai/sim/pull/5155/files#diff-61eee923cf18262c36f17f4ee5c06c6b1880fc4f13111c58fc629bb47b766b25
apps/sim/lib/uploads/shared/types.tshttps://github.com/simstudioai/sim/pull/5155/files#diff-9fe4883673f33f33785c7e6e3f5757e9329f88d2d6207a9dc82289b5acd3492b
View file https://github.com/simstudioai/sim/blob/e8ffb1516b828ce77f6232758746f8e8ae94ea4e/apps/sim/lib/uploads/shared/types.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5155/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5155/files#diff-9fe4883673f33f33785c7e6e3f5757e9329f88d2d6207a9dc82289b5acd3492b
https://github.com/simstudioai/sim/pull/5155/files#diff-9fe4883673f33f33785c7e6e3f5757e9329f88d2d6207a9dc82289b5acd3492b
Please reload this pagehttps://github.com/simstudioai/sim/pull/5155/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.