Title: fix(file-decompress): enforce decompression caps on inflated stream, not declared zip size by waleedlatif1 · Pull Request #5154 · simstudioai/sim · GitHub
Open Graph Title: fix(file-decompress): enforce decompression caps on inflated stream, not declared zip size by waleedlatif1 · Pull Request #5154 · simstudioai/sim
X Title: fix(file-decompress): enforce decompression caps on inflated stream, not declared zip size by waleedlatif1 · Pull Request #5154 · simstudioai/sim
Description: Summary The decompress operation (POST /api/tools/file/manage, operation: "decompress") enforced its per-entry and total size caps only after JSZip had already fully inflated each entry into a Node Buffer. The only guard running before inflation trusted the archive's declared (attacker-controlled) uncompressed size, so a crafted ZIP with a forged-small or absent declared size bypassed the pre-check and OOM-crashed the shared Node worker (DoS affecting co-tenants on hosted sim.ai). Replaced entry.async('nodebuffer') with a streaming counting sink (inflateEntryWithinCaps) that inflates each entry through entry.nodeStream() and tears the stream down the moment cumulative output would breach the per-entry cap or the remaining total budget. Enforcement now happens on the real inflated bytes as they arrive — peak memory is bounded by the cap plus one DEFLATE chunk. Kept the declared-size check as an advisory fast-reject for honestly-declared archives only; it is no longer the authoritative guard. Type of Change Bug fix (security) Testing Tested manually: verified that an entry with a forged-small declared uncompressedSize (100 B) over a 20 MB payload is aborted by the streaming sink with an "entry too large" result, that normal entries inflate byte-identically to the previous async('nodebuffer') path (fully backwards compatible), and that empty entries still yield a 0-length buffer. Typecheck, biome, and check:api-validation all pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary The decompress operation (POST /api/tools/file/manage, operation: "decompress") enforced its per-entry and total size caps only after JSZip had already fully inflated each entry ...
X Description: Summary The decompress operation (POST /api/tools/file/manage, operation: "decompress") enforced its per-entry and total size caps only after JSZip had already fully inflated eac...
Opengraph URL: https://github.com/simstudioai/sim/pull/5154
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:2d5dec6e-e6a8-029d-be6d-35b105d38419 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E11A:2D6147:720C9D:A25B1D:6AFB4970 |
| html-safe-nonce | 53bf87083ea1a7f4e1dff94ff527ab4fff610c8651e3025f8013e848c1cc6cdb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTFBOjJENjE0Nzo3MjBDOUQ6QTI1QjFEOjZBRkI0OTcwIiwidmlzaXRvcl9pZCI6IjI5MTEwNzQ5MDc0MTQyODQ2NTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5e540c0fc0be1aa1e5bb269dbbc6aed64ade2a55adab985a6312d007f3b2e9a4 |
| hovercard-subject-tag | pull_request:3905033725 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5154/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary The decompress operation (POST /api/tools/file/manage, operation: "decompress") enforced its per-entry and total size caps only after JSZip had already fully inflated each entry ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | acf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26504db649b58525278f77a52b80ba5f10d5f4de |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width