René's URL Explorer Experiment


Title: fix(file-decompress): enforce decompression caps on inflated stream, not declared zip size by waleedlatif1 · Pull Request #5154 · simstudioai/sim · GitHub

Open Graph Title: fix(file-decompress): enforce decompression caps on inflated stream, not declared zip size by waleedlatif1 · Pull Request #5154 · simstudioai/sim

X Title: fix(file-decompress): enforce decompression caps on inflated stream, not declared zip size by waleedlatif1 · Pull Request #5154 · simstudioai/sim

Description: Summary The decompress operation (POST /api/tools/file/manage, operation: "decompress") enforced its per-entry and total size caps only after JSZip had already fully inflated each entry into a Node Buffer. The only guard running before inflation trusted the archive's declared (attacker-controlled) uncompressed size, so a crafted ZIP with a forged-small or absent declared size bypassed the pre-check and OOM-crashed the shared Node worker (DoS affecting co-tenants on hosted sim.ai). Replaced entry.async('nodebuffer') with a streaming counting sink (inflateEntryWithinCaps) that inflates each entry through entry.nodeStream() and tears the stream down the moment cumulative output would breach the per-entry cap or the remaining total budget. Enforcement now happens on the real inflated bytes as they arrive — peak memory is bounded by the cap plus one DEFLATE chunk. Kept the declared-size check as an advisory fast-reject for honestly-declared archives only; it is no longer the authoritative guard. Type of Change Bug fix (security) Testing Tested manually: verified that an entry with a forged-small declared uncompressedSize (100 B) over a 20 MB payload is aborted by the streaming sink with an "entry too large" result, that normal entries inflate byte-identically to the previous async('nodebuffer') path (fully backwards compatible), and that empty entries still yield a 0-length buffer. Typecheck, biome, and check:api-validation all pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The decompress operation (POST /api/tools/file/manage, operation: "decompress") enforced its per-entry and total size caps only after JSZip had already fully inflated each entry ...

X Description: Summary The decompress operation (POST /api/tools/file/manage, operation: "decompress") enforced its per-entry and total size caps only after JSZip had already fully inflated eac...

Opengraph URL: https://github.com/simstudioai/sim/pull/5154

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2d5dec6e-e6a8-029d-be6d-35b105d38419
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE11A:2D6147:720C9D:A25B1D:6AFB4970
html-safe-nonce53bf87083ea1a7f4e1dff94ff527ab4fff610c8651e3025f8013e848c1cc6cdb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTFBOjJENjE0Nzo3MjBDOUQ6QTI1QjFEOjZBRkI0OTcwIiwidmlzaXRvcl9pZCI6IjI5MTEwNzQ5MDc0MTQyODQ2NTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5e540c0fc0be1aa1e5bb269dbbc6aed64ade2a55adab985a6312d007f3b2e9a4
hovercard-subject-tagpull_request:3905033725
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5154/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The decompress operation (POST /api/tools/file/manage, operation: "decompress") enforced its per-entry and total size caps only after JSZip had already fully inflated each entry ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5154/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5154%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5154%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5154/files
Reloadhttps://github.com/simstudioai/sim/pull/5154/files
Reloadhttps://github.com/simstudioai/sim/pull/5154/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/decompress-bombhttps://github.com/simstudioai/sim/tree/fix/decompress-bomb
Conversation 7 https://github.com/simstudioai/sim/pull/5154
Commits 2 https://github.com/simstudioai/sim/pull/5154/commits
Checks 15 https://github.com/simstudioai/sim/pull/5154/checks
Files changed https://github.com/simstudioai/sim/pull/5154/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5154/files
fix(file-decompress): enforce decompression caps on inflated stream, not declared zip size https://github.com/simstudioai/sim/pull/5154/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/5154/files
4b78437 fix(file-decompress): enforce decompression caps on inflated stream, … waleedlatif1 Jun 20, 2026 https://github.com/simstudioai/sim/pull/5154/commits/4b78437a5807b65dddfd1816879e1148e0bdb54e
789e99c fix(file-decompress): destroy inflate stream on error to avoid resour… waleedlatif1 Jun 20, 2026 https://github.com/simstudioai/sim/pull/5154/commits/789e99c7bd3d44662c259cc183c592ad112739b2
Clear filters https://github.com/simstudioai/sim/pull/5154/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5154/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5154/files
apps/sim/app/api/tools/file/manage/route.tshttps://github.com/simstudioai/sim/pull/5154/files#diff-d83cb3ae7797f37be74e772050f9816866e6c2588e054c84190902bce990e376
View file https://github.com/simstudioai/sim/blob/789e99c7bd3d44662c259cc183c592ad112739b2/apps/sim/app/api/tools/file/manage/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5154/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5154/files#diff-d83cb3ae7797f37be74e772050f9816866e6c2588e054c84190902bce990e376
https://github.com/simstudioai/sim/pull/5154/files#diff-d83cb3ae7797f37be74e772050f9816866e6c2588e054c84190902bce990e376
Please reload this pagehttps://github.com/simstudioai/sim/pull/5154/files
https://github.com/simstudioai/sim/pull/5154/files#diff-d83cb3ae7797f37be74e772050f9816866e6c2588e054c84190902bce990e376
https://github.com/simstudioai/sim/pull/5154/files#diff-d83cb3ae7797f37be74e772050f9816866e6c2588e054c84190902bce990e376
https://github.com/simstudioai/sim/pull/5154/files#diff-d83cb3ae7797f37be74e772050f9816866e6c2588e054c84190902bce990e376
https://github.com/simstudioai/sim/pull/5154/files#diff-d83cb3ae7797f37be74e772050f9816866e6c2588e054c84190902bce990e376
Please reload this pagehttps://github.com/simstudioai/sim/pull/5154/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.