René's URL Explorer Experiment


Title: fix(credential-sets): security hardening by waleedlatif1 · Pull Request #5074 · simstudioai/sim · GitHub

Open Graph Title: fix(credential-sets): security hardening by waleedlatif1 · Pull Request #5074 · simstudioai/sim

X Title: fix(credential-sets): security hardening by waleedlatif1 · Pull Request #5074 · simstudioai/sim

Description: Sim is the collaborative workspace to build, deploy, and monitor AI agents and workflows. Used by 100,000+ builders. - fix(credential-sets): security hardening by waleedlatif1 · Pull Request #5074 · simstudioai/sim

Open Graph Description: Summary GET /api/credential-sets/invitations returned every pending, unexpired link-only (null-email) invitation across all organizations, including the bearer token. Any authenticated user could ...

X Description: Summary GET /api/credential-sets/invitations returned every pending, unexpired link-only (null-email) invitation across all organizations, including the bearer token. Any authenticated user could ...

Opengraph URL: https://github.com/simstudioai/sim/pull/5074

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7d243018-00ca-6926-c51a-4248ced26352
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBEB6:277BD5:823C09:B39782:6AFB46F9
html-safe-nonce66f42b3a451624ffc9fcf65b1421495adb6e83e3440cc2c14337a75b31f5e145
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRUI2OjI3N0JENTo4MjNDMDk6QjM5NzgyOjZBRkI0NkY5IiwidmlzaXRvcl9pZCI6IjQzODcwNDYwMTA3MzIxMDM0MTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace505122a3451070a616ebea12fc5c65a1ff1f24c1420f8c208578970d6d9ddc2
hovercard-subject-tagpull_request:3871694422
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/simstudioai/sim/5074/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2394d6b58222c9de9e3006c6154dd388903ad41449238bb6ba138b3c3f1d25c1/simstudioai/sim/pull/5074
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2394d6b58222c9de9e3006c6154dd388903ad41449238bb6ba138b3c3f1d25c1/simstudioai/sim/pull/5074
og:image:altSummary GET /api/credential-sets/invitations returned every pending, unexpired link-only (null-email) invitation across all organizations, including the bearer token. Any authenticated user could ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewaleedlatif1
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-cache
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5074#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5074
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5074
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5074
Reloadhttps://github.com/simstudioai/sim/pull/5074
Reloadhttps://github.com/simstudioai/sim/pull/5074
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
https://github.com/simstudioai/sim
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/credential-set-invite-token-leakhttps://github.com/simstudioai/sim/tree/fix/credential-set-invite-token-leak
Conversationhttps://github.com/simstudioai/sim/pull/5074
Commits1 (1)https://github.com/simstudioai/sim/pull/5074/commits
Checkshttps://github.com/simstudioai/sim/pull/5074/checks
Files changedhttps://github.com/simstudioai/sim/pull/5074/files
fix(credential-sets): security hardeninghttps://github.com/simstudioai/sim/pull/5074#top
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/credential-set-invite-token-leakhttps://github.com/simstudioai/sim/tree/fix/credential-set-invite-token-leak
https://github.com/waleedlatif1
waleedlatif1https://github.com/waleedlatif1
Jun 15, 2026https://github.com/simstudioai/sim/pull/5074#issue-4669624571
Contributor License Agreement (CLA)https://github.com/simstudioai/sim/pull/CONTRIBUTING.md#contributor-license-agreement-cla
Please reload this pagehttps://github.com/simstudioai/sim/pull/5074
https://github.com/waleedlatif1
fix(credential-sets): stop leaking open-invite tokens to all usershttps://github.com/simstudioai/sim/pull/5074/commits/e93a5caf5ca4e738de2184b9a31a3819eb449dd3
e93a5cahttps://github.com/simstudioai/sim/pull/5074/commits/e93a5caf5ca4e738de2184b9a31a3819eb449dd3
https://github.com/apps/vercel
vercelhttps://github.com/apps/vercel
Jun 15, 2026https://github.com/simstudioai/sim/pull/5074#issuecomment-4713244399
Vercel for GitHubhttps://vercel.link/github-learn-more
docshttps://vercel.com/sim-studio/docs
https://camo.githubusercontent.com/1bb29feed7826aff3191ae8ff19d3c61e80fc99f9cc9373030210090f890893b/68747470733a2f2f76657263656c2e636f6d2f7374617469632f7374617475732f63616e63656c65642e737667
Skippedhttps://vercel.com/sim-studio/docs/FASXAjSyeXidDHVRpUpXjmRx9bKS
https://vercel.com/vercel-agent/request-review?owner=simstudioai&repo=sim&pr=5074
Please reload this pagehttps://github.com/simstudioai/sim/pull/5074
https://github.com/waleedlatif1
waleedlatif1https://github.com/waleedlatif1
Jun 15, 2026https://github.com/simstudioai/sim/pull/5074#issuecomment-4713244436
@greptilehttps://github.com/greptile
Please reload this pagehttps://github.com/simstudioai/sim/pull/5074
https://github.com/waleedlatif1
waleedlatif1https://github.com/waleedlatif1
Jun 15, 2026https://github.com/simstudioai/sim/pull/5074#issuecomment-4713244515
@cursorhttps://github.com/cursor
Please reload this pagehttps://github.com/simstudioai/sim/pull/5074
https://github.com/apps/cursor
cursorhttps://github.com/apps/cursor
Jun 15, 2026https://github.com/simstudioai/sim/pull/5074#issuecomment-4713244712
Please reload this pagehttps://github.com/simstudioai/sim/pull/5074
Cursor Bugbothttps://cursor.com/bugbot
e93a5cahttps://github.com/simstudioai/sim/commit/e93a5caf5ca4e738de2184b9a31a3819eb449dd3
herehttps://www.cursor.com/dashboard/bugbot
Please reload this pagehttps://github.com/simstudioai/sim/pull/5074
https://github.com/apps/cursor
cursorhttps://github.com/apps/cursor
Jun 15, 2026 https://github.com/simstudioai/sim/pull/5074#pullrequestreview-4501961363
View reviewed changes https://github.com/simstudioai/sim/pull/5074/files/e93a5caf5ca4e738de2184b9a31a3819eb449dd3
cursorhttps://github.com/apps/cursor
https://github.com/simstudioai/sim/pull/5074#pullrequestreview-4501961363
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Cursor Bugbothttps://cursor.com/bugbot
e93a5cahttps://github.com/simstudioai/sim/commit/e93a5caf5ca4e738de2184b9a31a3819eb449dd3
herehttps://www.cursor.com/dashboard/bugbot
Please reload this pagehttps://github.com/simstudioai/sim/pull/5074
https://github.com/waleedlatif1
waleedlatif1https://github.com/waleedlatif1
Jun 15, 2026https://github.com/simstudioai/sim/pull/5074#event-26782851814
https://github.com/apps/greptile-apps
greptile-appshttps://github.com/apps/greptile-apps
Jun 15, 2026https://github.com/simstudioai/sim/pull/5074#issuecomment-4713253500
%%{init: {'theme': 'neutral'}}%% sequenceDiagram participant U as Authenticated User participant L as GET /api/credential-sets/invitations participant A as POST /api/credential-sets/invite/[token] participant DB as Database note over L,DB: BEFORE (vulnerable) U->>L: GET invitations L->>DB: "WHERE email = me OR email IS NULL" DB-->>L: All pending invitations (any org, including tokens) L-->>U: Tokens for other orgs open-link invites U->>A: "POST /invite/{stolen_token}" A->>DB: Lookup token (no email check for null-email invites) DB-->>A: Invitation found A-->>U: Joined another org credential set note over L,DB: AFTER (fixed) U->>L: GET invitations L->>DB: "WHERE email = me (only)" DB-->>L: Only invitations addressed to caller L-->>U: Callers own tokens only U->>A: "POST /invite/{own_token}" A->>DB: Lookup + enforce email match A-->>U: Accept own invitation only Loading https://github.com/simstudioai/sim/pull/5074#gh-light-mode-only
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% sequenceDiagram participant U as Authenticated User participant L as GET /api/credential-sets/invitations participant A as POST /api/credential-sets/invite/[token] participant DB as Database note over L,DB: BEFORE (vulnerable) U->>L: GET invitations L->>DB: "WHERE email = me OR email IS NULL" DB-->>L: All pending invitations (any org, including tokens) L-->>U: Tokens for other orgs open-link invites U->>A: "POST /invite/{stolen_token}" A->>DB: Lookup token (no email check for null-email invites) DB-->>A: Invitation found A-->>U: Joined another org credential set note over L,DB: AFTER (fixed) U->>L: GET invitations L->>DB: "WHERE email = me (only)" DB-->>L: Only invitations addressed to caller L-->>U: Callers own tokens only U->>A: "POST /invite/{own_token}" A->>DB: Lookup + enforce email match A-->>U: Accept own invitation only Loading https://github.com/simstudioai/sim/pull/5074#gh-dark-mode-only
"fix(credential-sets): stop leaking open-..."https://github.com/simstudioai/sim/commit/e93a5caf5ca4e738de2184b9a31a3819eb449dd3
Re-trigger Greptilehttps://app.greptile.com/api/retrigger?id=37765070
Please reload this pagehttps://github.com/simstudioai/sim/pull/5074
https://github.com/apps/greptile-apps
greptile-appshttps://github.com/apps/greptile-apps
Jun 15, 2026https://github.com/simstudioai/sim/pull/5074#issuecomment-4713254579
%%{init: {'theme': 'neutral'}}%% sequenceDiagram participant U as Authenticated User participant LIST as GET /api/credential-sets/invitations participant ACCEPT as POST /api/credential-sets/invite/[token] participant DB as Database Note over LIST,DB: BEFORE: returned ALL pending null-email invitations (any org) U->>LIST: GET /invitations LIST->>DB: "WHERE (email = me OR email IS NULL) AND status=pending" DB-->>LIST: rows including open-invite tokens from other orgs LIST-->>U: tokens for other orgs open invites exposed Note over LIST,DB: AFTER: only caller own email-addressed invitations U->>LIST: GET /invitations LIST->>DB: "WHERE email = session.email AND status=pending" DB-->>LIST: only invitations addressed to this user LIST-->>U: callers own invitations token safe to return Note over ACCEPT,DB: Open-link invite redemption unchanged by design U->>ACCEPT: POST /invite/[token] token from out-of-band URL ACCEPT->>DB: "SELECT WHERE token = :token" DB-->>ACCEPT: "invitation email=null" Note over ACCEPT: email IS NULL skip email check token possession = auth ACCEPT->>DB: INSERT member + UPDATE invitation accepted ACCEPT-->>U: accepted Loading https://github.com/simstudioai/sim/pull/5074#gh-light-mode-only
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% sequenceDiagram participant U as Authenticated User participant LIST as GET /api/credential-sets/invitations participant ACCEPT as POST /api/credential-sets/invite/[token] participant DB as Database Note over LIST,DB: BEFORE: returned ALL pending null-email invitations (any org) U->>LIST: GET /invitations LIST->>DB: "WHERE (email = me OR email IS NULL) AND status=pending" DB-->>LIST: rows including open-invite tokens from other orgs LIST-->>U: tokens for other orgs open invites exposed Note over LIST,DB: AFTER: only caller own email-addressed invitations U->>LIST: GET /invitations LIST->>DB: "WHERE email = session.email AND status=pending" DB-->>LIST: only invitations addressed to this user LIST-->>U: callers own invitations token safe to return Note over ACCEPT,DB: Open-link invite redemption unchanged by design U->>ACCEPT: POST /invite/[token] token from out-of-band URL ACCEPT->>DB: "SELECT WHERE token = :token" DB-->>ACCEPT: "invitation email=null" Note over ACCEPT: email IS NULL skip email check token possession = auth ACCEPT->>DB: INSERT member + UPDATE invitation accepted ACCEPT-->>U: accepted Loading https://github.com/simstudioai/sim/pull/5074#gh-dark-mode-only
"fix(credential-sets): stop leaking open-..."https://github.com/simstudioai/sim/commit/e93a5caf5ca4e738de2184b9a31a3819eb449dd3
Re-trigger Greptilehttps://app.greptile.com/api/retrigger?id=37765070
Please reload this pagehttps://github.com/simstudioai/sim/pull/5074
https://github.com/waleedlatif1
waleedlatif1https://github.com/waleedlatif1
3e2b641https://github.com/simstudioai/sim/commit/3e2b641e9dc15da6f201d51015a54c0f68695335
Jun 15, 2026https://github.com/simstudioai/sim/pull/5074#event-26783092605
Please reload this pagehttps://github.com/simstudioai/sim/pull/5074
https://github.com/waleedlatif1
waleedlatif1https://github.com/waleedlatif1
June 15, 2026 23:24https://github.com/simstudioai/sim/pull/5074#event-26783093632
https://github.com/waleedlatif1
waleedlatif1https://github.com/waleedlatif1
Jun 16, 2026 https://github.com/simstudioai/sim/pull/5074#ref-pullrequest-4670824993
v0.7.8: security hardening, code hygiene, MSFT oauth provider, new atlassian assets and google calendar tools #5088 https://github.com/simstudioai/sim/pull/5088
Deployedhttps://docs-f1644sel3-sim-studio.vercel.app
vercel[bot]https://github.com/apps/vercel
View deployment https://docs-f1644sel3-sim-studio.vercel.app
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5074
https://github.com/apps/cursor
cursor[bot] https://github.com/apps/cursor
https://github.com/simstudioai/sim/pull/5074/files/e93a5caf5ca4e738de2184b9a31a3819eb449dd3
Please reload this pagehttps://github.com/simstudioai/sim/pull/5074
Please reload this pagehttps://github.com/simstudioai/sim/pull/5074
https://github.com/waleedlatif1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.