Title: fix(credential-sets): security hardening by waleedlatif1 · Pull Request #5074 · simstudioai/sim · GitHub
Open Graph Title: fix(credential-sets): security hardening by waleedlatif1 · Pull Request #5074 · simstudioai/sim
X Title: fix(credential-sets): security hardening by waleedlatif1 · Pull Request #5074 · simstudioai/sim
Description: Sim is the collaborative workspace to build, deploy, and monitor AI agents and workflows. Used by 100,000+ builders. - fix(credential-sets): security hardening by waleedlatif1 · Pull Request #5074 · simstudioai/sim
Open Graph Description: Summary GET /api/credential-sets/invitations returned every pending, unexpired link-only (null-email) invitation across all organizations, including the bearer token. Any authenticated user could ...
X Description: Summary GET /api/credential-sets/invitations returned every pending, unexpired link-only (null-email) invitation across all organizations, including the bearer token. Any authenticated user could ...
Opengraph URL: https://github.com/simstudioai/sim/pull/5074
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7d243018-00ca-6926-c51a-4248ced26352 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BEB6:277BD5:823C09:B39782:6AFB46F9 |
| html-safe-nonce | 66f42b3a451624ffc9fcf65b1421495adb6e83e3440cc2c14337a75b31f5e145 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRUI2OjI3N0JENTo4MjNDMDk6QjM5NzgyOjZBRkI0NkY5IiwidmlzaXRvcl9pZCI6IjQzODcwNDYwMTA3MzIxMDM0MTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e505122a3451070a616ebea12fc5c65a1ff1f24c1420f8c208578970d6d9ddc2 |
| hovercard-subject-tag | pull_request:3871694422 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/simstudioai/sim/5074/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2394d6b58222c9de9e3006c6154dd388903ad41449238bb6ba138b3c3f1d25c1/simstudioai/sim/pull/5074 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2394d6b58222c9de9e3006c6154dd388903ad41449238bb6ba138b3c3f1d25c1/simstudioai/sim/pull/5074 |
| og:image:alt | Summary GET /api/credential-sets/invitations returned every pending, unexpired link-only (null-email) invitation across all organizations, including the bearer token. Any authenticated user could ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | waleedlatif1 |
| hostname | github.com |
| expected-hostname | github.com |
| None | acf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1 |
| turbo-cache-control | no-cache |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26504db649b58525278f77a52b80ba5f10d5f4de |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
Links:
| Skip to content | https://github.com/simstudioai/sim/pull/5074#start-of-content |
| https://github.com/ | |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5074 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5074 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=simstudioai%2Fsim |
| Reload | https://github.com/simstudioai/sim/pull/5074 |
| Reload | https://github.com/simstudioai/sim/pull/5074 |
| Reload | https://github.com/simstudioai/sim/pull/5074 |
| simstudioai | https://github.com/simstudioai |
| sim | https://github.com/simstudioai/sim |
| Code | https://github.com/simstudioai/sim |
| Issues129 (129) | https://github.com/simstudioai/sim/issues |
| Pull requests199 (199) | https://github.com/simstudioai/sim/pulls |
| Actions | https://github.com/simstudioai/sim/actions |
| Projects | https://github.com/simstudioai/sim/projects |
| Security and quality | https://github.com/simstudioai/sim/security |
| Insights | https://github.com/simstudioai/sim/pulse |
| https://github.com/simstudioai/sim | |
| waleedlatif1 | https://github.com/waleedlatif1 |
| staging | https://github.com/simstudioai/sim/tree/staging |
| fix/credential-set-invite-token-leak | https://github.com/simstudioai/sim/tree/fix/credential-set-invite-token-leak |
| Conversation | https://github.com/simstudioai/sim/pull/5074 |
| Commits1 (1) | https://github.com/simstudioai/sim/pull/5074/commits |
| Checks | https://github.com/simstudioai/sim/pull/5074/checks |
| Files changed | https://github.com/simstudioai/sim/pull/5074/files |
| fix(credential-sets): security hardening | https://github.com/simstudioai/sim/pull/5074#top |
| waleedlatif1 | https://github.com/waleedlatif1 |
| staging | https://github.com/simstudioai/sim/tree/staging |
| fix/credential-set-invite-token-leak | https://github.com/simstudioai/sim/tree/fix/credential-set-invite-token-leak |
| https://github.com/waleedlatif1 | |
| waleedlatif1 | https://github.com/waleedlatif1 |
| Jun 15, 2026 | https://github.com/simstudioai/sim/pull/5074#issue-4669624571 |
| Contributor License Agreement (CLA) | https://github.com/simstudioai/sim/pull/CONTRIBUTING.md#contributor-license-agreement-cla |
| Please reload this page | https://github.com/simstudioai/sim/pull/5074 |
| https://github.com/waleedlatif1 | |
| fix(credential-sets): stop leaking open-invite tokens to all users | https://github.com/simstudioai/sim/pull/5074/commits/e93a5caf5ca4e738de2184b9a31a3819eb449dd3 |
| e93a5ca | https://github.com/simstudioai/sim/pull/5074/commits/e93a5caf5ca4e738de2184b9a31a3819eb449dd3 |
| https://github.com/apps/vercel | |
| vercel | https://github.com/apps/vercel |
| Jun 15, 2026 | https://github.com/simstudioai/sim/pull/5074#issuecomment-4713244399 |
| Vercel for GitHub | https://vercel.link/github-learn-more |
| docs | https://vercel.com/sim-studio/docs |
| https://camo.githubusercontent.com/1bb29feed7826aff3191ae8ff19d3c61e80fc99f9cc9373030210090f890893b/68747470733a2f2f76657263656c2e636f6d2f7374617469632f7374617475732f63616e63656c65642e737667 | |
| Skipped | https://vercel.com/sim-studio/docs/FASXAjSyeXidDHVRpUpXjmRx9bKS |
| https://vercel.com/vercel-agent/request-review?owner=simstudioai&repo=sim&pr=5074 | |
| Please reload this page | https://github.com/simstudioai/sim/pull/5074 |
| https://github.com/waleedlatif1 | |
| waleedlatif1 | https://github.com/waleedlatif1 |
| Jun 15, 2026 | https://github.com/simstudioai/sim/pull/5074#issuecomment-4713244436 |
| @greptile | https://github.com/greptile |
| Please reload this page | https://github.com/simstudioai/sim/pull/5074 |
| https://github.com/waleedlatif1 | |
| waleedlatif1 | https://github.com/waleedlatif1 |
| Jun 15, 2026 | https://github.com/simstudioai/sim/pull/5074#issuecomment-4713244515 |
| @cursor | https://github.com/cursor |
| Please reload this page | https://github.com/simstudioai/sim/pull/5074 |
| https://github.com/apps/cursor | |
| cursor | https://github.com/apps/cursor |
| Jun 15, 2026 | https://github.com/simstudioai/sim/pull/5074#issuecomment-4713244712 |
| Please reload this page | https://github.com/simstudioai/sim/pull/5074 |
| Cursor Bugbot | https://cursor.com/bugbot |
| e93a5ca | https://github.com/simstudioai/sim/commit/e93a5caf5ca4e738de2184b9a31a3819eb449dd3 |
| here | https://www.cursor.com/dashboard/bugbot |
| Please reload this page | https://github.com/simstudioai/sim/pull/5074 |
| https://github.com/apps/cursor | |
| cursor | https://github.com/apps/cursor |
| Jun 15, 2026 | https://github.com/simstudioai/sim/pull/5074#pullrequestreview-4501961363 |
| View reviewed changes | https://github.com/simstudioai/sim/pull/5074/files/e93a5caf5ca4e738de2184b9a31a3819eb449dd3 |
| cursor | https://github.com/apps/cursor |
| https://github.com/simstudioai/sim/pull/5074#pullrequestreview-4501961363 | |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Cursor Bugbot | https://cursor.com/bugbot |
| e93a5ca | https://github.com/simstudioai/sim/commit/e93a5caf5ca4e738de2184b9a31a3819eb449dd3 |
| here | https://www.cursor.com/dashboard/bugbot |
| Please reload this page | https://github.com/simstudioai/sim/pull/5074 |
| https://github.com/waleedlatif1 | |
| waleedlatif1 | https://github.com/waleedlatif1 |
| Jun 15, 2026 | https://github.com/simstudioai/sim/pull/5074#event-26782851814 |
| https://github.com/apps/greptile-apps | |
| greptile-apps | https://github.com/apps/greptile-apps |
| Jun 15, 2026 | https://github.com/simstudioai/sim/pull/5074#issuecomment-4713253500 |
| %%{init: {'theme': 'neutral'}}%% sequenceDiagram participant U as Authenticated User participant L as GET /api/credential-sets/invitations participant A as POST /api/credential-sets/invite/[token] participant DB as Database note over L,DB: BEFORE (vulnerable) U->>L: GET invitations L->>DB: "WHERE email = me OR email IS NULL" DB-->>L: All pending invitations (any org, including tokens) L-->>U: Tokens for other orgs open-link invites U->>A: "POST /invite/{stolen_token}" A->>DB: Lookup token (no email check for null-email invites) DB-->>A: Invitation found A-->>U: Joined another org credential set note over L,DB: AFTER (fixed) U->>L: GET invitations L->>DB: "WHERE email = me (only)" DB-->>L: Only invitations addressed to caller L-->>U: Callers own tokens only U->>A: "POST /invite/{own_token}" A->>DB: Lookup + enforce email match A-->>U: Accept own invitation only Loading | https://github.com/simstudioai/sim/pull/5074#gh-light-mode-only |
| %%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% sequenceDiagram participant U as Authenticated User participant L as GET /api/credential-sets/invitations participant A as POST /api/credential-sets/invite/[token] participant DB as Database note over L,DB: BEFORE (vulnerable) U->>L: GET invitations L->>DB: "WHERE email = me OR email IS NULL" DB-->>L: All pending invitations (any org, including tokens) L-->>U: Tokens for other orgs open-link invites U->>A: "POST /invite/{stolen_token}" A->>DB: Lookup token (no email check for null-email invites) DB-->>A: Invitation found A-->>U: Joined another org credential set note over L,DB: AFTER (fixed) U->>L: GET invitations L->>DB: "WHERE email = me (only)" DB-->>L: Only invitations addressed to caller L-->>U: Callers own tokens only U->>A: "POST /invite/{own_token}" A->>DB: Lookup + enforce email match A-->>U: Accept own invitation only Loading | https://github.com/simstudioai/sim/pull/5074#gh-dark-mode-only |
| "fix(credential-sets): stop leaking open-..." | https://github.com/simstudioai/sim/commit/e93a5caf5ca4e738de2184b9a31a3819eb449dd3 |
| Re-trigger Greptile | https://app.greptile.com/api/retrigger?id=37765070 |
| Please reload this page | https://github.com/simstudioai/sim/pull/5074 |
| https://github.com/apps/greptile-apps | |
| greptile-apps | https://github.com/apps/greptile-apps |
| Jun 15, 2026 | https://github.com/simstudioai/sim/pull/5074#issuecomment-4713254579 |
| %%{init: {'theme': 'neutral'}}%% sequenceDiagram participant U as Authenticated User participant LIST as GET /api/credential-sets/invitations participant ACCEPT as POST /api/credential-sets/invite/[token] participant DB as Database Note over LIST,DB: BEFORE: returned ALL pending null-email invitations (any org) U->>LIST: GET /invitations LIST->>DB: "WHERE (email = me OR email IS NULL) AND status=pending" DB-->>LIST: rows including open-invite tokens from other orgs LIST-->>U: tokens for other orgs open invites exposed Note over LIST,DB: AFTER: only caller own email-addressed invitations U->>LIST: GET /invitations LIST->>DB: "WHERE email = session.email AND status=pending" DB-->>LIST: only invitations addressed to this user LIST-->>U: callers own invitations token safe to return Note over ACCEPT,DB: Open-link invite redemption unchanged by design U->>ACCEPT: POST /invite/[token] token from out-of-band URL ACCEPT->>DB: "SELECT WHERE token = :token" DB-->>ACCEPT: "invitation email=null" Note over ACCEPT: email IS NULL skip email check token possession = auth ACCEPT->>DB: INSERT member + UPDATE invitation accepted ACCEPT-->>U: accepted Loading | https://github.com/simstudioai/sim/pull/5074#gh-light-mode-only |
| %%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% sequenceDiagram participant U as Authenticated User participant LIST as GET /api/credential-sets/invitations participant ACCEPT as POST /api/credential-sets/invite/[token] participant DB as Database Note over LIST,DB: BEFORE: returned ALL pending null-email invitations (any org) U->>LIST: GET /invitations LIST->>DB: "WHERE (email = me OR email IS NULL) AND status=pending" DB-->>LIST: rows including open-invite tokens from other orgs LIST-->>U: tokens for other orgs open invites exposed Note over LIST,DB: AFTER: only caller own email-addressed invitations U->>LIST: GET /invitations LIST->>DB: "WHERE email = session.email AND status=pending" DB-->>LIST: only invitations addressed to this user LIST-->>U: callers own invitations token safe to return Note over ACCEPT,DB: Open-link invite redemption unchanged by design U->>ACCEPT: POST /invite/[token] token from out-of-band URL ACCEPT->>DB: "SELECT WHERE token = :token" DB-->>ACCEPT: "invitation email=null" Note over ACCEPT: email IS NULL skip email check token possession = auth ACCEPT->>DB: INSERT member + UPDATE invitation accepted ACCEPT-->>U: accepted Loading | https://github.com/simstudioai/sim/pull/5074#gh-dark-mode-only |
| "fix(credential-sets): stop leaking open-..." | https://github.com/simstudioai/sim/commit/e93a5caf5ca4e738de2184b9a31a3819eb449dd3 |
| Re-trigger Greptile | https://app.greptile.com/api/retrigger?id=37765070 |
| Please reload this page | https://github.com/simstudioai/sim/pull/5074 |
| https://github.com/waleedlatif1 | |
| waleedlatif1 | https://github.com/waleedlatif1 |
| 3e2b641 | https://github.com/simstudioai/sim/commit/3e2b641e9dc15da6f201d51015a54c0f68695335 |
| Jun 15, 2026 | https://github.com/simstudioai/sim/pull/5074#event-26783092605 |
| Please reload this page | https://github.com/simstudioai/sim/pull/5074 |
| https://github.com/waleedlatif1 | |
| waleedlatif1 | https://github.com/waleedlatif1 |
| June 15, 2026 23:24 | https://github.com/simstudioai/sim/pull/5074#event-26783093632 |
| https://github.com/waleedlatif1 | |
| waleedlatif1 | https://github.com/waleedlatif1 |
| Jun 16, 2026 | https://github.com/simstudioai/sim/pull/5074#ref-pullrequest-4670824993 |
| v0.7.8: security hardening, code hygiene, MSFT oauth provider, new atlassian assets and google calendar tools #5088 | https://github.com/simstudioai/sim/pull/5088 |
| Deployed | https://docs-f1644sel3-sim-studio.vercel.app |
| vercel[bot] | https://github.com/apps/vercel |
| View deployment | https://docs-f1644sel3-sim-studio.vercel.app |
| https://github.co/hiddenchars | |
| https://github.com/simstudioai/sim/pull/{{ revealButtonHref }} | |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5074 |
| https://github.com/apps/cursor | |
| cursor[bot] | https://github.com/apps/cursor |
| https://github.com/simstudioai/sim/pull/5074/files/e93a5caf5ca4e738de2184b9a31a3819eb449dd3 | |
| Please reload this page | https://github.com/simstudioai/sim/pull/5074 |
| Please reload this page | https://github.com/simstudioai/sim/pull/5074 |
| https://github.com/waleedlatif1 | |
| https://github.com | |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |
Viewport: width=device-width