René's URL Explorer Experiment


Title: fix(files): support Safari < 17.4 in PDF preview by waleedlatif1 · Pull Request #4992 · simstudioai/sim · GitHub

Open Graph Title: fix(files): support Safari < 17.4 in PDF preview by waleedlatif1 · Pull Request #4992 · simstudioai/sim

X Title: fix(files): support Safari < 17.4 in PDF preview by waleedlatif1 · Pull Request #4992 · simstudioai/sim

Description: Summary Fixes "Something went wrong" on every PDF preview (chat + Files tab) for Safari < 17.4 users — pdf.js 5.x calls Promise.withResolvers (Safari ≥ 17.4) and URL.parse (Safari ≥ 18) at module-evaluation time, so importing react-pdf threw an uncaught TypeError that unwound to the workspace error boundary Adds lib/core/utils/browser-polyfills.ts, imported for side effects before the react-pdf import in pdf-viewer.tsx (the crash happens while pdf.js evaluates, so import order matters) Switches workerSrc to the legacy pdf.js worker build — the worker runs in its own context that main-thread polyfills can't reach, and the legacy build bundles its own polyfills (same pdfjs-dist version, so the API/worker version handshake is unaffected) Wraps the PDF preview in a PreviewErrorBoundary (styled after the existing workflow ErrorBoundary) so a viewer crash degrades to the standard PreviewError fallback instead of replacing the whole workspace view Type of Change Bug fix Testing Reproduced the production incident headlessly: bundled the real PdfViewerCore against the exact PDF bytes prod served, removed the two APIs to simulate Safari 17.3 → crashed with Promise.withResolvers is not a function (blank render). With this fix the same simulation renders both pages with zero console errors; modern-browser profile verified unaffected. tsc --noEmit and biome check clean on all changed files. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Fixes "Something went wrong" on every PDF preview (chat + Files tab) for Safari < 17.4 users — pdf.js 5.x calls Promise.withResolvers (Safari ≥ 17.4) and URL.parse (Safari ≥ 1...

X Description: Summary Fixes &quot;Something went wrong&quot; on every PDF preview (chat + Files tab) for Safari &lt; 17.4 users — pdf.js 5.x calls Promise.withResolvers (Safari ≥ 17.4) and URL.parse...

Opengraph URL: https://github.com/simstudioai/sim/pull/4992

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:71111ff0-fb3d-a765-c309-3f690f254e69
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBBF4:1C88A1:A1AF1C:E55E50:6AFB534C
html-safe-nonce84ab8e48eca8434523836744704035f5cd6b7156aba7d2d10a71fc1e9017a30a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQkY0OjFDODhBMTpBMUFGMUM6RTU1RTUwOjZBRkI1MzRDIiwidmlzaXRvcl9pZCI6IjM3NTI0OTQ2MTQ1Njk1MDU2MTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac35e442d3e3459a47e3594c9c1b308df7abe8ad7c1bbe610358e434c73920aeec
hovercard-subject-tagpull_request:3852073297
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4992/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Fixes "Something went wrong" on every PDF preview (chat + Files tab) for Safari < 17.4 users — pdf.js 5.x calls Promise.withResolvers (Safari ≥ 17.4) and URL.parse (Safari ≥ 1...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/4992/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4992%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4992%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/4992/files
Reloadhttps://github.com/simstudioai/sim/pull/4992/files
Reloadhttps://github.com/simstudioai/sim/pull/4992/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/pdf-preview-safari-compathttps://github.com/simstudioai/sim/tree/fix/pdf-preview-safari-compat
Conversation 29 https://github.com/simstudioai/sim/pull/4992
Commits 5 https://github.com/simstudioai/sim/pull/4992/commits
Checks 14 https://github.com/simstudioai/sim/pull/4992/checks
Files changed https://github.com/simstudioai/sim/pull/4992/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4992/files
fix(files): support Safari < 17.4 in PDF preview https://github.com/simstudioai/sim/pull/4992/files#top
Show all changes 5 commits https://github.com/simstudioai/sim/pull/4992/files
1d06dd9 fix(files): support Safari < 17.4 in PDF preview waleedlatif1 Jun 12, 2026 https://github.com/simstudioai/sim/pull/4992/commits/1d06dd9224a4f0e32906f106f6118f6ebe41ee4d
e913d69 fix(files): reset preview error boundary on content change, log compo… waleedlatif1 Jun 12, 2026 https://github.com/simstudioai/sim/pull/4992/commits/e913d69bd1db30165cc6669b3893ef2a5884e45e
df46f60 fix(files): apply preview mode once deep-linked file record loads waleedlatif1 Jun 12, 2026 https://github.com/simstudioai/sim/pull/4992/commits/df46f601cd0fc1d58514b3dbb551b22a9c5b14d9
fe60590 improvement(files): derive routed-file presence from existing selecte… waleedlatif1 Jun 12, 2026 https://github.com/simstudioai/sim/pull/4992/commits/fe60590f1f7825d124fbda4f6d91b123f789fd70
0b409f9 fix(files): settle preview mode when a deep-linked file id is missing waleedlatif1 Jun 12, 2026 https://github.com/simstudioai/sim/pull/4992/commits/0b409f9183877498ae29d135244474af15eaf5c5
Clear filters https://github.com/simstudioai/sim/pull/4992/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4992/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4992/files
file-viewer.tsx https://github.com/simstudioai/sim/pull/4992/files#diff-41f31a97adfda85382418ff71f00df02005b2d85b01516c49967857a1ee0b948
pdf-viewer.tsx https://github.com/simstudioai/sim/pull/4992/files#diff-4569edfcc7a1e27b5ed89764f1b01fba3c073348e4855c35d67dcdb0655ae10f
preview-shared.tsx https://github.com/simstudioai/sim/pull/4992/files#diff-b9f27b1882b6b0a833b1e4fc4b81f9b1a34f6df9cca678980fdc767c1bd4807f
files.tsx https://github.com/simstudioai/sim/pull/4992/files#diff-0284e2e46ba0636bd37fb01a0bee2a53844af9bbaf0a5879e3b182c0f34e67a9
browser-polyfills.ts https://github.com/simstudioai/sim/pull/4992/files#diff-cbaa5fcac453b9481c2a0a4af73e63a1468f5d22ff99384e9f74beacfc4b6e40
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/file-viewer.tsxhttps://github.com/simstudioai/sim/pull/4992/files#diff-41f31a97adfda85382418ff71f00df02005b2d85b01516c49967857a1ee0b948
View file https://github.com/simstudioai/sim/blob/0b409f9183877498ae29d135244474af15eaf5c5/apps/sim/app/workspace/%5BworkspaceId%5D/files/components/file-viewer/file-viewer.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4992/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4992/files#diff-41f31a97adfda85382418ff71f00df02005b2d85b01516c49967857a1ee0b948
https://github.com/simstudioai/sim/pull/4992/files#diff-41f31a97adfda85382418ff71f00df02005b2d85b01516c49967857a1ee0b948
https://github.com/simstudioai/sim/pull/4992/files#diff-41f31a97adfda85382418ff71f00df02005b2d85b01516c49967857a1ee0b948
Please reload this pagehttps://github.com/simstudioai/sim/pull/4992/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4992/files
https://github.com/simstudioai/sim/pull/4992/files#diff-41f31a97adfda85382418ff71f00df02005b2d85b01516c49967857a1ee0b948
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/pdf-viewer.tsxhttps://github.com/simstudioai/sim/pull/4992/files#diff-4569edfcc7a1e27b5ed89764f1b01fba3c073348e4855c35d67dcdb0655ae10f
View file https://github.com/simstudioai/sim/blob/0b409f9183877498ae29d135244474af15eaf5c5/apps/sim/app/workspace/%5BworkspaceId%5D/files/components/file-viewer/pdf-viewer.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4992/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4992/files#diff-4569edfcc7a1e27b5ed89764f1b01fba3c073348e4855c35d67dcdb0655ae10f
https://github.com/simstudioai/sim/pull/4992/files#diff-4569edfcc7a1e27b5ed89764f1b01fba3c073348e4855c35d67dcdb0655ae10f
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/preview-shared.tsxhttps://github.com/simstudioai/sim/pull/4992/files#diff-b9f27b1882b6b0a833b1e4fc4b81f9b1a34f6df9cca678980fdc767c1bd4807f
View file https://github.com/simstudioai/sim/blob/0b409f9183877498ae29d135244474af15eaf5c5/apps/sim/app/workspace/%5BworkspaceId%5D/files/components/file-viewer/preview-shared.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4992/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4992/files#diff-b9f27b1882b6b0a833b1e4fc4b81f9b1a34f6df9cca678980fdc767c1bd4807f
https://github.com/simstudioai/sim/pull/4992/files#diff-b9f27b1882b6b0a833b1e4fc4b81f9b1a34f6df9cca678980fdc767c1bd4807f
apps/sim/app/workspace/[workspaceId]/files/files.tsxhttps://github.com/simstudioai/sim/pull/4992/files#diff-0284e2e46ba0636bd37fb01a0bee2a53844af9bbaf0a5879e3b182c0f34e67a9
View file https://github.com/simstudioai/sim/blob/0b409f9183877498ae29d135244474af15eaf5c5/apps/sim/app/workspace/%5BworkspaceId%5D/files/files.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4992/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4992/files#diff-0284e2e46ba0636bd37fb01a0bee2a53844af9bbaf0a5879e3b182c0f34e67a9
https://github.com/simstudioai/sim/pull/4992/files#diff-0284e2e46ba0636bd37fb01a0bee2a53844af9bbaf0a5879e3b182c0f34e67a9
apps/sim/lib/core/utils/browser-polyfills.tshttps://github.com/simstudioai/sim/pull/4992/files#diff-cbaa5fcac453b9481c2a0a4af73e63a1468f5d22ff99384e9f74beacfc4b6e40
View file https://github.com/simstudioai/sim/blob/0b409f9183877498ae29d135244474af15eaf5c5/apps/sim/lib/core/utils/browser-polyfills.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4992/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/4992/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.