Title: fix(deps): dedupe radix focus-scope/dismissable-layer so in-modal dropdowns open by waleedlatif1 · Pull Request #4977 · simstudioai/sim · GitHub
Open Graph Title: fix(deps): dedupe radix focus-scope/dismissable-layer so in-modal dropdowns open by waleedlatif1 · Pull Request #4977 · simstudioai/sim
X Title: fix(deps): dedupe radix focus-scope/dismissable-layer so in-modal dropdowns open by waleedlatif1 · Pull Request #4977 · simstudioai/sim
Description: Summary Root cause of the credential "Add people" role dropdown not opening in production: the bundle contained two copies of Radix's coordination singletons. @radix-ui/react-dropdown-menu was the only Radix package pinned exactly (2.1.16), so when the lockfile refreshed in #4923, react-dialog moved to focus-scope@1.1.9 + dismissable-layer@1.1.12 while react-menu stayed on 1.1.7/1.1.11 With two copies, a menu portaled out of a modal registers in the wrong focusScopesStack, so the dialog's focus trap never pauses, yanks focus back as the menu opens, and the menu's dismiss layer unmounts it in the same tick — the dropdown never appears. Stale local installs (single shared copy via react-dialog@1.1.15) keep working, which is why this only reproduced on fresh-install/production builds The earlier z-index fix (#4947) didn't help because ChipDropdown was already on the popover layer — z-index was never the cause Fix: bump @radix-ui/react-dropdown-menu to 2.1.17, whose react-menu pins the same internals batch as react-dialog@1.1.16. Verified every coordination package (dismissable-layer, focus-scope, focus-guards, portal, popper, presence) now resolves to a single version tree-wide Type of Change Bug fix Testing Verified via clean bun install that the duplicate dismissable-layer/focus-scope copies existed before and resolve to single versions after Reproduced end-to-end in Chromium (Playwright) with a minimal modal-Dialog + non-modal DropdownMenu page: with dialog@1.1.16 + dropdown-menu@2.1.16 (the shipped pair) the menu fires open→close in the same tick and never renders; with dropdown-menu@2.1.17 it opens, items select, and it closes cleanly Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Root cause of the credential "Add people" role dropdown not opening in production: the bundle contained two copies of Radix's coordination singletons. @radix-ui/react-dropdow...
X Description: Summary Root cause of the credential "Add people" role dropdown not opening in production: the bundle contained two copies of Radix's coordination singletons. @radix-ui/r...
Opengraph URL: https://github.com/simstudioai/sim/pull/4977
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8d5a4aaf-004b-bb53-c5c5-3a6494e09e23 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D7A6:1D7E5A:AC9DBC:ED4854:6AFB50BF |
| html-safe-nonce | 098a517c1c5025dff07c722374466114e148762957c701cb7f0497c7aca658c4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0E2OjFEN0U1QTpBQzlEQkM6RUQ0ODU0OjZBRkI1MEJGIiwidmlzaXRvcl9pZCI6IjIyNDMzMjU4ODM2NTk4MDA3NjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | edfce30b28bac389d1fd627191537ce92946ba313f6dfc3e0d19f8472fdab187 |
| hovercard-subject-tag | pull_request:3849857376 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4977/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Root cause of the credential "Add people" role dropdown not opening in production: the bundle contained two copies of Radix's coordination singletons. @radix-ui/react-dropdow... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width