René's URL Explorer Experiment


Title: fix(deps): dedupe radix focus-scope/dismissable-layer so in-modal dropdowns open by waleedlatif1 · Pull Request #4977 · simstudioai/sim · GitHub

Open Graph Title: fix(deps): dedupe radix focus-scope/dismissable-layer so in-modal dropdowns open by waleedlatif1 · Pull Request #4977 · simstudioai/sim

X Title: fix(deps): dedupe radix focus-scope/dismissable-layer so in-modal dropdowns open by waleedlatif1 · Pull Request #4977 · simstudioai/sim

Description: Summary Root cause of the credential "Add people" role dropdown not opening in production: the bundle contained two copies of Radix's coordination singletons. @radix-ui/react-dropdown-menu was the only Radix package pinned exactly (2.1.16), so when the lockfile refreshed in #4923, react-dialog moved to focus-scope@1.1.9 + dismissable-layer@1.1.12 while react-menu stayed on 1.1.7/1.1.11 With two copies, a menu portaled out of a modal registers in the wrong focusScopesStack, so the dialog's focus trap never pauses, yanks focus back as the menu opens, and the menu's dismiss layer unmounts it in the same tick — the dropdown never appears. Stale local installs (single shared copy via react-dialog@1.1.15) keep working, which is why this only reproduced on fresh-install/production builds The earlier z-index fix (#4947) didn't help because ChipDropdown was already on the popover layer — z-index was never the cause Fix: bump @radix-ui/react-dropdown-menu to 2.1.17, whose react-menu pins the same internals batch as react-dialog@1.1.16. Verified every coordination package (dismissable-layer, focus-scope, focus-guards, portal, popper, presence) now resolves to a single version tree-wide Type of Change Bug fix Testing Verified via clean bun install that the duplicate dismissable-layer/focus-scope copies existed before and resolve to single versions after Reproduced end-to-end in Chromium (Playwright) with a minimal modal-Dialog + non-modal DropdownMenu page: with dialog@1.1.16 + dropdown-menu@2.1.16 (the shipped pair) the menu fires open→close in the same tick and never renders; with dropdown-menu@2.1.17 it opens, items select, and it closes cleanly Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Root cause of the credential "Add people" role dropdown not opening in production: the bundle contained two copies of Radix's coordination singletons. @radix-ui/react-dropdow...

X Description: Summary Root cause of the credential "Add people" role dropdown not opening in production: the bundle contained two copies of Radix's coordination singletons. @radix-ui/r...

Opengraph URL: https://github.com/simstudioai/sim/pull/4977

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8d5a4aaf-004b-bb53-c5c5-3a6494e09e23
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD7A6:1D7E5A:AC9DBC:ED4854:6AFB50BF
html-safe-nonce098a517c1c5025dff07c722374466114e148762957c701cb7f0497c7aca658c4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0E2OjFEN0U1QTpBQzlEQkM6RUQ0ODU0OjZBRkI1MEJGIiwidmlzaXRvcl9pZCI6IjIyNDMzMjU4ODM2NTk4MDA3NjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacedfce30b28bac389d1fd627191537ce92946ba313f6dfc3e0d19f8472fdab187
hovercard-subject-tagpull_request:3849857376
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4977/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Root cause of the credential "Add people" role dropdown not opening in production: the bundle contained two copies of Radix's coordination singletons. @radix-ui/react-dropdow...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/4977/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4977%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4977%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/4977/files
Reloadhttps://github.com/simstudioai/sim/pull/4977/files
Reloadhttps://github.com/simstudioai/sim/pull/4977/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/radix-in-modal-dropdown-dedupehttps://github.com/simstudioai/sim/tree/fix/radix-in-modal-dropdown-dedupe
Conversation 7 https://github.com/simstudioai/sim/pull/4977
Commits 2 https://github.com/simstudioai/sim/pull/4977/commits
Checks 14 https://github.com/simstudioai/sim/pull/4977/checks
Files changed https://github.com/simstudioai/sim/pull/4977/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4977/files
fix(deps): dedupe radix focus-scope/dismissable-layer so in-modal dropdowns open https://github.com/simstudioai/sim/pull/4977/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/4977/files
cdd8261 fix(deps): dedupe radix focus-scope/dismissable-layer so in-modal dro… waleedlatif1 Jun 11, 2026 https://github.com/simstudioai/sim/pull/4977/commits/cdd826121b4e4025094781d3411c031f13af888a
b746787 fix(deps): use caret range for dropdown-menu so radix internals track… waleedlatif1 Jun 11, 2026 https://github.com/simstudioai/sim/pull/4977/commits/b7467875bce8a869954860a18b7b21dadbefb93d
Clear filters https://github.com/simstudioai/sim/pull/4977/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4977/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4977/files
package.json https://github.com/simstudioai/sim/pull/4977/files#diff-43a1bb37ce68ac536b0a4ed9e973d9d52da3975d74b37865f591bb37e191be64
bun.lock https://github.com/simstudioai/sim/pull/4977/files#diff-bfd0ef82a01108fa1e836c2500b98b7de8a92bb1ae352a8efcbd9d6ffcaabd60
https://github.com/simstudioai/sim/blob/staging/.github/CODEOWNERS#L36
apps/sim/package.jsonhttps://github.com/simstudioai/sim/pull/4977/files#diff-43a1bb37ce68ac536b0a4ed9e973d9d52da3975d74b37865f591bb37e191be64
View file https://github.com/simstudioai/sim/blob/b7467875bce8a869954860a18b7b21dadbefb93d/apps/sim/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4977/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4977/files#diff-43a1bb37ce68ac536b0a4ed9e973d9d52da3975d74b37865f591bb37e191be64
https://github.com/simstudioai/sim/pull/4977/files#diff-43a1bb37ce68ac536b0a4ed9e973d9d52da3975d74b37865f591bb37e191be64
Please reload this pagehttps://github.com/simstudioai/sim/pull/4977/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4977/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.