René's URL Explorer Experiment


Title: refactor(emcn): make ChipModal footer/header props-driven and migrate all consumers by emir-karabeg · Pull Request #4905 · simstudioai/sim · GitHub

Open Graph Title: refactor(emcn): make ChipModal footer/header props-driven and migrate all consumers by emir-karabeg · Pull Request #4905 · simstudioai/sim

X Title: refactor(emcn): make ChipModal footer/header props-driven and migrate all consumers by emir-karabeg · Pull Request #4905 · simstudioai/sim

Description: Sim is the collaborative workspace to build, deploy, and monitor AI agents and workflows. Used by 100,000+ builders. - refactor(emcn): make ChipModal footer/header props-driven and migrate all consumers by emir-karabeg · Pull Request #4905 · simstudioai/sim

Open Graph Description: Summary Makes the EMCN modal system fully declarative across two button grammars, and migrates every consumer to it. 1. Props-driven ChipModalFooter / ChipModalHeader (form modals) ChipModalFooter...

X Description: Summary Makes the EMCN modal system fully declarative across two button grammars, and migrates every consumer to it. 1. Props-driven ChipModalFooter / ChipModalHeader (form modals) ChipModalFooter...

Opengraph URL: https://github.com/simstudioai/sim/pull/4905

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:178d4263-a14d-de2a-7b2d-70adf5eebb20
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id84D0:14B945:A0269E:DCE0DC:6AFB4FF0
html-safe-nonce0526ccdc0b00722eca88dcb24336645e50ed47bfb9384d8238975c4f12310d27
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEQwOjE0Qjk0NTpBMDI2OUU6RENFMERDOjZBRkI0RkYwIiwidmlzaXRvcl9pZCI6IjQ3NDIyMTM0MTM1MzcyNzE3OTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac402246e7779c2511a9f78dd5280c008c442e602f22908734034a0f77e619d99a
hovercard-subject-tagpull_request:3825746958
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4905/commits
twitter:imagehttps://opengraph.githubassets.com/4c337b5a532d985872fa81d81e61459c6f1d5538f50c416c67bd557107f4cccc/simstudioai/sim/pull/4905
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4c337b5a532d985872fa81d81e61459c6f1d5538f50c416c67bd557107f4cccc/simstudioai/sim/pull/4905
og:image:altSummary Makes the EMCN modal system fully declarative across two button grammars, and migrates every consumer to it. 1. Props-driven ChipModalFooter / ChipModalHeader (form modals) ChipModalFooter...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameemir-karabeg
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-cache
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/4905/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4905%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4905%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/4905/commits
Reloadhttps://github.com/simstudioai/sim/pull/4905/commits
Reloadhttps://github.com/simstudioai/sim/pull/4905/commits
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
https://github.com/simstudioai/sim
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
refactor/chip-modal-migrationhttps://github.com/simstudioai/sim/tree/refactor/chip-modal-migration
Conversationhttps://github.com/simstudioai/sim/pull/4905
Commits8 (8)https://github.com/simstudioai/sim/pull/4905/commits
Checkshttps://github.com/simstudioai/sim/pull/4905/checks
Files changedhttps://github.com/simstudioai/sim/pull/4905/files
refactor(emcn): make ChipModal footer/header props-driven and migrate all consumershttps://github.com/simstudioai/sim/pull/4905/commits#top
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
refactor/chip-modal-migrationhttps://github.com/simstudioai/sim/tree/refactor/chip-modal-migration
refactor(emcn): make ChipModal footer/header props-driven and migrate all consumershttps://github.com/simstudioai/sim/pull/4905/commits/94d36b2304d745f0abde67b10a8163151321718f
https://github.com/emir-karabeg
emir-karabeghttps://github.com/simstudioai/sim/commits?author=emir-karabeg
94d36b2https://github.com/simstudioai/sim/pull/4905/commits/94d36b2304d745f0abde67b10a8163151321718f
https://github.com/simstudioai/sim/tree/94d36b2304d745f0abde67b10a8163151321718f
fix(emcn): restore Cancel disable guard for in-flight ChipModal actionshttps://github.com/simstudioai/sim/pull/4905/commits/6c7cbdb681de4dde8543e58c7f51b6c19cf52800
https://github.com/emir-karabeg
emir-karabeghttps://github.com/simstudioai/sim/commits?author=emir-karabeg
6c7cbdbhttps://github.com/simstudioai/sim/pull/4905/commits/6c7cbdb681de4dde8543e58c7f51b6c19cf52800
https://github.com/simstudioai/sim/tree/6c7cbdb681de4dde8543e58c7f51b6c19cf52800
Merge remote-tracking branch 'origin/staging' into refactor/chip-modal-migrationhttps://github.com/simstudioai/sim/pull/4905/commits/9bc4a0f19468e32ee9b2e9bb83681ba28aff5d1a
https://github.com/emir-karabeg
emir-karabeghttps://github.com/simstudioai/sim/commits?author=emir-karabeg
9bc4a0fhttps://github.com/simstudioai/sim/pull/4905/commits/9bc4a0f19468e32ee9b2e9bb83681ba28aff5d1a
https://github.com/simstudioai/sim/tree/9bc4a0f19468e32ee9b2e9bb83681ba28aff5d1a
Merge remote-tracking branch 'origin/staging' into refactor/chip-modal-migrationhttps://github.com/simstudioai/sim/pull/4905/commits/535a2627e2ae7efbfd0b2a81066bde9ed76b93b8
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
535a262https://github.com/simstudioai/sim/pull/4905/commits/535a2627e2ae7efbfd0b2a81066bde9ed76b93b8
https://github.com/simstudioai/sim/tree/535a2627e2ae7efbfd0b2a81066bde9ed76b93b8
feat(emcn): add ChipConfirmModal confirmation primitivehttps://github.com/simstudioai/sim/pull/4905/commits/d1990de173dd80129a6f715ee21a1cc0c240ad45
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
d1990dehttps://github.com/simstudioai/sim/pull/4905/commits/d1990de173dd80129a6f715ee21a1cc0c240ad45
https://github.com/simstudioai/sim/tree/d1990de173dd80129a6f715ee21a1cc0c240ad45
refactor(emcn): migrate all confirmation dialogs to ChipConfirmModalhttps://github.com/simstudioai/sim/pull/4905/commits/73e974c12cb816996f736335b53096efe15820dd
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
73e974chttps://github.com/simstudioai/sim/pull/4905/commits/73e974c12cb816996f736335b53096efe15820dd
https://github.com/simstudioai/sim/tree/73e974c12cb816996f736335b53096efe15820dd
style(emcn): normalize confirm pendingLabel ellipsis to '...'https://github.com/simstudioai/sim/pull/4905/commits/2d63e7655d884fba8ebd533fd7f1f0550a0390c5
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
2d63e76https://github.com/simstudioai/sim/pull/4905/commits/2d63e7655d884fba8ebd533fd7f1f0550a0390c5
https://github.com/simstudioai/sim/tree/2d63e7655d884fba8ebd533fd7f1f0550a0390c5
fix(emcn): restore Enter-to-submit in form modals after footer migrationhttps://github.com/simstudioai/sim/pull/4905/commits/3901145d0086eb477fadecd586f6777270527dee
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
3901145https://github.com/simstudioai/sim/pull/4905/commits/3901145d0086eb477fadecd586f6777270527dee
https://github.com/simstudioai/sim/tree/3901145d0086eb477fadecd586f6777270527dee
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.