| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/commits(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:178d4263-a14d-de2a-7b2d-70adf5eebb20 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 84D0:14B945:A0269E:DCE0DC:6AFB4FF0 |
| html-safe-nonce | 0526ccdc0b00722eca88dcb24336645e50ed47bfb9384d8238975c4f12310d27 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEQwOjE0Qjk0NTpBMDI2OUU6RENFMERDOjZBRkI0RkYwIiwidmlzaXRvcl9pZCI6IjQ3NDIyMTM0MTM1MzcyNzE3OTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 402246e7779c2511a9f78dd5280c008c442e602f22908734034a0f77e619d99a |
| hovercard-subject-tag | pull_request:3825746958 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/commits |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4905/commits |
| twitter:image | https://opengraph.githubassets.com/4c337b5a532d985872fa81d81e61459c6f1d5538f50c416c67bd557107f4cccc/simstudioai/sim/pull/4905 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4c337b5a532d985872fa81d81e61459c6f1d5538f50c416c67bd557107f4cccc/simstudioai/sim/pull/4905 |
| og:image:alt | Summary
Makes the EMCN modal system fully declarative across two button grammars, and migrates every consumer to it.
1. Props-driven ChipModalFooter / ChipModalHeader (form modals)
ChipModalFooter... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | emir-karabeg |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-cache |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/simstudioai/sim/pull/4905/commits#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4905%2Fcommits |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4905%2Fcommits |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=simstudioai%2Fsim |
| Reload | https://github.com/simstudioai/sim/pull/4905/commits |
| Reload | https://github.com/simstudioai/sim/pull/4905/commits |
| Reload | https://github.com/simstudioai/sim/pull/4905/commits |
| simstudioai | https://github.com/simstudioai |
| sim | https://github.com/simstudioai/sim |
| Code | https://github.com/simstudioai/sim |
| Issues129 (129) | https://github.com/simstudioai/sim/issues |
| Pull requests197 (197) | https://github.com/simstudioai/sim/pulls |
| Actions | https://github.com/simstudioai/sim/actions |
| Projects | https://github.com/simstudioai/sim/projects |
| Security and quality | https://github.com/simstudioai/sim/security |
| Insights | https://github.com/simstudioai/sim/pulse |
| https://github.com/simstudioai/sim |
| waleedlatif1 | https://github.com/waleedlatif1 |
| staging | https://github.com/simstudioai/sim/tree/staging |
| refactor/chip-modal-migration | https://github.com/simstudioai/sim/tree/refactor/chip-modal-migration |
| Conversation | https://github.com/simstudioai/sim/pull/4905 |
| Commits8 (8) | https://github.com/simstudioai/sim/pull/4905/commits |
| Checks | https://github.com/simstudioai/sim/pull/4905/checks |
| Files changed | https://github.com/simstudioai/sim/pull/4905/files |
| refactor(emcn): make ChipModal footer/header props-driven and migrate all consumers | https://github.com/simstudioai/sim/pull/4905/commits#top |
| waleedlatif1 | https://github.com/waleedlatif1 |
| staging | https://github.com/simstudioai/sim/tree/staging |
| refactor/chip-modal-migration | https://github.com/simstudioai/sim/tree/refactor/chip-modal-migration |
| refactor(emcn): make ChipModal footer/header props-driven and migrate all consumers | https://github.com/simstudioai/sim/pull/4905/commits/94d36b2304d745f0abde67b10a8163151321718f |
| https://github.com/emir-karabeg |
| emir-karabeg | https://github.com/simstudioai/sim/commits?author=emir-karabeg |
| 94d36b2 | https://github.com/simstudioai/sim/pull/4905/commits/94d36b2304d745f0abde67b10a8163151321718f |
| https://github.com/simstudioai/sim/tree/94d36b2304d745f0abde67b10a8163151321718f |
| fix(emcn): restore Cancel disable guard for in-flight ChipModal actions | https://github.com/simstudioai/sim/pull/4905/commits/6c7cbdb681de4dde8543e58c7f51b6c19cf52800 |
| https://github.com/emir-karabeg |
| emir-karabeg | https://github.com/simstudioai/sim/commits?author=emir-karabeg |
| 6c7cbdb | https://github.com/simstudioai/sim/pull/4905/commits/6c7cbdb681de4dde8543e58c7f51b6c19cf52800 |
| https://github.com/simstudioai/sim/tree/6c7cbdb681de4dde8543e58c7f51b6c19cf52800 |
| Merge remote-tracking branch 'origin/staging' into refactor/chip-modal-migration | https://github.com/simstudioai/sim/pull/4905/commits/9bc4a0f19468e32ee9b2e9bb83681ba28aff5d1a |
| https://github.com/emir-karabeg |
| emir-karabeg | https://github.com/simstudioai/sim/commits?author=emir-karabeg |
| 9bc4a0f | https://github.com/simstudioai/sim/pull/4905/commits/9bc4a0f19468e32ee9b2e9bb83681ba28aff5d1a |
| https://github.com/simstudioai/sim/tree/9bc4a0f19468e32ee9b2e9bb83681ba28aff5d1a |
| Merge remote-tracking branch 'origin/staging' into refactor/chip-modal-migration | https://github.com/simstudioai/sim/pull/4905/commits/535a2627e2ae7efbfd0b2a81066bde9ed76b93b8 |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| 535a262 | https://github.com/simstudioai/sim/pull/4905/commits/535a2627e2ae7efbfd0b2a81066bde9ed76b93b8 |
| https://github.com/simstudioai/sim/tree/535a2627e2ae7efbfd0b2a81066bde9ed76b93b8 |
| feat(emcn): add ChipConfirmModal confirmation primitive | https://github.com/simstudioai/sim/pull/4905/commits/d1990de173dd80129a6f715ee21a1cc0c240ad45 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| claude | https://github.com/simstudioai/sim/commits?author=claude |
| d1990de | https://github.com/simstudioai/sim/pull/4905/commits/d1990de173dd80129a6f715ee21a1cc0c240ad45 |
| https://github.com/simstudioai/sim/tree/d1990de173dd80129a6f715ee21a1cc0c240ad45 |
| refactor(emcn): migrate all confirmation dialogs to ChipConfirmModal | https://github.com/simstudioai/sim/pull/4905/commits/73e974c12cb816996f736335b53096efe15820dd |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| claude | https://github.com/simstudioai/sim/commits?author=claude |
| 73e974c | https://github.com/simstudioai/sim/pull/4905/commits/73e974c12cb816996f736335b53096efe15820dd |
| https://github.com/simstudioai/sim/tree/73e974c12cb816996f736335b53096efe15820dd |
| style(emcn): normalize confirm pendingLabel ellipsis to '...' | https://github.com/simstudioai/sim/pull/4905/commits/2d63e7655d884fba8ebd533fd7f1f0550a0390c5 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| claude | https://github.com/simstudioai/sim/commits?author=claude |
| 2d63e76 | https://github.com/simstudioai/sim/pull/4905/commits/2d63e7655d884fba8ebd533fd7f1f0550a0390c5 |
| https://github.com/simstudioai/sim/tree/2d63e7655d884fba8ebd533fd7f1f0550a0390c5 |
| fix(emcn): restore Enter-to-submit in form modals after footer migration | https://github.com/simstudioai/sim/pull/4905/commits/3901145d0086eb477fadecd586f6777270527dee |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| claude | https://github.com/simstudioai/sim/commits?author=claude |
| 3901145 | https://github.com/simstudioai/sim/pull/4905/commits/3901145d0086eb477fadecd586f6777270527dee |
| https://github.com/simstudioai/sim/tree/3901145d0086eb477fadecd586f6777270527dee |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |