René's URL Explorer Experiment


Title: fix(user-input): atomic chip selection, modifier-key handling, and stale overlay ghost by waleedlatif1 · Pull Request #4902 · simstudioai/sim · GitHub

Open Graph Title: fix(user-input): atomic chip selection, modifier-key handling, and stale overlay ghost by waleedlatif1 · Pull Request #4902 · simstudioai/sim

X Title: fix(user-input): atomic chip selection, modifier-key handling, and stale overlay ghost by waleedlatif1 · Pull Request #4902 · simstudioai/sim

Description: Summary Mention chips in the home user input are now atomic under every selection gesture: select-all, drag, Shift+arrows (grow and shrink), Cmd+Shift jumps, and double-click all snap selection edges to chip boundaries instead of collapsing the selection Plain arrow chip-hop no longer swallows Shift/Cmd/Alt/Ctrl arrow combos or IME composition; Cmd/Ctrl shortcuts are no longer blocked when the caret sits at a chip edge Fixed ghost text lingering after Cmd+A + Delete: the mirror overlay was an unnecessary composited scroll container whose stale GPU layer could outlive the clear — it is now pinned inset-0 with overflow-hidden and shares one class source with the textarea so the two layers can't drift Type of Change Bug fix Testing Tested manually (selection matrix: select-all, drag grow/shrink, shift-arrow grow/shrink across chips, cmd+shift jumps, double-click, click-in-chip caret snap). Typecheck and lint pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Mention chips in the home user input are now atomic under every selection gesture: select-all, drag, Shift+arrows (grow and shrink), Cmd+Shift jumps, and double-click all snap selection ed...

X Description: Summary Mention chips in the home user input are now atomic under every selection gesture: select-all, drag, Shift+arrows (grow and shrink), Cmd+Shift jumps, and double-click all snap selection ed...

Opengraph URL: https://github.com/simstudioai/sim/pull/4902

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1def3d65-8f94-d2ba-ea8f-be1652144167
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD2DC:2E9461:1E4A3E:2AE592:6AFB6F0B
html-safe-noncea697cf6a603924c15e03828a7e7d0347d64bd010276944b154f6d40ae9b214a7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkRDOjJFOTQ2MToxRTRBM0U6MkFFNTkyOjZBRkI2RjBCIiwidmlzaXRvcl9pZCI6Ijc4MzUzODI4MjA2OTkzMzY0NTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6bf84b1fc55ddbd92f57ca12358f103b476326238dda1a03d56be2cf44f38f5b
hovercard-subject-tagpull_request:3819418312
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4902/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Mention chips in the home user input are now atomic under every selection gesture: select-all, drag, Shift+arrows (grow and shrink), Cmd+Shift jumps, and double-click all snap selection ed...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecca289ecd54650fcf3c0b037a58b97186dee2cc4406819d87fab93728fd83700
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release88808b1fae5ab8a526a73e7ce5542a10eb9d6971
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/4902/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4902%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4902%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/4902/files
Reloadhttps://github.com/simstudioai/sim/pull/4902/files
Reloadhttps://github.com/simstudioai/sim/pull/4902/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/logohttps://github.com/simstudioai/sim/tree/fix/logo
Conversation 42 https://github.com/simstudioai/sim/pull/4902
Commits 13 https://github.com/simstudioai/sim/pull/4902/commits
Checks 13 https://github.com/simstudioai/sim/pull/4902/checks
Files changed https://github.com/simstudioai/sim/pull/4902/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4902/files
fix(user-input): atomic chip selection, modifier-key handling, and stale overlay ghost https://github.com/simstudioai/sim/pull/4902/files#top
Show all changes 13 commits https://github.com/simstudioai/sim/pull/4902/files
2e0aacd fix(user-input): atomic chip selection, modifier-key handling, and st… waleedlatif1 Jun 7, 2026 https://github.com/simstudioai/sim/pull/4902/commits/2e0aacdf50a4156ed576539ecfcad81746e19617
9567adf fix(user-input): track raw selection in ref and sync mention menus on… waleedlatif1 Jun 7, 2026 https://github.com/simstudioai/sim/pull/4902/commits/9567adf3890f8fc84e539e491928d1891dec0b2c
d1b3562 fix(user-input): translate overlay content instead of scrolling the o… waleedlatif1 Jun 7, 2026 https://github.com/simstudioai/sim/pull/4902/commits/d1b356285670d8428a4b03276b25cca3ff292030
1a2e63f fix(user-input): read selection direction at apply time, document edg… waleedlatif1 Jun 7, 2026 https://github.com/simstudioai/sim/pull/4902/commits/1a2e63fdc0eb06da4d7e0396aecd104df4d020d1
6997d3e fix(user-input): reconcile textarea DOM with state on selection events waleedlatif1 Jun 7, 2026 https://github.com/simstudioai/sim/pull/4902/commits/6997d3e288007ae88ab766fa171a013474cc5f1e
35a2591 fix(user-input): keep Cmd+Backspace native instead of single-chip delete waleedlatif1 Jun 7, 2026 https://github.com/simstudioai/sim/pull/4902/commits/35a2591f1c7556f050abd2effffee2576c11366f
7c3e298 fix(user-input): record observed selection before reconcile early-return waleedlatif1 Jun 7, 2026 https://github.com/simstudioai/sim/pull/4902/commits/7c3e298c7e3d7a16b59ee3f113c3d276c741ecbd
5b02798 refactor(user-input): extract adoptDomValue; drop flushSync pre-paint… waleedlatif1 Jun 7, 2026 https://github.com/simstudioai/sim/pull/4902/commits/5b027985ea6f6e0dd2de34eb7d8a32e1c767d7af
31c66fa refactor(user-input): native co-scroll for textarea + overlay, remove… waleedlatif1 Jun 7, 2026 https://github.com/simstudioai/sim/pull/4902/commits/31c66fa5958fb214ee94a64561f3d0bbc4e4e121
05af559 refactor(user-input): extract pure snapSelectionToChips with unit tests waleedlatif1 Jun 7, 2026 https://github.com/simstudioai/sim/pull/4902/commits/05af5590071848ef58b85deede4e2a881ea6854b
d505023 fix(user-input): track prev selection via selectionchange; make chip … waleedlatif1 Jun 8, 2026 https://github.com/simstudioai/sim/pull/4902/commits/d505023fd55bee5aef57c4ecd8e6ea2e9e389591
c2624ad docs(user-input): trim verbose comments in selection logic waleedlatif1 Jun 8, 2026 https://github.com/simstudioai/sim/pull/4902/commits/c2624adcf9d43bf247260c49e527b5d93b2de9ca
e2dfe15 fix(user-input): fall back to setRangeText when execCommand delete is… waleedlatif1 Jun 8, 2026 https://github.com/simstudioai/sim/pull/4902/commits/e2dfe15ec4dd32c4538ef22e960218614c294e66
Clear filters https://github.com/simstudioai/sim/pull/4902/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4902/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4902/files
chip-selection.test.ts https://github.com/simstudioai/sim/pull/4902/files#diff-5996204d6524ba46c6d7109fa990251aa41773bf8452dc559af97b0e115e86a4
chip-selection.ts https://github.com/simstudioai/sim/pull/4902/files#diff-4b00069a8411239fba93e85eccce03e380880569cda21e3b6835503b7eeb0b24
constants.ts https://github.com/simstudioai/sim/pull/4902/files#diff-722ba9dd9456aa1a476572d6129783a59a5a3c7880b6094d8233054202603952
index.ts https://github.com/simstudioai/sim/pull/4902/files#diff-bb4697c2b8c5121abc23cc3a103b0120cf7f487ecc58f80788e6017d4b2f389a
user-input.tsx https://github.com/simstudioai/sim/pull/4902/files#diff-a4d72576c5bd76f63419f4c296e3918e941f585f4ef74cd2d1a4443cc5db23b5
use-mention-tokens.ts https://github.com/simstudioai/sim/pull/4902/files#diff-52898a8088207ab78e6580806c76fa00cfce9bb9062f1530200fe698ac17e072
apps/sim/app/workspace/[workspaceId]/home/components/user-input/chip-selection.test.tshttps://github.com/simstudioai/sim/pull/4902/files#diff-5996204d6524ba46c6d7109fa990251aa41773bf8452dc559af97b0e115e86a4
View file https://github.com/simstudioai/sim/blob/e2dfe15ec4dd32c4538ef22e960218614c294e66/apps/sim/app/workspace/%5BworkspaceId%5D/home/components/user-input/chip-selection.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4902/{{ revealButtonHref }}
apps/sim/app/workspace/[workspaceId]/home/components/user-input/chip-selection.tshttps://github.com/simstudioai/sim/pull/4902/files#diff-4b00069a8411239fba93e85eccce03e380880569cda21e3b6835503b7eeb0b24
View file https://github.com/simstudioai/sim/blob/e2dfe15ec4dd32c4538ef22e960218614c294e66/apps/sim/app/workspace/%5BworkspaceId%5D/home/components/user-input/chip-selection.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4902/{{ revealButtonHref }}
apps/sim/app/workspace/[workspaceId]/home/components/user-input/components/constants.tshttps://github.com/simstudioai/sim/pull/4902/files#diff-722ba9dd9456aa1a476572d6129783a59a5a3c7880b6094d8233054202603952
View file https://github.com/simstudioai/sim/blob/e2dfe15ec4dd32c4538ef22e960218614c294e66/apps/sim/app/workspace/%5BworkspaceId%5D/home/components/user-input/components/constants.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4902/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4902/files#diff-722ba9dd9456aa1a476572d6129783a59a5a3c7880b6094d8233054202603952
https://github.com/simstudioai/sim/pull/4902/files#diff-722ba9dd9456aa1a476572d6129783a59a5a3c7880b6094d8233054202603952
https://github.com/simstudioai/sim/pull/4902/files#diff-722ba9dd9456aa1a476572d6129783a59a5a3c7880b6094d8233054202603952
apps/sim/app/workspace/[workspaceId]/home/components/user-input/components/index.tshttps://github.com/simstudioai/sim/pull/4902/files#diff-bb4697c2b8c5121abc23cc3a103b0120cf7f487ecc58f80788e6017d4b2f389a
View file https://github.com/simstudioai/sim/blob/e2dfe15ec4dd32c4538ef22e960218614c294e66/apps/sim/app/workspace/%5BworkspaceId%5D/home/components/user-input/components/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4902/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4902/files#diff-bb4697c2b8c5121abc23cc3a103b0120cf7f487ecc58f80788e6017d4b2f389a
https://github.com/simstudioai/sim/pull/4902/files#diff-bb4697c2b8c5121abc23cc3a103b0120cf7f487ecc58f80788e6017d4b2f389a
Please reload this pagehttps://github.com/simstudioai/sim/pull/4902/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4902/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.