René's URL Explorer Experiment


Title: fix(dev): use globalThis for singleton state to prevent HMR memory leaks by waleedlatif1 · Pull Request #4869 · simstudioai/sim · GitHub

Open Graph Title: fix(dev): use globalThis for singleton state to prevent HMR memory leaks by waleedlatif1 · Pull Request #4869 · simstudioai/sim

X Title: fix(dev): use globalThis for singleton state to prevent HMR memory leaks by waleedlatif1 · Pull Request #4869 · simstudioai/sim

Description: Summary Redis client, ping interval, MCP pub/sub channels, MCP connection manager, task pub/sub, tool confirmation channel, and execution cancellation channel were all instantiated at module scope Next.js HMR re-evaluates module code on every file save, creating new instances while old ones are retained in memory via setInterval/setTimeout closures — causing unbounded memory growth in dev (observed: 68GB) Moved all singleton state to globalThis so it survives HMR re-evaluations and is only created once per process Type of Change Bug fix Testing Tested manually Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Redis client, ping interval, MCP pub/sub channels, MCP connection manager, task pub/sub, tool confirmation channel, and execution cancellation channel were all instantiated at module scope...

X Description: Summary Redis client, ping interval, MCP pub/sub channels, MCP connection manager, task pub/sub, tool confirmation channel, and execution cancellation channel were all instantiated at module scope...

Opengraph URL: https://github.com/simstudioai/sim/pull/4869

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:36eb30a8-fa72-fdeb-b0d8-e681cb0163f1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9A66:1EC912:90028F:CC0734:6AFB513E
html-safe-noncedec025d22affd878424d8c7029806d2e61de606300a6f2fb94c3376baecbddb7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTY2OjFFQzkxMjo5MDAyOEY6Q0MwNzM0OjZBRkI1MTNFIiwidmlzaXRvcl9pZCI6IjMzNTg5OTA5Nzc5MjUzMzc0MDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4fcc53b408ca4cf2753547bdb0dab4512d43d89f4e1dd7435ae898778e8c0a4a
hovercard-subject-tagpull_request:3798244370
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4869/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Redis client, ping interval, MCP pub/sub channels, MCP connection manager, task pub/sub, tool confirmation channel, and execution cancellation channel were all instantiated at module scope...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/4869/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4869%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4869%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/4869/files
Reloadhttps://github.com/simstudioai/sim/pull/4869/files
Reloadhttps://github.com/simstudioai/sim/pull/4869/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/hmr-singleton-leakhttps://github.com/simstudioai/sim/tree/fix/hmr-singleton-leak
Conversation 9 https://github.com/simstudioai/sim/pull/4869
Commits 3 https://github.com/simstudioai/sim/pull/4869/commits
Checks 13 https://github.com/simstudioai/sim/pull/4869/checks
Files changed https://github.com/simstudioai/sim/pull/4869/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4869/files
fix(dev): use globalThis for singleton state to prevent HMR memory leaks https://github.com/simstudioai/sim/pull/4869/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/4869/files
57eafa7 fix(dev): use globalThis for singleton state to prevent HMR memory leaks waleedlatif1 Jun 3, 2026 https://github.com/simstudioai/sim/pull/4869/commits/57eafa7b9e95bcf7bc821af4505a5aa2f8374f33
54d4446 fix(dev): apply globalThis guard to rate-limiter storage factory to p… waleedlatif1 Jun 3, 2026 https://github.com/simstudioai/sim/pull/4869/commits/54d4446d375caa1f9ceaf41b52f00473195d9da7
138f146 fix(types): resolve McpConnectionManager globalThis undefined type error waleedlatif1 Jun 3, 2026 https://github.com/simstudioai/sim/pull/4869/commits/138f146365a592720189e65599250fbf75e3d85d
Clear filters https://github.com/simstudioai/sim/pull/4869/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4869/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4869/files
index.ts https://github.com/simstudioai/sim/pull/4869/files#diff-74eb83dd34560c50c56aece5b3a730f1ae0afea32f489ed81524552aee1fd690
tasks.ts https://github.com/simstudioai/sim/pull/4869/files#diff-5d34e248aabcaf8d5088f4c28b1bcf01a9af68310e9e7ffdc12bec910a248edc
redis.ts https://github.com/simstudioai/sim/pull/4869/files#diff-af191f255d57cc29ed5bf97c929967b6b922d94d754a7d73abcbf88594b4dc7d
factory.ts https://github.com/simstudioai/sim/pull/4869/files#diff-2c61f378b3d959c44323b4fbc0b2b5b6f6fab3afac6a04611c67cbce2948771d
cancellation.ts https://github.com/simstudioai/sim/pull/4869/files#diff-9ecf6712715bd985d8bab22d6b5bb4bf8530163f11e12a2f240a32916a19ff63
connection-manager.ts https://github.com/simstudioai/sim/pull/4869/files#diff-c4c5382013f44bc01eced63f50ecfcb606b8671498f14bb3e27467c1a5b632a1
pubsub.ts https://github.com/simstudioai/sim/pull/4869/files#diff-966d8e96b6bfc9a2afef720e0bc1d34930d27bbce7eec288d9417303df911800
apps/sim/lib/copilot/persistence/tool-confirm/index.tshttps://github.com/simstudioai/sim/pull/4869/files#diff-74eb83dd34560c50c56aece5b3a730f1ae0afea32f489ed81524552aee1fd690
View file https://github.com/simstudioai/sim/blob/138f146365a592720189e65599250fbf75e3d85d/apps/sim/lib/copilot/persistence/tool-confirm/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4869/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4869/files#diff-74eb83dd34560c50c56aece5b3a730f1ae0afea32f489ed81524552aee1fd690
https://github.com/simstudioai/sim/pull/4869/files#diff-74eb83dd34560c50c56aece5b3a730f1ae0afea32f489ed81524552aee1fd690
apps/sim/lib/copilot/tasks.tshttps://github.com/simstudioai/sim/pull/4869/files#diff-5d34e248aabcaf8d5088f4c28b1bcf01a9af68310e9e7ffdc12bec910a248edc
View file https://github.com/simstudioai/sim/blob/138f146365a592720189e65599250fbf75e3d85d/apps/sim/lib/copilot/tasks.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4869/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4869/files#diff-5d34e248aabcaf8d5088f4c28b1bcf01a9af68310e9e7ffdc12bec910a248edc
https://github.com/simstudioai/sim/pull/4869/files#diff-5d34e248aabcaf8d5088f4c28b1bcf01a9af68310e9e7ffdc12bec910a248edc
https://github.com/simstudioai/sim/pull/4869/files#diff-5d34e248aabcaf8d5088f4c28b1bcf01a9af68310e9e7ffdc12bec910a248edc
apps/sim/lib/core/config/redis.tshttps://github.com/simstudioai/sim/pull/4869/files#diff-af191f255d57cc29ed5bf97c929967b6b922d94d754a7d73abcbf88594b4dc7d
View file https://github.com/simstudioai/sim/blob/138f146365a592720189e65599250fbf75e3d85d/apps/sim/lib/core/config/redis.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4869/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4869/files#diff-af191f255d57cc29ed5bf97c929967b6b922d94d754a7d73abcbf88594b4dc7d
Please reload this pagehttps://github.com/simstudioai/sim/pull/4869/files
https://github.com/simstudioai/sim/pull/4869/files#diff-af191f255d57cc29ed5bf97c929967b6b922d94d754a7d73abcbf88594b4dc7d
https://github.com/simstudioai/sim/pull/4869/files#diff-af191f255d57cc29ed5bf97c929967b6b922d94d754a7d73abcbf88594b4dc7d
https://github.com/simstudioai/sim/pull/4869/files#diff-af191f255d57cc29ed5bf97c929967b6b922d94d754a7d73abcbf88594b4dc7d
https://github.com/simstudioai/sim/pull/4869/files#diff-af191f255d57cc29ed5bf97c929967b6b922d94d754a7d73abcbf88594b4dc7d
https://github.com/simstudioai/sim/pull/4869/files#diff-af191f255d57cc29ed5bf97c929967b6b922d94d754a7d73abcbf88594b4dc7d
https://github.com/simstudioai/sim/pull/4869/files#diff-af191f255d57cc29ed5bf97c929967b6b922d94d754a7d73abcbf88594b4dc7d
apps/sim/lib/core/rate-limiter/storage/factory.tshttps://github.com/simstudioai/sim/pull/4869/files#diff-2c61f378b3d959c44323b4fbc0b2b5b6f6fab3afac6a04611c67cbce2948771d
View file https://github.com/simstudioai/sim/blob/138f146365a592720189e65599250fbf75e3d85d/apps/sim/lib/core/rate-limiter/storage/factory.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4869/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4869/files#diff-2c61f378b3d959c44323b4fbc0b2b5b6f6fab3afac6a04611c67cbce2948771d
https://github.com/simstudioai/sim/pull/4869/files#diff-2c61f378b3d959c44323b4fbc0b2b5b6f6fab3afac6a04611c67cbce2948771d
apps/sim/lib/execution/cancellation.tshttps://github.com/simstudioai/sim/pull/4869/files#diff-9ecf6712715bd985d8bab22d6b5bb4bf8530163f11e12a2f240a32916a19ff63
View file https://github.com/simstudioai/sim/blob/138f146365a592720189e65599250fbf75e3d85d/apps/sim/lib/execution/cancellation.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4869/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4869/files#diff-9ecf6712715bd985d8bab22d6b5bb4bf8530163f11e12a2f240a32916a19ff63
https://github.com/simstudioai/sim/pull/4869/files#diff-9ecf6712715bd985d8bab22d6b5bb4bf8530163f11e12a2f240a32916a19ff63
apps/sim/lib/mcp/connection-manager.tshttps://github.com/simstudioai/sim/pull/4869/files#diff-c4c5382013f44bc01eced63f50ecfcb606b8671498f14bb3e27467c1a5b632a1
View file https://github.com/simstudioai/sim/blob/138f146365a592720189e65599250fbf75e3d85d/apps/sim/lib/mcp/connection-manager.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4869/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4869/files#diff-c4c5382013f44bc01eced63f50ecfcb606b8671498f14bb3e27467c1a5b632a1
Please reload this pagehttps://github.com/simstudioai/sim/pull/4869/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4869/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.