René's URL Explorer Experiment


Title: fix(auth): link SSO sign-in to existing same-email accounts by waleedlatif1 · Pull Request #4866 · simstudioai/sim · GitHub

Open Graph Title: fix(auth): link SSO sign-in to existing same-email accounts by waleedlatif1 · Pull Request #4866 · simstudioai/sim

X Title: fix(auth): link SSO sign-in to existing same-email accounts by waleedlatif1 · Pull Request #4866 · simstudioai/sim

Description: Problem Self-hosted SSO sign-ins failed with account not linked, followed by a cascading ERROR [Better Auth]: Invalid callbackURL that left the user stuck. It surfaced after the better-auth 1.3.12 → 1.6.11 upgrade (#4766). Root cause (verified against the 1.6.11 source): @better-auth/sso provisions the user with emailVerified: options?.trustEmailVerified ? : false. With trustEmailVerified unset, every SSO login arrives emailVerified: false, which trips the account-linking gate in handleOAuthUserInfo: (!isTrustedProvider && !userInfo.emailVerified) || (requireLocalEmailVerified && !dbUser.emailVerified) || enabled === false || disableImplicitLinking === true For Sim's config only the first term can fire — so when the configured SSO providerId isn't in accountLinking.trustedProviders and the IdP email isn't treated as verified, an existing same-email account (e.g. prior email/password signup) can't be linked. The literal-spaces error string (account not linked, not account_not_linked) pins the failure to the OIDC callback. Fix trustEmailVerified: true on the SSO plugin — honor the IdP's verified-email claim (Okta, Entra ID, Google Workspace, Auth0 all assert it). Closes the gate via userInfo.emailVerified. Trust the operator's provider — merge SSO_PROVIDER_ID (when present in the app environment) plus a new optional SSO_TRUSTED_PROVIDER_IDS (comma-separated) into trustedProviders. Closes the gate via isTrustedProvider, unconditionally, for IdPs that omit email_verified. Computed only when SSO_ENABLED and empty/unset ⇒ [] ⇒ no behavior change for non-SSO / unconfigured deployments. Docs — SSO_TRUSTED_PROVIDER_IDS documented in the SSO docs, Helm values.yaml, and values.schema.json; new FAQ + callout for the same-email linking behavior. Safety / regressions The two levers each independently close the gate; either one fixes the bug. trustEmailVerified is evaluated live per sign-in (covers any provider, incl. SAML, which runs the same gate in 1.6.11). With no SSO env vars set (or SSO_ENABLED off), the trusted-provider list is [] and trustEmailVerified lives inside the SSO_ENABLED block — byte-for-byte equivalent config for non-SSO / unconfigured deployments. No new attack surface: linking remains domain-scoped (a provider only handles its registered, conflict-checked email domain). trustEmailVerified is strictly more conservative than the pre-existing unconditional trust of common provider IDs. No tests assert the prior behavior; Biome clean; check:api-validation at baseline. Notes An earlier revision also simplified the invite getCallbackUrl() (dropping ?token=); that was reverted after review — it removed the sessionStorage-unavailable fallback for no real benefit, since the account-linking fix removes the error that produced the malformed callback URL, and the success path keeps the token-bearing URL working. The middleware (proxy.ts) still carries the invite token in the login callbackUrl, which is the existing, working behavior.

Open Graph Description: Problem Self-hosted SSO sign-ins failed with account not linked, followed by a cascading ERROR [Better Auth]: Invalid callbackURL that left the user stuck. It surfaced after the better-auth 1.3.12 ...

X Description: Problem Self-hosted SSO sign-ins failed with account not linked, followed by a cascading ERROR [Better Auth]: Invalid callbackURL that left the user stuck. It surfaced after the better-auth 1.3.12 ...

Opengraph URL: https://github.com/simstudioai/sim/pull/4866

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d7a1564b-398e-e0bf-d9db-9686e276b83b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCEAC:14B945:A5D6D1:E49526:6AFB515C
html-safe-nonce92de44b2862e0ed35aac2a9cd10746230a0033f33c45f8e1c64daea8f29371e1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUFDOjE0Qjk0NTpBNUQ2RDE6RTQ5NTI2OjZBRkI1MTVDIiwidmlzaXRvcl9pZCI6IjY5NjE5Mjg2MTg5MzA1NTcyNzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac47729e01660b7ffe50617634e7a7bf70801ad6f1cc64941095287cdfcfbc9087
hovercard-subject-tagpull_request:3797310720
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4866/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altProblem Self-hosted SSO sign-ins failed with account not linked, followed by a cascading ERROR [Better Auth]: Invalid callbackURL that left the user stuck. It surfaced after the better-auth 1.3.12 ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/4866/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4866%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4866%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/4866/files
Reloadhttps://github.com/simstudioai/sim/pull/4866/files
Reloadhttps://github.com/simstudioai/sim/pull/4866/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
waleedlatif1/-nonehttps://github.com/simstudioai/sim/tree/waleedlatif1/-none
Conversation 16 https://github.com/simstudioai/sim/pull/4866
Commits 4 https://github.com/simstudioai/sim/pull/4866/commits
Checks 13 https://github.com/simstudioai/sim/pull/4866/checks
Files changed https://github.com/simstudioai/sim/pull/4866/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4866/files
fix(auth): link SSO sign-in to existing same-email accounts https://github.com/simstudioai/sim/pull/4866/files#top
Show all changes 4 commits https://github.com/simstudioai/sim/pull/4866/files
b07ee18 fix(auth): link SSO sign-in to existing same-email accounts waleedlatif1 Jun 3, 2026 https://github.com/simstudioai/sim/pull/4866/commits/b07ee18ad544a73666a136c8d671f5d00e167820
45d5d64 fix(auth): address review — guard trusted SSO providers, revert invit… waleedlatif1 Jun 3, 2026 https://github.com/simstudioai/sim/pull/4866/commits/45d5d64b7f097221a4438fef0518a2b84c619cfe
481c66d fix(auth): guard trusted SSO providers with isSsoEnabled (isTruthy) waleedlatif1 Jun 3, 2026 https://github.com/simstudioai/sim/pull/4866/commits/481c66d3c46ba1eea17ce89b49693aabb5defd36
b08e6cf Merge remote-tracking branch 'origin/staging' into waleedlatif1/-none waleedlatif1 Jun 3, 2026 https://github.com/simstudioai/sim/pull/4866/commits/b08e6cfad8d7c634041fbde20260b88f80872b3b
Clear filters https://github.com/simstudioai/sim/pull/4866/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4866/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4866/files
sso.mdx https://github.com/simstudioai/sim/pull/4866/files#diff-bade541a41f563ad989dbd6d95398fe1d71812bff33ea8bd2fb419ab4309d4c3
auth.ts https://github.com/simstudioai/sim/pull/4866/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
env.ts https://github.com/simstudioai/sim/pull/4866/files#diff-7db3fc610ff89cf819c4eb69b43ec37ae18530e1861f6c322faeb62f8f48f298
values.schema.json https://github.com/simstudioai/sim/pull/4866/files#diff-3203678a723acd84dd61f119ae4b9e439b04d35a123c7918821e20c31a72c791
values.yaml https://github.com/simstudioai/sim/pull/4866/files#diff-5586790157aac5be1a3be674910d22e602e8c840abbf289d0ad31ffb5dac5cb1
apps/docs/content/docs/en/enterprise/sso.mdxhttps://github.com/simstudioai/sim/pull/4866/files#diff-bade541a41f563ad989dbd6d95398fe1d71812bff33ea8bd2fb419ab4309d4c3
View file https://github.com/simstudioai/sim/blob/b08e6cfad8d7c634041fbde20260b88f80872b3b/apps/docs/content/docs/en/enterprise/sso.mdx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4866/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4866/files#diff-bade541a41f563ad989dbd6d95398fe1d71812bff33ea8bd2fb419ab4309d4c3
https://github.com/simstudioai/sim/pull/4866/files#diff-bade541a41f563ad989dbd6d95398fe1d71812bff33ea8bd2fb419ab4309d4c3
https://github.com/simstudioai/sim/pull/4866/files#diff-bade541a41f563ad989dbd6d95398fe1d71812bff33ea8bd2fb419ab4309d4c3
https://github.com/simstudioai/sim/pull/4866/files#diff-bade541a41f563ad989dbd6d95398fe1d71812bff33ea8bd2fb419ab4309d4c3
apps/sim/lib/auth/auth.tshttps://github.com/simstudioai/sim/pull/4866/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
View file https://github.com/simstudioai/sim/blob/b08e6cfad8d7c634041fbde20260b88f80872b3b/apps/sim/lib/auth/auth.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4866/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4866/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/4866/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/4866/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
Please reload this pagehttps://github.com/simstudioai/sim/pull/4866/files
https://github.com/simstudioai/sim/pull/4866/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/4866/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/4866/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/4866/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/4866/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
apps/sim/lib/core/config/env.tshttps://github.com/simstudioai/sim/pull/4866/files#diff-7db3fc610ff89cf819c4eb69b43ec37ae18530e1861f6c322faeb62f8f48f298
View file https://github.com/simstudioai/sim/blob/b08e6cfad8d7c634041fbde20260b88f80872b3b/apps/sim/lib/core/config/env.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4866/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4866/files#diff-7db3fc610ff89cf819c4eb69b43ec37ae18530e1861f6c322faeb62f8f48f298
https://github.com/simstudioai/sim/pull/4866/files#diff-7db3fc610ff89cf819c4eb69b43ec37ae18530e1861f6c322faeb62f8f48f298
helm/sim/values.schema.jsonhttps://github.com/simstudioai/sim/pull/4866/files#diff-3203678a723acd84dd61f119ae4b9e439b04d35a123c7918821e20c31a72c791
View file https://github.com/simstudioai/sim/blob/b08e6cfad8d7c634041fbde20260b88f80872b3b/helm/sim/values.schema.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4866/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4866/files#diff-3203678a723acd84dd61f119ae4b9e439b04d35a123c7918821e20c31a72c791
https://github.com/simstudioai/sim/pull/4866/files#diff-3203678a723acd84dd61f119ae4b9e439b04d35a123c7918821e20c31a72c791
helm/sim/values.yamlhttps://github.com/simstudioai/sim/pull/4866/files#diff-5586790157aac5be1a3be674910d22e602e8c840abbf289d0ad31ffb5dac5cb1
View file https://github.com/simstudioai/sim/blob/b08e6cfad8d7c634041fbde20260b88f80872b3b/helm/sim/values.yaml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4866/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4866/files#diff-5586790157aac5be1a3be674910d22e602e8c840abbf289d0ad31ffb5dac5cb1
https://github.com/simstudioai/sim/pull/4866/files#diff-5586790157aac5be1a3be674910d22e602e8c840abbf289d0ad31ffb5dac5cb1
Please reload this pagehttps://github.com/simstudioai/sim/pull/4866/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.