Title: fix(condition-execution): parallel execution of output blocks from condition block by aadamgough · Pull Request #486 · simstudioai/sim · GitHub
Open Graph Title: fix(condition-execution): parallel execution of output blocks from condition block by aadamgough · Pull Request #486 · simstudioai/sim
X Title: fix(condition-execution): parallel execution of output blocks from condition block by aadamgough · Pull Request #486 · simstudioai/sim
Description: Description When there are multiple output edges from a connection block, only the first block connected to a condition handle was added to activeExecutionPath, which would cause other blocks to not execute in parallel. Now, all blocks connected to the selected condition handle are added to activeExecutionPath. This follows same pattern as other block execution paths. Type of change Please delete options that are not relevant. Bug fix (non-breaking change which fixes an issue) How Has This Been Tested? Recreated the issue in prod, added multiple outgoing edges of the conditional block to confirm that they execute in parallel. Checklist: My code follows the style guidelines of this project I have performed a self-review of my own code I have commented my code, particularly in hard-to-understand areas I have added tests that prove my fix is effective or that my feature works All tests pass locally and in CI (bun run test) My changes generate no new warnings Any dependent changes have been merged and published in downstream modules I have updated version numbers as needed (if needed) I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) Security Considerations: My changes do not introduce any new security vulnerabilities I have considered the security implications of my changes
Open Graph Description: Description When there are multiple output edges from a connection block, only the first block connected to a condition handle was added to activeExecutionPath, which would cause other blocks to no...
X Description: Description When there are multiple output edges from a connection block, only the first block connected to a condition handle was added to activeExecutionPath, which would cause other blocks to no...
Opengraph URL: https://github.com/simstudioai/sim/pull/486
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:728845ff-7c72-2717-b6d7-2cdca2395250 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BCAE:303206:B5D2E0:1002BFD:6AFB597F |
| html-safe-nonce | aa4991f475a8f3c36ba26648f8f1ec7bbbfc2db8f03af9f2eccbde34ad2d6377 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQ0FFOjMwMzIwNjpCNUQyRTA6MTAwMkJGRDo2QUZCNTk3RiIsInZpc2l0b3JfaWQiOiIxNTAyMjI2MjE0NDIzMzIwOTYwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ee218625aa1577292ea82471ebf5cc1ac4c48c2e4bdacb90fe831794f69373f4 |
| hovercard-subject-tag | pull_request:2589110662 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/486/files |
| twitter:image | https://avatars.githubusercontent.com/u/77861281?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/77861281?s=400&v=4 |
| og:image:alt | Description When there are multiple output edges from a connection block, only the first block connected to a condition handle was added to activeExecutionPath, which would cause other blocks to no... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | ea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ef97164c52cf59bd10558ddec9c4f482763988 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width