René's URL Explorer Experiment


Title: fix(files): never dedup external URL fetches by path filename by waleedlatif1 · Pull Request #4733 · simstudioai/sim · GitHub

Open Graph Title: fix(files): never dedup external URL fetches by path filename by waleedlatif1 · Pull Request #4733 · simstudioai/sim

X Title: fix(files): never dedup external URL fetches by path filename by waleedlatif1 · Pull Request #4733 · simstudioai/sim

Description: Summary External URL fetches in the file parse route were keyed on the path filename, so two distinct URLs ending in image.png (e.g. every Slack clipboard paste) collided in the workspace cache and returned stale bytes from a prior fetch Extracted fetch + workspace save into fetchExternalUrlToWorkspace helper so the broken dedup pattern can't be reintroduced Helper always downloads; uploadWorkspaceFile already disambiguates same-name collisions on save (image.png -> image (1).png -> ...) Audited the rest of the codebase for the same anti-pattern — none found, isolated to this route Type of Change Bug fix Testing New helper unit tests covering URL-vs-filename independence, SSRF rejection, permission gating, save-error handling, and header forwarding Updated route test that previously asserted the buggy cache-reuse behavior — now asserts both URLs fetch fresh Full `apps/sim/lib/uploads` + `apps/sim/app/api/files` suite green (158 tests) `bun run check:api-validation` passes Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary External URL fetches in the file parse route were keyed on the path filename, so two distinct URLs ending in image.png (e.g. every Slack clipboard paste) collided in the workspace cache an...

X Description: Summary External URL fetches in the file parse route were keyed on the path filename, so two distinct URLs ending in image.png (e.g. every Slack clipboard paste) collided in the workspace cache an...

Opengraph URL: https://github.com/simstudioai/sim/pull/4733

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2f1d812b-5886-c4ad-50b1-6dc31c247747
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAA4E:37E613:D2FD49:1232410:6AFB5DBA
html-safe-noncefbe93811c5ec47df1bcb0fb9ac7859b84035da21112548dedaec960656edd3c9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTRFOjM3RTYxMzpEMkZENDk6MTIzMjQxMDo2QUZCNURCQSIsInZpc2l0b3JfaWQiOiIxNTg4NTk2Mjc1ODc0MDYxNzU0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1eef580e3cc7d458179b97d15b0508352830a86a6ed2f51048786fa6e483413e
hovercard-subject-tagpull_request:3735920941
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4733/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary External URL fetches in the file parse route were keyed on the path filename, so two distinct URLs ending in image.png (e.g. every Slack clipboard paste) collided in the workspace cache an...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/4733/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4733%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4733%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/4733/files
Reloadhttps://github.com/simstudioai/sim/pull/4733/files
Reloadhttps://github.com/simstudioai/sim/pull/4733/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
waleedlatif1/slack-file-cache-key-bughttps://github.com/simstudioai/sim/tree/waleedlatif1/slack-file-cache-key-bug
Conversation 9 https://github.com/simstudioai/sim/pull/4733
Commits 2 https://github.com/simstudioai/sim/pull/4733/commits
Checks 13 https://github.com/simstudioai/sim/pull/4733/checks
Files changed https://github.com/simstudioai/sim/pull/4733/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4733/files
fix(files): never dedup external URL fetches by path filename https://github.com/simstudioai/sim/pull/4733/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/4733/files
13cf392 fix(files): never dedup external URL fetches by path filename waleedlatif1 May 23, 2026 https://github.com/simstudioai/sim/pull/4733/commits/13cf392ceb188568646ccb24542ce994274d0c22
ab766f5 fix(files): distinguish non-member from read-only in workspace-save s… waleedlatif1 May 23, 2026 https://github.com/simstudioai/sim/pull/4733/commits/ab766f55ec6d9c99943708286cff592875c5fb17
Clear filters https://github.com/simstudioai/sim/pull/4733/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4733/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4733/files
route.test.ts https://github.com/simstudioai/sim/pull/4733/files#diff-94b695313032a8ece810a35226318b21b74f1eec2fa53d6fd95f5d3e4cec20e2
route.ts https://github.com/simstudioai/sim/pull/4733/files#diff-5de8408eba335984f30d739706963bb60ea778413ab6a54836d2524ef2b7c968
fetch-external-url.test.ts https://github.com/simstudioai/sim/pull/4733/files#diff-270277b8cd32e78a4be34c6cd10bb177697150165c604ee57c02f48b6da077c5
fetch-external-url.ts https://github.com/simstudioai/sim/pull/4733/files#diff-3b96ff9cacb7268579c8c67c7ec04dfca4c0c8221707257710289b403f85c028
index.ts https://github.com/simstudioai/sim/pull/4733/files#diff-53adaf73a02c63e7c25631d9c064291be434a717f8d6b7a00aac382e85e7cd99
apps/sim/app/api/files/parse/route.test.tshttps://github.com/simstudioai/sim/pull/4733/files#diff-94b695313032a8ece810a35226318b21b74f1eec2fa53d6fd95f5d3e4cec20e2
View file https://github.com/simstudioai/sim/blob/ab766f55ec6d9c99943708286cff592875c5fb17/apps/sim/app/api/files/parse/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4733/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4733/files#diff-94b695313032a8ece810a35226318b21b74f1eec2fa53d6fd95f5d3e4cec20e2
https://github.com/simstudioai/sim/pull/4733/files#diff-94b695313032a8ece810a35226318b21b74f1eec2fa53d6fd95f5d3e4cec20e2
https://github.com/simstudioai/sim/pull/4733/files#diff-94b695313032a8ece810a35226318b21b74f1eec2fa53d6fd95f5d3e4cec20e2
https://github.com/simstudioai/sim/pull/4733/files#diff-94b695313032a8ece810a35226318b21b74f1eec2fa53d6fd95f5d3e4cec20e2
https://github.com/simstudioai/sim/pull/4733/files#diff-94b695313032a8ece810a35226318b21b74f1eec2fa53d6fd95f5d3e4cec20e2
https://github.com/simstudioai/sim/pull/4733/files#diff-94b695313032a8ece810a35226318b21b74f1eec2fa53d6fd95f5d3e4cec20e2
https://github.com/simstudioai/sim/pull/4733/files#diff-94b695313032a8ece810a35226318b21b74f1eec2fa53d6fd95f5d3e4cec20e2
https://github.com/simstudioai/sim/pull/4733/files#diff-94b695313032a8ece810a35226318b21b74f1eec2fa53d6fd95f5d3e4cec20e2
https://github.com/simstudioai/sim/pull/4733/files#diff-94b695313032a8ece810a35226318b21b74f1eec2fa53d6fd95f5d3e4cec20e2
https://github.com/simstudioai/sim/pull/4733/files#diff-94b695313032a8ece810a35226318b21b74f1eec2fa53d6fd95f5d3e4cec20e2
https://github.com/simstudioai/sim/pull/4733/files#diff-94b695313032a8ece810a35226318b21b74f1eec2fa53d6fd95f5d3e4cec20e2
apps/sim/app/api/files/parse/route.tshttps://github.com/simstudioai/sim/pull/4733/files#diff-5de8408eba335984f30d739706963bb60ea778413ab6a54836d2524ef2b7c968
View file https://github.com/simstudioai/sim/blob/ab766f55ec6d9c99943708286cff592875c5fb17/apps/sim/app/api/files/parse/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4733/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4733/files#diff-5de8408eba335984f30d739706963bb60ea778413ab6a54836d2524ef2b7c968
https://github.com/simstudioai/sim/pull/4733/files#diff-5de8408eba335984f30d739706963bb60ea778413ab6a54836d2524ef2b7c968
https://github.com/simstudioai/sim/pull/4733/files#diff-5de8408eba335984f30d739706963bb60ea778413ab6a54836d2524ef2b7c968
https://github.com/simstudioai/sim/pull/4733/files#diff-5de8408eba335984f30d739706963bb60ea778413ab6a54836d2524ef2b7c968
https://github.com/simstudioai/sim/pull/4733/files#diff-5de8408eba335984f30d739706963bb60ea778413ab6a54836d2524ef2b7c968
https://github.com/simstudioai/sim/pull/4733/files#diff-5de8408eba335984f30d739706963bb60ea778413ab6a54836d2524ef2b7c968
https://github.com/simstudioai/sim/pull/4733/files#diff-5de8408eba335984f30d739706963bb60ea778413ab6a54836d2524ef2b7c968
https://github.com/simstudioai/sim/pull/4733/files#diff-5de8408eba335984f30d739706963bb60ea778413ab6a54836d2524ef2b7c968
https://github.com/simstudioai/sim/pull/4733/files#diff-5de8408eba335984f30d739706963bb60ea778413ab6a54836d2524ef2b7c968
Please reload this pagehttps://github.com/simstudioai/sim/pull/4733/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4733/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.