René's URL Explorer Experiment


Title: fix(tools): pin resolved IP in DB connectors to prevent DNS-rebinding SSRF by waleedlatif1 · Pull Request #4725 · simstudioai/sim · GitHub

Open Graph Title: fix(tools): pin resolved IP in DB connectors to prevent DNS-rebinding SSRF by waleedlatif1 · Pull Request #4725 · simstudioai/sim

X Title: fix(tools): pin resolved IP in DB connectors to prevent DNS-rebinding SSRF by waleedlatif1 · Pull Request #4725 · simstudioai/sim

Description: Summary validateDatabaseHost resolved an IP that was then discarded; the drivers re-resolved the hostname at connect time, leaving a DNS-rebinding TOCTOU window MongoDB: pass resolved IP via the MongoClient lookup option MySQL: pin the TCP socket via the stream factory; keep config.host for TLS servername PostgreSQL: connect to resolved IP; pass ssl as object with servername so SNI works against the pinned IP Redis: parse the URL explicitly and pass options-only (URL+options doesn't override host due to ioredis's lodash.defaults); set tls.servername for rediss:// Neo4j: pin IP only for plain bolt://; leave bolt+s/neo4j+s unchanged so Aura cert validation keeps working (driver hardcodes servername with no override) Type of Change Bug fix (security) Testing Tested manually. Type-check, biome lint, and bun run check:api-validation all pass. Driver source code reviewed to verify each pinning mechanism reaches the underlying net.connect/tls.connect call. Pre-merge verification still needed against live managed providers (Atlas, RDS, Heroku PG, ElastiCache TLS, Aura). Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary validateDatabaseHost resolved an IP that was then discarded; the drivers re-resolved the hostname at connect time, leaving a DNS-rebinding TOCTOU window MongoDB: pass resolved IP via the M...

X Description: Summary validateDatabaseHost resolved an IP that was then discarded; the drivers re-resolved the hostname at connect time, leaving a DNS-rebinding TOCTOU window MongoDB: pass resolved IP via the M...

Opengraph URL: https://github.com/simstudioai/sim/pull/4725

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8317b759-5e1c-a1ce-9904-a0836964ab50
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB80:9D91A:1CB6CE:289909:6AFB502E
html-safe-nonce05af86f32a280b4ced0074538c8cc27258dffa6333a4bdd614020ebe20f5b280
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjgwOjlEOTFBOjFDQjZDRToyODk5MDk6NkFGQjUwMkUiLCJ2aXNpdG9yX2lkIjoiMjE3MTQwOTY2Mjc2NTM4NzgyMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfcd62ae7e65e53f890ce114fa8caa9cb8767ab2ab527c1dbe9372a9e5de33985
hovercard-subject-tagpull_request:3731521415
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4725/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary validateDatabaseHost resolved an IP that was then discarded; the drivers re-resolved the hostname at connect time, leaving a DNS-rebinding TOCTOU window MongoDB: pass resolved IP via the M...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/4725/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4725%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4725%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/4725/files
Reloadhttps://github.com/simstudioai/sim/pull/4725/files
Reloadhttps://github.com/simstudioai/sim/pull/4725/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
waleedlatif1/fix-dns-rebind-ssrfhttps://github.com/simstudioai/sim/tree/waleedlatif1/fix-dns-rebind-ssrf
Conversation 21 https://github.com/simstudioai/sim/pull/4725
Commits 6 https://github.com/simstudioai/sim/pull/4725/commits
Checks 13 https://github.com/simstudioai/sim/pull/4725/checks
Files changed https://github.com/simstudioai/sim/pull/4725/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4725/files
fix(tools): pin resolved IP in DB connectors to prevent DNS-rebinding SSRF https://github.com/simstudioai/sim/pull/4725/files#top
Show all changes 6 commits https://github.com/simstudioai/sim/pull/4725/files
d932884 fix(tools): pin resolved IP in DB connectors to prevent DNS-rebinding… waleedlatif1 May 22, 2026 https://github.com/simstudioai/sim/pull/4725/commits/d932884afa8da660f39fec569ecb0b9106f1d582
4230027 chore(tools): remove explainer comments from DB connector SSRF fix waleedlatif1 May 22, 2026 https://github.com/simstudioai/sim/pull/4725/commits/42300279bde6d7d170c2926452793fb65729abba
47def7b fix(tools): add explicit TCP timeout to mysql stream factory waleedlatif1 May 22, 2026 https://github.com/simstudioai/sim/pull/4725/commits/47def7bd11ff584a7fc16bff9e889eb7160d2918
8c16645 fix(tools): unify postgres ssl handling to send SNI in preferred mode waleedlatif1 May 22, 2026 https://github.com/simstudioai/sim/pull/4725/commits/8c1664560ae3b4780ec85bd9a0909f9454d6c3c6
5aaf0e3 fix(tools): preserve postgres 'preferred' fallback behavior for backw… waleedlatif1 May 22, 2026 https://github.com/simstudioai/sim/pull/4725/commits/5aaf0e315f834dedf58a177da12283d930a495ef
32c4b1a fix(tools): reject non-numeric Redis URL db segment instead of silent… waleedlatif1 May 22, 2026 https://github.com/simstudioai/sim/pull/4725/commits/32c4b1ad245b1df98974ae4558b3f15f2be0f4a7
Clear filters https://github.com/simstudioai/sim/pull/4725/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4725/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4725/files
utils.ts https://github.com/simstudioai/sim/pull/4725/files#diff-f58a5dee30eae7758877673abb1b2142e8044667b810fcdd289f900b4f7f604e
utils.ts https://github.com/simstudioai/sim/pull/4725/files#diff-b47fd3e2135f12b3ad3e1ab69aaccd771e89e6da36967180d604f7cafef3b510
utils.ts https://github.com/simstudioai/sim/pull/4725/files#diff-78d61d8287f86dd529cac6ebc3a2fa5029622e11c130e501ca89724368557682
utils.ts https://github.com/simstudioai/sim/pull/4725/files#diff-52de8f52e951900471a3bf7c0f25c0844cf3d84cd7ef5b1dd218c9c8f41b341e
route.ts https://github.com/simstudioai/sim/pull/4725/files#diff-cb0537a86911d21bbab64456bf3041466fbdc6608c9665a9644fdf1b0f043c55
apps/sim/app/api/tools/mongodb/utils.tshttps://github.com/simstudioai/sim/pull/4725/files#diff-f58a5dee30eae7758877673abb1b2142e8044667b810fcdd289f900b4f7f604e
View file https://github.com/simstudioai/sim/blob/32c4b1ad245b1df98974ae4558b3f15f2be0f4a7/apps/sim/app/api/tools/mongodb/utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4725/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4725/files#diff-f58a5dee30eae7758877673abb1b2142e8044667b810fcdd289f900b4f7f604e
https://github.com/simstudioai/sim/pull/4725/files#diff-f58a5dee30eae7758877673abb1b2142e8044667b810fcdd289f900b4f7f604e
https://github.com/simstudioai/sim/pull/4725/files#diff-f58a5dee30eae7758877673abb1b2142e8044667b810fcdd289f900b4f7f604e
apps/sim/app/api/tools/mysql/utils.tshttps://github.com/simstudioai/sim/pull/4725/files#diff-b47fd3e2135f12b3ad3e1ab69aaccd771e89e6da36967180d604f7cafef3b510
View file https://github.com/simstudioai/sim/blob/32c4b1ad245b1df98974ae4558b3f15f2be0f4a7/apps/sim/app/api/tools/mysql/utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4725/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4725/files#diff-b47fd3e2135f12b3ad3e1ab69aaccd771e89e6da36967180d604f7cafef3b510
https://github.com/simstudioai/sim/pull/4725/files#diff-b47fd3e2135f12b3ad3e1ab69aaccd771e89e6da36967180d604f7cafef3b510
apps/sim/app/api/tools/neo4j/utils.tshttps://github.com/simstudioai/sim/pull/4725/files#diff-78d61d8287f86dd529cac6ebc3a2fa5029622e11c130e501ca89724368557682
View file https://github.com/simstudioai/sim/blob/32c4b1ad245b1df98974ae4558b3f15f2be0f4a7/apps/sim/app/api/tools/neo4j/utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4725/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4725/files#diff-78d61d8287f86dd529cac6ebc3a2fa5029622e11c130e501ca89724368557682
Please reload this pagehttps://github.com/simstudioai/sim/pull/4725/files
https://github.com/simstudioai/sim/pull/4725/files#diff-78d61d8287f86dd529cac6ebc3a2fa5029622e11c130e501ca89724368557682
apps/sim/app/api/tools/postgresql/utils.tshttps://github.com/simstudioai/sim/pull/4725/files#diff-52de8f52e951900471a3bf7c0f25c0844cf3d84cd7ef5b1dd218c9c8f41b341e
View file https://github.com/simstudioai/sim/blob/32c4b1ad245b1df98974ae4558b3f15f2be0f4a7/apps/sim/app/api/tools/postgresql/utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4725/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4725/files#diff-52de8f52e951900471a3bf7c0f25c0844cf3d84cd7ef5b1dd218c9c8f41b341e
https://github.com/simstudioai/sim/pull/4725/files#diff-52de8f52e951900471a3bf7c0f25c0844cf3d84cd7ef5b1dd218c9c8f41b341e
apps/sim/app/api/tools/redis/execute/route.tshttps://github.com/simstudioai/sim/pull/4725/files#diff-cb0537a86911d21bbab64456bf3041466fbdc6608c9665a9644fdf1b0f043c55
View file https://github.com/simstudioai/sim/blob/32c4b1ad245b1df98974ae4558b3f15f2be0f4a7/apps/sim/app/api/tools/redis/execute/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4725/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4725/files#diff-cb0537a86911d21bbab64456bf3041466fbdc6608c9665a9644fdf1b0f043c55
https://github.com/simstudioai/sim/pull/4725/files#diff-cb0537a86911d21bbab64456bf3041466fbdc6608c9665a9644fdf1b0f043c55
Please reload this pagehttps://github.com/simstudioai/sim/pull/4725/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.