René's URL Explorer Experiment


Title: improvement(mcp): post-merge hardening — protocol negotiation + distributed OAuth lock + typed errors by waleedlatif1 · Pull Request #4722 · simstudioai/sim · GitHub

Open Graph Title: improvement(mcp): post-merge hardening — protocol negotiation + distributed OAuth lock + typed errors by waleedlatif1 · Pull Request #4722 · simstudioai/sim

X Title: improvement(mcp): post-merge hardening — protocol negotiation + distributed OAuth lock + typed errors by waleedlatif1 · Pull Request #4722 · simstudioai/sim

Description: Summary Inbound MCP server protocol-version negotiation (serve/[serverId]/route.ts): echoes the client's protocolVersion when supported (2025-06-18 / 2025-03-26 / 2024-11-05), falls back to our latest. Previously hardcoded to the oldest spec version, forcing modern clients into legacy behavior. Distributed OAuth refresh lock (oauth/storage.ts): withMcpOauthRefreshLock now wraps fn in a Postgres advisory transaction lock (pg_advisory_xact_lock) in addition to the in-process Promise chain. Multi-task ECS deployments no longer race rotated refresh tokens. Typed-error dispatch in categorizeError (utils.ts): dispatches on McpOauthAuthorizationRequiredError / UnauthorizedError / McpConnectionError first. Adds HTTP 502 for connection failures and 503 for cooldown. Substring matching kept only as a fallback for SDK/third-party errors we don't own a class for. Drop dead allSettled().catch() (service.ts): each deferred side-effect already self-logs; just mark per-promise as handled to silence unhandled-rejection warnings. Type of Change Improvement Testing Tested manually. 298 MCP tests pass (8 new: 4 covering protocol-version negotiation paths, 4 covering typed-error dispatch). `bun run check:api-validation` and lint clean. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Inbound MCP server protocol-version negotiation (serve/[serverId]/route.ts): echoes the client's protocolVersion when supported (2025-06-18 / 2025-03-26 / 2024-11-05), falls back to ou...

X Description: Summary Inbound MCP server protocol-version negotiation (serve/[serverId]/route.ts): echoes the client's protocolVersion when supported (2025-06-18 / 2025-03-26 / 2024-11-05), falls back t...

Opengraph URL: https://github.com/simstudioai/sim/pull/4722

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:822d125a-7604-5136-9e3b-4b64ce56b9a6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB79A:23725B:BC4F57:102CFC7:6AFB528D
html-safe-nonce9daa369b204bf82488143079422029a2e7e38e9cda789262561e205b6a7cc5d3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzlBOjIzNzI1QjpCQzRGNTc6MTAyQ0ZDNzo2QUZCNTI4RCIsInZpc2l0b3JfaWQiOiIyNDUxNzg5NzAxOTg4NDM4NjY5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac60c17661939d6e7d16327590478e0b4c1208303b6cd06ca62d2d41c49febb735
hovercard-subject-tagpull_request:3731405903
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4722/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Inbound MCP server protocol-version negotiation (serve/[serverId]/route.ts): echoes the client's protocolVersion when supported (2025-06-18 / 2025-03-26 / 2024-11-05), falls back to ou...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/4722/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4722%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4722%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/4722/files
Reloadhttps://github.com/simstudioai/sim/pull/4722/files
Reloadhttps://github.com/simstudioai/sim/pull/4722/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
improvement/mcp-hardeninghttps://github.com/simstudioai/sim/tree/improvement/mcp-hardening
Conversation 26 https://github.com/simstudioai/sim/pull/4722
Commits 9 https://github.com/simstudioai/sim/pull/4722/commits
Checks 12 https://github.com/simstudioai/sim/pull/4722/checks
Files changed https://github.com/simstudioai/sim/pull/4722/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4722/files
improvement(mcp): post-merge hardening — protocol negotiation + distributed OAuth lock + typed errors https://github.com/simstudioai/sim/pull/4722/files#top
Show all changes 9 commits https://github.com/simstudioai/sim/pull/4722/files
d67085d improvement(mcp): post-merge hardening — protocol negotiation + distr… waleedlatif1 May 22, 2026 https://github.com/simstudioai/sim/pull/4722/commits/d67085d652f99ea6389cbd3e627f31afba9b7341
13c2a6d fix(mcp): bugbot review on hardening PR waleedlatif1 May 22, 2026 https://github.com/simstudioai/sim/pull/4722/commits/13c2a6db1eae508372f8cd9dc489ff6f74702a15
d01506b chore(mcp): trim verbose comments + reuse SDK Tool type in McpTool waleedlatif1 May 22, 2026 https://github.com/simstudioai/sim/pull/4722/commits/d01506bf625a915370a0c182f7b46ce212139668
cdb3e14 improvement(mcp): swap PG advisory lock for Redis mutex on OAuth refresh waleedlatif1 May 22, 2026 https://github.com/simstudioai/sim/pull/4722/commits/cdb3e14874b2867f92e10b244231bee7df80d253
e6c4ec2 improvement(mcp): use SDK protocol versions + pool pinned undici agen… waleedlatif1 May 22, 2026 https://github.com/simstudioai/sim/pull/4722/commits/e6c4ec2b725a49cc094978ea623b2d028e36172e
c5069c0 fix(mcp): serialize OAuth refresh callers; do not share McpClient waleedlatif1 May 22, 2026 https://github.com/simstudioai/sim/pull/4722/commits/c5069c02cb448e7b2ee5d40966d77e9986330e1f
6d67cb7 fix(mcp): bugbot — TTL watchdog on OAuth lock + don't close evicted p… waleedlatif1 May 22, 2026 https://github.com/simstudioai/sim/pull/4722/commits/6d67cb746c5b40fdcbb95c6d5dca2055302cabe7
4c05f63 fix(mcp): throw instead of falling open when refresh lock wait exceed… waleedlatif1 May 22, 2026 https://github.com/simstudioai/sim/pull/4722/commits/4c05f6307f4b8c09f7c2bd761a59cb581f0326e7
12144cf docs(mcp): restore TSDoc that documented intent on exported types/met… waleedlatif1 May 22, 2026 https://github.com/simstudioai/sim/pull/4722/commits/12144cfa496d1d0c994d8f0dca76fd57b5346598
Clear filters https://github.com/simstudioai/sim/pull/4722/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4722/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4722/files
route.test.ts https://github.com/simstudioai/sim/pull/4722/files#diff-640b70d1a89956b78bee61dbe58795cb6ea2ea7ca0d1feb513d4347b842c165f
route.ts https://github.com/simstudioai/sim/pull/4722/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
mcp.ts https://github.com/simstudioai/sim/pull/4722/files#diff-155dcbbfb44ea9f00a3bc5e2f52b439962b86957ee62ffec4f1837cf5701cc4e
client.ts https://github.com/simstudioai/sim/pull/4722/files#diff-25cb24353597fac644145b37622d21ec7315282c29ccb1c4275f3ccb46441e1a
storage.test.ts https://github.com/simstudioai/sim/pull/4722/files#diff-66094e664dff339f1814324210dd249590c4244822f6c616c16ea9b4a86114d1
storage.ts https://github.com/simstudioai/sim/pull/4722/files#diff-bc42502cd550b1aaf3a3ccb5c126f87212a28f35a15a9cb88f6b52f90482b8ff
pinned-fetch.test.ts https://github.com/simstudioai/sim/pull/4722/files#diff-eb3b541d290de33fb3e61f5b074e2cfdb26cfd7a770a0ce1566316334a5ffec9
pinned-fetch.ts https://github.com/simstudioai/sim/pull/4722/files#diff-762eddc0923a0e087da8b1ddba48178609b8d41572e63b65e0cc2d027e79648c
service.ts https://github.com/simstudioai/sim/pull/4722/files#diff-19f6b7bbc0682d9438560d27d332499a5f8e1e4d1bf8aeb68dde6f2431137355
types.ts https://github.com/simstudioai/sim/pull/4722/files#diff-e2500ed2ccd0ca3bc978e658046d3908d959b18e02308756df87eb46e311df44
utils.test.ts https://github.com/simstudioai/sim/pull/4722/files#diff-9513abf5f55ac7ccad8953c0baee77dbc7122bd798fbb36133ec7941c7e34173
utils.ts https://github.com/simstudioai/sim/pull/4722/files#diff-3e3a2ab59257f1f643c0bfcbb46e4acb6a9ac29cb0906aa9c4d9d9a05e8852a4
apps/sim/app/api/mcp/serve/[serverId]/route.test.tshttps://github.com/simstudioai/sim/pull/4722/files#diff-640b70d1a89956b78bee61dbe58795cb6ea2ea7ca0d1feb513d4347b842c165f
View file https://github.com/simstudioai/sim/blob/12144cfa496d1d0c994d8f0dca76fd57b5346598/apps/sim/app/api/mcp/serve/%5BserverId%5D/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4722/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4722/files#diff-640b70d1a89956b78bee61dbe58795cb6ea2ea7ca0d1feb513d4347b842c165f
apps/sim/app/api/mcp/serve/[serverId]/route.tshttps://github.com/simstudioai/sim/pull/4722/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
View file https://github.com/simstudioai/sim/blob/12144cfa496d1d0c994d8f0dca76fd57b5346598/apps/sim/app/api/mcp/serve/%5BserverId%5D/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4722/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4722/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/4722/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/4722/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/4722/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
https://github.com/simstudioai/sim/pull/4722/files#diff-e5f4a6fbc67fd2506e3169c78d69cd7ff6762e859114ded61f85ebc49993441b
apps/sim/hooks/queries/mcp.tshttps://github.com/simstudioai/sim/pull/4722/files#diff-155dcbbfb44ea9f00a3bc5e2f52b439962b86957ee62ffec4f1837cf5701cc4e
View file https://github.com/simstudioai/sim/blob/12144cfa496d1d0c994d8f0dca76fd57b5346598/apps/sim/hooks/queries/mcp.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4722/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4722/files#diff-155dcbbfb44ea9f00a3bc5e2f52b439962b86957ee62ffec4f1837cf5701cc4e
https://github.com/simstudioai/sim/pull/4722/files#diff-155dcbbfb44ea9f00a3bc5e2f52b439962b86957ee62ffec4f1837cf5701cc4e
https://github.com/simstudioai/sim/pull/4722/files#diff-155dcbbfb44ea9f00a3bc5e2f52b439962b86957ee62ffec4f1837cf5701cc4e
https://github.com/simstudioai/sim/pull/4722/files#diff-155dcbbfb44ea9f00a3bc5e2f52b439962b86957ee62ffec4f1837cf5701cc4e
https://github.com/simstudioai/sim/pull/4722/files#diff-155dcbbfb44ea9f00a3bc5e2f52b439962b86957ee62ffec4f1837cf5701cc4e
https://github.com/simstudioai/sim/pull/4722/files#diff-155dcbbfb44ea9f00a3bc5e2f52b439962b86957ee62ffec4f1837cf5701cc4e
https://github.com/simstudioai/sim/pull/4722/files#diff-155dcbbfb44ea9f00a3bc5e2f52b439962b86957ee62ffec4f1837cf5701cc4e
https://github.com/simstudioai/sim/pull/4722/files#diff-155dcbbfb44ea9f00a3bc5e2f52b439962b86957ee62ffec4f1837cf5701cc4e
apps/sim/lib/mcp/client.tshttps://github.com/simstudioai/sim/pull/4722/files#diff-25cb24353597fac644145b37622d21ec7315282c29ccb1c4275f3ccb46441e1a
View file https://github.com/simstudioai/sim/blob/12144cfa496d1d0c994d8f0dca76fd57b5346598/apps/sim/lib/mcp/client.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4722/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4722/files#diff-25cb24353597fac644145b37622d21ec7315282c29ccb1c4275f3ccb46441e1a
https://github.com/simstudioai/sim/pull/4722/files#diff-25cb24353597fac644145b37622d21ec7315282c29ccb1c4275f3ccb46441e1a
https://github.com/simstudioai/sim/pull/4722/files#diff-25cb24353597fac644145b37622d21ec7315282c29ccb1c4275f3ccb46441e1a
https://github.com/simstudioai/sim/pull/4722/files#diff-25cb24353597fac644145b37622d21ec7315282c29ccb1c4275f3ccb46441e1a
https://github.com/simstudioai/sim/pull/4722/files#diff-25cb24353597fac644145b37622d21ec7315282c29ccb1c4275f3ccb46441e1a
https://github.com/simstudioai/sim/pull/4722/files#diff-25cb24353597fac644145b37622d21ec7315282c29ccb1c4275f3ccb46441e1a
https://github.com/simstudioai/sim/pull/4722/files#diff-25cb24353597fac644145b37622d21ec7315282c29ccb1c4275f3ccb46441e1a
https://github.com/simstudioai/sim/pull/4722/files#diff-25cb24353597fac644145b37622d21ec7315282c29ccb1c4275f3ccb46441e1a
https://github.com/simstudioai/sim/pull/4722/files#diff-25cb24353597fac644145b37622d21ec7315282c29ccb1c4275f3ccb46441e1a
https://github.com/simstudioai/sim/pull/4722/files#diff-25cb24353597fac644145b37622d21ec7315282c29ccb1c4275f3ccb46441e1a
https://github.com/simstudioai/sim/pull/4722/files#diff-25cb24353597fac644145b37622d21ec7315282c29ccb1c4275f3ccb46441e1a
https://github.com/simstudioai/sim/pull/4722/files#diff-25cb24353597fac644145b37622d21ec7315282c29ccb1c4275f3ccb46441e1a
https://github.com/simstudioai/sim/pull/4722/files#diff-25cb24353597fac644145b37622d21ec7315282c29ccb1c4275f3ccb46441e1a
Please reload this pagehttps://github.com/simstudioai/sim/pull/4722/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4722/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.