Title: fix(table): typewriter full-text flash on table workflow column by TheodoreSpeaks · Pull Request #4694 · simstudioai/sim · GitHub
Open Graph Title: fix(table): typewriter full-text flash on table workflow column by TheodoreSpeaks · Pull Request #4694 · simstudioai/sim
X Title: fix(table): typewriter full-text flash on table workflow column by TheodoreSpeaks · Pull Request #4694 · simstudioai/sim
Description: Problem
The typewriter intermittently flashed the full value for one frame before typing it out. Reproducible during a large Run-all (verified in-browser: 60+ cells flashing per run).
Root cause
The reveal held a lagging nullable revealed state, and the caller renders revealed ?? kind.text. Under React 18 concurrent rendering, a committed render could observe revealed === null while text was the full value (the render-phase reset to '' didn't reliably win the race), so the ?? kind.text fallback painted the entire string for a frame before the type-on. Captured directly with a render-level probe: a committed render with text.length = 74, revealed = null.
Fix
Stop holding the revealed text in nullable state with a full-text fallback. Derive the slice from text + elapsed time during render:
For a non-null value the result is never null and never the full string on the frame text changes (elapsed ≈ 0 → 0 chars), so the ?? kind.text fallback can't fire → the flash is structurally impossible.
prevText is tracked in state (not a ref) so a render React starts then discards rolls it back and the change is re-detected on the committed render.
Same hook shape, same rAF cadence, same elapsed-time reveal (dropped frames catch up).
Verification
Instrumented the live build with a DOM MutationObserver over the grid:
Before: 60/60 animated cells showed 0 →
Open Graph Description: Problem The typewriter intermittently flashed the full value for one frame before typing it out. Reproducible during a large Run-all (verified in-browser: 60+ cells flashing per run). Root cause Th...
X Description: Problem The typewriter intermittently flashed the full value for one frame before typing it out. Reproducible during a large Run-all (verified in-browser: 60+ cells flashing per run). Root cause Th...
Opengraph URL: https://github.com/simstudioai/sim/pull/4694
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f19b6cf3-5602-a256-5a53-1a5069ca34d7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B170:3BD2EB:7042DE:9E56D9:6AFB67C4 |
| html-safe-nonce | f62b499de20dce9bfbd8178f278d0e33605700a76f2b49c32490828bfb68c834 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTcwOjNCRDJFQjo3MDQyREU6OUU1NkQ5OjZBRkI2N0M0IiwidmlzaXRvcl9pZCI6IjczMTEyNzAxODYzNjE1MTM5MjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 7fff35f6b906cf6cf28704da5397f49baabb3e54e96e976bb92b4856a825e185 |
| hovercard-subject-tag | pull_request:3722273467 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4694/files |
| twitter:image | https://avatars.githubusercontent.com/u/19564703?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/19564703?s=400&v=4 |
| og:image:alt | Problem The typewriter intermittently flashed the full value for one frame before typing it out. Reproducible during a large Run-all (verified in-browser: 60+ cells flashing per run). Root cause Th... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | ea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ef97164c52cf59bd10558ddec9c4f482763988 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width