René's URL Explorer Experiment


Title: improvement(knowledge): eliminate N+1 on tag definitions in bulk upload by waleedlatif1 · Pull Request #4681 · simstudioai/sim · GitHub

Open Graph Title: improvement(knowledge): eliminate N+1 on tag definitions in bulk upload by waleedlatif1 · Pull Request #4681 · simstudioai/sim

X Title: improvement(knowledge): eliminate N+1 on tag definitions in bulk upload by waleedlatif1 · Pull Request #4681 · simstudioai/sim

Description: Summary Found an N+1 in createDocumentRecords: every doc with tags ran its own SELECT against knowledge_base_tag_definitions, all returning the same knowledgeBaseId-scoped rows. Worse, those reads used the global db pool while the surrounding transaction held a FOR UPDATE lock on the KB row — risking pool contention during large bulk uploads. Split the helper into loadTagDefinitions (single query, accepts the tx as executor) and resolveDocumentTags (pure function, takes the pre-loaded Map). Bulk upload now loads tag definitions once per request using the transaction's connection. createSingleDocument keeps the same call pattern (load once outside its tx). Same throw-on-validation-error semantics preserved. Impact For a 500-doc bulk upload where every doc has tags: 499 fewer SELECTs on knowledge_base_tag_definitions, plus 499 fewer pool checkouts taken while holding the KB FOR UPDATE lock. Type of Change Performance improvement Testing All 208 KB unit tests pass (lib/knowledge/**, app/api/knowledge/**). No behavioral change: validation throws on the same inputs as before. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Found an N+1 in createDocumentRecords: every doc with tags ran its own SELECT against knowledge_base_tag_definitions, all returning the same knowledgeBaseId-scoped rows. Worse, those reads...

X Description: Summary Found an N+1 in createDocumentRecords: every doc with tags ran its own SELECT against knowledge_base_tag_definitions, all returning the same knowledgeBaseId-scoped rows. Worse, those reads...

Opengraph URL: https://github.com/simstudioai/sim/pull/4681

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:419cc89f-6d8d-cff2-cc8e-87eff02c63c4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC3E:F138D:10E7334:17213C7:6AFB67C6
html-safe-nonce1ba27ffffa6d102126aca8f11aa751d37e0f846cc71ff9fe5e5f7a79f6f5abf1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzNFOkYxMzhEOjEwRTczMzQ6MTcyMTNDNzo2QUZCNjdDNiIsInZpc2l0b3JfaWQiOiIxMDcyMzU0NzU3NTE2NjgzMjA2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc162726dda431e852823b3baccca6f275bdb67fd5091778dc1bdd294228a7977
hovercard-subject-tagpull_request:3719443898
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4681/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Found an N+1 in createDocumentRecords: every doc with tags ran its own SELECT against knowledge_base_tag_definitions, all returning the same knowledgeBaseId-scoped rows. Worse, those reads...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/4681/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4681%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4681%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/4681/files
Reloadhttps://github.com/simstudioai/sim/pull/4681/files
Reloadhttps://github.com/simstudioai/sim/pull/4681/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
waleedlatif1/dublin-v3https://github.com/simstudioai/sim/tree/waleedlatif1/dublin-v3
Conversation 7 https://github.com/simstudioai/sim/pull/4681
Commits 4 https://github.com/simstudioai/sim/pull/4681/commits
Checks 13 https://github.com/simstudioai/sim/pull/4681/checks
Files changed https://github.com/simstudioai/sim/pull/4681/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4681/files
improvement(knowledge): eliminate N+1 on tag definitions in bulk upload https://github.com/simstudioai/sim/pull/4681/files#top
Show all changes 4 commits https://github.com/simstudioai/sim/pull/4681/files
6c6c799 improvement(knowledge): eliminate N+1 on tag definitions in bulk upload waleedlatif1 May 20, 2026 https://github.com/simstudioai/sim/pull/4681/commits/6c6c79904e33c9894c8238c00d959d3ec764147c
457b67c improvement(knowledge): fold processDocumentAsync prefetches into one… waleedlatif1 May 20, 2026 https://github.com/simstudioai/sim/pull/4681/commits/457b67c3ef25d4382e098dd6771cfe942470263d
00f93b1 improvement(knowledge): skip tag-definitions load when no doc carries… waleedlatif1 May 20, 2026 https://github.com/simstudioai/sim/pull/4681/commits/00f93b1bb32debf6406723b1e37efeec70835553
4ce7939 lint waleedlatif1 May 20, 2026 https://github.com/simstudioai/sim/pull/4681/commits/4ce7939e614ba2f8d3acdb8e83a0f9a014a2a92c
Clear filters https://github.com/simstudioai/sim/pull/4681/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4681/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4681/files
utils.test.ts https://github.com/simstudioai/sim/pull/4681/files#diff-23b670a77c544ff5ccc0c31dd1c6700ef269c8eddeaddc29039f960c17ca2ac6
service.ts https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
apps/sim/app/api/knowledge/utils.test.tshttps://github.com/simstudioai/sim/pull/4681/files#diff-23b670a77c544ff5ccc0c31dd1c6700ef269c8eddeaddc29039f960c17ca2ac6
View file https://github.com/simstudioai/sim/blob/4ce7939e614ba2f8d3acdb8e83a0f9a014a2a92c/apps/sim/app/api/knowledge/utils.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4681/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4681/files#diff-23b670a77c544ff5ccc0c31dd1c6700ef269c8eddeaddc29039f960c17ca2ac6
https://github.com/simstudioai/sim/pull/4681/files#diff-23b670a77c544ff5ccc0c31dd1c6700ef269c8eddeaddc29039f960c17ca2ac6
apps/sim/lib/knowledge/documents/service.tshttps://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
View file https://github.com/simstudioai/sim/blob/4ce7939e614ba2f8d3acdb8e83a0f9a014a2a92c/apps/sim/lib/knowledge/documents/service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4681/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/4681/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
Please reload this pagehttps://github.com/simstudioai/sim/pull/4681/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.