René's URL Explorer Experiment


Title: improvement(knowledge): eliminate N+1 on tag definitions in bulk upload by waleedlatif1 · Pull Request #4681 · simstudioai/sim · GitHub

Open Graph Title: improvement(knowledge): eliminate N+1 on tag definitions in bulk upload by waleedlatif1 · Pull Request #4681 · simstudioai/sim

X Title: improvement(knowledge): eliminate N+1 on tag definitions in bulk upload by waleedlatif1 · Pull Request #4681 · simstudioai/sim

Description: Sim is the collaborative workspace to build, deploy, and monitor AI agents and workflows. Used by 100,000+ builders. - improvement(knowledge): eliminate N+1 on tag definitions in bulk upload by waleedlatif1 · Pull Request #4681 · simstudioai/sim

Open Graph Description: Summary Found an N+1 in createDocumentRecords: every doc with tags ran its own SELECT against knowledge_base_tag_definitions, all returning the same knowledgeBaseId-scoped rows. Worse, those reads...

X Description: Summary Found an N+1 in createDocumentRecords: every doc with tags ran its own SELECT against knowledge_base_tag_definitions, all returning the same knowledgeBaseId-scoped rows. Worse, those reads...

Opengraph URL: https://github.com/simstudioai/sim/pull/4681

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cce81dea-667e-a43a-f75c-2f3243961a35
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB918:CEB06:63D65D:8C7F8F:6AFB645D
html-safe-noncef16673b98b097176ed2da9d18285c3db69123c5a20f5bb85070a4cb8780b59dd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTE4OkNFQjA2OjYzRDY1RDo4QzdGOEY6NkFGQjY0NUQiLCJ2aXNpdG9yX2lkIjoiNzEwNDYxNjEwNDA0MjY1Mjc2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacaac95afc0c088e73d2bf93ae5144214151252141dc37fde8ecd8f0841c8421be
hovercard-subject-tagpull_request:3719443898
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/simstudioai/sim/4681/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5be4349ef370ee5f1f67975515954c87fb6539dab485b1b3477aeb8a67283fa7/simstudioai/sim/pull/4681
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5be4349ef370ee5f1f67975515954c87fb6539dab485b1b3477aeb8a67283fa7/simstudioai/sim/pull/4681
og:image:altSummary Found an N+1 in createDocumentRecords: every doc with tags ran its own SELECT against knowledge_base_tag_definitions, all returning the same knowledgeBaseId-scoped rows. Worse, those reads...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewaleedlatif1
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-cache
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/4681#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4681
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4681
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/4681
Reloadhttps://github.com/simstudioai/sim/pull/4681
Reloadhttps://github.com/simstudioai/sim/pull/4681
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
https://github.com/simstudioai/sim
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
waleedlatif1/dublin-v3https://github.com/simstudioai/sim/tree/waleedlatif1/dublin-v3
Conversationhttps://github.com/simstudioai/sim/pull/4681
Commits4 (4)https://github.com/simstudioai/sim/pull/4681/commits
Checkshttps://github.com/simstudioai/sim/pull/4681/checks
Files changedhttps://github.com/simstudioai/sim/pull/4681/files
improvement(knowledge): eliminate N+1 on tag definitions in bulk uploadhttps://github.com/simstudioai/sim/pull/4681#top
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
waleedlatif1/dublin-v3https://github.com/simstudioai/sim/tree/waleedlatif1/dublin-v3
https://github.com/waleedlatif1
waleedlatif1https://github.com/waleedlatif1
May 20, 2026https://github.com/simstudioai/sim/pull/4681#issue-4489826665
Contributor License Agreement (CLA)https://github.com/simstudioai/sim/pull/CONTRIBUTING.md#contributor-license-agreement-cla
Please reload this pagehttps://github.com/simstudioai/sim/pull/4681
https://github.com/waleedlatif1
improvement(knowledge): eliminate N+1 on tag definitions in bulk uploadhttps://github.com/simstudioai/sim/pull/4681/commits/6c6c79904e33c9894c8238c00d959d3ec764147c
6c6c799https://github.com/simstudioai/sim/pull/4681/commits/6c6c79904e33c9894c8238c00d959d3ec764147c
https://github.com/apps/vercel
vercelhttps://github.com/apps/vercel
May 20, 2026https://github.com/simstudioai/sim/pull/4681#issuecomment-4502539281
Please reload this pagehttps://github.com/simstudioai/sim/pull/4681
Vercel for GitHubhttps://vercel.link/github-learn-more
docshttps://vercel.com/sim-studio/docs
https://camo.githubusercontent.com/1bb29feed7826aff3191ae8ff19d3c61e80fc99f9cc9373030210090f890893b/68747470733a2f2f76657263656c2e636f6d2f7374617469632f7374617475732f63616e63656c65642e737667
Skippedhttps://vercel.com/sim-studio/docs/FKuL9UaAixSPL8Gui1CXpsW8sLTn
https://vercel.com/vercel-agent/request-review?owner=simstudioai&repo=sim&pr=4681
Please reload this pagehttps://github.com/simstudioai/sim/pull/4681
https://github.com/apps/cursor
cursorhttps://github.com/apps/cursor
May 20, 2026https://github.com/simstudioai/sim/pull/4681#issuecomment-4502539702
Please reload this pagehttps://github.com/simstudioai/sim/pull/4681
Cursor Bugbothttps://cursor.com/bugbot
4ce7939https://github.com/simstudioai/sim/commit/4ce7939e614ba2f8d3acdb8e83a0f9a014a2a92c
herehttps://www.cursor.com/dashboard/bugbot
Please reload this pagehttps://github.com/simstudioai/sim/pull/4681
https://github.com/apps/greptile-apps
greptile-appshttps://github.com/apps/greptile-apps
May 20, 2026https://github.com/simstudioai/sim/pull/4681#issuecomment-4502556792
Please reload this pagehttps://github.com/simstudioai/sim/pull/4681
"lint"https://github.com/simstudioai/sim/commit/4ce7939e614ba2f8d3acdb8e83a0f9a014a2a92c
Re-trigger Greptilehttps://app.greptile.com/api/retrigger?id=33116455
Please reload this pagehttps://github.com/simstudioai/sim/pull/4681
https://github.com/apps/greptile-apps
greptile-appshttps://github.com/apps/greptile-apps
May 20, 2026 https://github.com/simstudioai/sim/pull/4681#pullrequestreview-4332180907
View reviewed changes https://github.com/simstudioai/sim/pull/4681/files/6c6c79904e33c9894c8238c00d959d3ec764147c
apps/sim/lib/knowledge/documents/service.tshttps://github.com/simstudioai/sim/pull/4681/files/6c6c79904e33c9894c8238c00d959d3ec764147c#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
Please reload this pagehttps://github.com/simstudioai/sim/pull/4681
https://github.com/waleedlatif1
improvement(knowledge): fold processDocumentAsync prefetches into one…https://github.com/simstudioai/sim/pull/4681/commits/457b67c3ef25d4382e098dd6771cfe942470263d
457b67chttps://github.com/simstudioai/sim/pull/4681/commits/457b67c3ef25d4382e098dd6771cfe942470263d
https://github.com/apps/vercel
vercelhttps://github.com/apps/vercel
temporarily deployedhttps://docs-kmku9zdyg-sim-studio.vercel.app
May 20, 2026 20:59https://github.com/simstudioai/sim/pull/4681#event-25777093267
https://github.com/waleedlatif1
improvement(knowledge): skip tag-definitions load when no doc carries…https://github.com/simstudioai/sim/pull/4681/commits/00f93b1bb32debf6406723b1e37efeec70835553
00f93b1https://github.com/simstudioai/sim/pull/4681/commits/00f93b1bb32debf6406723b1e37efeec70835553
https://github.com/apps/vercel
vercelhttps://github.com/apps/vercel
temporarily deployedhttps://docs-2fio30jri-sim-studio.vercel.app
May 20, 2026 21:00https://github.com/simstudioai/sim/pull/4681#event-25777133037
https://github.com/waleedlatif1
linthttps://github.com/simstudioai/sim/pull/4681/commits/4ce7939e614ba2f8d3acdb8e83a0f9a014a2a92c
4ce7939https://github.com/simstudioai/sim/pull/4681/commits/4ce7939e614ba2f8d3acdb8e83a0f9a014a2a92c
https://github.com/apps/vercel
vercelhttps://github.com/apps/vercel
temporarily deployedhttps://docs-i9dm4tifs-sim-studio.vercel.app
May 20, 2026 21:05https://github.com/simstudioai/sim/pull/4681#event-25777289590
https://github.com/waleedlatif1
waleedlatif1https://github.com/waleedlatif1
May 20, 2026https://github.com/simstudioai/sim/pull/4681#issuecomment-4502645311
@greptilehttps://github.com/greptile
Please reload this pagehttps://github.com/simstudioai/sim/pull/4681
https://github.com/waleedlatif1
waleedlatif1https://github.com/waleedlatif1
May 20, 2026https://github.com/simstudioai/sim/pull/4681#issuecomment-4502646263
@cursorhttps://github.com/cursor
Please reload this pagehttps://github.com/simstudioai/sim/pull/4681
https://github.com/apps/cursor
cursorhttps://github.com/apps/cursor
May 20, 2026 https://github.com/simstudioai/sim/pull/4681#pullrequestreview-4332308931
View reviewed changes https://github.com/simstudioai/sim/pull/4681/files/4ce7939e614ba2f8d3acdb8e83a0f9a014a2a92c
cursorhttps://github.com/apps/cursor
https://github.com/simstudioai/sim/pull/4681#pullrequestreview-4332308931
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Cursor Bugbothttps://cursor.com/bugbot
4ce7939https://github.com/simstudioai/sim/commit/4ce7939e614ba2f8d3acdb8e83a0f9a014a2a92c
herehttps://www.cursor.com/dashboard/bugbot
Please reload this pagehttps://github.com/simstudioai/sim/pull/4681
https://github.com/waleedlatif1
waleedlatif1https://github.com/waleedlatif1
4ca7651https://github.com/simstudioai/sim/commit/4ca7651ea66425a6f4c0886699dbda028a2d513e
May 20, 2026https://github.com/simstudioai/sim/pull/4681#event-25777743432
Please reload this pagehttps://github.com/simstudioai/sim/pull/4681
https://github.com/waleedlatif1
waleedlatif1https://github.com/waleedlatif1
May 21, 2026 01:16https://github.com/simstudioai/sim/pull/4681#event-25783255048
https://github.com/waleedlatif1
waleedlatif1https://github.com/waleedlatif1
May 21, 2026 https://github.com/simstudioai/sim/pull/4681#ref-pullrequest-4491361915
v0.6.86: CORS updates, OAuth MCP, navigation pinning dynamic pages, google slides endpoints, DB access pattern improvements #4690 https://github.com/simstudioai/sim/pull/4690
Deployedhttps://docs-i9dm4tifs-sim-studio.vercel.app
vercel[bot]https://github.com/apps/vercel
View deployment https://docs-i9dm4tifs-sim-studio.vercel.app
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4681
https://github.com/apps/greptile-apps
greptile-apps[bot] https://github.com/apps/greptile-apps
https://github.com/simstudioai/sim/pull/4681/files/6c6c79904e33c9894c8238c00d959d3ec764147c
https://github.com/apps/cursor
cursor[bot] https://github.com/apps/cursor
https://github.com/simstudioai/sim/pull/4681/files/4ce7939e614ba2f8d3acdb8e83a0f9a014a2a92c
Please reload this pagehttps://github.com/simstudioai/sim/pull/4681
Please reload this pagehttps://github.com/simstudioai/sim/pull/4681
https://github.com/waleedlatif1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.