Title: fix(docker): restore NEXT_PUBLIC_APP_URL build arg with dummy fallback by waleedlatif1 · Pull Request #4665 · simstudioai/sim · GitHub
Open Graph Title: fix(docker): restore NEXT_PUBLIC_APP_URL build arg with dummy fallback by waleedlatif1 · Pull Request #4665 · simstudioai/sim
X Title: fix(docker): restore NEXT_PUBLIC_APP_URL build arg with dummy fallback by waleedlatif1 · Pull Request #4665 · simstudioai/sim
Description: Summary PR #4658 removed ARG NEXT_PUBLIC_APP_URL from the Dockerfile. That broke next build in the Docker image: getBaseUrl() in apps/sim/lib/core/utils/urls.ts throws if NEXT_PUBLIC_APP_URL is unset, and it's evaluated at module load during page-data collection (fails at /_not-found). Restore the dummy build-time fallback (mirrors the existing DATABASE_URL pattern). Why this is safe (CORS fix from #4658 still holds) The original bug was next.config.ts reading NEXT_PUBLIC_APP_URL at build time and baking it into static API CORS headers. #4658 removed that headers block. This change only restores a build-time arg so module evaluation succeeds; it does not reintroduce build-time CORS resolution: next.config.ts no longer reads NEXT_PUBLIC_APP_URL at build time proxy.ts calls getEnv('NEXT_PUBLIC_APP_URL') at request time No module-level expression captures getBaseUrl() (verified by grep) — every caller invokes it lazily The dummy http://localhost:3000 only exists inside the build environment Test plan Docker image builds cleanly (no /_not-found page-data collection failure) Deployed container with real NEXT_PUBLIC_APP_URL env var serves correct Access-Control-Allow-Origin (not localhost)
Open Graph Description: Summary PR #4658 removed ARG NEXT_PUBLIC_APP_URL from the Dockerfile. That broke next build in the Docker image: getBaseUrl() in apps/sim/lib/core/utils/urls.ts throws if NEXT_PUBLIC_APP_URL is un...
X Description: Summary PR #4658 removed ARG NEXT_PUBLIC_APP_URL from the Dockerfile. That broke next build in the Docker image: getBaseUrl() in apps/sim/lib/core/utils/urls.ts throws if NEXT_PUBLIC_APP_URL is un...
Opengraph URL: https://github.com/simstudioai/sim/pull/4665
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:a6f41dc7-58e1-8747-011e-9c47487f7d63 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 81D4:243FA5:DD022A:12EE01A:6AFB5C8C |
| html-safe-nonce | 82ebcb9d56fc1966854eadf2b334f0832a0c941b7016daae039d8baaf8ac21bd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MUQ0OjI0M0ZBNTpERDAyMkE6MTJFRTAxQTo2QUZCNUM4QyIsInZpc2l0b3JfaWQiOiI3ODQ4NDc4Mzc3ODQ4Mjk4NjM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 98334723c03d6a92c6e4d8d450182b2a49d4fc7d29c53f83dbd8ac81b51d855c |
| hovercard-subject-tag | pull_request:3711750001 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4665/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary PR #4658 removed ARG NEXT_PUBLIC_APP_URL from the Dockerfile. That broke next build in the Docker image: getBaseUrl() in apps/sim/lib/core/utils/urls.ts throws if NEXT_PUBLIC_APP_URL is un... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | ea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ef97164c52cf59bd10558ddec9c4f482763988 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width