Title: fix(date-picker): eliminate infinite re-render crash on re-open with existing selection by waleedlatif1 · Pull Request #4609 · simstudioai/sim · GitHub
Open Graph Title: fix(date-picker): eliminate infinite re-render crash on re-open with existing selection by waleedlatif1 · Pull Request #4609 · simstudioai/sim
X Title: fix(date-picker): eliminate infinite re-render crash on re-open with existing selection by waleedlatif1 · Pull Request #4609 · simstudioai/sim
Description: Summary Date-picker crash (root cause fix): The useEffect that syncs picker state on open had initialStart and initialEnd — Date objects computed fresh on every render — in its dependency array. Because Object.is returns false for any two distinct Date instances, the effect re-fired on every render while open=true, calling setRangeStart/setRangeEnd, triggering another render, and repeating until React's re-render limit was hit and the page crashed with "Something went wrong." Reproduced by: select a custom date range with time enabled, then click the picker again. Fix: compute start/end as local variables inside the effect; use the stable string props (props.startDate, props.endDate) as deps instead. Multipart quota guard cleanup: Removes the redundant typeof fileSize === 'number' condition from the quota check. fileSize is typed as number (required) in initiateMultipartBodySchema so the typeof guard was dead code. Uses fileSize ?? 0 as a defensive fallback (the ?? 0 is unreachable but clarifies intent for future readers). JSDoc clarification: Improves the QUOTA_EXEMPT_STORAGE_CONTEXTS comment to explain that logs is unreachable via the multipart endpoint (rejected at context validation) but active for non-multipart paths used by the execution logging pipeline. Test plan Select a custom date range with time enabled in the Logs view Click the time picker button again — confirm the date picker opens without crashing Apply a new range and confirm it saves correctly Confirm quota enforcement still blocks over-limit uploads (existing tests pass)
Open Graph Description: Summary Date-picker crash (root cause fix): The useEffect that syncs picker state on open had initialStart and initialEnd — Date objects computed fresh on every render — in its dependency array. ...
X Description: Summary Date-picker crash (root cause fix): The useEffect that syncs picker state on open had initialStart and initialEnd — Date objects computed fresh on every render — in its dependency array. ...
Opengraph URL: https://github.com/simstudioai/sim/pull/4609
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ea4ea08e-7e92-56a4-414b-a1d831d0e2ec |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A2E4:3B28F7:3CFDBC:53643A:6AFB994E |
| html-safe-nonce | 2709b832e1507f29de1eebd7123a17253ce377c96ddfae5274dbb2f287e6db18 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkU0OjNCMjhGNzozQ0ZEQkM6NTM2NDNBOjZBRkI5OTRFIiwidmlzaXRvcl9pZCI6IjUyOTUwMzUwMzk1MDU2ODQ4MTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 3be748aeaeb742d899228d6cc12aa7ca313b5333f2542297c2ea96d75559da48 |
| hovercard-subject-tag | pull_request:3686665135 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4609/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Date-picker crash (root cause fix): The useEffect that syncs picker state on open had initialStart and initialEnd — Date objects computed fresh on every render — in its dependency array. ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3cefd19a936819d82cfb5279d50fb56fe79cb9ec30f0f807e04e89b0c58ffae1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 606800bdb1b81d125fc845bdcc262c9fe063fc8f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width