René's URL Explorer Experiment


Title: fix(console): match child-workflow inner blocks by instanceId when reconciling dropped SSE events by waleedlatif1 · Pull Request #4575 · simstudioai/sim · GitHub

Open Graph Title: fix(console): match child-workflow inner blocks by instanceId when reconciling dropped SSE events by waleedlatif1 · Pull Request #4575 · simstudioai/sim

X Title: fix(console): match child-workflow inner blocks by instanceId when reconciling dropped SSE events by waleedlatif1 · Pull Request #4575 · simstudioai/sim

Description: Summary Fix child-workflow inner blocks getting stuck isRunning: true (manifested as 34.57s wall-clock duration + value undefined on setProjects etc.) when a block:completed SSE event was dropped in transit Root cause: reconcileChildTraceSpans matched entries against the parent's static nodeId, but inner-block entries store the per-invocation instanceId (set server-side via childWorkflowContext.parentBlockId). Strict equality always failed → rescue silently no-op'd → finishRunningEntries wall-clocked the row Switch matcher to childWorkflowInstanceId throughout reconcileChildTraceSpans / spanConsoleIdentity / findConsoleEntryForSpan Add logger.warn when a span finds no matching entry, so future misses are visible in CloudWatch Close the test-coverage gap that let this ship: previous unit tests used a bare vi.fn() for updateConsole and only verified call args. Add an integration test file that exercises the real useTerminalConsoleStore and asserts entries actually flip end-to-end Type of Change Bug fix Testing New integration test seeds inner entries with the production shape (childWorkflowBlockId = instanceId) and confirms isRunning flips to false with the span's duration/output applied Full apps/sim suite green: 382 files / 6229 tests type-check clean Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Fix child-workflow inner blocks getting stuck isRunning: true (manifested as 34.57s wall-clock duration + value undefined on setProjects etc.) when a block:completed SSE event was dropped ...

X Description: Summary Fix child-workflow inner blocks getting stuck isRunning: true (manifested as 34.57s wall-clock duration + value undefined on setProjects etc.) when a block:completed SSE event was dropped ...

Opengraph URL: https://github.com/simstudioai/sim/pull/4575

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:34fc0a57-cf48-bedd-d2ac-ccc30a9f4826
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBC26:73CE1:B16AAA:F34D0B:6AFB5132
html-safe-noncedbec32991ba438bbd12e2fb086ebe26905cb4140d941f269e98a6de3c504fac4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzI2OjczQ0UxOkIxNkFBQTpGMzREMEI6NkFGQjUxMzIiLCJ2aXNpdG9yX2lkIjoiMTk3MjUwNjk4MjgwMzUyNTkzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1aa7dea2f8f49d92e24daacc35d6503fbaa4a7e97d7c3bc5db08657348bba43d
hovercard-subject-tagpull_request:3672459828
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4575/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Fix child-workflow inner blocks getting stuck isRunning: true (manifested as 34.57s wall-clock duration + value undefined on setProjects etc.) when a block:completed SSE event was dropped ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/4575/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4575%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4575%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/4575/files
Reloadhttps://github.com/simstudioai/sim/pull/4575/files
Reloadhttps://github.com/simstudioai/sim/pull/4575/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
waleedlatif1/fix-child-workflow-reconcilehttps://github.com/simstudioai/sim/tree/waleedlatif1/fix-child-workflow-reconcile
Conversation 7 https://github.com/simstudioai/sim/pull/4575
Commits 2 https://github.com/simstudioai/sim/pull/4575/commits
Checks 13 https://github.com/simstudioai/sim/pull/4575/checks
Files changed https://github.com/simstudioai/sim/pull/4575/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4575/files
fix(console): match child-workflow inner blocks by instanceId when reconciling dropped SSE events https://github.com/simstudioai/sim/pull/4575/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/4575/files
17a9a7b fix(console): match child-workflow inner blocks by instanceId when re… waleedlatif1 May 13, 2026 https://github.com/simstudioai/sim/pull/4575/commits/17a9a7bdc1b468c11ffcad38c89d3b6d3e16e04c
5754939 fix(console): drop noisy warn when reconcile finds no matching entry waleedlatif1 May 13, 2026 https://github.com/simstudioai/sim/pull/4575/commits/575493959fd10cefecba01ea01feaf81184ec973
Clear filters https://github.com/simstudioai/sim/pull/4575/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4575/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4575/files
workflow-execution-utils.integration.test.ts https://github.com/simstudioai/sim/pull/4575/files#diff-d74798a8ee1924f7cb7b24cac8fa84547c2c1a280bf6d1ce39719d8eb26192ea
workflow-execution-utils.test.ts https://github.com/simstudioai/sim/pull/4575/files#diff-0bb6b9c24801c3f51438797381c33a956293f613599bd1263b7c780dab8c797a
workflow-execution-utils.ts https://github.com/simstudioai/sim/pull/4575/files#diff-022741a49bd24846cb2fe5f8b909c47bcc61bcfe5aeadcefa74a738700f83596
...workspace/[workspaceId]/w/[workflowId]/utils/workflow-execution-utils.integration.test.tshttps://github.com/simstudioai/sim/pull/4575/files#diff-d74798a8ee1924f7cb7b24cac8fa84547c2c1a280bf6d1ce39719d8eb26192ea
View file https://github.com/simstudioai/sim/blob/575493959fd10cefecba01ea01feaf81184ec973/apps/sim/app/workspace/%5BworkspaceId%5D/w/%5BworkflowId%5D/utils/workflow-execution-utils.integration.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4575/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/4575/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4575/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4575/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.