Title: fix(console): match child-workflow inner blocks by instanceId when reconciling dropped SSE events by waleedlatif1 · Pull Request #4575 · simstudioai/sim · GitHub
Open Graph Title: fix(console): match child-workflow inner blocks by instanceId when reconciling dropped SSE events by waleedlatif1 · Pull Request #4575 · simstudioai/sim
X Title: fix(console): match child-workflow inner blocks by instanceId when reconciling dropped SSE events by waleedlatif1 · Pull Request #4575 · simstudioai/sim
Description: Summary Fix child-workflow inner blocks getting stuck isRunning: true (manifested as 34.57s wall-clock duration + value undefined on setProjects etc.) when a block:completed SSE event was dropped in transit Root cause: reconcileChildTraceSpans matched entries against the parent's static nodeId, but inner-block entries store the per-invocation instanceId (set server-side via childWorkflowContext.parentBlockId). Strict equality always failed → rescue silently no-op'd → finishRunningEntries wall-clocked the row Switch matcher to childWorkflowInstanceId throughout reconcileChildTraceSpans / spanConsoleIdentity / findConsoleEntryForSpan Add logger.warn when a span finds no matching entry, so future misses are visible in CloudWatch Close the test-coverage gap that let this ship: previous unit tests used a bare vi.fn() for updateConsole and only verified call args. Add an integration test file that exercises the real useTerminalConsoleStore and asserts entries actually flip end-to-end Type of Change Bug fix Testing New integration test seeds inner entries with the production shape (childWorkflowBlockId = instanceId) and confirms isRunning flips to false with the span's duration/output applied Full apps/sim suite green: 382 files / 6229 tests type-check clean Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Fix child-workflow inner blocks getting stuck isRunning: true (manifested as 34.57s wall-clock duration + value undefined on setProjects etc.) when a block:completed SSE event was dropped ...
X Description: Summary Fix child-workflow inner blocks getting stuck isRunning: true (manifested as 34.57s wall-clock duration + value undefined on setProjects etc.) when a block:completed SSE event was dropped ...
Opengraph URL: https://github.com/simstudioai/sim/pull/4575
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:34fc0a57-cf48-bedd-d2ac-ccc30a9f4826 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BC26:73CE1:B16AAA:F34D0B:6AFB5132 |
| html-safe-nonce | dbec32991ba438bbd12e2fb086ebe26905cb4140d941f269e98a6de3c504fac4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzI2OjczQ0UxOkIxNkFBQTpGMzREMEI6NkFGQjUxMzIiLCJ2aXNpdG9yX2lkIjoiMTk3MjUwNjk4MjgwMzUyNTkzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1aa7dea2f8f49d92e24daacc35d6503fbaa4a7e97d7c3bc5db08657348bba43d |
| hovercard-subject-tag | pull_request:3672459828 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4575/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Fix child-workflow inner blocks getting stuck isRunning: true (manifested as 34.57s wall-clock duration + value undefined on setProjects etc.) when a block:completed SSE event was dropped ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width