René's URL Explorer Experiment


Title: fix(security): close cross-tenant IDOR gaps in OAuth credential and execution auth by waleedlatif1 · Pull Request #4549 · simstudioai/sim · GitHub

Open Graph Title: fix(security): close cross-tenant IDOR gaps in OAuth credential and execution auth by waleedlatif1 · Pull Request #4549 · simstudioai/sim

X Title: fix(security): close cross-tenant IDOR gaps in OAuth credential and execution auth by waleedlatif1 · Pull Request #4549 · simstudioai/sim

Description: Summary Several tool routes (gmail/label, onedrive/files, onedrive/folder, outlook/folders, wealthbox/item, auth/oauth/wealthbox/item) called resolveOAuthAccountId then only checked workspace permissions when workspaceId was set — the legacy account-ID fallback path returned no workspaceId, silently skipping all ownership validation. Any authenticated user could supply a raw account.id to access another tenant's OAuth credentials Replace all instances with authorizeCredentialUse, which enforces ownership on every credential type including the legacy fallback path Add authorizeCredentialUse ownership gate before resolveVertexCredential in providers/route.ts (Vertex AI credential path had the same gap) Add verifyFileAccess check in wordpress/upload before downloadFileFromStorage — file key was user-supplied with no ownership verification Add optional workflowId filter to all PauseResumeManager methods (enqueueOrStartResume, beginPausedCancellation, etc.) — previously looked up paused executions by executionId only, allowing any authenticated user to cancel or resume another tenant's paused workflow execution; update all call sites (cancel, resume, poll routes) Type of Change Bug fix Testing Tested manually. authorizeCredentialUse backwards-compatibility verified: legacy account-ID callers who own their credentials still work (ownership enforced); HITL manager workflowId param is optional so internal self-calls without it are unaffected; verifyFileAccess confirmed to exist and match usage. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Several tool routes (gmail/label, onedrive/files, onedrive/folder, outlook/folders, wealthbox/item, auth/oauth/wealthbox/item) called resolveOAuthAccountId then only checked workspace perm...

X Description: Summary Several tool routes (gmail/label, onedrive/files, onedrive/folder, outlook/folders, wealthbox/item, auth/oauth/wealthbox/item) called resolveOAuthAccountId then only checked workspace perm...

Opengraph URL: https://github.com/simstudioai/sim/pull/4549

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cfbbe336-6a63-20f0-d49a-784103ce69bb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA0EC:243422:D9DBC:132956:6AFB7588
html-safe-nonce6398a0b4e23eb564387df1daf9d857e4cf82e86af02742a0bf6b2ab2bf78b5d2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMEVDOjI0MzQyMjpEOURCQzoxMzI5NTY6NkFGQjc1ODgiLCJ2aXNpdG9yX2lkIjoiNTEwMDgwNDQxMTA1NzQxMTkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac93469a1bfde7e65bf6154e40d1382d42f5e4a6cc4e7ab504b3e01abe8a9fed2b
hovercard-subject-tagpull_request:3658290038
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4549/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Several tool routes (gmail/label, onedrive/files, onedrive/folder, outlook/folders, wealthbox/item, auth/oauth/wealthbox/item) called resolveOAuthAccountId then only checked workspace perm...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/4549/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4549%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4549%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/4549/files
Reloadhttps://github.com/simstudioai/sim/pull/4549/files
Reloadhttps://github.com/simstudioai/sim/pull/4549/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests201 (201)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/security-idor-authhttps://github.com/simstudioai/sim/tree/fix/security-idor-auth
Conversation 35 https://github.com/simstudioai/sim/pull/4549
Commits 8 https://github.com/simstudioai/sim/pull/4549/commits
Checks 13 https://github.com/simstudioai/sim/pull/4549/checks
Files changed https://github.com/simstudioai/sim/pull/4549/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4549/files
fix(security): close cross-tenant IDOR gaps in OAuth credential and execution auth https://github.com/simstudioai/sim/pull/4549/files#top
Show all changes 8 commits https://github.com/simstudioai/sim/pull/4549/files
1cdb3c6 fix(security): close IDOR gaps in OAuth credential and execution auth… waleedlatif1 May 10, 2026 https://github.com/simstudioai/sim/pull/4549/commits/1cdb3c677dc9abe2b8270587c5e12e0874b4b627
94bc2e2 fix(security): close verifyFileAccess bypass, thread workflowId to pr… waleedlatif1 May 11, 2026 https://github.com/simstudioai/sim/pull/4549/commits/94bc2e204cb0f597cce8f5b167b92ff4e5d89575
fd234ac fix(security): thread workflowId through all processQueuedResumes cal… waleedlatif1 May 11, 2026 https://github.com/simstudioai/sim/pull/4549/commits/fd234acb08c888da1793edfd86119f00214ade37
0d4c9c6 fix(security): remove any types, drop extraneous comments, normalize … waleedlatif1 May 11, 2026 https://github.com/simstudioai/sim/pull/4549/commits/0d4c9c6f759018f741377f6eb10b4496d381d364
eb1cf3f fix: use logger.warn for credential access denial in outlook folders … waleedlatif1 May 11, 2026 https://github.com/simstudioai/sim/pull/4549/commits/eb1cf3f7ba349bd42311fb9cbfe3cf840738bc50
a60057a fix(security): make workflowId required in all HITL pause/resume methods waleedlatif1 May 11, 2026 https://github.com/simstudioai/sim/pull/4549/commits/a60057aca777e28d16f26903b67de13a8f8a5645
86f3a53 fix(security): thread workflowId through internal HITL cancellation c… waleedlatif1 May 11, 2026 https://github.com/simstudioai/sim/pull/4549/commits/86f3a532518d01276995d0c8e11177a4865fd89a
026405f fix(security): harden workflowId scoping and file key guard waleedlatif1 May 11, 2026 https://github.com/simstudioai/sim/pull/4549/commits/026405fbce7bd3a30e8d741a65c05e529bb42598
Clear filters https://github.com/simstudioai/sim/pull/4549/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4549/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4549/files
route.ts https://github.com/simstudioai/sim/pull/4549/files#diff-e50cc5e71808501284b7ed0a0fe02edec6a1e04e91c9fabf03f9b7dc2a344416
route.ts https://github.com/simstudioai/sim/pull/4549/files#diff-e0174d10938eba63dde75bec0fc930cb529cee9b458559127a2ddb7dd2217c70
route.ts https://github.com/simstudioai/sim/pull/4549/files#diff-f0099906729eb6afd2000b6dced811259d2d33f9603467865a6f175dcc06e685
route.ts https://github.com/simstudioai/sim/pull/4549/files#diff-1fa8d8879a9089d8831706102fd3abd373274845bfb739d1b2d2d9bb9a58fd2c
route.ts https://github.com/simstudioai/sim/pull/4549/files#diff-301198a060dc7dc6362458efb74989b3c212726fcbc14145fe54f727a992a72c
route.ts https://github.com/simstudioai/sim/pull/4549/files#diff-6fbd43627d447a8c5fda9596a6a8765d0a32f04cb2a2f64120f5b1e36b1e99e5
route.ts https://github.com/simstudioai/sim/pull/4549/files#diff-3423c68e5cdfc48d42706901ec81001cdb398be32b3edb0f01ff8f437714511d
route.ts https://github.com/simstudioai/sim/pull/4549/files#diff-2d4dfb0d0aa3bb34224729f3c9b9f62bfc08400886be11d0ffcf41620dd68a0a
route.ts https://github.com/simstudioai/sim/pull/4549/files#diff-e05d9bc2c6e81f1c2efe63bcb2beb440a84c35f9f8e69ef18023b988960ae927
route.ts https://github.com/simstudioai/sim/pull/4549/files#diff-54c752df9e2a38d18621746d2209f7ca397e8e3836037d494be5c24567893cb7
route.ts https://github.com/simstudioai/sim/pull/4549/files#diff-6276e3e602de8f65c65d92c4b1d7319a3385ffc7bd214947a94b39a60a0a40bd
credential-access.ts https://github.com/simstudioai/sim/pull/4549/files#diff-82960c002df9ce80b14f06949caf6dde10eaa909486b825986ecc549368cef31
tool-schemas-v1.ts https://github.com/simstudioai/sim/pull/4549/files#diff-d6bbefc705a9a562b6c1fbf9721f8653c610e12436e493f01dbd7a2895ebaa66
human-in-the-loop-manager.ts https://github.com/simstudioai/sim/pull/4549/files#diff-bb1129b15dc9783d16371ddc2f8992d36e41c60787a458e77e1c59a7e721d292
pause-persistence.ts https://github.com/simstudioai/sim/pull/4549/files#diff-9a984c11cb7b01067171772619556cadb351e42707dbfc3f079abc0915b4c01b
apps/sim/app/api/auth/oauth/wealthbox/item/route.tshttps://github.com/simstudioai/sim/pull/4549/files#diff-e50cc5e71808501284b7ed0a0fe02edec6a1e04e91c9fabf03f9b7dc2a344416
View file https://github.com/simstudioai/sim/blob/026405fbce7bd3a30e8d741a65c05e529bb42598/apps/sim/app/api/auth/oauth/wealthbox/item/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4549/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4549/files#diff-e50cc5e71808501284b7ed0a0fe02edec6a1e04e91c9fabf03f9b7dc2a344416
https://github.com/simstudioai/sim/pull/4549/files#diff-e50cc5e71808501284b7ed0a0fe02edec6a1e04e91c9fabf03f9b7dc2a344416
https://github.com/simstudioai/sim/pull/4549/files#diff-e50cc5e71808501284b7ed0a0fe02edec6a1e04e91c9fabf03f9b7dc2a344416
apps/sim/app/api/providers/route.tshttps://github.com/simstudioai/sim/pull/4549/files#diff-e0174d10938eba63dde75bec0fc930cb529cee9b458559127a2ddb7dd2217c70
View file https://github.com/simstudioai/sim/blob/026405fbce7bd3a30e8d741a65c05e529bb42598/apps/sim/app/api/providers/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4549/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4549/files#diff-e0174d10938eba63dde75bec0fc930cb529cee9b458559127a2ddb7dd2217c70
https://github.com/simstudioai/sim/pull/4549/files#diff-e0174d10938eba63dde75bec0fc930cb529cee9b458559127a2ddb7dd2217c70
https://github.com/simstudioai/sim/pull/4549/files#diff-e0174d10938eba63dde75bec0fc930cb529cee9b458559127a2ddb7dd2217c70
https://github.com/simstudioai/sim/pull/4549/files#diff-e0174d10938eba63dde75bec0fc930cb529cee9b458559127a2ddb7dd2217c70
apps/sim/app/api/resume/[workflowId]/[executionId]/[contextId]/route.tshttps://github.com/simstudioai/sim/pull/4549/files#diff-f0099906729eb6afd2000b6dced811259d2d33f9603467865a6f175dcc06e685
View file https://github.com/simstudioai/sim/blob/026405fbce7bd3a30e8d741a65c05e529bb42598/apps/sim/app/api/resume/%5BworkflowId%5D/%5BexecutionId%5D/%5BcontextId%5D/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4549/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4549/files#diff-f0099906729eb6afd2000b6dced811259d2d33f9603467865a6f175dcc06e685
https://github.com/simstudioai/sim/pull/4549/files#diff-f0099906729eb6afd2000b6dced811259d2d33f9603467865a6f175dcc06e685
https://github.com/simstudioai/sim/pull/4549/files#diff-f0099906729eb6afd2000b6dced811259d2d33f9603467865a6f175dcc06e685
https://github.com/simstudioai/sim/pull/4549/files#diff-f0099906729eb6afd2000b6dced811259d2d33f9603467865a6f175dcc06e685
https://github.com/simstudioai/sim/pull/4549/files#diff-f0099906729eb6afd2000b6dced811259d2d33f9603467865a6f175dcc06e685
https://github.com/simstudioai/sim/pull/4549/files#diff-f0099906729eb6afd2000b6dced811259d2d33f9603467865a6f175dcc06e685
apps/sim/app/api/resume/poll/route.tshttps://github.com/simstudioai/sim/pull/4549/files#diff-1fa8d8879a9089d8831706102fd3abd373274845bfb739d1b2d2d9bb9a58fd2c
View file https://github.com/simstudioai/sim/blob/026405fbce7bd3a30e8d741a65c05e529bb42598/apps/sim/app/api/resume/poll/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4549/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4549/files#diff-1fa8d8879a9089d8831706102fd3abd373274845bfb739d1b2d2d9bb9a58fd2c
https://github.com/simstudioai/sim/pull/4549/files#diff-1fa8d8879a9089d8831706102fd3abd373274845bfb739d1b2d2d9bb9a58fd2c
apps/sim/app/api/tools/gmail/label/route.tshttps://github.com/simstudioai/sim/pull/4549/files#diff-301198a060dc7dc6362458efb74989b3c212726fcbc14145fe54f727a992a72c
View file https://github.com/simstudioai/sim/blob/026405fbce7bd3a30e8d741a65c05e529bb42598/apps/sim/app/api/tools/gmail/label/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4549/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4549/files#diff-301198a060dc7dc6362458efb74989b3c212726fcbc14145fe54f727a992a72c
https://github.com/simstudioai/sim/pull/4549/files#diff-301198a060dc7dc6362458efb74989b3c212726fcbc14145fe54f727a992a72c
https://github.com/simstudioai/sim/pull/4549/files#diff-301198a060dc7dc6362458efb74989b3c212726fcbc14145fe54f727a992a72c
Please reload this pagehttps://github.com/simstudioai/sim/pull/4549/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4549/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.