René's URL Explorer Experiment


Title: fix(security): enforce workspace scope on workflow middleware and validate shopify shop domain by waleedlatif1 · Pull Request #4535 · simstudioai/sim · GitHub

Open Graph Title: fix(security): enforce workspace scope on workflow middleware and validate shopify shop domain by waleedlatif1 · Pull Request #4535 · simstudioai/sim

X Title: fix(security): enforce workspace scope on workflow middleware and validate shopify shop domain by waleedlatif1 · Pull Request #4535 · simstudioai/sim

Description: Summary validateWorkflowAccess now rejects workspace-scoped API keys whose workspaceId doesn't match the workflow's workspace, closing a boundary leak across /api/workflows/[id]/{log,paused,status} and /api/resume/[workflowId]/[executionId]/[contextId] shopify authorize route validates the resolved shop domain against shopifyShopDomainSchema before initiating OAuth adds middleware tests covering workspace-key cross-workspace rejection, matching-workspace acceptance, personal key, and session auth paths Type of Change Bug fix Testing bun run vitest run app/api/workflows/middleware.test.ts — 5/5 passing Manually verified existing personal-key and session flows still pass Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary validateWorkflowAccess now rejects workspace-scoped API keys whose workspaceId doesn't match the workflow's workspace, closing a boundary leak across /api/workflows/[id]/{log,pause...

X Description: Summary validateWorkflowAccess now rejects workspace-scoped API keys whose workspaceId doesn't match the workflow's workspace, closing a boundary leak across /api/workflows/[id]/{l...

Opengraph URL: https://github.com/simstudioai/sim/pull/4535

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7bd2404a-0b3c-ee34-41c2-1c358fb4e092
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9946:1C8E04:E04CE0:13413A1:6AFB5EFD
html-safe-nonce74b8af4e9b41476c55564380c13b9ae568859ad3229675f31241346b9ad4c226
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTQ2OjFDOEUwNDpFMDRDRTA6MTM0MTNBMTo2QUZCNUVGRCIsInZpc2l0b3JfaWQiOiIyNTE0MTg0OTMzODcwMzYyMzY1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb6788a9c6f44a041cf91d7b7f25e6bab76c5145f70ad35f382525dfbe105e766
hovercard-subject-tagpull_request:3655669548
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4535/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary validateWorkflowAccess now rejects workspace-scoped API keys whose workspaceId doesn't match the workflow's workspace, closing a boundary leak across /api/workflows/[id]/{log,pause...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/4535/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4535%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4535%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/4535/files
Reloadhttps://github.com/simstudioai/sim/pull/4535/files
Reloadhttps://github.com/simstudioai/sim/pull/4535/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
waleedlatif1/fix-workspace-api-key-scopehttps://github.com/simstudioai/sim/tree/waleedlatif1/fix-workspace-api-key-scope
Conversation 12 https://github.com/simstudioai/sim/pull/4535
Commits 4 https://github.com/simstudioai/sim/pull/4535/commits
Checks 13 https://github.com/simstudioai/sim/pull/4535/checks
Files changed https://github.com/simstudioai/sim/pull/4535/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4535/files
fix(security): enforce workspace scope on workflow middleware and validate shopify shop domain https://github.com/simstudioai/sim/pull/4535/files#top
Show all changes 4 commits https://github.com/simstudioai/sim/pull/4535/files
a07e652 fix(security): enforce workspace scope on workflow middleware and val… waleedlatif1 May 9, 2026 https://github.com/simstudioai/sim/pull/4535/commits/a07e652a52090a35f9ba5ea05550a217848858c0
ec2c02b fix(shopify): disallow trailing hyphen in shop subdomain regex waleedlatif1 May 9, 2026 https://github.com/simstudioai/sim/pull/4535/commits/ec2c02b793c470ccf3c7f15a24d2c182f0ede9a9
75bff52 fix(shopify): align shop domain regex with shopify handle rules (3-60… waleedlatif1 May 9, 2026 https://github.com/simstudioai/sim/pull/4535/commits/75bff52bea72ef086be0a2cc8a2fae45d667e06e
00a5e08 fix(security): widen shopify subdomain regex to allow up to 63 chars waleedlatif1 May 9, 2026 https://github.com/simstudioai/sim/pull/4535/commits/00a5e084ac7871079ed4a9f9ca99396414e90167
Clear filters https://github.com/simstudioai/sim/pull/4535/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4535/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4535/files
route.ts https://github.com/simstudioai/sim/pull/4535/files#diff-036f2a1a3d8ad0298d44d6890ef408009208a98b5469f37e2ee2be482db0ad53
middleware.test.ts https://github.com/simstudioai/sim/pull/4535/files#diff-9b0a72232e68a4169ae7e0edcab4bfa18c64918620d41aa18a16b6611677a006
middleware.ts https://github.com/simstudioai/sim/pull/4535/files#diff-49d789f6b5f17292fae5f7b6d34e2c4a08ca6dad83c6142aaad11b995bff30de
oauth-connections.ts https://github.com/simstudioai/sim/pull/4535/files#diff-0739b1b3bf7297d453c13efe632bd792eaa11980402762f508aec9f54fd13ffc
apps/sim/app/api/auth/shopify/authorize/route.tshttps://github.com/simstudioai/sim/pull/4535/files#diff-036f2a1a3d8ad0298d44d6890ef408009208a98b5469f37e2ee2be482db0ad53
View file https://github.com/simstudioai/sim/blob/00a5e084ac7871079ed4a9f9ca99396414e90167/apps/sim/app/api/auth/shopify/authorize/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4535/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4535/files#diff-036f2a1a3d8ad0298d44d6890ef408009208a98b5469f37e2ee2be482db0ad53
https://github.com/simstudioai/sim/pull/4535/files#diff-036f2a1a3d8ad0298d44d6890ef408009208a98b5469f37e2ee2be482db0ad53
https://github.com/simstudioai/sim/pull/4535/files#diff-036f2a1a3d8ad0298d44d6890ef408009208a98b5469f37e2ee2be482db0ad53
apps/sim/app/api/workflows/middleware.test.tshttps://github.com/simstudioai/sim/pull/4535/files#diff-9b0a72232e68a4169ae7e0edcab4bfa18c64918620d41aa18a16b6611677a006
View file https://github.com/simstudioai/sim/blob/00a5e084ac7871079ed4a9f9ca99396414e90167/apps/sim/app/api/workflows/middleware.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4535/{{ revealButtonHref }}
apps/sim/app/api/workflows/middleware.tshttps://github.com/simstudioai/sim/pull/4535/files#diff-49d789f6b5f17292fae5f7b6d34e2c4a08ca6dad83c6142aaad11b995bff30de
View file https://github.com/simstudioai/sim/blob/00a5e084ac7871079ed4a9f9ca99396414e90167/apps/sim/app/api/workflows/middleware.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4535/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4535/files#diff-49d789f6b5f17292fae5f7b6d34e2c4a08ca6dad83c6142aaad11b995bff30de
https://github.com/simstudioai/sim/pull/4535/files#diff-49d789f6b5f17292fae5f7b6d34e2c4a08ca6dad83c6142aaad11b995bff30de
apps/sim/lib/api/contracts/oauth-connections.tshttps://github.com/simstudioai/sim/pull/4535/files#diff-0739b1b3bf7297d453c13efe632bd792eaa11980402762f508aec9f54fd13ffc
View file https://github.com/simstudioai/sim/blob/00a5e084ac7871079ed4a9f9ca99396414e90167/apps/sim/lib/api/contracts/oauth-connections.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4535/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4535/files#diff-0739b1b3bf7297d453c13efe632bd792eaa11980402762f508aec9f54fd13ffc
https://github.com/simstudioai/sim/pull/4535/files#diff-0739b1b3bf7297d453c13efe632bd792eaa11980402762f508aec9f54fd13ffc
Please reload this pagehttps://github.com/simstudioai/sim/pull/4535/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.