René's URL Explorer Experiment


Title: fix(uploads): allow images/video/audio in mothership presigned route by waleedlatif1 · Pull Request #4534 · simstudioai/sim · GitHub

Open Graph Title: fix(uploads): allow images/video/audio in mothership presigned route by waleedlatif1 · Pull Request #4534 · simstudioai/sim

X Title: fix(uploads): allow images/video/audio in mothership presigned route by waleedlatif1 · Pull Request #4534 · simstudioai/sim

Description: Summary The mothership branch of /api/files/presigned calls validateFileType, which only permits SUPPORTED_DOCUMENT_EXTENSIONS. That rejects PNG screenshots (and any image/video/audio) at the new presigned upload path introduced in #4509, even though Mothership has always supported media attachments via the legacy /api/files/upload route. Introduce validateAttachmentFileType in lib/uploads/utils/validation.ts, backed by the union of document, code, image, audio, and video extension sets, and wire it into the mothership branch. Behavior now matches what /api/files/upload already enforced. Executables and unknown extensions are still rejected. Test plan Drag a .png screenshot into Mothership chat input on staging — uploads successfully Drag a .mp4 / .mp3 — uploads successfully Drag a .exe — rejected with a clear error bun run check:api-validation passes

Open Graph Description: Summary The mothership branch of /api/files/presigned calls validateFileType, which only permits SUPPORTED_DOCUMENT_EXTENSIONS. That rejects PNG screenshots (and any image/video/audio) at the new ...

X Description: Summary The mothership branch of /api/files/presigned calls validateFileType, which only permits SUPPORTED_DOCUMENT_EXTENSIONS. That rejects PNG screenshots (and any image/video/audio) at the new ...

Opengraph URL: https://github.com/simstudioai/sim/pull/4534

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:265aece4-f91f-a281-69d9-d3669645ecf8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD226:C876F:E03A9F:134C089:6AFB5F02
html-safe-noncecd63bfee8f219f45985b7e1c2a70aba946697705e17a6c733ac4d229b5d9151d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjI2OkM4NzZGOkUwM0E5RjoxMzRDMDg5OjZBRkI1RjAyIiwidmlzaXRvcl9pZCI6IjQ4MTMxMjU3MDczMDEwODQ5MzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8ecfcff270c41dda3349aa04dd74dda55d09f6f32d36f8484ff0ed51decee28c
hovercard-subject-tagpull_request:3655401273
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4534/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The mothership branch of /api/files/presigned calls validateFileType, which only permits SUPPORTED_DOCUMENT_EXTENSIONS. That rejects PNG screenshots (and any image/video/audio) at the new ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/4534/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4534%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4534%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/4534/files
Reloadhttps://github.com/simstudioai/sim/pull/4534/files
Reloadhttps://github.com/simstudioai/sim/pull/4534/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
waleedlatif1/mothership-upload-errhttps://github.com/simstudioai/sim/tree/waleedlatif1/mothership-upload-err
Conversation 14 https://github.com/simstudioai/sim/pull/4534
Commits 4 https://github.com/simstudioai/sim/pull/4534/commits
Checks 13 https://github.com/simstudioai/sim/pull/4534/checks
Files changed https://github.com/simstudioai/sim/pull/4534/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4534/files
fix(uploads): allow images/video/audio in mothership presigned route https://github.com/simstudioai/sim/pull/4534/files#top
Show all changes 4 commits https://github.com/simstudioai/sim/pull/4534/files
c508a0d fix(uploads): allow image/video/audio attachments in mothership presi… waleedlatif1 May 9, 2026 https://github.com/simstudioai/sim/pull/4534/commits/c508a0d01ca28f0e97780246040692cb9de0c7d8
c44177b fix(uploads): allow non-document execution outputs in presigned route waleedlatif1 May 9, 2026 https://github.com/simstudioai/sim/pull/4534/commits/c44177b1a61704e6ab6282adc5612cda872ec85f
93b1565 test(uploads): add coverage for attachment validator and dedupe exten… waleedlatif1 May 9, 2026 https://github.com/simstudioai/sim/pull/4534/commits/93b156562b5c897c3c07970f05f56f67808bfdff
a70f6f2 fix(uploads): restore SUPPORTED_IMAGE_EXTENSIONS import in upload route waleedlatif1 May 9, 2026 https://github.com/simstudioai/sim/pull/4534/commits/a70f6f21599cb9540326b575fd13651d93a4e8da
Clear filters https://github.com/simstudioai/sim/pull/4534/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4534/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4534/files
route.test.ts https://github.com/simstudioai/sim/pull/4534/files#diff-9a380a36165a2c6c2d46586d280bf22d896cc481033d062503c9db60ce0db1e3
route.ts https://github.com/simstudioai/sim/pull/4534/files#diff-8afbc69ee8a248a0b4f51fb065b51a2d1004ae80cf2d93578a2d2a6bab5923e4
route.ts https://github.com/simstudioai/sim/pull/4534/files#diff-ce9d09ae154528087734e3e471bff2f2e1615d7924140fb91813b745e68e5f2c
validation.test.ts https://github.com/simstudioai/sim/pull/4534/files#diff-55eb5adedfcb204c6883e8ef32c801aa59a51697c4b7c19f5bee6c4fe2546ebc
validation.ts https://github.com/simstudioai/sim/pull/4534/files#diff-6e969dcbe99884cfb0fda54f020f55be9a89f6622f19bb47043ab7595059f614
apps/sim/app/api/files/presigned/route.test.tshttps://github.com/simstudioai/sim/pull/4534/files#diff-9a380a36165a2c6c2d46586d280bf22d896cc481033d062503c9db60ce0db1e3
View file https://github.com/simstudioai/sim/blob/a70f6f21599cb9540326b575fd13651d93a4e8da/apps/sim/app/api/files/presigned/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4534/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4534/files#diff-9a380a36165a2c6c2d46586d280bf22d896cc481033d062503c9db60ce0db1e3
https://github.com/simstudioai/sim/pull/4534/files#diff-9a380a36165a2c6c2d46586d280bf22d896cc481033d062503c9db60ce0db1e3
https://github.com/simstudioai/sim/pull/4534/files#diff-9a380a36165a2c6c2d46586d280bf22d896cc481033d062503c9db60ce0db1e3
https://github.com/simstudioai/sim/pull/4534/files#diff-9a380a36165a2c6c2d46586d280bf22d896cc481033d062503c9db60ce0db1e3
https://github.com/simstudioai/sim/pull/4534/files#diff-9a380a36165a2c6c2d46586d280bf22d896cc481033d062503c9db60ce0db1e3
https://github.com/simstudioai/sim/pull/4534/files#diff-9a380a36165a2c6c2d46586d280bf22d896cc481033d062503c9db60ce0db1e3
https://github.com/simstudioai/sim/pull/4534/files#diff-9a380a36165a2c6c2d46586d280bf22d896cc481033d062503c9db60ce0db1e3
https://github.com/simstudioai/sim/pull/4534/files#diff-9a380a36165a2c6c2d46586d280bf22d896cc481033d062503c9db60ce0db1e3
apps/sim/app/api/files/presigned/route.tshttps://github.com/simstudioai/sim/pull/4534/files#diff-8afbc69ee8a248a0b4f51fb065b51a2d1004ae80cf2d93578a2d2a6bab5923e4
View file https://github.com/simstudioai/sim/blob/a70f6f21599cb9540326b575fd13651d93a4e8da/apps/sim/app/api/files/presigned/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4534/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4534/files#diff-8afbc69ee8a248a0b4f51fb065b51a2d1004ae80cf2d93578a2d2a6bab5923e4
https://github.com/simstudioai/sim/pull/4534/files#diff-8afbc69ee8a248a0b4f51fb065b51a2d1004ae80cf2d93578a2d2a6bab5923e4
https://github.com/simstudioai/sim/pull/4534/files#diff-8afbc69ee8a248a0b4f51fb065b51a2d1004ae80cf2d93578a2d2a6bab5923e4
Please reload this pagehttps://github.com/simstudioai/sim/pull/4534/files
https://github.com/simstudioai/sim/pull/4534/files#diff-8afbc69ee8a248a0b4f51fb065b51a2d1004ae80cf2d93578a2d2a6bab5923e4
https://github.com/simstudioai/sim/pull/4534/files#diff-8afbc69ee8a248a0b4f51fb065b51a2d1004ae80cf2d93578a2d2a6bab5923e4
https://github.com/simstudioai/sim/pull/4534/files#diff-8afbc69ee8a248a0b4f51fb065b51a2d1004ae80cf2d93578a2d2a6bab5923e4
apps/sim/app/api/files/upload/route.tshttps://github.com/simstudioai/sim/pull/4534/files#diff-ce9d09ae154528087734e3e471bff2f2e1615d7924140fb91813b745e68e5f2c
View file https://github.com/simstudioai/sim/blob/a70f6f21599cb9540326b575fd13651d93a4e8da/apps/sim/app/api/files/upload/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4534/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4534/files#diff-ce9d09ae154528087734e3e471bff2f2e1615d7924140fb91813b745e68e5f2c
https://github.com/simstudioai/sim/pull/4534/files#diff-ce9d09ae154528087734e3e471bff2f2e1615d7924140fb91813b745e68e5f2c
https://github.com/simstudioai/sim/pull/4534/files#diff-ce9d09ae154528087734e3e471bff2f2e1615d7924140fb91813b745e68e5f2c
apps/sim/lib/uploads/utils/validation.test.tshttps://github.com/simstudioai/sim/pull/4534/files#diff-55eb5adedfcb204c6883e8ef32c801aa59a51697c4b7c19f5bee6c4fe2546ebc
View file https://github.com/simstudioai/sim/blob/a70f6f21599cb9540326b575fd13651d93a4e8da/apps/sim/lib/uploads/utils/validation.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4534/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/4534/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4534/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.