René's URL Explorer Experiment


Title: fix(redis): drop cached client and restart PING loop after forced reconnect by TheodoreSpeaks · Pull Request #4501 · simstudioai/sim · GitHub

Open Graph Title: fix(redis): drop cached client and restart PING loop after forced reconnect by TheodoreSpeaks · Pull Request #4501 · simstudioai/sim

X Title: fix(redis): drop cached client and restart PING loop after forced reconnect by TheodoreSpeaks · Pull Request #4501 · simstudioai/sim

Description: Summary After 2 consecutive PING failures, startPingHealthCheck was disconnecting the dead client but leaving globalRedisClient cached, so the next getRedisClient() returned the dead reference and every command sat in its offline queue until the 5s commandTimeout. Now the global is cleared and the PING interval is reset before disconnect, so the next call builds a fresh client with a fresh health check. Added a 200ms deadline race to releaseDistributedLease in isolated-vm.ts (matching tryAcquireDistributedLease) so a hung Redis client doesn't make releases wait the full 5s. Added two tests covering the cache-drop and PING-restart behavior. Type of Change Bug fix Testing bun run test lib/core/config/redis.test.ts (13/13) bun run test lib/execution/isolated-vm.test.ts (9/9) bunx tsc --noEmit -p tsconfig.json clean bun run lint clean bun run check:api-validation:strict passed Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary After 2 consecutive PING failures, startPingHealthCheck was disconnecting the dead client but leaving globalRedisClient cached, so the next getRedisClient() returned the dead reference and...

X Description: Summary After 2 consecutive PING failures, startPingHealthCheck was disconnecting the dead client but leaving globalRedisClient cached, so the next getRedisClient() returned the dead reference and...

Opengraph URL: https://github.com/simstudioai/sim/pull/4501

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e3b9894e-d168-6a5c-f035-7999caa090cd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC940:1EE905:C31611:1136D50:6AFB5EF8
html-safe-nonce7489fa72a3e50cdb5820aac5d64845761a0514cf16940ad5d1c04d85f9891570
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTQwOjFFRTkwNTpDMzE2MTE6MTEzNkQ1MDo2QUZCNUVGOCIsInZpc2l0b3JfaWQiOiI2ODk2MzcyMjI2Njk0Mjc0ODA4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac53fd1513e852f84068a362a04364b4c0f4c954f3f9098ee1ca7e6f8ebe4c3f33
hovercard-subject-tagpull_request:3646171172
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4501/files
twitter:imagehttps://avatars.githubusercontent.com/u/19564703?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/19564703?s=400&v=4
og:image:altSummary After 2 consecutive PING failures, startPingHealthCheck was disconnecting the dead client but leaving globalRedisClient cached, so the next getRedisClient() returned the dead reference and...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/4501/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4501%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4501%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/4501/files
Reloadhttps://github.com/simstudioai/sim/pull/4501/files
Reloadhttps://github.com/simstudioai/sim/pull/4501/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
TheodoreSpeakshttps://github.com/TheodoreSpeaks
staginghttps://github.com/simstudioai/sim/tree/staging
fix/redis-client-cache-after-ping-failurehttps://github.com/simstudioai/sim/tree/fix/redis-client-cache-after-ping-failure
Conversation 3 https://github.com/simstudioai/sim/pull/4501
Commits 1 https://github.com/simstudioai/sim/pull/4501/commits
Checks 13 https://github.com/simstudioai/sim/pull/4501/checks
Files changed https://github.com/simstudioai/sim/pull/4501/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4501/files
fix(redis): drop cached client and restart PING loop after forced reconnect https://github.com/simstudioai/sim/pull/4501/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/4501/files
331d735 fix(redis): drop cached client and restart PING loop after forced rec… TheodoreSpeaks May 7, 2026 https://github.com/simstudioai/sim/pull/4501/commits/331d735a73886a0731afb4348f6e7936eb6c7cf8
Clear filters https://github.com/simstudioai/sim/pull/4501/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4501/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4501/files
redis.test.ts https://github.com/simstudioai/sim/pull/4501/files#diff-c6ad185c1c43eadf2b2ccc55086d0ee0bb12266114edc693d20f1bf9b94da3b5
redis.ts https://github.com/simstudioai/sim/pull/4501/files#diff-af191f255d57cc29ed5bf97c929967b6b922d94d754a7d73abcbf88594b4dc7d
isolated-vm.ts https://github.com/simstudioai/sim/pull/4501/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
apps/sim/lib/core/config/redis.test.tshttps://github.com/simstudioai/sim/pull/4501/files#diff-c6ad185c1c43eadf2b2ccc55086d0ee0bb12266114edc693d20f1bf9b94da3b5
View file https://github.com/simstudioai/sim/blob/331d735a73886a0731afb4348f6e7936eb6c7cf8/apps/sim/lib/core/config/redis.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4501/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4501/files#diff-c6ad185c1c43eadf2b2ccc55086d0ee0bb12266114edc693d20f1bf9b94da3b5
https://github.com/simstudioai/sim/pull/4501/files#diff-c6ad185c1c43eadf2b2ccc55086d0ee0bb12266114edc693d20f1bf9b94da3b5
apps/sim/lib/core/config/redis.tshttps://github.com/simstudioai/sim/pull/4501/files#diff-af191f255d57cc29ed5bf97c929967b6b922d94d754a7d73abcbf88594b4dc7d
View file https://github.com/simstudioai/sim/blob/331d735a73886a0731afb4348f6e7936eb6c7cf8/apps/sim/lib/core/config/redis.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4501/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4501/files#diff-af191f255d57cc29ed5bf97c929967b6b922d94d754a7d73abcbf88594b4dc7d
https://github.com/simstudioai/sim/pull/4501/files#diff-af191f255d57cc29ed5bf97c929967b6b922d94d754a7d73abcbf88594b4dc7d
apps/sim/lib/execution/isolated-vm.tshttps://github.com/simstudioai/sim/pull/4501/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
View file https://github.com/simstudioai/sim/blob/331d735a73886a0731afb4348f6e7936eb6c7cf8/apps/sim/lib/execution/isolated-vm.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4501/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4501/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/4501/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
Please reload this pagehttps://github.com/simstudioai/sim/pull/4501/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.