René's URL Explorer Experiment


Title: revert(executor): undo correctness-by-construction for workflow logs (#4382) by waleedlatif1 · Pull Request #4399 · simstudioai/sim · GitHub

Open Graph Title: revert(executor): undo correctness-by-construction for workflow logs (#4382) by waleedlatif1 · Pull Request #4399 · simstudioai/sim

X Title: revert(executor): undo correctness-by-construction for workflow logs (#4382) by waleedlatif1 · Pull Request #4399 · simstudioai/sim

Description: Summary Reverts #4382 in full — restores pre-Stage-1 executor/terminal state Stuck "Running" Start block + cancel-leaves-blocks-running regressions observed in staging Type of Change Bug fix Testing Tested manually Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Reverts #4382 in full — restores pre-Stage-1 executor/terminal state Stuck "Running" Start block + cancel-leaves-blocks-running regressions observed in staging Type of Change ...

X Description: Summary Reverts #4382 in full — restores pre-Stage-1 executor/terminal state Stuck "Running" Start block + cancel-leaves-blocks-running regressions observed in staging Type of C...

Opengraph URL: https://github.com/simstudioai/sim/pull/4399

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:03592f10-6f7f-9438-a696-489002eab147
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC3B2:2B8D95:B8D731:105B4E7:6AFB5DAB
html-safe-nonceb11f0ccd618684f29b01da0afd9031ea2d05d0535513927c5731754722f68c0e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDM0IyOjJCOEQ5NTpCOEQ3MzE6MTA1QjRFNzo2QUZCNURBQiIsInZpc2l0b3JfaWQiOiI1MDg1ODkyMDk2NjUzMjIxMjkxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd5d9de89dfffd95ecbd4a5cbd2f974bd9e4d82a1f1fabe539649bf63d48d56a0
hovercard-subject-tagpull_request:3617244354
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4399/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Reverts #4382 in full — restores pre-Stage-1 executor/terminal state Stuck "Running" Start block + cancel-leaves-blocks-running regressions observed in staging Type of Change ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/4399/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4399%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4399%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/4399/files
Reloadhttps://github.com/simstudioai/sim/pull/4399/files
Reloadhttps://github.com/simstudioai/sim/pull/4399/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
waleedlatif1/revert-correctness-by-constructionhttps://github.com/simstudioai/sim/tree/waleedlatif1/revert-correctness-by-construction
Conversation 19 https://github.com/simstudioai/sim/pull/4399
Commits 5 https://github.com/simstudioai/sim/pull/4399/commits
Checks 13 https://github.com/simstudioai/sim/pull/4399/checks
Files changed https://github.com/simstudioai/sim/pull/4399/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4399/files
revert(executor): undo correctness-by-construction for workflow logs (#4382) https://github.com/simstudioai/sim/pull/4399/files#top
Show all changes 5 commits https://github.com/simstudioai/sim/pull/4399/files
0397fdf Revert "improvement(executor): correctness-by-construction for workfl… waleedlatif1 May 2, 2026 https://github.com/simstudioai/sim/pull/4399/commits/0397fdf8365a284ef4057699edd15348f396181e
25f46e3 fix(terminal): re-read entries inside reconcileFinalBlockLogs loop waleedlatif1 May 2, 2026 https://github.com/simstudioai/sim/pull/4399/commits/25f46e3f637b558b98bddf0aacd069327c8ab5a4
f396975 chore(terminal): remove dead consoleMode 'add' branch and helpers waleedlatif1 May 2, 2026 https://github.com/simstudioai/sim/pull/4399/commits/f396975879569b755bc8e52e967426b061ffc5d2
910a51a fix(executor): reconcile finalBlockLogs on execution:completed waleedlatif1 May 2, 2026 https://github.com/simstudioai/sim/pull/4399/commits/910a51a4d3eef3aa66b980ddb09ec6c80260c568
7819cfc fix(executor): emit finalBlockLogs on queued/HITL error and cancel paths waleedlatif1 May 2, 2026 https://github.com/simstudioai/sim/pull/4399/commits/7819cfc0f584e58a1101ed6719ececd62aab0358
Clear filters https://github.com/simstudioai/sim/pull/4399/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4399/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4399/files
route.ts https://github.com/simstudioai/sim/pull/4399/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
use-workflow-execution.ts https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
workflow-execution-utils.test.ts https://github.com/simstudioai/sim/pull/4399/files#diff-0bb6b9c24801c3f51438797381c33a956293f613599bd1263b7c780dab8c797a
workflow-execution-utils.ts https://github.com/simstudioai/sim/pull/4399/files#diff-022741a49bd24846cb2fe5f8b909c47bcc61bcfe5aeadcefa74a738700f83596
block-executor.ts https://github.com/simstudioai/sim/pull/4399/files#diff-56a5432011895e99101ab4af087446b215bca1a2b216e3c44a5087a11223000d
executor.ts https://github.com/simstudioai/sim/pull/4399/files#diff-749f8b453a93eaba5cab96f549bbc618400c2aead886a3444c868730c511dc1b
types.ts https://github.com/simstudioai/sim/pull/4399/files#diff-13fa0f819e17231a9e7f2853107d2f340fd9f18b0e86b8bdb411237ad0563669
types.ts https://github.com/simstudioai/sim/pull/4399/files#diff-b266de0e8311cee15872078a12705439e0d9b58ab87b7685752a0b3ea60cd378
execution-core.test.ts https://github.com/simstudioai/sim/pull/4399/files#diff-40c3467de29e00eaa8563d025139feccb3d119364e628433260c1b6c70d89704
execution-core.ts https://github.com/simstudioai/sim/pull/4399/files#diff-2a32d546272efa06e3cbe2ccce1cf4e69c74ff37fe98253bcb2742ffed5bae4b
execution-events.ts https://github.com/simstudioai/sim/pull/4399/files#diff-8f165b95e5278d98c27f5777c4173efe2bfbbf1df9b76de333a94de1d9c998ce
human-in-the-loop-manager.ts https://github.com/simstudioai/sim/pull/4399/files#diff-bb1129b15dc9783d16371ddc2f8992d36e41c60787a458e77e1c59a7e721d292
queued-workflow-execution.ts https://github.com/simstudioai/sim/pull/4399/files#diff-5cadd779a9814e81f5eb11eb0492a5450e53099b389a50c0d6088f698f44d03a
store.test.ts https://github.com/simstudioai/sim/pull/4399/files#diff-763135cc379bff65ddc2ba651f87a689c488fa335dab71e16725c2cf2011d1ec
store.ts https://github.com/simstudioai/sim/pull/4399/files#diff-74553352f4a27ac3143f7c1165a50f05ce06496d97fe9c22add5d3b36e009a50
types.ts https://github.com/simstudioai/sim/pull/4399/files#diff-1233686eeec5187196dea58824178d574b5f68953d8d4f458909a64cd71baa1b
apps/sim/app/api/workflows/[id]/execute/route.tshttps://github.com/simstudioai/sim/pull/4399/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
View file https://github.com/simstudioai/sim/blob/7819cfc0f584e58a1101ed6719ececd62aab0358/apps/sim/app/api/workflows/%5Bid%5D/execute/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4399/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4399/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4399/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4399/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4399/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4399/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4399/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4399/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4399/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4399/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4399/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4399/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4399/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4399/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4399/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
Please reload this pagehttps://github.com/simstudioai/sim/pull/4399/files
https://github.com/simstudioai/sim/pull/4399/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-workflow-execution.tshttps://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
View file https://github.com/simstudioai/sim/blob/7819cfc0f584e58a1101ed6719ececd62aab0358/apps/sim/app/workspace/%5BworkspaceId%5D/w/%5BworkflowId%5D/hooks/use-workflow-execution.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4399/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4399/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
Please reload this pagehttps://github.com/simstudioai/sim/pull/4399/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4399/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.