René's URL Explorer Experiment


Title: improvement(executor): correctness-by-construction for workflow logs by waleedlatif1 · Pull Request #4382 · simstudioai/sim · GitHub

Open Graph Title: improvement(executor): correctness-by-construction for workflow logs by waleedlatif1 · Pull Request #4382 · simstudioai/sim

X Title: improvement(executor): correctness-by-construction for workflow logs by waleedlatif1 · Pull Request #4382 · simstudioai/sim

Description: Summary Drain pending block-callback promises at terminal boundaries via try/finally in DAGExecutor.execute() / executeFromBlock() — covers interactive, queued, HITL, and child-workflow paths automatically Mint a per-invocation blockExecutionId on block:started; thread through BlockLog, block:completed, block:error, and ConsoleEntry Switch console store primary keying to entryIdByBlockExecutionId (O(1)); keep legacy index as fallback for cross-deploy in-flight runs and IndexedDB hydration, with telemetry on actual fallback usage Unify consoleMode: always create placeholder on block:started, update on terminal — addConsole idempotent on blockExecutionId Delete reconciliation layer: reconcileFinalBlockLogs, finalBlockLogs SSE piggyback, terminal-handler cancelRunningEntries, store cross-checks Type of Change Improvement Testing Tested manually — three repros from #4372 stay fixed, reconnect mid-run, queued runs, HITL pause/resume, loop iterations, child workflows. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Drain pending block-callback promises at terminal boundaries via try/finally in DAGExecutor.execute() / executeFromBlock() — covers interactive, queued, HITL, and child-workflow paths auto...

X Description: Summary Drain pending block-callback promises at terminal boundaries via try/finally in DAGExecutor.execute() / executeFromBlock() — covers interactive, queued, HITL, and child-workflow paths auto...

Opengraph URL: https://github.com/simstudioai/sim/pull/4382

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4907e32b-f8f0-bf3e-ca3a-4ef0d55c02da
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBDCA:9464C:C766B0:110B294:6AFB569D
html-safe-nonce32ec68e8edf9eccab95653b542aa2b5eed938a09138420333eb2fe26448b6196
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRENBOjk0NjRDOkM3NjZCMDoxMTBCMjk0OjZBRkI1NjlEIiwidmlzaXRvcl9pZCI6Ijc0OTEyMzc0MDc3ODIyOTUxOTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3765d727015447cf0702b5600c46eb01602fb410e4f53e5b1e4b78c095cec6f3
hovercard-subject-tagpull_request:3615701355
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4382/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Drain pending block-callback promises at terminal boundaries via try/finally in DAGExecutor.execute() / executeFromBlock() — covers interactive, queued, HITL, and child-workflow paths auto...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/4382/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4382%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4382%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/4382/files
Reloadhttps://github.com/simstudioai/sim/pull/4382/files
Reloadhttps://github.com/simstudioai/sim/pull/4382/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
waleedlatif1/asuncion-v2https://github.com/simstudioai/sim/tree/waleedlatif1/asuncion-v2
Conversation 9 https://github.com/simstudioai/sim/pull/4382
Commits 6 https://github.com/simstudioai/sim/pull/4382/commits
Checks 13 https://github.com/simstudioai/sim/pull/4382/checks
Files changed https://github.com/simstudioai/sim/pull/4382/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4382/files
improvement(executor): correctness-by-construction for workflow logs https://github.com/simstudioai/sim/pull/4382/files#top
Show all changes 6 commits https://github.com/simstudioai/sim/pull/4382/files
31ecd39 improvement(executor): correctness-by-construction for workflow logs waleedlatif1 May 1, 2026 https://github.com/simstudioai/sim/pull/4382/commits/31ecd39a74989e64182627494351872462dab028
0ef18ea Merge remote-tracking branch 'origin/staging' into waleedlatif1/asunc… waleedlatif1 May 1, 2026 https://github.com/simstudioai/sim/pull/4382/commits/0ef18ea3104f0b23f4ba6d920821d98c766400e3
b442f6f test(executor): remove stale fire-and-forget assertion waleedlatif1 May 1, 2026 https://github.com/simstudioai/sim/pull/4382/commits/b442f6f9ddba5f5f14909de83a2ab3b8da97fc0a
a544293 test(console-store): cover blockExecutionId keying and idempotency waleedlatif1 May 1, 2026 https://github.com/simstudioai/sim/pull/4382/commits/a544293287aa10daa9b2e05becbda589c41ce024
2854944 fix(executor): capture BlockExecutor locally so finally drains its ow… waleedlatif1 May 1, 2026 https://github.com/simstudioai/sim/pull/4382/commits/2854944e75207fed9287b44b2f66924d3e5753ca
378abb0 test(terminal): capture store logger by label, not first warn-bearing… waleedlatif1 May 1, 2026 https://github.com/simstudioai/sim/pull/4382/commits/378abb0a4d3297c5916d3b29f8a646cb13788f32
Clear filters https://github.com/simstudioai/sim/pull/4382/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4382/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4382/files
route.ts https://github.com/simstudioai/sim/pull/4382/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
use-workflow-execution.ts https://github.com/simstudioai/sim/pull/4382/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
workflow-execution-utils.test.ts https://github.com/simstudioai/sim/pull/4382/files#diff-0bb6b9c24801c3f51438797381c33a956293f613599bd1263b7c780dab8c797a
workflow-execution-utils.ts https://github.com/simstudioai/sim/pull/4382/files#diff-022741a49bd24846cb2fe5f8b909c47bcc61bcfe5aeadcefa74a738700f83596
block-executor.ts https://github.com/simstudioai/sim/pull/4382/files#diff-56a5432011895e99101ab4af087446b215bca1a2b216e3c44a5087a11223000d
executor.ts https://github.com/simstudioai/sim/pull/4382/files#diff-749f8b453a93eaba5cab96f549bbc618400c2aead886a3444c868730c511dc1b
types.ts https://github.com/simstudioai/sim/pull/4382/files#diff-13fa0f819e17231a9e7f2853107d2f340fd9f18b0e86b8bdb411237ad0563669
types.ts https://github.com/simstudioai/sim/pull/4382/files#diff-b266de0e8311cee15872078a12705439e0d9b58ab87b7685752a0b3ea60cd378
execution-core.test.ts https://github.com/simstudioai/sim/pull/4382/files#diff-40c3467de29e00eaa8563d025139feccb3d119364e628433260c1b6c70d89704
execution-core.ts https://github.com/simstudioai/sim/pull/4382/files#diff-2a32d546272efa06e3cbe2ccce1cf4e69c74ff37fe98253bcb2742ffed5bae4b
execution-events.ts https://github.com/simstudioai/sim/pull/4382/files#diff-8f165b95e5278d98c27f5777c4173efe2bfbbf1df9b76de333a94de1d9c998ce
store.test.ts https://github.com/simstudioai/sim/pull/4382/files#diff-763135cc379bff65ddc2ba651f87a689c488fa335dab71e16725c2cf2011d1ec
store.ts https://github.com/simstudioai/sim/pull/4382/files#diff-74553352f4a27ac3143f7c1165a50f05ce06496d97fe9c22add5d3b36e009a50
types.ts https://github.com/simstudioai/sim/pull/4382/files#diff-1233686eeec5187196dea58824178d574b5f68953d8d4f458909a64cd71baa1b
apps/sim/app/api/workflows/[id]/execute/route.tshttps://github.com/simstudioai/sim/pull/4382/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
View file https://github.com/simstudioai/sim/blob/378abb0a4d3297c5916d3b29f8a646cb13788f32/apps/sim/app/api/workflows/%5Bid%5D/execute/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4382/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4382/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4382/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4382/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4382/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4382/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4382/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4382/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4382/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4382/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4382/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4382/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4382/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4382/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/4382/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-workflow-execution.tshttps://github.com/simstudioai/sim/pull/4382/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
View file https://github.com/simstudioai/sim/blob/378abb0a4d3297c5916d3b29f8a646cb13788f32/apps/sim/app/workspace/%5BworkspaceId%5D/w/%5BworkflowId%5D/hooks/use-workflow-execution.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4382/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4382/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4382/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4382/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4382/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4382/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4382/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4382/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4382/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4382/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4382/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4382/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4382/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4382/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4382/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4382/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4382/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
https://github.com/simstudioai/sim/pull/4382/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
Please reload this pagehttps://github.com/simstudioai/sim/pull/4382/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4382/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.