Title: fix(mcp): Use SDK web-standard transport for copilot mcp by TheodoreSpeaks · Pull Request #4320 · simstudioai/sim · GitHub
Open Graph Title: fix(mcp): Use SDK web-standard transport for copilot mcp by TheodoreSpeaks · Pull Request #4320 · simstudioai/sim
X Title: fix(mcp): Use SDK web-standard transport for copilot mcp by TheodoreSpeaks · Pull Request #4320 · simstudioai/sim
Description: Summary Our mcp copilot was broken, consistently returning 5xx. This was due to upgrading mcp sdk versions. Since now the sdk supports WebStandardStreamableHTTPServerTransport, removed the shims and directly used that class instead. When it broke Commit 45bf39696 — "fix(deps): bump drizzle-orm 0.45.2 + adopt MCP SDK 1.25.3 native types (#4252)" — merged 2026-04-21. That PR touched only apps/sim/package.json (one-line bump @modelcontextprotocol/sdk 1.20.2 → 1.25.3) and apps/sim/lib/copilot/tools/mcp/definitions.ts (cosmetic type cleanup). The route file itself was not modified. The shim there had been working untouched since 2026-02-09. Why the PR review didn't catch it The SDK's StreamableHTTPServerTransport was silently re-architected upstream: Same export name, same handleRequest(req, res, parsedBody) signature → TypeScript saw nothing. 1.20.2: self-contained Node implementation using raw-body + node:crypto. Only ever read req.headers.*. Our minimal shim { method, headers } was sufficient. 1.25.3: "a thin wrapper around WebStandardStreamableHTTPServerTransport" using @hono/node-server's getRequestListener. For any non-GET/HEAD request, Hono calls incoming.on("end", …) (listener.js:598). Our shim has no .on → TypeError → caught by Hono → routed to handleFetchError → Response(null, { status: 500 }) → written to our NextResponseCapture via writeHead(500, …) → returned by our route as if it were a normal response. Our route's catch block never saw the error (which is why the "recategorize" framing of this branch was misleading — there was no fault to recategorize, the route handler never ran). No route.test.ts under apps/sim/app/api/mcp/copilot/ — nothing in CI round-tripped a POST through the transport, so the regression slipped to prod. The fix Swap the broken Node-style transport for the SDK's web-standard transport, which Next.js can drive directly (NextRequest already extends Web Request) Also drops the now-unused NextResponseCapture shim (~190 lines) and normalizeRequestHeaders helper. The catch block additionally maps client-aborted requests to 499 (ConnectionClosed) since aborts do legitimately reach it now (unlike everything else, which the SDK handles internally). Verification (local) Before After initialize POST 500, empty body, text/plain 200, full JSON-RPC envelope, application/json tools/list POST unreachable 200, all 23 tools (list_workspaces, create_workflow, sim_workflow, …) Catch block fires never (synthetic 500 from Hono) only on real exceptions Confirmed end-to-end with claude mcp add --transport http sim-copilot http://localhost:3000/api/mcp/copilot --header "x-api-key: …" → Connected. Type of Change Bug fix New feature Breaking change Documentation Other: ___________ Testing Tested locally. Initialize handshake returns 200 with proper MCP server info; tools/list returns all 23 tools. Validated claude mcp add --transport http sim-copilot http://localhost:3000/api/mcp/copilot succeeds with Connected. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Our mcp copilot was broken, consistently returning 5xx. This was due to upgrading mcp sdk versions. Since now the sdk supports WebStandardStreamableHTTPServerTransport, removed the shims an...
X Description: Summary Our mcp copilot was broken, consistently returning 5xx. This was due to upgrading mcp sdk versions. Since now the sdk supports WebStandardStreamableHTTPServerTransport, removed the shims an...
Opengraph URL: https://github.com/simstudioai/sim/pull/4320
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f439caf7-5d19-d258-63a9-cb241318bae9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CED2:267719:670F3E:8E0924:6AFB4106 |
| html-safe-nonce | 897dc996d3b43acd4a24bf3fbc444bf1efa6c0f049e243f1393706e5c96fe8d1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUQyOjI2NzcxOTo2NzBGM0U6OEUwOTI0OjZBRkI0MTA2IiwidmlzaXRvcl9pZCI6IjE3NzA2NzUyNDY4MTQ5MzczNTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | cb91a50a510b4a70bb79b54bdd3bac60dfa2d966989f6cbbf6e4d86196e84c2a |
| hovercard-subject-tag | pull_request:3597634062 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4320/files |
| twitter:image | https://avatars.githubusercontent.com/u/19564703?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/19564703?s=400&v=4 |
| og:image:alt | Summary Our mcp copilot was broken, consistently returning 5xx. This was due to upgrading mcp sdk versions. Since now the sdk supports WebStandardStreamableHTTPServerTransport, removed the shims an... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | d849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a6c2f87cbcb6414452377b4967858ed6a66f1109 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width