Title: fix(logs): close sidebar when selected log disappears from filtered list by waleedlatif1 · Pull Request #4186 · simstudioai/sim · GitHub
Open Graph Title: fix(logs): close sidebar when selected log disappears from filtered list by waleedlatif1 · Pull Request #4186 · simstudioai/sim
X Title: fix(logs): close sidebar when selected log disappears from filtered list by waleedlatif1 · Pull Request #4186 · simstudioai/sim
Description: Summary Bug fix: Sidebar now closes automatically when the selected log disappears from the filtered list (e.g., clearing an execution ID filter). Uses derived state (effectiveSidebarOpen) instead of a useEffect, avoiding extra render cycles and covering all filter-clearing paths. Cleanup: Removed 12 unnecessary useMemo and 6 useCallback calls from non-memo'd components in the logs module. Replaced a dashboard useEffect state reset with a render-time reset pattern. Fixed CSS variable token usage in the line chart. Added hierarchical statsAll key to the React Query key factory. Added partialize to the log details UI store to prevent persisting transient isResizing state. Test plan Open logs page, select a log to open the sidebar Apply an execution ID filter, then clear it — sidebar should close Apply status/workflow filters, select a log, clear filters — sidebar should close if log is no longer in list Verify sidebar resize still works and persists width across reloads Verify dashboard chart segment selection resets when filters change Verify notification workflow selector still works
Open Graph Description: Summary Bug fix: Sidebar now closes automatically when the selected log disappears from the filtered list (e.g., clearing an execution ID filter). Uses derived state (effectiveSidebarOpen) instead...
X Description: Summary Bug fix: Sidebar now closes automatically when the selected log disappears from the filtered list (e.g., clearing an execution ID filter). Uses derived state (effectiveSidebarOpen) instead...
Opengraph URL: https://github.com/simstudioai/sim/pull/4186
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5e2ec3b9-f289-f6f5-913a-b0beef558e63 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E2D8:16F3DB:A3D150:E97F07:6A63806A |
| html-safe-nonce | 01c8b4994e91d7881c2f4d64679eba5dea6ac0aa6a235c6b58050688c0786c75 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMkQ4OjE2RjNEQjpBM0QxNTA6RTk3RjA3OjZBNjM4MDZBIiwidmlzaXRvcl9pZCI6Ijc4MDE0OTAzMzE4MTM1MTEyNzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f5f072e73bb9662f511dc12f6478cc74c66056b1ba0fe73ec7897c8f46ef5004 |
| hovercard-subject-tag | pull_request:3535911198 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4186/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Bug fix: Sidebar now closes automatically when the selected log disappears from the filtered list (e.g., clearing an execution ID filter). Uses derived state (effectiveSidebarOpen) instead... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | e4fb64aef87da454ec25b158147f7f5f14aef29216e5ca1612c2e48faa599d1f |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e839936ba5faffb9c836dda1cf4729d50c88a32e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width