René's URL Explorer Experiment


Title: fix(parallel): remove broken node-counting completion + resolver claim cross-block by waleedlatif1 · Pull Request #4045 · simstudioai/sim · GitHub

Open Graph Title: fix(parallel): remove broken node-counting completion + resolver claim cross-block by waleedlatif1 · Pull Request #4045 · simstudioai/sim

X Title: fix(parallel): remove broken node-counting completion + resolver claim cross-block by waleedlatif1 · Pull Request #4045 · simstudioai/sim

Description: Summary Parallel blocks used totalExpectedNodes = branchCount * allNodesInParallel to detect completion, which is wrong when branches have conditional paths (error edges, conditions) Success branches complete fewer nodes than error branches, so the count never matches and the counting-based aggregation misfires Removed the counting mechanism entirely — sentinel-end (triggered by edge processing) is the correct and sole mechanism for detecting parallel completion Wrong resolver claiming known properties to fix issue #4043 Type of Change Bug fix Testing All 670 executor tests pass. Tested with parallel blocks containing error edges. Added tests for cross-block case. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Parallel blocks used totalExpectedNodes = branchCount * allNodesInParallel to detect completion, which is wrong when branches have conditional paths (error edges, conditions) Success branc...

X Description: Summary Parallel blocks used totalExpectedNodes = branchCount * allNodesInParallel to detect completion, which is wrong when branches have conditional paths (error edges, conditions) Success branc...

Opengraph URL: https://github.com/simstudioai/sim/pull/4045

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:47d658aa-87b4-6730-afe4-5e748f75eb8e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8206:2F3575:BA9302:1099014:6AFB5DC6
html-safe-nonce8095a1ece446b69bc94f150df32c9024e85f65d50441c74181e206c827246294
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjA2OjJGMzU3NTpCQTkzMDI6MTA5OTAxNDo2QUZCNURDNiIsInZpc2l0b3JfaWQiOiI3NjYwNzQ0MDk0NjE5NzUzOTI2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3f355426407c6b43749f7af5727ec5d1f1137a45a80d7f460a77b1e1f26e544e
hovercard-subject-tagpull_request:3501917947
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/4045/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Parallel blocks used totalExpectedNodes = branchCount * allNodesInParallel to detect completion, which is wrong when branches have conditional paths (error edges, conditions) Success branc...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/4045/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4045%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F4045%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/4045/files
Reloadhttps://github.com/simstudioai/sim/pull/4045/files
Reloadhttps://github.com/simstudioai/sim/pull/4045/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
icecrasher321https://github.com/icecrasher321
staginghttps://github.com/simstudioai/sim/tree/staging
waleedlatif1/parallel-error-handlinghttps://github.com/simstudioai/sim/tree/waleedlatif1/parallel-error-handling
Conversation 5 https://github.com/simstudioai/sim/pull/4045
Commits 2 https://github.com/simstudioai/sim/pull/4045/commits
Checks 11 https://github.com/simstudioai/sim/pull/4045/checks
Files changed https://github.com/simstudioai/sim/pull/4045/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4045/files
fix(parallel): remove broken node-counting completion + resolver claim cross-block https://github.com/simstudioai/sim/pull/4045/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/4045/files
8c7b975 fix(parallel): remove broken node-counting completion in parallel blocks waleedlatif1 Apr 8, 2026 https://github.com/simstudioai/sim/pull/4045/commits/8c7b9756a11a35844ed6e76a5f1b9fa467c7dc9d
c4ee839 fix resolver claim Apr 8, 2026 https://github.com/simstudioai/sim/pull/4045/commits/c4ee839e42d20072006bc8405377d059f42c81a7
Clear filters https://github.com/simstudioai/sim/pull/4045/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4045/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4045/files
state.ts https://github.com/simstudioai/sim/pull/4045/files#diff-faf6864efdd66bd215787fa17b5ab586fed16f5e79eb8c8c1020bc4c037e4408
node.ts https://github.com/simstudioai/sim/pull/4045/files#diff-d02f82f0f50cc3aaeefbfd9638412409acb37a64e199af6c80dbcf8e0e47f832
parallel.test.ts https://github.com/simstudioai/sim/pull/4045/files#diff-b80f4ecc5eda5439d350c8e114dc97e6583587c615543dc16d21104521b88298
parallel.ts https://github.com/simstudioai/sim/pull/4045/files#diff-918ad942913fd2a85ba30146e69cba397330abb870d94465e8ef88b73eb250ae
types.ts https://github.com/simstudioai/sim/pull/4045/files#diff-b266de0e8311cee15872078a12705439e0d9b58ab87b7685752a0b3ea60cd378
iteration-context.test.ts https://github.com/simstudioai/sim/pull/4045/files#diff-66017a1358340bd89a0afc0507a9868b88a0021fecab3d9e4c5ce31dc94e2a16
parallel.test.ts https://github.com/simstudioai/sim/pull/4045/files#diff-8a9681a8f6682715942f250262c5b3c736c1407cec6df87ebae45334c8be12af
parallel.ts https://github.com/simstudioai/sim/pull/4045/files#diff-b30c716c94d47561552103f0c45a52347570b32f21c698eb870d62936f7d58f8
apps/sim/executor/execution/state.tshttps://github.com/simstudioai/sim/pull/4045/files#diff-faf6864efdd66bd215787fa17b5ab586fed16f5e79eb8c8c1020bc4c037e4408
View file https://github.com/simstudioai/sim/blob/c4ee839e42d20072006bc8405377d059f42c81a7/apps/sim/executor/execution/state.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4045/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4045/files#diff-faf6864efdd66bd215787fa17b5ab586fed16f5e79eb8c8c1020bc4c037e4408
https://github.com/simstudioai/sim/pull/4045/files#diff-faf6864efdd66bd215787fa17b5ab586fed16f5e79eb8c8c1020bc4c037e4408
apps/sim/executor/orchestrators/node.tshttps://github.com/simstudioai/sim/pull/4045/files#diff-d02f82f0f50cc3aaeefbfd9638412409acb37a64e199af6c80dbcf8e0e47f832
View file https://github.com/simstudioai/sim/blob/c4ee839e42d20072006bc8405377d059f42c81a7/apps/sim/executor/orchestrators/node.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4045/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4045/files#diff-d02f82f0f50cc3aaeefbfd9638412409acb37a64e199af6c80dbcf8e0e47f832
https://github.com/simstudioai/sim/pull/4045/files#diff-d02f82f0f50cc3aaeefbfd9638412409acb37a64e199af6c80dbcf8e0e47f832
https://github.com/simstudioai/sim/pull/4045/files#diff-d02f82f0f50cc3aaeefbfd9638412409acb37a64e199af6c80dbcf8e0e47f832
https://github.com/simstudioai/sim/pull/4045/files#diff-d02f82f0f50cc3aaeefbfd9638412409acb37a64e199af6c80dbcf8e0e47f832
https://github.com/simstudioai/sim/pull/4045/files#diff-d02f82f0f50cc3aaeefbfd9638412409acb37a64e199af6c80dbcf8e0e47f832
https://github.com/simstudioai/sim/pull/4045/files#diff-d02f82f0f50cc3aaeefbfd9638412409acb37a64e199af6c80dbcf8e0e47f832
apps/sim/executor/orchestrators/parallel.test.tshttps://github.com/simstudioai/sim/pull/4045/files#diff-b80f4ecc5eda5439d350c8e114dc97e6583587c615543dc16d21104521b88298
View file https://github.com/simstudioai/sim/blob/c4ee839e42d20072006bc8405377d059f42c81a7/apps/sim/executor/orchestrators/parallel.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4045/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4045/files#diff-b80f4ecc5eda5439d350c8e114dc97e6583587c615543dc16d21104521b88298
https://github.com/simstudioai/sim/pull/4045/files#diff-b80f4ecc5eda5439d350c8e114dc97e6583587c615543dc16d21104521b88298
apps/sim/executor/orchestrators/parallel.tshttps://github.com/simstudioai/sim/pull/4045/files#diff-918ad942913fd2a85ba30146e69cba397330abb870d94465e8ef88b73eb250ae
View file https://github.com/simstudioai/sim/blob/c4ee839e42d20072006bc8405377d059f42c81a7/apps/sim/executor/orchestrators/parallel.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4045/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4045/files#diff-918ad942913fd2a85ba30146e69cba397330abb870d94465e8ef88b73eb250ae
https://github.com/simstudioai/sim/pull/4045/files#diff-918ad942913fd2a85ba30146e69cba397330abb870d94465e8ef88b73eb250ae
https://github.com/simstudioai/sim/pull/4045/files#diff-918ad942913fd2a85ba30146e69cba397330abb870d94465e8ef88b73eb250ae
https://github.com/simstudioai/sim/pull/4045/files#diff-918ad942913fd2a85ba30146e69cba397330abb870d94465e8ef88b73eb250ae
https://github.com/simstudioai/sim/pull/4045/files#diff-918ad942913fd2a85ba30146e69cba397330abb870d94465e8ef88b73eb250ae
https://github.com/simstudioai/sim/pull/4045/files#diff-918ad942913fd2a85ba30146e69cba397330abb870d94465e8ef88b73eb250ae
https://github.com/simstudioai/sim/pull/4045/files#diff-918ad942913fd2a85ba30146e69cba397330abb870d94465e8ef88b73eb250ae
https://github.com/simstudioai/sim/pull/4045/files#diff-918ad942913fd2a85ba30146e69cba397330abb870d94465e8ef88b73eb250ae
https://github.com/simstudioai/sim/pull/4045/files#diff-918ad942913fd2a85ba30146e69cba397330abb870d94465e8ef88b73eb250ae
apps/sim/executor/types.tshttps://github.com/simstudioai/sim/pull/4045/files#diff-b266de0e8311cee15872078a12705439e0d9b58ab87b7685752a0b3ea60cd378
View file https://github.com/simstudioai/sim/blob/c4ee839e42d20072006bc8405377d059f42c81a7/apps/sim/executor/types.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4045/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4045/files#diff-b266de0e8311cee15872078a12705439e0d9b58ab87b7685752a0b3ea60cd378
https://github.com/simstudioai/sim/pull/4045/files#diff-b266de0e8311cee15872078a12705439e0d9b58ab87b7685752a0b3ea60cd378
apps/sim/executor/utils/iteration-context.test.tshttps://github.com/simstudioai/sim/pull/4045/files#diff-66017a1358340bd89a0afc0507a9868b88a0021fecab3d9e4c5ce31dc94e2a16
View file https://github.com/simstudioai/sim/blob/c4ee839e42d20072006bc8405377d059f42c81a7/apps/sim/executor/utils/iteration-context.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/4045/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/4045/files#diff-66017a1358340bd89a0afc0507a9868b88a0021fecab3d9e4c5ce31dc94e2a16
https://github.com/simstudioai/sim/pull/4045/files#diff-66017a1358340bd89a0afc0507a9868b88a0021fecab3d9e4c5ce31dc94e2a16
https://github.com/simstudioai/sim/pull/4045/files#diff-66017a1358340bd89a0afc0507a9868b88a0021fecab3d9e4c5ce31dc94e2a16
https://github.com/simstudioai/sim/pull/4045/files#diff-66017a1358340bd89a0afc0507a9868b88a0021fecab3d9e4c5ce31dc94e2a16
https://github.com/simstudioai/sim/pull/4045/files#diff-66017a1358340bd89a0afc0507a9868b88a0021fecab3d9e4c5ce31dc94e2a16
https://github.com/simstudioai/sim/pull/4045/files#diff-66017a1358340bd89a0afc0507a9868b88a0021fecab3d9e4c5ce31dc94e2a16
https://github.com/simstudioai/sim/pull/4045/files#diff-66017a1358340bd89a0afc0507a9868b88a0021fecab3d9e4c5ce31dc94e2a16
https://github.com/simstudioai/sim/pull/4045/files#diff-66017a1358340bd89a0afc0507a9868b88a0021fecab3d9e4c5ce31dc94e2a16
https://github.com/simstudioai/sim/pull/4045/files#diff-66017a1358340bd89a0afc0507a9868b88a0021fecab3d9e4c5ce31dc94e2a16
https://github.com/simstudioai/sim/pull/4045/files#diff-66017a1358340bd89a0afc0507a9868b88a0021fecab3d9e4c5ce31dc94e2a16
https://github.com/simstudioai/sim/pull/4045/files#diff-66017a1358340bd89a0afc0507a9868b88a0021fecab3d9e4c5ce31dc94e2a16
https://github.com/simstudioai/sim/pull/4045/files#diff-66017a1358340bd89a0afc0507a9868b88a0021fecab3d9e4c5ce31dc94e2a16
https://github.com/simstudioai/sim/pull/4045/files#diff-66017a1358340bd89a0afc0507a9868b88a0021fecab3d9e4c5ce31dc94e2a16
https://github.com/simstudioai/sim/pull/4045/files#diff-66017a1358340bd89a0afc0507a9868b88a0021fecab3d9e4c5ce31dc94e2a16
https://github.com/simstudioai/sim/pull/4045/files#diff-66017a1358340bd89a0afc0507a9868b88a0021fecab3d9e4c5ce31dc94e2a16
https://github.com/simstudioai/sim/pull/4045/files#diff-66017a1358340bd89a0afc0507a9868b88a0021fecab3d9e4c5ce31dc94e2a16
https://github.com/simstudioai/sim/pull/4045/files#diff-66017a1358340bd89a0afc0507a9868b88a0021fecab3d9e4c5ce31dc94e2a16
https://github.com/simstudioai/sim/pull/4045/files#diff-66017a1358340bd89a0afc0507a9868b88a0021fecab3d9e4c5ce31dc94e2a16
https://github.com/simstudioai/sim/pull/4045/files#diff-66017a1358340bd89a0afc0507a9868b88a0021fecab3d9e4c5ce31dc94e2a16
https://github.com/simstudioai/sim/pull/4045/files#diff-66017a1358340bd89a0afc0507a9868b88a0021fecab3d9e4c5ce31dc94e2a16
https://github.com/simstudioai/sim/pull/4045/files#diff-66017a1358340bd89a0afc0507a9868b88a0021fecab3d9e4c5ce31dc94e2a16
Please reload this pagehttps://github.com/simstudioai/sim/pull/4045/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/4045/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.