Title: fix(modals): center modals in visible content area accounting for sidebar and panel by waleedlatif1 · Pull Request #3933 · simstudioai/sim · GitHub
Open Graph Title: fix(modals): center modals in visible content area accounting for sidebar and panel by waleedlatif1 · Pull Request #3933 · simstudioai/sim
X Title: fix(modals): center modals in visible content area accounting for sidebar and panel by waleedlatif1 · Pull Request #3933 · simstudioai/sim
Description: Summary Command K and all emcn modals now center in the visible content area (between sidebar and panel) instead of the full viewport Fixed `--sidebar-width` CSS default to `0px` so non-workspace pages (login, landing) keep modals viewport-centered Blocking script now always explicitly sets `--sidebar-width` on workspace pages, covering new users and error cases Search modal accounts for the right panel on workflow pages using `isOnWorkflowPage` prop emcn `ModalContent` uses `usePathname` to detect workflow pages and apply the panel-aware formula Removed horizontal slide animation from emcn Modal (was tied to hardcoded `left: 50%`) Type of Change Bug fix Testing Tested manually Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Command K and all emcn modals now center in the visible content area (between sidebar and panel) instead of the full viewport Fixed `--sidebar-width` CSS default to `0px` so non-workspace ...
X Description: Summary Command K and all emcn modals now center in the visible content area (between sidebar and panel) instead of the full viewport Fixed `--sidebar-width` CSS default to `0px` so non-workspace ...
Opengraph URL: https://github.com/simstudioai/sim/pull/3933
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:037de24e-a9e5-8ab2-a9ce-031f3ee63ade |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BD8A:3EFFC5:BF6BCA:10E4C2A:6AFB5DA2 |
| html-safe-nonce | a32842a63f67a4bebc0e99f19ec6226948bc5802b1dec93c4576459de8f422a1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDhBOjNFRkZDNTpCRjZCQ0E6MTBFNEMyQTo2QUZCNURBMiIsInZpc2l0b3JfaWQiOiI1NzEyNTQ2MTY4OTQ0OTQyNDk4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 86ec4a7462227d34bd8de5f034a68e7c2af48047705adf4a6ec92633fa1b7ba0 |
| hovercard-subject-tag | pull_request:3488062693 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/3933/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Command K and all emcn modals now center in the visible content area (between sidebar and panel) instead of the full viewport Fixed `--sidebar-width` CSS default to `0px` so non-workspace ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | ea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ef97164c52cf59bd10558ddec9c4f482763988 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width