René's URL Explorer Experiment


Title: fix(knowledge): give users choice to keep or delete documents when removing connector by waleedlatif1 · Pull Request #3825 · simstudioai/sim · GitHub

Open Graph Title: fix(knowledge): give users choice to keep or delete documents when removing connector by waleedlatif1 · Pull Request #3825 · simstudioai/sim

X Title: fix(knowledge): give users choice to keep or delete documents when removing connector by waleedlatif1 · Pull Request #3825 · simstudioai/sim

Description: Sim is the collaborative workspace to build, deploy, and monitor AI agents and workflows. Used by 100,000+ builders. - fix(knowledge): give users choice to keep or delete documents when removing connector by waleedlatif1 · Pull Request #3825 · simstudioai/sim

Open Graph Description: Summary Fix misleading delete connector modal — previously said "documents will remain" but actually hard-deleted everything Add checkbox "Also delete all synced documents" to ...

X Description: Summary Fix misleading delete connector modal — previously said "documents will remain" but actually hard-deleted everything Add checkbox "Also delete all synced documen...

Opengraph URL: https://github.com/simstudioai/sim/pull/3825

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:88c3ae47-da7d-4b6c-4785-ddc2b4c23dd0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD690:267719:FD1B72:15ABD33:6AFB6452
html-safe-noncee3c5837e9dd181fb70d22ebfd7be2ae48da4c23feee4538079b4283392891d2a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjkwOjI2NzcxOTpGRDFCNzI6MTVBQkQzMzo2QUZCNjQ1MiIsInZpc2l0b3JfaWQiOiI4Mjc0NTQ5ODM1NjQzODc0MTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac21b58cbab337ce92719989155add3ad8021260c3fef99d1c339118888bdd8348
hovercard-subject-tagpull_request:3461100064
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/simstudioai/sim/3825/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3afb6648c1975ed9c5d122e1d6fb0f7c20a7bf1f33de10abd576a9fb717666b8/simstudioai/sim/pull/3825
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3afb6648c1975ed9c5d122e1d6fb0f7c20a7bf1f33de10abd576a9fb717666b8/simstudioai/sim/pull/3825
og:image:altSummary Fix misleading delete connector modal — previously said "documents will remain" but actually hard-deleted everything Add checkbox "Also delete all synced documents" to ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewaleedlatif1
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-cache
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/3825#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F3825
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F3825
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/3825
Reloadhttps://github.com/simstudioai/sim/pull/3825
Reloadhttps://github.com/simstudioai/sim/pull/3825
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
https://github.com/simstudioai/sim
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
waleedlatif1/fix-extension-parsinghttps://github.com/simstudioai/sim/tree/waleedlatif1/fix-extension-parsing
Conversationhttps://github.com/simstudioai/sim/pull/3825
Commits7 (7)https://github.com/simstudioai/sim/pull/3825/commits
Checkshttps://github.com/simstudioai/sim/pull/3825/checks
Files changedhttps://github.com/simstudioai/sim/pull/3825/files
fix(knowledge): give users choice to keep or delete documents when removing connectorhttps://github.com/simstudioai/sim/pull/3825#top
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
waleedlatif1/fix-extension-parsinghttps://github.com/simstudioai/sim/tree/waleedlatif1/fix-extension-parsing
https://github.com/waleedlatif1
waleedlatif1https://github.com/waleedlatif1
Mar 28, 2026https://github.com/simstudioai/sim/pull/3825#issue-4161195613
Contributor License Agreement (CLA)https://github.com/simstudioai/sim/pull/CONTRIBUTING.md#contributor-license-agreement-cla
Please reload this pagehttps://github.com/simstudioai/sim/pull/3825
https://github.com/apps/cursor
cursorhttps://github.com/apps/cursor
Mar 28, 2026https://github.com/simstudioai/sim/pull/3825#issuecomment-4148559718
Please reload this pagehttps://github.com/simstudioai/sim/pull/3825
Cursor Bugbothttps://cursor.com/dashboard?tab=bugbot
a2959f5https://github.com/simstudioai/sim/commit/a2959f5df069e251e7c7b0bab2b77b2ccffa6dfc
herehttps://cursor.com/dashboard?tab=bugbot
Please reload this pagehttps://github.com/simstudioai/sim/pull/3825
https://github.com/apps/vercel
vercelhttps://github.com/apps/vercel
Mar 28, 2026https://github.com/simstudioai/sim/pull/3825#issuecomment-4148559723
Please reload this pagehttps://github.com/simstudioai/sim/pull/3825
Vercel for GitHubhttps://vercel.link/github-learn-more
docshttps://vercel.com/sim-studio/docs
https://camo.githubusercontent.com/833ba95642364322d56bfc6cc95692affdd7a5a6ca7b50fdcc44aa7e47372d3b/68747470733a2f2f76657263656c2e636f6d2f7374617469632f7374617475732f72656164792e737667
Readyhttps://vercel.com/sim-studio/docs/9MFp263HzcaAGSFF57L3UCADMcgK
Previewhttps://docs-git-waleedlatif1-fix-extension-parsing-sim-studio.vercel.app
Commenthttps://vercel.live/open-feedback/docs-git-waleedlatif1-fix-extension-parsing-sim-studio.vercel.app?via=pr-comment-feedback-link
https://vercel.com/vercel-agent/request-review?owner=simstudioai&repo=sim&pr=3825
Please reload this pagehttps://github.com/simstudioai/sim/pull/3825
https://github.com/apps/greptile-apps
greptile-appshttps://github.com/apps/greptile-apps
Mar 28, 2026https://github.com/simstudioai/sim/pull/3825#issuecomment-4148566601
Please reload this pagehttps://github.com/simstudioai/sim/pull/3825
"fix(knowledge): fix connector delete tes..."https://github.com/simstudioai/sim/commit/a2959f5df069e251e7c7b0bab2b77b2ccffa6dfc
Re-trigger Greptilehttps://app.greptile.com/api/retrigger?id=26661824
Please reload this pagehttps://github.com/simstudioai/sim/pull/3825
https://github.com/apps/greptile-apps
greptile-appshttps://github.com/apps/greptile-apps
Mar 28, 2026 https://github.com/simstudioai/sim/pull/3825#pullrequestreview-4025849328
View reviewed changes https://github.com/simstudioai/sim/pull/3825/files
apps/sim/app/api/knowledge/[id]/connectors/[connectorId]/route.tshttps://github.com/simstudioai/sim/pull/3825/files#diff-1123ed11307562c4f018c51d26a42b13f893f6351dbda1a01bfb6213179697ea
Please reload this pagehttps://github.com/simstudioai/sim/pull/3825
https://github.com/apps/cursor
cursorhttps://github.com/apps/cursor
Mar 28, 2026 https://github.com/simstudioai/sim/pull/3825#pullrequestreview-4025850259
View reviewed changes https://github.com/simstudioai/sim/pull/3825/files
apps/sim/app/api/knowledge/[id]/connectors/[connectorId]/route.tshttps://github.com/simstudioai/sim/pull/3825/files#diff-1123ed11307562c4f018c51d26a42b13f893f6351dbda1a01bfb6213179697ea
Please reload this pagehttps://github.com/simstudioai/sim/pull/3825
https://github.com/apps/vercel
vercelhttps://github.com/apps/vercel
temporarily deployedhttps://docs-p1kcdbys9-sim-studio.vercel.app
March 28, 2026 18:27https://github.com/simstudioai/sim/pull/3825#event-24001008071
https://github.com/apps/vercel
vercelhttps://github.com/apps/vercel
temporarily deployedhttps://docs-5ea1nmtre-sim-studio.vercel.app
March 28, 2026 18:29https://github.com/simstudioai/sim/pull/3825#event-24001027291
https://github.com/apps/vercel
vercelhttps://github.com/apps/vercel
deployedhttps://docs-b7i33rblu-sim-studio.vercel.app
Previewhttps://docs-b7i33rblu-sim-studio.vercel.app
March 28, 2026 18:40https://github.com/simstudioai/sim/pull/3825#event-24001128648
View deploymenthttps://docs-b7i33rblu-sim-studio.vercel.app
waleedlatif1https://github.com/waleedlatif1
March 28, 2026 11:43https://github.com/simstudioai/sim/pull/3825#commits-pushed-2e48eaa
https://github.com/waleedlatif1
fix(knowledge): give users choice to keep or delete documents when re…https://github.com/simstudioai/sim/pull/3825/commits/2e48eaa8b9b2511754f435b0f9d3f34e5c2933c1
2e48eaahttps://github.com/simstudioai/sim/pull/3825/commits/2e48eaa8b9b2511754f435b0f9d3f34e5c2933c1
https://github.com/waleedlatif1
https://github.com/claude
refactor(knowledge): clean up connector delete and extract shared ext…https://github.com/simstudioai/sim/pull/3825/commits/05d8c1872bb8f3d7306205a1737011b17a978166
05d8c18https://github.com/simstudioai/sim/pull/3825/commits/05d8c1872bb8f3d7306205a1737011b17a978166
https://github.com/waleedlatif1
https://github.com/claude
refactor(knowledge): remove duplicate extension list from parser-exte…https://github.com/simstudioai/sim/pull/3825/commits/d54cf4ba82c70c877321864de92949c97fe81330
d54cf4bhttps://github.com/simstudioai/sim/pull/3825/commits/d54cf4ba82c70c877321864de92949c97fe81330
https://github.com/waleedlatif1
https://github.com/claude
fix(db): change document.connectorId FK from cascade to set nullhttps://github.com/simstudioai/sim/pull/3825/commits/6ef313a38fcff8f47f05fef079a103f18fb226eb
6ef313ahttps://github.com/simstudioai/sim/pull/3825/commits/6ef313a38fcff8f47f05fef079a103f18fb226eb
https://github.com/waleedlatif1
https://github.com/claude
chore(db): add migration metadata for connectorId FK changehttps://github.com/simstudioai/sim/pull/3825/commits/ee5cc5ba2c6defad29123062365591edea94dcba
ee5cc5bhttps://github.com/simstudioai/sim/pull/3825/commits/ee5cc5ba2c6defad29123062365591edea94dcba
https://github.com/waleedlatif1
waleedlatif1https://github.com/waleedlatif1
force-pushedhttps://github.com/simstudioai/sim/compare/abbc17ee84fe6f0680368c94f310cba06c7df216..ee5cc5ba2c6defad29123062365591edea94dcba
abbc17ehttps://github.com/simstudioai/sim/commit/abbc17ee84fe6f0680368c94f310cba06c7df216
ee5cc5bhttps://github.com/simstudioai/sim/commit/ee5cc5ba2c6defad29123062365591edea94dcba
Compare https://github.com/simstudioai/sim/compare/abbc17ee84fe6f0680368c94f310cba06c7df216..ee5cc5ba2c6defad29123062365591edea94dcba
March 28, 2026 18:43https://github.com/simstudioai/sim/pull/3825#event-24001164928
https://github.com/apps/vercel
vercelhttps://github.com/apps/vercel
deployedhttps://docs-mi660ddon-sim-studio.vercel.app
Previewhttps://docs-mi660ddon-sim-studio.vercel.app
March 28, 2026 18:46https://github.com/simstudioai/sim/pull/3825#event-24001199891
View deploymenthttps://docs-mi660ddon-sim-studio.vercel.app
https://github.com/waleedlatif1
https://github.com/claude
fix(knowledge): fix connector delete test and use URL-safe searchParamshttps://github.com/simstudioai/sim/pull/3825/commits/a2959f5df069e251e7c7b0bab2b77b2ccffa6dfc
a2959f5https://github.com/simstudioai/sim/pull/3825/commits/a2959f5df069e251e7c7b0bab2b77b2ccffa6dfc
https://github.com/apps/vercel
vercelhttps://github.com/apps/vercel
temporarily deployedhttps://docs-5lxrlnyzx-sim-studio.vercel.app
March 28, 2026 18:47https://github.com/simstudioai/sim/pull/3825#event-24001222643
https://github.com/waleedlatif1
waleedlatif1https://github.com/waleedlatif1
Mar 28, 2026https://github.com/simstudioai/sim/pull/3825#issuecomment-4148614419
@cursorhttps://github.com/cursor
Please reload this pagehttps://github.com/simstudioai/sim/pull/3825
https://github.com/waleedlatif1
waleedlatif1https://github.com/waleedlatif1
Mar 28, 2026https://github.com/simstudioai/sim/pull/3825#issuecomment-4148614514
@greptilehttps://github.com/greptile
Please reload this pagehttps://github.com/simstudioai/sim/pull/3825
https://github.com/apps/cursor
cursorhttps://github.com/apps/cursor
Mar 28, 2026 https://github.com/simstudioai/sim/pull/3825#pullrequestreview-4025904299
View reviewed changes https://github.com/simstudioai/sim/pull/3825/files/a2959f5df069e251e7c7b0bab2b77b2ccffa6dfc
cursorhttps://github.com/apps/cursor
https://github.com/simstudioai/sim/pull/3825#pullrequestreview-4025904299
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/simstudioai/sim/pull/3825
https://github.com/waleedlatif1
spacinghttps://github.com/simstudioai/sim/pull/3825/commits/4457078e749195d317866f819b6c850318337da4
4457078https://github.com/simstudioai/sim/pull/3825/commits/4457078e749195d317866f819b6c850318337da4
https://github.com/apps/vercel
vercelhttps://github.com/apps/vercel
temporarily deployedhttps://docs-5t5iwk0t5-sim-studio.vercel.app
March 28, 2026 19:04https://github.com/simstudioai/sim/pull/3825#event-24001421790
https://github.com/waleedlatif1
waleedlatif1https://github.com/waleedlatif1
e4d3573https://github.com/simstudioai/sim/commit/e4d35735b11e6396ce203e8daef0b791d3565fe7
Mar 28, 2026https://github.com/simstudioai/sim/pull/3825#event-24001422261
Please reload this pagehttps://github.com/simstudioai/sim/pull/3825
https://github.com/waleedlatif1
waleedlatif1https://github.com/waleedlatif1
March 28, 2026 19:04https://github.com/simstudioai/sim/pull/3825#event-24001422757
https://github.com/waleedlatif1
waleedlatif1https://github.com/waleedlatif1
Mar 30, 2026 https://github.com/simstudioai/sim/pull/3825#ref-pullrequest-4167603183
v0.6.15: workers, security hardening, sidebar improvements, chat fixes, profound #3840 https://github.com/simstudioai/sim/pull/3840
waleedlatif1https://github.com/waleedlatif1
Apr 4, 2026 https://github.com/simstudioai/sim/pull/3825#ref-commit-0cb4d2e
https://github.com/waleedlatif1
https://github.com/claude
fix(knowledge): give users choice to keep or delete documents when re…https://github.com/simstudioai/sim/commit/0cb4d2e785ccf71197b7b9e4beb466c65f7b46eb
0cb4d2ehttps://github.com/simstudioai/sim/commit/0cb4d2e785ccf71197b7b9e4beb466c65f7b46eb
#3825https://github.com/simstudioai/sim/pull/3825
Deployedhttps://docs-5t5iwk0t5-sim-studio.vercel.app
vercel[bot]https://github.com/apps/vercel
View deployment https://docs-5t5iwk0t5-sim-studio.vercel.app
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F3825
https://github.com/apps/greptile-apps
greptile-apps[bot] https://github.com/apps/greptile-apps
https://github.com/simstudioai/sim/pull/3825/files/8acbf1cff29417c0349b905192c07591f270d6ac
https://github.com/apps/cursor
cursor[bot] https://github.com/apps/cursor
https://github.com/simstudioai/sim/pull/3825/files/a2959f5df069e251e7c7b0bab2b77b2ccffa6dfc
Please reload this pagehttps://github.com/simstudioai/sim/pull/3825
Please reload this pagehttps://github.com/simstudioai/sim/pull/3825
https://github.com/waleedlatif1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.