René's URL Explorer Experiment


Title: fix(security): pentest remediation — condition escaping, SSRF hardening, ReDoS protection by waleedlatif1 · Pull Request #3820 · simstudioai/sim · GitHub

Open Graph Title: fix(security): pentest remediation — condition escaping, SSRF hardening, ReDoS protection by waleedlatif1 · Pull Request #3820 · simstudioai/sim

X Title: fix(security): pentest remediation — condition escaping, SSRF hardening, ReDoS protection by waleedlatif1 · Pull Request #3820 · simstudioai/sim

Description: Summary Condition expression escaping: escape newline/CR/line-separator characters in resolved string values before embedding in JS condition expressions — unescaped newlines caused SyntaxError and workflow execution failure SSRF localhost hardening: use isHosted feature flag instead of allowHttp to gate localhost/loopback access in URL validation — blocks SSRF via localhost in hosted environments while preserving self-hosted functionality ReDoS protection: add safe-regex2 validation and 10K char input length limit to regex guardrails to prevent catastrophic backtracking Type of Change Bug fix Testing Tested manually Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Condition expression escaping: escape newline/CR/line-separator characters in resolved string values before embedding in JS condition expressions — unescaped newlines caused SyntaxError an...

X Description: Summary Condition expression escaping: escape newline/CR/line-separator characters in resolved string values before embedding in JS condition expressions — unescaped newlines caused SyntaxError an...

Opengraph URL: https://github.com/simstudioai/sim/pull/3820

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3361e9aa-a990-e154-f501-48851692e904
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA790:37EBB:D6091B:12E90EC:6AFB6432
html-safe-nonce7bba75734e13ea85001ca61c5ed531053f1404b0161bb40968910f3316edd81e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzkwOjM3RUJCOkQ2MDkxQjoxMkU5MEVDOjZBRkI2NDMyIiwidmlzaXRvcl9pZCI6Ijg2NjYxNjEwNDIwMDQwNzU1NzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7f027d9ecd484fc8f0c49e44b3aa5669c2da59688a4184c6d19db50b74539a6b
hovercard-subject-tagpull_request:3459535053
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/3820/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Condition expression escaping: escape newline/CR/line-separator characters in resolved string values before embedding in JS condition expressions — unescaped newlines caused SyntaxError an...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/3820/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F3820%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F3820%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/3820/files
Reloadhttps://github.com/simstudioai/sim/pull/3820/files
Reloadhttps://github.com/simstudioai/sim/pull/3820/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
waleedlatif1/assess-pentest-findinghttps://github.com/simstudioai/sim/tree/waleedlatif1/assess-pentest-finding
Conversation 16 https://github.com/simstudioai/sim/pull/3820
Commits 7 https://github.com/simstudioai/sim/pull/3820/commits
Checks 11 https://github.com/simstudioai/sim/pull/3820/checks
Files changed https://github.com/simstudioai/sim/pull/3820/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/3820/files
fix(security): pentest remediation — condition escaping, SSRF hardening, ReDoS protection https://github.com/simstudioai/sim/pull/3820/files#top
Show all changes 7 commits https://github.com/simstudioai/sim/pull/3820/files
026bc76 fix(executor): escape newline characters in condition expression strings waleedlatif1 Mar 28, 2026 https://github.com/simstudioai/sim/pull/3820/commits/026bc76edcc3bb861ff7245c0a2e012aa53ea9bf
f1fc068 fix(security): prevent ReDoS in guardrails regex validation waleedlatif1 Mar 28, 2026 https://github.com/simstudioai/sim/pull/3820/commits/f1fc0684ed8c427b49b1f5b65f180b2ebe630533
ccaa49d fix(security): SSRF localhost hardening and regex DoS protection waleedlatif1 Mar 28, 2026 https://github.com/simstudioai/sim/pull/3820/commits/ccaa49d225e383764da899c31e91202b10c62f75
34be2a7 fix(security): validate regex syntax before safety check waleedlatif1 Mar 28, 2026 https://github.com/simstudioai/sim/pull/3820/commits/34be2a7beaa82dcd9878d3c7e7bbf0181f8ba20d
8d03be3 fix(security): address PR review feedback waleedlatif1 Mar 28, 2026 https://github.com/simstudioai/sim/pull/3820/commits/8d03be3c62b5858857af6198561ef39a30d42a17
f63d1c6 fix(security): remove input length cap from regex validation waleedlatif1 Mar 28, 2026 https://github.com/simstudioai/sim/pull/3820/commits/f63d1c692e4ee7880e88c6f32858080fec36b396
301f9be fix(tests): mock isHosted in input-validation and function-execute tests waleedlatif1 Mar 28, 2026 https://github.com/simstudioai/sim/pull/3820/commits/301f9be7ec0454bfafd4fa8b92596f351a9aea3f
Clear filters https://github.com/simstudioai/sim/pull/3820/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/3820/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/3820/files
route.test.ts https://github.com/simstudioai/sim/pull/3820/files#diff-f3b89f4f3a3c7e2956982e58774c7080375eabe6a1d23f84ccce8eb8807de6b7
resolver.ts https://github.com/simstudioai/sim/pull/3820/files#diff-689d75b70daf1f65a0914798bb39ad228e6918dc990978d09a349acfe0ca22f6
input-validation.server.ts https://github.com/simstudioai/sim/pull/3820/files#diff-6aff011dd9656fc3e2283ce7a33580a51622749a977dcacb0b75050284426798
input-validation.test.ts https://github.com/simstudioai/sim/pull/3820/files#diff-3fa161edf2857cae95d194e040ac32e0272691ebcbbd04c9776d9dc0465774b5
input-validation.ts https://github.com/simstudioai/sim/pull/3820/files#diff-69599ab9ede3d937e027206bfbbaef65edcfeae21ad92d8b3d69fd5d11f8adf6
validate_regex.ts https://github.com/simstudioai/sim/pull/3820/files#diff-be394194550043f5dd99c23e10a61489df7415d30b8e9a5560b494e29c7c8ec1
package.json https://github.com/simstudioai/sim/pull/3820/files#diff-43a1bb37ce68ac536b0a4ed9e973d9d52da3975d74b37865f591bb37e191be64
bun.lock https://github.com/simstudioai/sim/pull/3820/files#diff-bfd0ef82a01108fa1e836c2500b98b7de8a92bb1ae352a8efcbd9d6ffcaabd60
apps/sim/app/api/function/execute/route.test.tshttps://github.com/simstudioai/sim/pull/3820/files#diff-f3b89f4f3a3c7e2956982e58774c7080375eabe6a1d23f84ccce8eb8807de6b7
View file https://github.com/simstudioai/sim/blob/301f9be7ec0454bfafd4fa8b92596f351a9aea3f/apps/sim/app/api/function/execute/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/3820/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/3820/files#diff-f3b89f4f3a3c7e2956982e58774c7080375eabe6a1d23f84ccce8eb8807de6b7
https://github.com/simstudioai/sim/pull/3820/files#diff-f3b89f4f3a3c7e2956982e58774c7080375eabe6a1d23f84ccce8eb8807de6b7
apps/sim/executor/variables/resolver.tshttps://github.com/simstudioai/sim/pull/3820/files#diff-689d75b70daf1f65a0914798bb39ad228e6918dc990978d09a349acfe0ca22f6
View file https://github.com/simstudioai/sim/blob/301f9be7ec0454bfafd4fa8b92596f351a9aea3f/apps/sim/executor/variables/resolver.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/3820/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/3820/files#diff-689d75b70daf1f65a0914798bb39ad228e6918dc990978d09a349acfe0ca22f6
https://github.com/simstudioai/sim/pull/3820/files#diff-689d75b70daf1f65a0914798bb39ad228e6918dc990978d09a349acfe0ca22f6
apps/sim/lib/core/security/input-validation.server.tshttps://github.com/simstudioai/sim/pull/3820/files#diff-6aff011dd9656fc3e2283ce7a33580a51622749a977dcacb0b75050284426798
View file https://github.com/simstudioai/sim/blob/301f9be7ec0454bfafd4fa8b92596f351a9aea3f/apps/sim/lib/core/security/input-validation.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/3820/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/3820/files#diff-6aff011dd9656fc3e2283ce7a33580a51622749a977dcacb0b75050284426798
https://github.com/simstudioai/sim/pull/3820/files#diff-6aff011dd9656fc3e2283ce7a33580a51622749a977dcacb0b75050284426798
https://github.com/simstudioai/sim/pull/3820/files#diff-6aff011dd9656fc3e2283ce7a33580a51622749a977dcacb0b75050284426798
https://github.com/simstudioai/sim/pull/3820/files#diff-6aff011dd9656fc3e2283ce7a33580a51622749a977dcacb0b75050284426798
apps/sim/lib/core/security/input-validation.test.tshttps://github.com/simstudioai/sim/pull/3820/files#diff-3fa161edf2857cae95d194e040ac32e0272691ebcbbd04c9776d9dc0465774b5
View file https://github.com/simstudioai/sim/blob/301f9be7ec0454bfafd4fa8b92596f351a9aea3f/apps/sim/lib/core/security/input-validation.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/3820/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/3820/files#diff-3fa161edf2857cae95d194e040ac32e0272691ebcbbd04c9776d9dc0465774b5
https://github.com/simstudioai/sim/pull/3820/files#diff-3fa161edf2857cae95d194e040ac32e0272691ebcbbd04c9776d9dc0465774b5
https://github.com/simstudioai/sim/pull/3820/files#diff-3fa161edf2857cae95d194e040ac32e0272691ebcbbd04c9776d9dc0465774b5
https://github.com/simstudioai/sim/pull/3820/files#diff-3fa161edf2857cae95d194e040ac32e0272691ebcbbd04c9776d9dc0465774b5
https://github.com/simstudioai/sim/pull/3820/files#diff-3fa161edf2857cae95d194e040ac32e0272691ebcbbd04c9776d9dc0465774b5
https://github.com/simstudioai/sim/pull/3820/files#diff-3fa161edf2857cae95d194e040ac32e0272691ebcbbd04c9776d9dc0465774b5
https://github.com/simstudioai/sim/pull/3820/files#diff-3fa161edf2857cae95d194e040ac32e0272691ebcbbd04c9776d9dc0465774b5
https://github.com/simstudioai/sim/pull/3820/files#diff-3fa161edf2857cae95d194e040ac32e0272691ebcbbd04c9776d9dc0465774b5
apps/sim/lib/core/security/input-validation.tshttps://github.com/simstudioai/sim/pull/3820/files#diff-69599ab9ede3d937e027206bfbbaef65edcfeae21ad92d8b3d69fd5d11f8adf6
View file https://github.com/simstudioai/sim/blob/301f9be7ec0454bfafd4fa8b92596f351a9aea3f/apps/sim/lib/core/security/input-validation.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/3820/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/3820/files#diff-69599ab9ede3d937e027206bfbbaef65edcfeae21ad92d8b3d69fd5d11f8adf6
https://github.com/simstudioai/sim/pull/3820/files#diff-69599ab9ede3d937e027206bfbbaef65edcfeae21ad92d8b3d69fd5d11f8adf6
Please reload this pagehttps://github.com/simstudioai/sim/pull/3820/files
https://github.com/simstudioai/sim/pull/3820/files#diff-69599ab9ede3d937e027206bfbbaef65edcfeae21ad92d8b3d69fd5d11f8adf6
apps/sim/lib/guardrails/validate_regex.tshttps://github.com/simstudioai/sim/pull/3820/files#diff-be394194550043f5dd99c23e10a61489df7415d30b8e9a5560b494e29c7c8ec1
View file https://github.com/simstudioai/sim/blob/301f9be7ec0454bfafd4fa8b92596f351a9aea3f/apps/sim/lib/guardrails/validate_regex.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/3820/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/3820/files#diff-be394194550043f5dd99c23e10a61489df7415d30b8e9a5560b494e29c7c8ec1
Please reload this pagehttps://github.com/simstudioai/sim/pull/3820/files
https://github.com/simstudioai/sim/blob/staging/.github/CODEOWNERS#L36
apps/sim/package.jsonhttps://github.com/simstudioai/sim/pull/3820/files#diff-43a1bb37ce68ac536b0a4ed9e973d9d52da3975d74b37865f591bb37e191be64
View file https://github.com/simstudioai/sim/blob/301f9be7ec0454bfafd4fa8b92596f351a9aea3f/apps/sim/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/3820/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/3820/files#diff-43a1bb37ce68ac536b0a4ed9e973d9d52da3975d74b37865f591bb37e191be64
https://github.com/simstudioai/sim/pull/3820/files#diff-43a1bb37ce68ac536b0a4ed9e973d9d52da3975d74b37865f591bb37e191be64
https://github.com/simstudioai/sim/pull/3820/files#diff-43a1bb37ce68ac536b0a4ed9e973d9d52da3975d74b37865f591bb37e191be64
https://github.com/simstudioai/sim/pull/3820/files#diff-43a1bb37ce68ac536b0a4ed9e973d9d52da3975d74b37865f591bb37e191be64
https://github.com/simstudioai/sim/blob/staging/.github/CODEOWNERS#L38
bun.lockhttps://github.com/simstudioai/sim/pull/3820/files#diff-bfd0ef82a01108fa1e836c2500b98b7de8a92bb1ae352a8efcbd9d6ffcaabd60
View file https://github.com/simstudioai/sim/blob/301f9be7ec0454bfafd4fa8b92596f351a9aea3f/bun.lock
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/simstudioai/sim/pull/3820/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/3820/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.