René's URL Explorer Experiment


Title: fix(security): harden auth, SSRF, injection, and CORS across API routes by waleedlatif1 · Pull Request #3792 · simstudioai/sim · GitHub

Open Graph Title: fix(security): harden auth, SSRF, injection, and CORS across API routes by waleedlatif1 · Pull Request #3792 · simstudioai/sim

X Title: fix(security): harden auth, SSRF, injection, and CORS across API routes by waleedlatif1 · Pull Request #3792 · simstudioai/sim

Description: Sim is the collaborative workspace to build, deploy, and monitor AI agents and workflows. Used by 100,000+ builders. - fix(security): harden auth, SSRF, injection, and CORS across API routes by waleedlatif1 · Pull Request #3792 · simstudioai/sim

Open Graph Description: Summary File serve auth bypass: replaced user-controlled ?context query param with key-prefix check so attackers can't skip auth by appending ?context=profile-pictures to any file URL. Added o...

X Description: Summary File serve auth bypass: replaced user-controlled ?context query param with key-prefix check so attackers can't skip auth by appending ?context=profile-pictures to any file URL. Add...

Opengraph URL: https://github.com/simstudioai/sim/pull/3792

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:045734ea-46a8-dfd4-d874-8ab8d67c0b71
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE696:1BD5CA:E8EDAD:13F4CC0:6AFB5EB2
html-safe-nonce9a1a2d464c84dacb207bfd4a96c9b0143387f1eb845d5e73eec7218c1ac98d24
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjk2OjFCRDVDQTpFOEVEQUQ6MTNGNENDMDo2QUZCNUVCMiIsInZpc2l0b3JfaWQiOiIxNDE2MzAyNzM1MDgyMDg2MDY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdd6b9edc359f3a599da98c196a6b687fd77ed535e13e1ff8c4a746fbf4265ecd
hovercard-subject-tagpull_request:3453912121
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/3792/commits
twitter:imagehttps://opengraph.githubassets.com/4970effe1e8a5aab967ab9108eb823439e7f64fb4a53463259bda35ffd793b7b/simstudioai/sim/pull/3792
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4970effe1e8a5aab967ab9108eb823439e7f64fb4a53463259bda35ffd793b7b/simstudioai/sim/pull/3792
og:image:altSummary File serve auth bypass: replaced user-controlled ?context query param with key-prefix check so attackers can't skip auth by appending ?context=profile-pictures to any file URL. Added o...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewaleedlatif1
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-cache
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/3792/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F3792%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F3792%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/3792/commits
Reloadhttps://github.com/simstudioai/sim/pull/3792/commits
Reloadhttps://github.com/simstudioai/sim/pull/3792/commits
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
https://github.com/simstudioai/sim
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
waleedlatif1/review-race-conditionhttps://github.com/simstudioai/sim/tree/waleedlatif1/review-race-condition
Conversationhttps://github.com/simstudioai/sim/pull/3792
Commits25 (25)https://github.com/simstudioai/sim/pull/3792/commits
Checkshttps://github.com/simstudioai/sim/pull/3792/checks
Files changedhttps://github.com/simstudioai/sim/pull/3792/files
fix(security): harden auth, SSRF, injection, and CORS across API routeshttps://github.com/simstudioai/sim/pull/3792/commits#top
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
waleedlatif1/review-race-conditionhttps://github.com/simstudioai/sim/tree/waleedlatif1/review-race-condition
fix: prevent auth bypass via user-controlled context query param in file servehttps://github.com/simstudioai/sim/pull/3792/commits/6f43fc97025eb06bbcf9ac97cc251638ebcfb294
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
6f43fc9https://github.com/simstudioai/sim/pull/3792/commits/6f43fc97025eb06bbcf9ac97cc251638ebcfb294
https://github.com/simstudioai/sim/tree/6f43fc97025eb06bbcf9ac97cc251638ebcfb294
fix: use randomized heredoc delimiter in SSH execute-script routehttps://github.com/simstudioai/sim/pull/3792/commits/be41fbca4c604693222db9baf4f6525b8a081257
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
be41fbchttps://github.com/simstudioai/sim/pull/3792/commits/be41fbca4c604693222db9baf4f6525b8a081257
https://github.com/simstudioai/sim/tree/be41fbca4c604693222db9baf4f6525b8a081257
fix: escape workingDirectory in SSH execute-command routehttps://github.com/simstudioai/sim/pull/3792/commits/86d7a209ee69ff7e6ffb2bb5580256ab3aa576af
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
86d7a20https://github.com/simstudioai/sim/pull/3792/commits/86d7a209ee69ff7e6ffb2bb5580256ab3aa576af
https://github.com/simstudioai/sim/tree/86d7a209ee69ff7e6ffb2bb5580256ab3aa576af
fix: harden chat/form deployment auth (OTP brute-force, CSPRNG, HMAC tokens)https://github.com/simstudioai/sim/pull/3792/commits/331e9fcd57518c15a27dcb162faad23d07a541d0
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
331e9fchttps://github.com/simstudioai/sim/pull/3792/commits/331e9fcd57518c15a27dcb162faad23d07a541d0
https://github.com/simstudioai/sim/tree/331e9fcd57518c15a27dcb162faad23d07a541d0
fix: harden SSRF protections and input validation across API routeshttps://github.com/simstudioai/sim/pull/3792/commits/dac7dda6fb1817081f3280d1166ada1d1751bd2e
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
dac7ddahttps://github.com/simstudioai/sim/pull/3792/commits/dac7dda6fb1817081f3280d1166ada1d1751bd2e
https://github.com/simstudioai/sim/tree/dac7dda6fb1817081f3280d1166ada1d1751bd2e
linthttps://github.com/simstudioai/sim/pull/3792/commits/c5ecc190988c3ad52dcf57a069e7be219ca96933
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
c5ecc19https://github.com/simstudioai/sim/pull/3792/commits/c5ecc190988c3ad52dcf57a069e7be219ca96933
https://github.com/simstudioai/sim/tree/c5ecc190988c3ad52dcf57a069e7be219ca96933
fix(file-serve): remove user-controlled context param from authenticated pathhttps://github.com/simstudioai/sim/pull/3792/commits/35bc843cd49e5568f6c58750f818260f6591c68b
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
35bc843https://github.com/simstudioai/sim/pull/3792/commits/35bc843cd49e5568f6c58750f818260f6591c68b
https://github.com/simstudioai/sim/tree/35bc843cd49e5568f6c58750f818260f6591c68b
fix: handle legacy OTP format in decodeOTPValue for deploy-time compathttps://github.com/simstudioai/sim/pull/3792/commits/dea9fbe2c0035d242ee37070df4812453e19f0f7
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
dea9fbehttps://github.com/simstudioai/sim/pull/3792/commits/dea9fbe2c0035d242ee37070df4812453e19f0f7
https://github.com/simstudioai/sim/tree/dea9fbe2c0035d242ee37070df4812453e19f0f7
fix(mcp): distinguish DNS resolution failures from SSRF policy blockshttps://github.com/simstudioai/sim/pull/3792/commits/7e56894667cb446b55ef61e00859abc8084d4e04
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
7e56894https://github.com/simstudioai/sim/pull/3792/commits/7e56894667cb446b55ef61e00859abc8084d4e04
https://github.com/simstudioai/sim/tree/7e56894667cb446b55ef61e00859abc8084d4e04
fix: make OTP attempt counting atomic to prevent TOCTOU racehttps://github.com/simstudioai/sim/pull/3792/commits/16072b5663ab06e2cd41100dc389715ba1f84139
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
16072b5https://github.com/simstudioai/sim/pull/3792/commits/16072b5663ab06e2cd41100dc389715ba1f84139
https://github.com/simstudioai/sim/tree/16072b5663ab06e2cd41100dc389715ba1f84139
fix: check attempt count before OTP comparison to prevent bypasshttps://github.com/simstudioai/sim/pull/3792/commits/44b8aba182aa521afc80a1d2668edc9842fc4108
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
44b8abahttps://github.com/simstudioai/sim/pull/3792/commits/44b8aba182aa521afc80a1d2668edc9842fc4108
https://github.com/simstudioai/sim/tree/44b8aba182aa521afc80a1d2668edc9842fc4108
fix: validate OIDC discovered endpoints against SSRFhttps://github.com/simstudioai/sim/pull/3792/commits/bf819382da92069d971fdeaf21be983c2aaabe8f
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
bf81938https://github.com/simstudioai/sim/pull/3792/commits/bf819382da92069d971fdeaf21be983c2aaabe8f
https://github.com/simstudioai/sim/tree/bf819382da92069d971fdeaf21be983c2aaabe8f
fix: remove duplicate OIDC endpoint SSRF validation blockhttps://github.com/simstudioai/sim/pull/3792/commits/002748f91ee114afb5aca24834ff1d6ad2d23d82
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
002748fhttps://github.com/simstudioai/sim/pull/3792/commits/002748f91ee114afb5aca24834ff1d6ad2d23d82
https://github.com/simstudioai/sim/tree/002748f91ee114afb5aca24834ff1d6ad2d23d82
fix: validate OIDC discovered endpoints and pin DNS for 1Password Connecthttps://github.com/simstudioai/sim/pull/3792/commits/5493234fddca45920cdad39eebb7d68d2a5846bd
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
5493234https://github.com/simstudioai/sim/pull/3792/commits/5493234fddca45920cdad39eebb7d68d2a5846bd
https://github.com/simstudioai/sim/tree/5493234fddca45920cdad39eebb7d68d2a5846bd
linthttps://github.com/simstudioai/sim/pull/3792/commits/994e71144f405e39e105d716244dde2a857d8ad7
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
994e711https://github.com/simstudioai/sim/pull/3792/commits/994e71144f405e39e105d716244dde2a857d8ad7
https://github.com/simstudioai/sim/tree/994e71144f405e39e105d716244dde2a857d8ad7
fix: replace KEEPTTL with TTL+EX for Redis <6.0 compat, add DB retry loophttps://github.com/simstudioai/sim/pull/3792/commits/971888dd988e4f9a472337aabca07235212664bf
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
971888dhttps://github.com/simstudioai/sim/pull/3792/commits/971888dd988e4f9a472337aabca07235212664bf
https://github.com/simstudioai/sim/tree/971888dd988e4f9a472337aabca07235212664bf
fix: address review feedback on OTP atomicity and 1Password fetchhttps://github.com/simstudioai/sim/pull/3792/commits/2f85b310c36d36e40b5c9e56a708a8dce4ac5cde
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
2f85b31https://github.com/simstudioai/sim/pull/3792/commits/2f85b310c36d36e40b5c9e56a708a8dce4ac5cde
https://github.com/simstudioai/sim/tree/2f85b310c36d36e40b5c9e56a708a8dce4ac5cde
fix: treat Lua nil return as locked when OTP key is missinghttps://github.com/simstudioai/sim/pull/3792/commits/13132655c91494369b30740af3daea6fe42019d3
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
1313265https://github.com/simstudioai/sim/pull/3792/commits/13132655c91494369b30740af3daea6fe42019d3
https://github.com/simstudioai/sim/tree/13132655c91494369b30740af3daea6fe42019d3
fix: handle Lua nil as locked OTP and add SSRF check to MCP env resolutionhttps://github.com/simstudioai/sim/pull/3792/commits/f1fd878910e829988d901b47df3d1931de61ee85
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
f1fd878https://github.com/simstudioai/sim/pull/3792/commits/f1fd878910e829988d901b47df3d1931de61ee85
https://github.com/simstudioai/sim/tree/f1fd878910e829988d901b47df3d1931de61ee85
fix: narrow resolvedIP type guard instead of non-null assertionhttps://github.com/simstudioai/sim/pull/3792/commits/1cc6ed40367e2f55beaa73257a09c2a65a4b1b20
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
1cc6ed4https://github.com/simstudioai/sim/pull/3792/commits/1cc6ed40367e2f55beaa73257a09c2a65a4b1b20
https://github.com/simstudioai/sim/tree/1cc6ed40367e2f55beaa73257a09c2a65a4b1b20
fix: bind auth tokens to deployment password for immediate revocationhttps://github.com/simstudioai/sim/pull/3792/commits/3db061b92a75927a3ff2be527001c1a147e2fa4f
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
3db061bhttps://github.com/simstudioai/sim/pull/3792/commits/3db061b92a75927a3ff2be527001c1a147e2fa4f
https://github.com/simstudioai/sim/tree/3db061b92a75927a3ff2be527001c1a147e2fa4f
fix: bind auth tokens to deployment password and remove resolvedIP non-null assertionhttps://github.com/simstudioai/sim/pull/3792/commits/78c04542d149488b22bcd248e6857e874954e902
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
78c0454https://github.com/simstudioai/sim/pull/3792/commits/78c04542d149488b22bcd248e6857e874954e902
https://github.com/simstudioai/sim/tree/78c04542d149488b22bcd248e6857e874954e902
fix: update test assertions for new encryptedPassword parameterhttps://github.com/simstudioai/sim/pull/3792/commits/b7bc59159fb2f696b454519088df65d90d809600
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
b7bc591https://github.com/simstudioai/sim/pull/3792/commits/b7bc59159fb2f696b454519088df65d90d809600
https://github.com/simstudioai/sim/tree/b7bc59159fb2f696b454519088df65d90d809600
fix: format long lines in chat/form test assertionshttps://github.com/simstudioai/sim/pull/3792/commits/479085391f657b2b16e3470d168fa0288eee2aa6
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
4790853https://github.com/simstudioai/sim/pull/3792/commits/479085391f657b2b16e3470d168fa0288eee2aa6
https://github.com/simstudioai/sim/tree/479085391f657b2b16e3470d168fa0288eee2aa6
fix: pass encryptedPassword through OTP route cookie generationhttps://github.com/simstudioai/sim/pull/3792/commits/33e6576336a51662f3066749a6d84b98fd7acc17
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
claudehttps://github.com/simstudioai/sim/commits?author=claude
33e6576https://github.com/simstudioai/sim/pull/3792/commits/33e6576336a51662f3066749a6d84b98fd7acc17
https://github.com/simstudioai/sim/tree/33e6576336a51662f3066749a6d84b98fd7acc17
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.