René's URL Explorer Experiment


Title: fix(tool): Fix custom tools spreading out string output by TheodoreSpeaks · Pull Request #3676 · simstudioai/sim · GitHub

Open Graph Title: fix(tool): Fix custom tools spreading out string output by TheodoreSpeaks · Pull Request #3676 · simstudioai/sim

X Title: fix(tool): Fix custom tools spreading out string output by TheodoreSpeaks · Pull Request #3676 · simstudioai/sim

Description: Summary https://sim-ai.slack.com/archives/C09B82TTM7Y/p1773913304490249 We have a bug introduced with stripping double underscored fields. We incorrectly assumed these outputs would always be jsons, but custom tools can pass a string. This incorrectly spreads out the output into json character by character. Fix: Do a typecheck on outputs before stripping any tool output. Skip stripping hidden fields on custom tools. This logic should only apply to our own tool calls. Type of Change Bug fix New feature Breaking change Documentation Other: ___________ Testing Duplicated issue by creating custom tool that returns a string. Validated issue, then validated fix. Then validated that double underscore isn't stripped from custom tools. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) Screenshots/Videos

Open Graph Description: Summary https://sim-ai.slack.com/archives/C09B82TTM7Y/p1773913304490249 We have a bug introduced with stripping double underscored fields. We incorrectly assumed these outputs would always be jsons...

X Description: Summary https://sim-ai.slack.com/archives/C09B82TTM7Y/p1773913304490249 We have a bug introduced with stripping double underscored fields. We incorrectly assumed these outputs would always be jsons...

Opengraph URL: https://github.com/simstudioai/sim/pull/3676

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1b8849b6-2c19-a1e7-50d5-b4e2881ce776
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id80E4:BD772:9F7473:DA8DBB:6AFB4DB5
html-safe-noncec95b5e854a0d4aee9417397f17b79007c634fae36aec6e5538b81db9b8805b2e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MEU0OkJENzcyOjlGNzQ3MzpEQThEQkI6NkFGQjREQjUiLCJ2aXNpdG9yX2lkIjoiMTEyNTcxOTg1NTAxODQ5NTQxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7bd83ad9ce4fc1bbb956c267846ac66d1b3f1b8b07e6ba2492c4dd3d02b99fab
hovercard-subject-tagpull_request:3421418775
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/3676/files
twitter:imagehttps://avatars.githubusercontent.com/u/19564703?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/19564703?s=400&v=4
og:image:altSummary https://sim-ai.slack.com/archives/C09B82TTM7Y/p1773913304490249 We have a bug introduced with stripping double underscored fields. We incorrectly assumed these outputs would always be jsons...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/3676/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F3676%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F3676%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/3676/files
Reloadhttps://github.com/simstudioai/sim/pull/3676/files
Reloadhttps://github.com/simstudioai/sim/pull/3676/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
TheodoreSpeakshttps://github.com/TheodoreSpeaks
staginghttps://github.com/simstudioai/sim/tree/staging
fix/custom-tool-strip-logichttps://github.com/simstudioai/sim/tree/fix/custom-tool-strip-logic
Conversation 8 https://github.com/simstudioai/sim/pull/3676
Commits 3 https://github.com/simstudioai/sim/pull/3676/commits
Checks 11 https://github.com/simstudioai/sim/pull/3676/checks
Files changed https://github.com/simstudioai/sim/pull/3676/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/3676/files
fix(tool): Fix custom tools spreading out string output https://github.com/simstudioai/sim/pull/3676/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/3676/files
6328c99 fix(tool): Fix issue with custom tools spreading out string output Mar 19, 2026 https://github.com/simstudioai/sim/pull/3676/commits/6328c99f1da3ee8417f33b51dfe4d5585ac237e0
2741413 Fix lint Mar 19, 2026 https://github.com/simstudioai/sim/pull/3676/commits/27414134eed008fbd9160a563100d2bf6ef5d24b
eb8b17e Avoid any transformation on custom tool outputs Mar 19, 2026 https://github.com/simstudioai/sim/pull/3676/commits/eb8b17e0add7203ba80350b1b99e0edeeb98d626
Clear filters https://github.com/simstudioai/sim/pull/3676/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/3676/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/3676/files
output-filter.ts https://github.com/simstudioai/sim/pull/3676/files#diff-4300e9ea2a723abffe130d2ce6b9ac031f22ffa4ce69158fba6e22207e26272e
index.test.ts https://github.com/simstudioai/sim/pull/3676/files#diff-9ba0f7033f9247e496b4f9e0f46183a13c79b1bb48d721ba4bf042bdd08e4dd0
index.ts https://github.com/simstudioai/sim/pull/3676/files#diff-47ae0066fea628681d98d136239929a240a55aaf3d99ef293c83b3eca7e197c1
apps/sim/executor/utils/output-filter.tshttps://github.com/simstudioai/sim/pull/3676/files#diff-4300e9ea2a723abffe130d2ce6b9ac031f22ffa4ce69158fba6e22207e26272e
View file https://github.com/simstudioai/sim/blob/eb8b17e0add7203ba80350b1b99e0edeeb98d626/apps/sim/executor/utils/output-filter.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/3676/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/3676/files#diff-4300e9ea2a723abffe130d2ce6b9ac031f22ffa4ce69158fba6e22207e26272e
https://github.com/simstudioai/sim/pull/3676/files#diff-4300e9ea2a723abffe130d2ce6b9ac031f22ffa4ce69158fba6e22207e26272e
apps/sim/tools/index.test.tshttps://github.com/simstudioai/sim/pull/3676/files#diff-9ba0f7033f9247e496b4f9e0f46183a13c79b1bb48d721ba4bf042bdd08e4dd0
View file https://github.com/simstudioai/sim/blob/eb8b17e0add7203ba80350b1b99e0edeeb98d626/apps/sim/tools/index.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/3676/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/3676/files#diff-9ba0f7033f9247e496b4f9e0f46183a13c79b1bb48d721ba4bf042bdd08e4dd0
https://github.com/simstudioai/sim/pull/3676/files#diff-9ba0f7033f9247e496b4f9e0f46183a13c79b1bb48d721ba4bf042bdd08e4dd0
apps/sim/tools/index.tshttps://github.com/simstudioai/sim/pull/3676/files#diff-47ae0066fea628681d98d136239929a240a55aaf3d99ef293c83b3eca7e197c1
View file https://github.com/simstudioai/sim/blob/eb8b17e0add7203ba80350b1b99e0edeeb98d626/apps/sim/tools/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/3676/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/3676/files#diff-47ae0066fea628681d98d136239929a240a55aaf3d99ef293c83b3eca7e197c1
https://github.com/simstudioai/sim/pull/3676/files#diff-47ae0066fea628681d98d136239929a240a55aaf3d99ef293c83b3eca7e197c1
https://github.com/simstudioai/sim/pull/3676/files#diff-47ae0066fea628681d98d136239929a240a55aaf3d99ef293c83b3eca7e197c1
https://github.com/simstudioai/sim/pull/3676/files#diff-47ae0066fea628681d98d136239929a240a55aaf3d99ef293c83b3eca7e197c1
https://github.com/simstudioai/sim/pull/3676/files#diff-47ae0066fea628681d98d136239929a240a55aaf3d99ef293c83b3eca7e197c1
https://github.com/simstudioai/sim/pull/3676/files#diff-47ae0066fea628681d98d136239929a240a55aaf3d99ef293c83b3eca7e197c1
Please reload this pagehttps://github.com/simstudioai/sim/pull/3676/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.