René's URL Explorer Experiment


Title: fix: add retry logic for resume race condition with pause persistence by guoyangzhen · Pull Request #3577 · simstudioai/sim · GitHub

Open Graph Title: fix: add retry logic for resume race condition with pause persistence by guoyangzhen · Pull Request #3577 · simstudioai/sim

X Title: fix: add retry logic for resume race condition with pause persistence by guoyangzhen · Pull Request #3577 · simstudioai/sim

Description: Problem When a resume API request arrives within milliseconds of a workflow pausing, persistPauseResult's INSERT may not yet be committed, causing enqueueOrStartResume to throw Paused execution not found. Race window (~10-50ms): Workflow reaches pause point persistPauseResult calls db.insert(pausedExecutions) INSERT commits to DB Meanwhile, resume API hits and SELECT ... FOR UPDATE finds nothing Fix Retry logic (3 attempts, 200ms delay) in enqueueOrStartResume that catches Paused execution not found errors. Other errors (invalid pause point, already resumed, snapshot not ready) are NOT retried. Retry is in the manager layer, not the API route, so all callers benefit. Why not just wrap in a transaction? Wrapping persistPauseResult in a transaction doesn't help — the race is between the method being called and its await db.insert() returning. PostgreSQL autocommit means INSERT is atomic and visible immediately after await returns. The retry handles the narrow window before persistPauseResult even starts. Fixes #3081

Open Graph Description: Problem When a resume API request arrives within milliseconds of a workflow pausing, persistPauseResult's INSERT may not yet be committed, causing enqueueOrStartResume to throw Paused execution...

X Description: Problem When a resume API request arrives within milliseconds of a workflow pausing, persistPauseResult's INSERT may not yet be committed, causing enqueueOrStartResume to throw Paused execu...

Opengraph URL: https://github.com/simstudioai/sim/pull/3577

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e9951b12-0cfc-ccf9-453c-484eafeb4119
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF8A:EA1A8:15E446B:1DE7D26:6AFB7E2A
html-safe-nonceb3e4ac2ff513f139dccb4f23d0d984d34ff25f9a7c2713e258df1d81e272477f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjhBOkVBMUE4OjE1RTQ0NkI6MURFN0QyNjo2QUZCN0UyQSIsInZpc2l0b3JfaWQiOiI2NTg4NzM4MzkwODkwMDg1OTMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac516116af62c5544bff6daef2acc0a8dddd4dce184a8d474c96c2cda54aecdfff
hovercard-subject-tagpull_request:3398971623
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/3577/files
twitter:imagehttps://avatars.githubusercontent.com/u/48578722?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/48578722?s=400&v=4
og:image:altProblem When a resume API request arrives within milliseconds of a workflow pausing, persistPauseResult's INSERT may not yet be committed, causing enqueueOrStartResume to throw Paused execution...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneef32892d4269fb87b55e81cc4ba8d86e0f16aa28446ffbf46cba8be5179ab188
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebc3703b4dcbe820d1284ef63c88b001c850be25e
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/3577/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F3577%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F3577%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/3577/files
Reloadhttps://github.com/simstudioai/sim/pull/3577/files
Reloadhttps://github.com/simstudioai/sim/pull/3577/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests201 (201)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
guoyangzhenhttps://github.com/guoyangzhen
simstudioai:mainhttps://github.com/simstudioai/sim/tree/main
guoyangzhen:fix/resume-race-conditionhttps://github.com/guoyangzhen/sim/tree/fix/resume-race-condition
Conversation 5 https://github.com/simstudioai/sim/pull/3577
Commits 2 https://github.com/simstudioai/sim/pull/3577/commits
Checks 3 https://github.com/simstudioai/sim/pull/3577/checks
Files changed https://github.com/simstudioai/sim/pull/3577/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/3577/files
fix: add retry logic for resume race condition with pause persistence https://github.com/simstudioai/sim/pull/3577/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/3577/files
278daf6 fix: add retry for resume race condition (#3081) guoyangzhen Mar 14, 2026 https://github.com/simstudioai/sim/pull/3577/commits/278daf650f980375350858eedcbfd8d309c0ecaa
d16d7bd fix: correct off-by-one in retry attempts (addressing review feedback) guoyangzhen Mar 14, 2026 https://github.com/simstudioai/sim/pull/3577/commits/d16d7bdad53deb0858b476ad2c59e7da8e09e9e8
Clear filters https://github.com/simstudioai/sim/pull/3577/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/3577/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/3577/files
apps/sim/lib/workflows/executor/human-in-the-loop-manager.tshttps://github.com/simstudioai/sim/pull/3577/files#diff-bb1129b15dc9783d16371ddc2f8992d36e41c60787a458e77e1c59a7e721d292
View file https://github.com/simstudioai/sim/blob/d16d7bdad53deb0858b476ad2c59e7da8e09e9e8/apps/sim/lib/workflows/executor/human-in-the-loop-manager.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/3577/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/3577/files#diff-bb1129b15dc9783d16371ddc2f8992d36e41c60787a458e77e1c59a7e721d292
https://github.com/simstudioai/sim/pull/3577/files#diff-bb1129b15dc9783d16371ddc2f8992d36e41c60787a458e77e1c59a7e721d292
https://github.com/simstudioai/sim/pull/3577/files#diff-bb1129b15dc9783d16371ddc2f8992d36e41c60787a458e77e1c59a7e721d292
greptile-appshttps://github.com/apps/greptile-apps
Mar 14, 2026https://github.com/simstudioai/sim/pull/3577/files#r2935185566
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/simstudioai/sim/pull/3577/files
https://github.com/simstudioai/sim/pull/3577/files#diff-bb1129b15dc9783d16371ddc2f8992d36e41c60787a458e77e1c59a7e721d292
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.