René's URL Explorer Experiment


Title: fix(execution): report cancellation durability truthfully by PlaneInABottle · Pull Request #3550 · simstudioai/sim · GitHub

Open Graph Title: fix(execution): report cancellation durability truthfully by PlaneInABottle · Pull Request #3550 · simstudioai/sim

X Title: fix(execution): report cancellation durability truthfully by PlaneInABottle · Pull Request #3550 · simstudioai/sim

Description: Summary make the cancel-execution response reflect whether the Redis-backed cancellation marker was durably recorded return durability metadata (durablyRecorded, reason) and avoid misleading success logging when persistence fails fix the targeted cancellation tests by hoisting Vitest mocks in cancellation.test.ts Problem / current behavior the cancel-execution API previously implied success after attempting cancellation even when the Redis-backed marker was not durably recorded when Redis was unavailable or the write failed, callers and operators could read the response/logging as a successful cancellation even though no durable cancellation marker existed the targeted cancellation tests also needed a follow-up fix so the mocked module state was initialized correctly under Vitest Proposed fix / behavior after update the cancellation helper to return structured durability results instead of a bare boolean make the cancel route set success based on whether the cancellation marker was durably recorded, and include durablyRecorded plus a failure reason in the response downgrade the non-durable path from misleading success reporting to warning-level reporting hoist the Vitest mocks in apps/sim/lib/execution/cancellation.test.ts so the targeted tests reliably validate the success and failure outcomes Why this matters prevents false-positive cancellation reporting makes Redis availability/write failures visible and actionable to API consumers and operators preserves regression coverage for the durability contract this branch introduces Files changed apps/sim/app/api/workflows/[id]/executions/[executionId]/cancel/route.ts apps/sim/app/api/workflows/[id]/executions/[executionId]/cancel/route.test.ts apps/sim/lib/execution/cancellation.ts apps/sim/lib/execution/cancellation.test.ts Tests run cd /Users/Y_ALTAY1/Documents/simWoot/sim/apps/sim && bun run test -- lib/execution/cancellation.test.ts 'app/api/workflows/[id]/executions/[executionId]/cancel/route.test.ts' Notes / non-goals / follow-ups this PR is intentionally scoped to truthful cancellation durability reporting plus the follow-up test-only fix it does not redesign broader cancellation orchestration, retries, or worker-side handling beyond surfacing whether the Redis-backed marker was durably written the second commit on this branch is test-only and limited to hoisting Vitest mocks in cancellation.test.ts

Open Graph Description: Summary make the cancel-execution response reflect whether the Redis-backed cancellation marker was durably recorded return durability metadata (durablyRecorded, reason) and avoid misleading succe...

X Description: Summary make the cancel-execution response reflect whether the Redis-backed cancellation marker was durably recorded return durability metadata (durablyRecorded, reason) and avoid misleading succe...

Opengraph URL: https://github.com/simstudioai/sim/pull/3550

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f83d7292-8398-5fc3-aee5-1bd5fc2d5632
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC9D4:23725B:CDFE80:11AD5D4:6AFB567D
html-safe-nonceb99702ab4819f7c3c10482fb63ac56b77945acf4bef9bf05de723fb3b3a7af6c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUQ0OjIzNzI1QjpDREZFODA6MTFBRDVENDo2QUZCNTY3RCIsInZpc2l0b3JfaWQiOiI2ODQ4ODMyOTkwMzM2NDcyNzAxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca216116d83f2b67fda1f8f2c03e9ccfeb9d0f2b5569b78697f9497ca72f081a2
hovercard-subject-tagpull_request:3392298339
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/3550/files
twitter:imagehttps://avatars.githubusercontent.com/u/187994327?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/187994327?s=400&v=4
og:image:altSummary make the cancel-execution response reflect whether the Redis-backed cancellation marker was durably recorded return durability metadata (durablyRecorded, reason) and avoid misleading succe...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/3550/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F3550%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F3550%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/3550/files
Reloadhttps://github.com/simstudioai/sim/pull/3550/files
Reloadhttps://github.com/simstudioai/sim/pull/3550/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
icecrasher321https://github.com/icecrasher321
simstudioai:staginghttps://github.com/simstudioai/sim/tree/staging
PlaneInABottle:fix/cancel-durabilityhttps://github.com/PlaneInABottle/sim/tree/fix/cancel-durability
Conversation 16 https://github.com/simstudioai/sim/pull/3550
Commits 5 https://github.com/simstudioai/sim/pull/3550/commits
Checks 11 https://github.com/simstudioai/sim/pull/3550/checks
Files changed https://github.com/simstudioai/sim/pull/3550/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/3550/files
fix(execution): report cancellation durability truthfully https://github.com/simstudioai/sim/pull/3550/files#top
Show all changes 5 commits https://github.com/simstudioai/sim/pull/3550/files
e4881f6 fix(cancel): report cancellation durability truthfully PlaneInABottle Mar 12, 2026 https://github.com/simstudioai/sim/pull/3550/commits/e4881f63560aa452ac0f549fcb0a5031fc15561f
2865ab3 fix: hoist cancellation test mocks PlaneInABottle Mar 12, 2026 https://github.com/simstudioai/sim/pull/3550/commits/2865ab3fb0f0cb8a0aa1e80f4e47de98c83164ae
a99aba2 fix(sim): harden execution cancel durability PlaneInABottle Mar 12, 2026 https://github.com/simstudioai/sim/pull/3550/commits/a99aba21a9a6f475d9c52baf2962c5fa72bdbd5a
d6222b3 fix(sim): fallback manual cancel without redis Mar 13, 2026 https://github.com/simstudioai/sim/pull/3550/commits/d6222b3890be9ba5ef0db7e5e31c462cb71141b7
7aed473 test: mock AuthType in async execute route Mar 13, 2026 https://github.com/simstudioai/sim/pull/3550/commits/7aed473e167d2eb3952a9a22265c215d35238db1
Clear filters https://github.com/simstudioai/sim/pull/3550/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/3550/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/3550/files
route.async.test.ts https://github.com/simstudioai/sim/pull/3550/files#diff-4fdd9c4e95852b855ff84d9c22a98a20cd5d8bcba347038993756118cd80e9f5
route.ts https://github.com/simstudioai/sim/pull/3550/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
route.test.ts https://github.com/simstudioai/sim/pull/3550/files#diff-13ee98aff8faa23229b43caf956471767ba043eb58fe9dd3dae7f24b40d19886
route.ts https://github.com/simstudioai/sim/pull/3550/files#diff-6276e3e602de8f65c65d92c4b1d7319a3385ffc7bd214947a94b39a60a0a40bd
cancellation.test.ts https://github.com/simstudioai/sim/pull/3550/files#diff-925b2906fb0e82adea49152069c331d982adcb56fd5f5f05a56dee5fb91648cb
cancellation.ts https://github.com/simstudioai/sim/pull/3550/files#diff-9ecf6712715bd985d8bab22d6b5bb4bf8530163f11e12a2f240a32916a19ff63
manual-cancellation.ts https://github.com/simstudioai/sim/pull/3550/files#diff-55ecbb9c2e91643388ab7781254b9136f27ccdf4b3e21f0ffc3633921300ee69
apps/sim/app/api/workflows/[id]/execute/route.async.test.tshttps://github.com/simstudioai/sim/pull/3550/files#diff-4fdd9c4e95852b855ff84d9c22a98a20cd5d8bcba347038993756118cd80e9f5
View file https://github.com/PlaneInABottle/sim/blob/7aed473e167d2eb3952a9a22265c215d35238db1/apps/sim/app/api/workflows/%5Bid%5D/execute/route.async.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/3550/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/3550/files#diff-4fdd9c4e95852b855ff84d9c22a98a20cd5d8bcba347038993756118cd80e9f5
https://github.com/simstudioai/sim/pull/3550/files#diff-4fdd9c4e95852b855ff84d9c22a98a20cd5d8bcba347038993756118cd80e9f5
apps/sim/app/api/workflows/[id]/execute/route.tshttps://github.com/simstudioai/sim/pull/3550/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
View file https://github.com/PlaneInABottle/sim/blob/7aed473e167d2eb3952a9a22265c215d35238db1/apps/sim/app/api/workflows/%5Bid%5D/execute/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/3550/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/3550/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/3550/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/3550/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/3550/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/3550/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/3550/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
https://github.com/simstudioai/sim/pull/3550/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
apps/sim/app/api/workflows/[id]/executions/[executionId]/cancel/route.test.tshttps://github.com/simstudioai/sim/pull/3550/files#diff-13ee98aff8faa23229b43caf956471767ba043eb58fe9dd3dae7f24b40d19886
View file https://github.com/PlaneInABottle/sim/blob/7aed473e167d2eb3952a9a22265c215d35238db1/apps/sim/app/api/workflows/%5Bid%5D/executions/%5BexecutionId%5D/cancel/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/3550/{{ revealButtonHref }}
apps/sim/app/api/workflows/[id]/executions/[executionId]/cancel/route.tshttps://github.com/simstudioai/sim/pull/3550/files#diff-6276e3e602de8f65c65d92c4b1d7319a3385ffc7bd214947a94b39a60a0a40bd
View file https://github.com/PlaneInABottle/sim/blob/7aed473e167d2eb3952a9a22265c215d35238db1/apps/sim/app/api/workflows/%5Bid%5D/executions/%5BexecutionId%5D/cancel/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/3550/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/3550/files#diff-6276e3e602de8f65c65d92c4b1d7319a3385ffc7bd214947a94b39a60a0a40bd
https://github.com/simstudioai/sim/pull/3550/files#diff-6276e3e602de8f65c65d92c4b1d7319a3385ffc7bd214947a94b39a60a0a40bd
https://github.com/simstudioai/sim/pull/3550/files#diff-6276e3e602de8f65c65d92c4b1d7319a3385ffc7bd214947a94b39a60a0a40bd
https://github.com/simstudioai/sim/pull/3550/files#diff-6276e3e602de8f65c65d92c4b1d7319a3385ffc7bd214947a94b39a60a0a40bd
apps/sim/lib/execution/cancellation.test.tshttps://github.com/simstudioai/sim/pull/3550/files#diff-925b2906fb0e82adea49152069c331d982adcb56fd5f5f05a56dee5fb91648cb
View file https://github.com/PlaneInABottle/sim/blob/7aed473e167d2eb3952a9a22265c215d35238db1/apps/sim/lib/execution/cancellation.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/3550/{{ revealButtonHref }}
apps/sim/lib/execution/cancellation.tshttps://github.com/simstudioai/sim/pull/3550/files#diff-9ecf6712715bd985d8bab22d6b5bb4bf8530163f11e12a2f240a32916a19ff63
View file https://github.com/PlaneInABottle/sim/blob/7aed473e167d2eb3952a9a22265c215d35238db1/apps/sim/lib/execution/cancellation.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/3550/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/3550/files#diff-9ecf6712715bd985d8bab22d6b5bb4bf8530163f11e12a2f240a32916a19ff63
https://github.com/simstudioai/sim/pull/3550/files#diff-9ecf6712715bd985d8bab22d6b5bb4bf8530163f11e12a2f240a32916a19ff63
apps/sim/lib/execution/manual-cancellation.tshttps://github.com/simstudioai/sim/pull/3550/files#diff-55ecbb9c2e91643388ab7781254b9136f27ccdf4b3e21f0ffc3633921300ee69
View file https://github.com/PlaneInABottle/sim/blob/7aed473e167d2eb3952a9a22265c215d35238db1/apps/sim/lib/execution/manual-cancellation.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/3550/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/3550/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.