René's URL Explorer Experiment


Title: fix(redis): cleanup access pattern across callsites by icecrasher321 · Pull Request #2289 · simstudioai/sim · GitHub

Open Graph Title: fix(redis): cleanup access pattern across callsites by icecrasher321 · Pull Request #2289 · simstudioai/sim

X Title: fix(redis): cleanup access pattern across callsites by icecrasher321 · Pull Request #2289 · simstudioai/sim

Description: Summary Cleanup access pattern across codebase for redis client. Should not fallback to db for transient failures -- creates non-deterministic edge cases that are hard to reason about. Acquire/Release Lock -- process B should not accidentally delete lock owned by process A. requestId as identifier was in place but not used. Remove dead code. Type of Change Bug fix Other: Reliability Testing Tested with @waleedlatif1 Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Cleanup access pattern across codebase for redis client. Should not fallback to db for transient failures -- creates non-deterministic edge cases that are hard to reason about. Acquire/Rel...

X Description: Summary Cleanup access pattern across codebase for redis client. Should not fallback to db for transient failures -- creates non-deterministic edge cases that are hard to reason about. Acquire/Rel...

Opengraph URL: https://github.com/simstudioai/sim/pull/2289

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2e50fe27-650b-9738-fbdc-1046cced41e9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD050:295356:236E15:31CB02:6AFB5144
html-safe-noncebfa33edce93f276f4e3f14730cc5bb2b44e4118f475e09dbf087abb1719fd15b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDUwOjI5NTM1NjoyMzZFMTU6MzFDQjAyOjZBRkI1MTQ0IiwidmlzaXRvcl9pZCI6IjE4OTU4NjgzNTk0Njc4MTUyMzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac614c0d8691fce59ca3ea9ea422fe59d7a91a1cffd8447e0174fc60bf30c53cd9
hovercard-subject-tagpull_request:3090526583
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/2289/files
twitter:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
og:image:altSummary Cleanup access pattern across codebase for redis client. Should not fallback to db for transient failures -- creates non-deterministic edge cases that are hard to reason about. Acquire/Rel...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/2289/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F2289%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F2289%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/2289/files
Reloadhttps://github.com/simstudioai/sim/pull/2289/files
Reloadhttps://github.com/simstudioai/sim/pull/2289/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/cleanup-redis-access-patternhttps://github.com/simstudioai/sim/tree/fix/cleanup-redis-access-pattern
Conversation 9 https://github.com/simstudioai/sim/pull/2289
Commits 2 https://github.com/simstudioai/sim/pull/2289/commits
Checks 8 https://github.com/simstudioai/sim/pull/2289/checks
Files changed https://github.com/simstudioai/sim/pull/2289/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/2289/files
fix(redis): cleanup access pattern across callsites https://github.com/simstudioai/sim/pull/2289/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/2289/files
06d2c74 fix(redis): cleanup access pattern across callsites Dec 10, 2025 https://github.com/simstudioai/sim/pull/2289/commits/06d2c74cd46e6040f23f75db37592ba878215aee
0749fc7 swap redis command to be non blocking Dec 10, 2025 https://github.com/simstudioai/sim/pull/2289/commits/0749fc7a1dd7cd9ca69b0ad07c592b060abe7a59
Clear filters https://github.com/simstudioai/sim/pull/2289/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/2289/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/2289/files
route.ts https://github.com/simstudioai/sim/pull/2289/files#diff-a13d9967f4a5ea9e418cd26f50714ea88964dd7a294e6781327e9a57fc4a5c36
route.ts https://github.com/simstudioai/sim/pull/2289/files#diff-4a82d62b62c2ffa2cc56d928e5d4d40a962b0cecabddfe8efa86e6cbacf5d584
route.ts https://github.com/simstudioai/sim/pull/2289/files#diff-7ee6d4fc1d8a175caf37bc8d856186659efdafdb0df3ad5aee66a94c5044f554
route.ts https://github.com/simstudioai/sim/pull/2289/files#diff-e9849a2d796a3100621b0dd1ebebf25cecd3f78cd59db06209bbf437686443c4
route.ts https://github.com/simstudioai/sim/pull/2289/files#diff-78021f2e32e11fea2f4793e3d6cf76a236397f61ccbe1ba407043ba7c41c7a7a
redis.ts https://github.com/simstudioai/sim/pull/2289/files#diff-af191f255d57cc29ed5bf97c929967b6b922d94d754a7d73abcbf88594b4dc7d
service.ts https://github.com/simstudioai/sim/pull/2289/files#diff-6622bed9a9e8ea71519df9b69f50201260f8b7aa4742fe7973f87212b37dc024
factory.ts https://github.com/simstudioai/sim/pull/2289/files#diff-2c61f378b3d959c44323b4fbc0b2b5b6f6fab3afac6a04611c67cbce2948771d
index.ts https://github.com/simstudioai/sim/pull/2289/files#diff-1db6ceb24db6064f3d5427570300784702a6b5a73ba8dc5b42c7c1b8463881f7
index.ts https://github.com/simstudioai/sim/pull/2289/files#diff-04506bf0b7beefc6f9264a8931d33106864bdd23fce9ffdd9b9bd6e5e8acc3a9
storage.ts https://github.com/simstudioai/sim/pull/2289/files#diff-897a7dddff4f39d4bbef585a9d6406c0119d78088724267954c6893fb725fef4
queue.ts https://github.com/simstudioai/sim/pull/2289/files#diff-480e8c8c3fdb8cff1a2735480fc8c6a7c2f606d7cfd8cdd5b071c3e324f1cabd
service.ts https://github.com/simstudioai/sim/pull/2289/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
bun.lock https://github.com/simstudioai/sim/pull/2289/files#diff-bfd0ef82a01108fa1e836c2500b98b7de8a92bb1ae352a8efcbd9d6ffcaabd60
apps/sim/app/api/chat/[identifier]/otp/route.tshttps://github.com/simstudioai/sim/pull/2289/files#diff-a13d9967f4a5ea9e418cd26f50714ea88964dd7a294e6781327e9a57fc4a5c36
View file https://github.com/simstudioai/sim/blob/0749fc7a1dd7cd9ca69b0ad07c592b060abe7a59/apps/sim/app/api/chat/%5Bidentifier%5D/otp/route.ts
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/simstudioai/sim/pull/2289/files
apps/sim/app/api/notifications/poll/route.tshttps://github.com/simstudioai/sim/pull/2289/files#diff-4a82d62b62c2ffa2cc56d928e5d4d40a962b0cecabddfe8efa86e6cbacf5d584
View file https://github.com/simstudioai/sim/blob/0749fc7a1dd7cd9ca69b0ad07c592b060abe7a59/apps/sim/app/api/notifications/poll/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/2289/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/2289/files#diff-4a82d62b62c2ffa2cc56d928e5d4d40a962b0cecabddfe8efa86e6cbacf5d584
https://github.com/simstudioai/sim/pull/2289/files#diff-4a82d62b62c2ffa2cc56d928e5d4d40a962b0cecabddfe8efa86e6cbacf5d584
https://github.com/simstudioai/sim/pull/2289/files#diff-4a82d62b62c2ffa2cc56d928e5d4d40a962b0cecabddfe8efa86e6cbacf5d584
apps/sim/app/api/webhooks/poll/gmail/route.tshttps://github.com/simstudioai/sim/pull/2289/files#diff-7ee6d4fc1d8a175caf37bc8d856186659efdafdb0df3ad5aee66a94c5044f554
View file https://github.com/simstudioai/sim/blob/0749fc7a1dd7cd9ca69b0ad07c592b060abe7a59/apps/sim/app/api/webhooks/poll/gmail/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/2289/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/2289/files#diff-7ee6d4fc1d8a175caf37bc8d856186659efdafdb0df3ad5aee66a94c5044f554
apps/sim/app/api/webhooks/poll/outlook/route.tshttps://github.com/simstudioai/sim/pull/2289/files#diff-e9849a2d796a3100621b0dd1ebebf25cecd3f78cd59db06209bbf437686443c4
View file https://github.com/simstudioai/sim/blob/0749fc7a1dd7cd9ca69b0ad07c592b060abe7a59/apps/sim/app/api/webhooks/poll/outlook/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/2289/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/2289/files#diff-e9849a2d796a3100621b0dd1ebebf25cecd3f78cd59db06209bbf437686443c4
apps/sim/app/api/webhooks/poll/rss/route.tshttps://github.com/simstudioai/sim/pull/2289/files#diff-78021f2e32e11fea2f4793e3d6cf76a236397f61ccbe1ba407043ba7c41c7a7a
View file https://github.com/simstudioai/sim/blob/0749fc7a1dd7cd9ca69b0ad07c592b060abe7a59/apps/sim/app/api/webhooks/poll/rss/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/2289/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/2289/files#diff-78021f2e32e11fea2f4793e3d6cf76a236397f61ccbe1ba407043ba7c41c7a7a
Please reload this pagehttps://github.com/simstudioai/sim/pull/2289/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.