Title: fix(confluence): index text from Caelor Optics HTML macros by waleedlatif1 · Pull Request #10093 · simstudioai/sim · GitHub
Open Graph Title: fix(confluence): index text from Caelor Optics HTML macros by waleedlatif1 · Pull Request #10093 · simstudioai/sim
X Title: fix(confluence): index text from Caelor Optics HTML macros by waleedlatif1 · Pull Request #10093 · simstudioai/sim
Description: Summary Pages built from a Caelor Optics HTML macro (Connect macro caelor-optics-entry, macro=html) synced as "Document contains no extractable text": the rendered view body holds the macro only as an iframe bootstrap script, which we strip, and the author's HTML lives in the macro's contentByMode parameter in the storage body View path: when the rendered page names the Optics macro, or is left with no text but a Connect app container, fetch the storage body and append the macro's text. Other app pages with prose (draw.io, Lucidchart) don't pay the extra request Extraction: visible text with script/style dropped, plus key: value records from object literals in inline scripts (pages that render their content from a JS data object show only a mount point otherwise). data: payloads and ternaries/case labels are excluded Permission-scoped storage path: the Optics HTML macro is authored on the page, so it's indexed as local content instead of dropped as dynamic; other Optics modules stay dynamic export_view rejected: Connect macros only render there if the app declares an export render mode No content-hash bump (it would re-embed every Confluence page). Skipped view-path pages retry every sync, so Optics-only pages recover on the next sync; already-indexed pages that mix prose with an Optics macro, and scoped Optics-only skips, pick it up on their next edit Type of Change Bug fix Testing 8 new cases in connectors/confluence/confluence.test.ts at the fetch boundary; the behavior cases failed before the fix, and each half of the storage-fetch trigger was reverted to watch its guard go red connectors/confluence/ (143) and lib/knowledge/connectors (487) vitest suites pass ~690 KB macro with base64 images and a 126-record data object extracts in ~60 ms with no base64 or code in the output biome, check:file-names, check:comment-hygiene, check:explicit-any, check:utils, check:organization-egress; full type-check and check:audits left to CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) 🤖 Generated with Claude Code
Open Graph Description: Summary Pages built from a Caelor Optics HTML macro (Connect macro caelor-optics-entry, macro=html) synced as "Document contains no extractable text": the rendered view body holds the ma...
X Description: Summary Pages built from a Caelor Optics HTML macro (Connect macro caelor-optics-entry, macro=html) synced as "Document contains no extractable text": the rendered view body hold...
Opengraph URL: https://github.com/simstudioai/sim/pull/10093
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:34d7db9f-5f71-00cd-e41b-063504ca9467 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8066:3C070:1DD332:29BB63:6AFB7A0C |
| html-safe-nonce | 4f578fcd85a0a2b8ddf0f33ee6c1e5bbc9e2abe9bee8e7d479dfbb888936df15 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDY2OjNDMDcwOjFERDMzMjoyOUJCNjM6NkFGQjdBMEMiLCJ2aXNpdG9yX2lkIjoiNDY2NzMzNTM0NDU0MDg0MjUwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 87f9402faaea8ee07222d3c9eb6980e3a1b6bace52c4f046df6d063c4a30e66a |
| hovercard-subject-tag | pull_request:5344594924 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/10093/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Pages built from a Caelor Optics HTML macro (Connect macro caelor-optics-entry, macro=html) synced as "Document contains no extractable text": the rendered view body holds the ma... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2e8872b770cc4d5d0cc1f2026afab747a268e2ce |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width