René's URL Explorer Experiment


Title: fix(search): follow Slack's file download redirects without carrying the token off its file host by waleedlatif1 · Pull Request #10084 · simstudioai/sim · GitHub

Open Graph Title: fix(search): follow Slack's file download redirects without carrying the token off its file host by waleedlatif1 · Pull Request #10084 · simstudioai/sim

X Title: fix(search): follow Slack's file download redirects without carrying the token off its file host by waleedlatif1 · Pull Request #10084 · simstudioai/sim

Description: Summary Follow-up to #10082: a live test against a real workspace read canvases, text files and DOCX in full, but a PDF still fell back to the preview. Its download failed before any response with an unclassified error, which on this path means a redirect rejected by maxRedirects: 0 Slack's file host now follows up to 3 redirects, only within files.slack.com (same origin, so an http: downgrade or lookalike host is refused too) via secure fetch's existing assertRedirectTarget hook. Every other native request, including Sheets, still follows none A hop to any other host is refused, not followed without credentials: Slack bounces a token it will not serve to the workspace sign-in page, and following that would read the sign-in page as the file. The refusal is a NativeSearchError, so the read keeps the preview and names the host it was sent to Matches Slack's guidance (handle redirects deliberately, require an exact Slack file host) and Sim's other Slack url_private downloaders, which already follow redirects Type of Change Bug fix Testing http.test.ts: the file-host redirect guard (the real closure passed to secure fetch) accepts a same-host hop and refuses the sign-in page, a lookalike host and an http: downgrade; Sheets keeps zero redirects and no guard. Comparing hostname instead of origin, dropping the guard, or letting Sheets follow redirects each turn a test red Redirect following itself is proven at the real HTTP boundary in pinned-redirect-replay.server.test.ts lib/sim-search/live + lib/knowledge/search suites pass; biome; egress-boundary, organization-egress, boundaries, comment-hygiene, test-patterns audits pass Will re-run the live PDF read on staging after merge Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-up to #10082: a live test against a real workspace read canvases, text files and DOCX in full, but a PDF still fell back to the preview. Its download failed before any response with...

X Description: Summary Follow-up to #10082: a live test against a real workspace read canvases, text files and DOCX in full, but a PDF still fell back to the preview. Its download failed before any response with...

Opengraph URL: https://github.com/simstudioai/sim/pull/10084

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:62102d03-7903-1f5f-6932-80e7900c1a98
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD696:3BD2EB:ADAAE5:F4BB92:6AFB79C5
html-safe-noncee21efa914f455077d0aab9ff12379865f0a4ddb6281cdc44fe3aaf295b3d361c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjk2OjNCRDJFQjpBREFBRTU6RjRCQjkyOjZBRkI3OUM1IiwidmlzaXRvcl9pZCI6IjIwNjAxMTEwNjAzNDY3ODIxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacebe5a6e65bf68f7495ab9ad7157465fbb7bed9f96f3d9e5b5072d3aabbdca029
hovercard-subject-tagpull_request:5332349231
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/10084/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up to #10082: a live test against a real workspace read canvases, text files and DOCX in full, but a PDF still fell back to the preview. Its download failed before any response with...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/10084/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10084%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10084%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/10084/files
Reloadhttps://github.com/simstudioai/sim/pull/10084/files
Reloadhttps://github.com/simstudioai/sim/pull/10084/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests202 (202)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/slack-file-redirectshttps://github.com/simstudioai/sim/tree/fix/slack-file-redirects
Conversation 8 https://github.com/simstudioai/sim/pull/10084
Commits 2 https://github.com/simstudioai/sim/pull/10084/commits
Checks 82 https://github.com/simstudioai/sim/pull/10084/checks
Files changed https://github.com/simstudioai/sim/pull/10084/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10084/files
fix(search): follow Slack's file download redirects without carrying the token off its file host https://github.com/simstudioai/sim/pull/10084/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/10084/files
b411707 fix(search): follow Slack's file download redirects without carrying … waleedlatif1 Nov 16, 2026 https://github.com/simstudioai/sim/pull/10084/commits/b4117072bd713c04373c0c21d12679645f3fd7ed
bf93223 fix(search): follow Slack file redirects only within the file host waleedlatif1 Nov 16, 2026 https://github.com/simstudioai/sim/pull/10084/commits/bf93223ee73b86319a631f80222a8a2958e2a833
Clear filters https://github.com/simstudioai/sim/pull/10084/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10084/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10084/files
README.md https://github.com/simstudioai/sim/pull/10084/files#diff-19572bf4479f2bc12cbad3de0512e7d2df1562e071af8aa5229541589fb25cc9
http.test.ts https://github.com/simstudioai/sim/pull/10084/files#diff-d28b55c3fe2736c2de5e2cd5b01dc7ecc3a2cc730b757f59e8d0b63a47568395
http.ts https://github.com/simstudioai/sim/pull/10084/files#diff-db05fa39c3e2fd0f48efd209b627af77b955e94f9ee317f45173cbfe5d3211ec
apps/sim/lib/sim-search/live/README.mdhttps://github.com/simstudioai/sim/pull/10084/files#diff-19572bf4479f2bc12cbad3de0512e7d2df1562e071af8aa5229541589fb25cc9
View file https://github.com/simstudioai/sim/blob/bf93223ee73b86319a631f80222a8a2958e2a833/apps/sim/lib/sim-search/live/README.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10084/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10084/files#diff-19572bf4479f2bc12cbad3de0512e7d2df1562e071af8aa5229541589fb25cc9
https://github.com/simstudioai/sim/pull/10084/files#diff-19572bf4479f2bc12cbad3de0512e7d2df1562e071af8aa5229541589fb25cc9
apps/sim/lib/sim-search/live/http.test.tshttps://github.com/simstudioai/sim/pull/10084/files#diff-d28b55c3fe2736c2de5e2cd5b01dc7ecc3a2cc730b757f59e8d0b63a47568395
View file https://github.com/simstudioai/sim/blob/bf93223ee73b86319a631f80222a8a2958e2a833/apps/sim/lib/sim-search/live/http.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10084/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10084/files#diff-d28b55c3fe2736c2de5e2cd5b01dc7ecc3a2cc730b757f59e8d0b63a47568395
https://github.com/simstudioai/sim/pull/10084/files#diff-d28b55c3fe2736c2de5e2cd5b01dc7ecc3a2cc730b757f59e8d0b63a47568395
https://github.com/simstudioai/sim/pull/10084/files#diff-d28b55c3fe2736c2de5e2cd5b01dc7ecc3a2cc730b757f59e8d0b63a47568395
https://github.com/simstudioai/sim/pull/10084/files#diff-d28b55c3fe2736c2de5e2cd5b01dc7ecc3a2cc730b757f59e8d0b63a47568395
apps/sim/lib/sim-search/live/http.tshttps://github.com/simstudioai/sim/pull/10084/files#diff-db05fa39c3e2fd0f48efd209b627af77b955e94f9ee317f45173cbfe5d3211ec
View file https://github.com/simstudioai/sim/blob/bf93223ee73b86319a631f80222a8a2958e2a833/apps/sim/lib/sim-search/live/http.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10084/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10084/files#diff-db05fa39c3e2fd0f48efd209b627af77b955e94f9ee317f45173cbfe5d3211ec
https://github.com/simstudioai/sim/pull/10084/files#diff-db05fa39c3e2fd0f48efd209b627af77b955e94f9ee317f45173cbfe5d3211ec
https://github.com/simstudioai/sim/pull/10084/files#diff-db05fa39c3e2fd0f48efd209b627af77b955e94f9ee317f45173cbfe5d3211ec
https://github.com/simstudioai/sim/pull/10084/files#diff-db05fa39c3e2fd0f48efd209b627af77b955e94f9ee317f45173cbfe5d3211ec
https://github.com/simstudioai/sim/pull/10084/files#diff-db05fa39c3e2fd0f48efd209b627af77b955e94f9ee317f45173cbfe5d3211ec
Please reload this pagehttps://github.com/simstudioai/sim/pull/10084/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.