René's URL Explorer Experiment


Title: fix(agent): drop tool-row values left from a previous operation by waleedlatif1 · Pull Request #10080 · simstudioai/sim · GitHub

Open Graph Title: fix(agent): drop tool-row values left from a previous operation by waleedlatif1 · Pull Request #10080 · simstudioai/sim

X Title: fix(agent): drop tool-row values left from a previous operation by waleedlatif1 · Pull Request #10080 · simstudioai/sim

Description: Summary An Agent tool row keeps its stored values when the user switches the row's operation, but it renders only the sub-blocks the new operation's condition shows. A value written only by now-hidden sub-blocks stayed out of sight. createLLMToolSchema also withheld that param from the model, because the user had "provided" it. The value still reached the block mapper and the vendor at execution. Four cases with the real block configs: Checkr: geo ID left over from Get Geo, row switched to List Candidates. The candidate list gets an invisible geo filter. Checkr: tags left over from Set Report Tags, row switched to Order Report. The old tags get attached to the new report. Trello: archive status left over from Update Card, row switched to Update List. The model can no longer set closed. Once mappers fall back to tool-call args, the list gets archived. CB Insights: websites left over from Look Up Organizations, row switched to Search Firmographics. Results get filtered by a field the user can't see. Fix omitConditionHiddenParams(subBlocks, params, operation) in lib/workflows/tool-input/hidden-params.ts drops a stored value only when every sub-block that writes it is decidably hidden under { ...params, operation }. The writers are sub-blocks matching the value's id or canonical id, widened to the whole basic/advanced group. Every unclear case keeps the value: The operation must be one of the block's own operation option ids. Otherwise a clause on operation is undecided. A clause on another field is decided only when the row holds a scalar value for that field. A stored 'true'/'5' is also tried as a boolean or number. A function condition goes through a Proxy that watches which fields it reads. If it reads an undecided field, nothing is dropped. Example: Video Generator gates settings on model, which the model supplies at call time. Credential and password fields, reactiveCondition fields, and params no sub-block writes are always kept. Applied at: transformBlockTool, before the schema, providerTool.params and the transform. This covers Agent and Pi tool rows, including rows saved before this change. The model now sees the param again when it is user-or-llm. Pi's projected-provenance copy keeps the same keys, the way the agent handler's copy already did. Human-in-the-loop v2 notification tools (prepareNotificationToolParams). v1 is unchanged on purpose. getParamsForToolOperation when the editor switches operations, so rows stop collecting stale values. It now takes the selected operation. Canvas execution is not affected. The serializer already drops sub-blocks whose condition is false (shouldSerializeSubBlock). Review An independent read-only reviewer ran the helper against the real tool-row renderer (getSubBlocksForToolInput). It covered every block with tools, including github, slack, gmail, google_sheets, table, file, notion, hubspot, jira, trello, checkr, cbinsights, airtable, salesforce and microsoft_teams, across every operation. For each operation it tried each option value of each dropdown, switch and checkbox, with values typed and as strings, and stored under both the sub-block id and the canonical id. That came to about 117k combinations and about 1M rendered fields. No visible value was dropped. Tests The new cases in providers/utils.test.ts run the real transform and prepareToolExecution with the real block configs: Four stale-value cases: Trello, CB Insights, and both Checkr cases. Each fails when the transformBlockTool guard is reverted. The operation-switch case fails when the getParamsForToolOperation guard is reverted. Cases that must keep their value: a canonical pair stored under the basic member, the advanced member, or the canonical id; a pure tool param; and an operation the block doesn't list. bun run test passes for providers/utils.test.ts, tools/index.test.ts, the agent, HITL and Pi handler suites, and the custom-block and tool-input suites. 🤖 Generated with Claude Code

Open Graph Description: Summary An Agent tool row keeps its stored values when the user switches the row's operation, but it renders only the sub-blocks the new operation's condition shows. A value written only by...

X Description: Summary An Agent tool row keeps its stored values when the user switches the row's operation, but it renders only the sub-blocks the new operation's condition shows. A value written...

Opengraph URL: https://github.com/simstudioai/sim/pull/10080

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:24b7a1ed-b7db-85c7-71c9-a64cea3c12e7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE1DE:D2A45:3F5DF0:56A551:6AFB998F
html-safe-nonce95bad176beca61d6e2705bd5b5c7a6ceb4607c9950ec79b8174a3d6c161f8ffe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMURFOkQyQTQ1OjNGNURGMDo1NkE1NTE6NkFGQjk5OEYiLCJ2aXNpdG9yX2lkIjoiNzYxMzk3MzI0NTA5MTA5Mjg3OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac657e78df3f7545acc411c19014785ecf875dfc373b584f1f6e41b6ccc63a4ce1
hovercard-subject-tagpull_request:5330254934
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/10080/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary An Agent tool row keeps its stored values when the user switches the row's operation, but it renders only the sub-blocks the new operation's condition shows. A value written only by...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3cefd19a936819d82cfb5279d50fb56fe79cb9ec30f0f807e04e89b0c58ffae1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release606800bdb1b81d125fc845bdcc262c9fe063fc8f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/10080/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10080%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10080%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/10080/files
Reloadhttps://github.com/simstudioai/sim/pull/10080/files
Reloadhttps://github.com/simstudioai/sim/pull/10080/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
sweep2/toolrowhttps://github.com/simstudioai/sim/tree/sweep2/toolrow
Conversation 2 https://github.com/simstudioai/sim/pull/10080
Commits 1 https://github.com/simstudioai/sim/pull/10080/commits
Checks 81 https://github.com/simstudioai/sim/pull/10080/checks
Files changed https://github.com/simstudioai/sim/pull/10080/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10080/files
fix(agent): drop tool-row values left from a previous operation https://github.com/simstudioai/sim/pull/10080/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/10080/files
592a925 fix(agent): drop tool-row values left from a previous operation waleedlatif1 Nov 16, 2026 https://github.com/simstudioai/sim/pull/10080/commits/592a925f98d5bf5b04590863a1413d21664d53d7
Clear filters https://github.com/simstudioai/sim/pull/10080/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10080/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10080/files
param-dependents.ts https://github.com/simstudioai/sim/pull/10080/files#diff-b115888073fbcdce3cdc0befb5f32a3ae9bbc418e0e0ca925f6485c23a78500c
tool-input.tsx https://github.com/simstudioai/sim/pull/10080/files#diff-9d18e37ae3bc1e0d6e4ea27b679516985bafc2a806b5adbddd05f35599dc5044
handler.ts https://github.com/simstudioai/sim/pull/10080/files#diff-c78ce7409e4fffd181672d172c87ba3d035fd5f8b7c3d2c2468a9882783808d2
sim-tools.ts https://github.com/simstudioai/sim/pull/10080/files#diff-19a23829ad3d6520c18f0c42c63422d9723db781541a75b61991316d0e4d4c5a
hidden-params.ts https://github.com/simstudioai/sim/pull/10080/files#diff-7fc4dcec0c1b0b1ed461d9d1ae9fb9b3dd0f00349dc291191448fc9028148f7c
utils.test.ts https://github.com/simstudioai/sim/pull/10080/files#diff-8eabf1c02c2ea4149f157a0f4345ce7273b3f388cd42a32c660e07f72335025b
utils.ts https://github.com/simstudioai/sim/pull/10080/files#diff-e5a8ed3fe51b6470c7acddd9beac4eecb4c915cacc23d40b68b566a998ac121e
...ts/panel/components/editor/components/sub-block/components/tool-input/param-dependents.tshttps://github.com/simstudioai/sim/pull/10080/files#diff-b115888073fbcdce3cdc0befb5f32a3ae9bbc418e0e0ca925f6485c23a78500c
View file https://github.com/simstudioai/sim/blob/592a925f98d5bf5b04590863a1413d21664d53d7/apps/sim/app/workspace/%5BworkspaceId%5D/w/%5BworkflowId%5D/components/panel/components/editor/components/sub-block/components/tool-input/param-dependents.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10080/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10080/files#diff-b115888073fbcdce3cdc0befb5f32a3ae9bbc418e0e0ca925f6485c23a78500c
https://github.com/simstudioai/sim/pull/10080/files#diff-b115888073fbcdce3cdc0befb5f32a3ae9bbc418e0e0ca925f6485c23a78500c
https://github.com/simstudioai/sim/pull/10080/files#diff-b115888073fbcdce3cdc0befb5f32a3ae9bbc418e0e0ca925f6485c23a78500c
https://github.com/simstudioai/sim/pull/10080/files#diff-b115888073fbcdce3cdc0befb5f32a3ae9bbc418e0e0ca925f6485c23a78500c
...ponents/panel/components/editor/components/sub-block/components/tool-input/tool-input.tsxhttps://github.com/simstudioai/sim/pull/10080/files#diff-9d18e37ae3bc1e0d6e4ea27b679516985bafc2a806b5adbddd05f35599dc5044
View file https://github.com/simstudioai/sim/blob/592a925f98d5bf5b04590863a1413d21664d53d7/apps/sim/app/workspace/%5BworkspaceId%5D/w/%5BworkflowId%5D/components/panel/components/editor/components/sub-block/components/tool-input/tool-input.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10080/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10080/files#diff-9d18e37ae3bc1e0d6e4ea27b679516985bafc2a806b5adbddd05f35599dc5044
https://github.com/simstudioai/sim/pull/10080/files#diff-9d18e37ae3bc1e0d6e4ea27b679516985bafc2a806b5adbddd05f35599dc5044
apps/sim/executor/handlers/human-in-the-loop/handler.tshttps://github.com/simstudioai/sim/pull/10080/files#diff-c78ce7409e4fffd181672d172c87ba3d035fd5f8b7c3d2c2468a9882783808d2
View file https://github.com/simstudioai/sim/blob/592a925f98d5bf5b04590863a1413d21664d53d7/apps/sim/executor/handlers/human-in-the-loop/handler.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10080/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10080/files#diff-c78ce7409e4fffd181672d172c87ba3d035fd5f8b7c3d2c2468a9882783808d2
https://github.com/simstudioai/sim/pull/10080/files#diff-c78ce7409e4fffd181672d172c87ba3d035fd5f8b7c3d2c2468a9882783808d2
https://github.com/simstudioai/sim/pull/10080/files#diff-c78ce7409e4fffd181672d172c87ba3d035fd5f8b7c3d2c2468a9882783808d2
https://github.com/simstudioai/sim/pull/10080/files#diff-c78ce7409e4fffd181672d172c87ba3d035fd5f8b7c3d2c2468a9882783808d2
https://github.com/simstudioai/sim/pull/10080/files#diff-c78ce7409e4fffd181672d172c87ba3d035fd5f8b7c3d2c2468a9882783808d2
apps/sim/executor/handlers/pi/local/sim-tools.tshttps://github.com/simstudioai/sim/pull/10080/files#diff-19a23829ad3d6520c18f0c42c63422d9723db781541a75b61991316d0e4d4c5a
View file https://github.com/simstudioai/sim/blob/592a925f98d5bf5b04590863a1413d21664d53d7/apps/sim/executor/handlers/pi/local/sim-tools.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10080/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10080/files#diff-19a23829ad3d6520c18f0c42c63422d9723db781541a75b61991316d0e4d4c5a
https://github.com/simstudioai/sim/pull/10080/files#diff-19a23829ad3d6520c18f0c42c63422d9723db781541a75b61991316d0e4d4c5a
apps/sim/lib/workflows/tool-input/hidden-params.tshttps://github.com/simstudioai/sim/pull/10080/files#diff-7fc4dcec0c1b0b1ed461d9d1ae9fb9b3dd0f00349dc291191448fc9028148f7c
View file https://github.com/simstudioai/sim/blob/592a925f98d5bf5b04590863a1413d21664d53d7/apps/sim/lib/workflows/tool-input/hidden-params.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10080/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/10080/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10080/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.