René's URL Explorer Experiment


Title: fix(brex): leave a blank spend-limit buffer unset by waleedlatif1 · Pull Request #10079 · simstudioai/sim · GitHub

Open Graph Title: fix(brex): leave a blank spend-limit buffer unset by waleedlatif1 · Pull Request #10079 · simstudioai/sim

X Title: fix(brex): leave a blank spend-limit buffer unset by waleedlatif1 · Pull Request #10079 · simstudioai/sim

Description: Summary Follow-up to #10074 for brex_create_spend_limit. Regression from #10074: the buffer check ran whenever limitBufferPercentage !== undefined. A saved canvas value of null or '' went through Number(), became 0, and passed the 0–100 check. Saved workflows that left the buffer blank started sending limit_buffer_percentage: 0, a value the user never set. Before #10074 the field went out as null. Older bug, same flow: transaction_limit was built whenever transactionLimitAmount !== undefined, so a null sent { amount: null, currency }. Brex's spec requires Money.amount to be an integer. In Brex's Budgets API OpenAPI spec, CreateAuthorizationSettings.limit_buffer_percentage (int32) and CreateSpendLimitRequest.transaction_limit (Money) are both optional and nullable. Both fields are now left out when the value is undefined, null, or a blank string. Leaving the buffer out means the same thing as the null that was sent before #10074, and an explicit 0 is still sent. Test plan tools/brex/create_spend_limit.test.ts: the 6 blank-value cases fail on the pre-fix code and pass with the fix. The explicit-0 and set-amount cases pass on both. 🤖 Generated with Claude Code

Open Graph Description: Summary Follow-up to #10074 for brex_create_spend_limit. Regression from #10074: the buffer check ran whenever limitBufferPercentage !== undefined. A saved canvas value of null or '' went ...

X Description: Summary Follow-up to #10074 for brex_create_spend_limit. Regression from #10074: the buffer check ran whenever limitBufferPercentage !== undefined. A saved canvas value of null or '&#3...

Opengraph URL: https://github.com/simstudioai/sim/pull/10079

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c9663a62-b13e-9cfd-f656-fdf7c3b2219e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC306:D2A45:4FD9F0:6CD7E7:6AFB9F12
html-safe-nonceaae5d0eb71f6a728523969cc13e45f5a54eeea9b0471b7a0a887e39ac20a22a6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzA2OkQyQTQ1OjRGRDlGMDo2Q0Q3RTc6NkFGQjlGMTIiLCJ2aXNpdG9yX2lkIjoiNTcwNjI3ODE0NTIxMjc4NDQwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac705ef894891427764ed6e9ce047c077017533027e4d0bcfba81da55484c661e0
hovercard-subject-tagpull_request:5330092901
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/10079/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up to #10074 for brex_create_spend_limit. Regression from #10074: the buffer check ran whenever limitBufferPercentage !== undefined. A saved canvas value of null or '' went ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3cefd19a936819d82cfb5279d50fb56fe79cb9ec30f0f807e04e89b0c58ffae1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release606800bdb1b81d125fc845bdcc262c9fe063fc8f
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/10079/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10079%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10079%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/10079/files
Reloadhttps://github.com/simstudioai/sim/pull/10079/files
Reloadhttps://github.com/simstudioai/sim/pull/10079/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
sweep2/followuphttps://github.com/simstudioai/sim/tree/sweep2/followup
Conversation 8 https://github.com/simstudioai/sim/pull/10079
Commits 2 https://github.com/simstudioai/sim/pull/10079/commits
Checks 81 https://github.com/simstudioai/sim/pull/10079/checks
Files changed https://github.com/simstudioai/sim/pull/10079/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10079/files
fix(brex): leave a blank spend-limit buffer unset https://github.com/simstudioai/sim/pull/10079/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/10079/files
30aa015 fix(brex): leave a blank spend-limit buffer and transaction limit unset waleedlatif1 Nov 16, 2026 https://github.com/simstudioai/sim/pull/10079/commits/30aa015ecaf4c06e23b4cd4daaf9db0d19d66dcd
2ec8f91 test(brex): narrow the spend-limit body builder result to a JSON object waleedlatif1 Nov 16, 2026 https://github.com/simstudioai/sim/pull/10079/commits/2ec8f91adc76af964443c9dd5d3117c7cfde7c1c
Clear filters https://github.com/simstudioai/sim/pull/10079/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10079/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10079/files
create_spend_limit.test.ts https://github.com/simstudioai/sim/pull/10079/files#diff-c0ff79be1deca49a99818dc2df6325ff3f31d1f09e8b19f60010600cf91f91c0
create_spend_limit.ts https://github.com/simstudioai/sim/pull/10079/files#diff-838b8222f2e652c53ffae51d3a1a55d27c1634770dcd3afd38bd0ca57c5f0529
apps/sim/tools/brex/create_spend_limit.test.tshttps://github.com/simstudioai/sim/pull/10079/files#diff-c0ff79be1deca49a99818dc2df6325ff3f31d1f09e8b19f60010600cf91f91c0
View file https://github.com/simstudioai/sim/blob/2ec8f91adc76af964443c9dd5d3117c7cfde7c1c/apps/sim/tools/brex/create_spend_limit.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10079/{{ revealButtonHref }}
apps/sim/tools/brex/create_spend_limit.tshttps://github.com/simstudioai/sim/pull/10079/files#diff-838b8222f2e652c53ffae51d3a1a55d27c1634770dcd3afd38bd0ca57c5f0529
View file https://github.com/simstudioai/sim/blob/2ec8f91adc76af964443c9dd5d3117c7cfde7c1c/apps/sim/tools/brex/create_spend_limit.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10079/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10079/files#diff-838b8222f2e652c53ffae51d3a1a55d27c1634770dcd3afd38bd0ca57c5f0529
https://github.com/simstudioai/sim/pull/10079/files#diff-838b8222f2e652c53ffae51d3a1a55d27c1634770dcd3afd38bd0ca57c5f0529
https://github.com/simstudioai/sim/pull/10079/files#diff-838b8222f2e652c53ffae51d3a1a55d27c1634770dcd3afd38bd0ca57c5f0529
https://github.com/simstudioai/sim/pull/10079/files#diff-838b8222f2e652c53ffae51d3a1a55d27c1634770dcd3afd38bd0ca57c5f0529
https://github.com/simstudioai/sim/pull/10079/files#diff-838b8222f2e652c53ffae51d3a1a55d27c1634770dcd3afd38bd0ca57c5f0529
Please reload this pagehttps://github.com/simstudioai/sim/pull/10079/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.