René's URL Explorer Experiment


Title: fix(pii): bound NER memory per worker so large texts stop OOM-killing Presidio workers by waleedlatif1 · Pull Request #10068 · simstudioai/sim · GitHub

Open Graph Title: fix(pii): bound NER memory per worker so large texts stop OOM-killing Presidio workers by waleedlatif1 · Pull Request #10068 · simstudioai/sim

X Title: fix(pii): bound NER memory per worker so large texts stop OOM-killing Presidio workers by waleedlatif1 · Pull Request #10068 · simstudioai/sim

Description: Summary Presidio workers were being killed by the kernel OOM killer: uvicorn logs Child process died with no Maximum request limit line before it. The trigger is full-NER traffic carrying single texts between the client's 256KB chunk budget and spaCy's 1M max_length. Those went whole through one NER pass, which peaks about 3.3GB above the worker's baseline for about 4s. Workers also ran one NER pass per in-flight request (FastAPI's sync threadpool), and glibc's per-thread malloc arenas kept each thread's peak. The memory stacked until the task hit its limit. The spikes are too short to show in per-minute memory metrics. NER now runs in 100k-char windows for any text over NER_WINDOW_CHARS, instead of only texts over max_length. This reuses the windowing from #9979: pattern and custom recognizers still run over the whole text, and every window's spans are kept. One NER pass at a time per worker (_NER_SLOT). A long text takes it per window, so it interleaves with other requests. Regex-only requests never take it. MALLOC_ARENA_MAX=2 in the image, and /health is async so health checks never queue behind waiting threads. Type of Change Bug fix Testing Reproduced on a box with the exact pinned deps, the real entrypoint and 2 workers. Memory and CPU were capped in proportion to prod (MemoryMax=10G, CPUQuota=200%), with 16 concurrent clients sending 2000-text full-NER batches plus 30% single texts of 300–900KB, for 5 minutes: OOM kills (= Child process died) ok / failed peak memory before 45 18 / 384 10.2GB (limit) after 0 129 / 0 8.0GB Each part alone falls short. At the original load (12 clients, 15% large), windowing alone left 2 OOM kills and the lock alone 9, against 12 before. On the heavy load, windowing plus MALLOC_ARENA_MAX without the lock left 2. Output check on 150k–650k-char texts against the original: no span lost. A few extra spans at window edges, merged into the same mask or masking a cut fragment: the trade-off #9979 accepted. Under that heavy load the slowest single large text took 335s. Before the fix none of them completed. The test-pii-redaction-e2e.ts long-text check (over 1M chars) still goes through the same windowed path. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Presidio workers were being killed by the kernel OOM killer: uvicorn logs Child process died with no Maximum request limit line before it. The trigger is full-NER traffic carrying single t...

X Description: Summary Presidio workers were being killed by the kernel OOM killer: uvicorn logs Child process died with no Maximum request limit line before it. The trigger is full-NER traffic carrying single t...

Opengraph URL: https://github.com/simstudioai/sim/pull/10068

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4ca925df-7576-0bc4-e344-65544ec93070
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id92CE:71DFA:926A55:CF3E77:6AFB5197
html-safe-nonceb04bc01723c0290fd0582a2eaaa239fc4b4dc5356a0dc045fa3dfe7df07390f9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkNFOjcxREZBOjkyNkE1NTpDRjNFNzc6NkFGQjUxOTciLCJ2aXNpdG9yX2lkIjoiMTE1MTYyNzEzMjEwNzcwNjc3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac757fccd1eb779049dc9f47277c4aa99406ac860fb1ea14ebfd921d07b2a0564d
hovercard-subject-tagpull_request:5321403393
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/10068/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Presidio workers were being killed by the kernel OOM killer: uvicorn logs Child process died with no Maximum request limit line before it. The trigger is full-NER traffic carrying single t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/10068/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10068%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10068%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/10068/files
Reloadhttps://github.com/simstudioai/sim/pull/10068/files
Reloadhttps://github.com/simstudioai/sim/pull/10068/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/pii-worker-deathshttps://github.com/simstudioai/sim/tree/fix/pii-worker-deaths
Conversation 2 https://github.com/simstudioai/sim/pull/10068
Commits 1 https://github.com/simstudioai/sim/pull/10068/commits
Checks 75 https://github.com/simstudioai/sim/pull/10068/checks
Files changed https://github.com/simstudioai/sim/pull/10068/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10068/files
fix(pii): bound NER memory per worker so large texts stop OOM-killing Presidio workers https://github.com/simstudioai/sim/pull/10068/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/10068/files
2e9b86d fix(pii): bound NER memory per worker so large texts stop OOM-killing… waleedlatif1 Nov 15, 2026 https://github.com/simstudioai/sim/pull/10068/commits/2e9b86d34b72219b8fce2f6b19818bb2adb83333
Clear filters https://github.com/simstudioai/sim/pull/10068/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10068/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10068/files
server.py https://github.com/simstudioai/sim/pull/10068/files#diff-4447adf1c9c684d32a5fd31a17e05677749ef10d0ca6bce34ac9b6263e781a40
pii.Dockerfile https://github.com/simstudioai/sim/pull/10068/files#diff-9ffed6e2379c4cb446d31f12ffaf134779b805cf63f2083664be12267918a8e2
apps/pii/server.pyhttps://github.com/simstudioai/sim/pull/10068/files#diff-4447adf1c9c684d32a5fd31a17e05677749ef10d0ca6bce34ac9b6263e781a40
View file https://github.com/simstudioai/sim/blob/2e9b86d34b72219b8fce2f6b19818bb2adb83333/apps/pii/server.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10068/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10068/files#diff-4447adf1c9c684d32a5fd31a17e05677749ef10d0ca6bce34ac9b6263e781a40
https://github.com/simstudioai/sim/pull/10068/files#diff-4447adf1c9c684d32a5fd31a17e05677749ef10d0ca6bce34ac9b6263e781a40
https://github.com/simstudioai/sim/pull/10068/files#diff-4447adf1c9c684d32a5fd31a17e05677749ef10d0ca6bce34ac9b6263e781a40
https://github.com/simstudioai/sim/pull/10068/files#diff-4447adf1c9c684d32a5fd31a17e05677749ef10d0ca6bce34ac9b6263e781a40
https://github.com/simstudioai/sim/pull/10068/files#diff-4447adf1c9c684d32a5fd31a17e05677749ef10d0ca6bce34ac9b6263e781a40
https://github.com/simstudioai/sim/pull/10068/files#diff-4447adf1c9c684d32a5fd31a17e05677749ef10d0ca6bce34ac9b6263e781a40
https://github.com/simstudioai/sim/pull/10068/files#diff-4447adf1c9c684d32a5fd31a17e05677749ef10d0ca6bce34ac9b6263e781a40
https://github.com/simstudioai/sim/pull/10068/files#diff-4447adf1c9c684d32a5fd31a17e05677749ef10d0ca6bce34ac9b6263e781a40
https://github.com/simstudioai/sim/pull/10068/files#diff-4447adf1c9c684d32a5fd31a17e05677749ef10d0ca6bce34ac9b6263e781a40
https://github.com/simstudioai/sim/pull/10068/files#diff-4447adf1c9c684d32a5fd31a17e05677749ef10d0ca6bce34ac9b6263e781a40
https://github.com/simstudioai/sim/pull/10068/files#diff-4447adf1c9c684d32a5fd31a17e05677749ef10d0ca6bce34ac9b6263e781a40
https://github.com/simstudioai/sim/pull/10068/files#diff-4447adf1c9c684d32a5fd31a17e05677749ef10d0ca6bce34ac9b6263e781a40
https://github.com/simstudioai/sim/pull/10068/files#diff-4447adf1c9c684d32a5fd31a17e05677749ef10d0ca6bce34ac9b6263e781a40
https://github.com/simstudioai/sim/pull/10068/files#diff-4447adf1c9c684d32a5fd31a17e05677749ef10d0ca6bce34ac9b6263e781a40
https://github.com/simstudioai/sim/pull/10068/files#diff-4447adf1c9c684d32a5fd31a17e05677749ef10d0ca6bce34ac9b6263e781a40
https://github.com/simstudioai/sim/pull/10068/files#diff-4447adf1c9c684d32a5fd31a17e05677749ef10d0ca6bce34ac9b6263e781a40
docker/pii.Dockerfilehttps://github.com/simstudioai/sim/pull/10068/files#diff-9ffed6e2379c4cb446d31f12ffaf134779b805cf63f2083664be12267918a8e2
View file https://github.com/simstudioai/sim/blob/2e9b86d34b72219b8fce2f6b19818bb2adb83333/docker/pii.Dockerfile
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10068/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10068/files#diff-9ffed6e2379c4cb446d31f12ffaf134779b805cf63f2083664be12267918a8e2
https://github.com/simstudioai/sim/pull/10068/files#diff-9ffed6e2379c4cb446d31f12ffaf134779b805cf63f2083664be12267918a8e2
Please reload this pagehttps://github.com/simstudioai/sim/pull/10068/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.