Title: fix(pii): bound NER memory per worker so large texts stop OOM-killing Presidio workers by waleedlatif1 · Pull Request #10068 · simstudioai/sim · GitHub
Open Graph Title: fix(pii): bound NER memory per worker so large texts stop OOM-killing Presidio workers by waleedlatif1 · Pull Request #10068 · simstudioai/sim
X Title: fix(pii): bound NER memory per worker so large texts stop OOM-killing Presidio workers by waleedlatif1 · Pull Request #10068 · simstudioai/sim
Description: Summary Presidio workers were being killed by the kernel OOM killer: uvicorn logs Child process died with no Maximum request limit line before it. The trigger is full-NER traffic carrying single texts between the client's 256KB chunk budget and spaCy's 1M max_length. Those went whole through one NER pass, which peaks about 3.3GB above the worker's baseline for about 4s. Workers also ran one NER pass per in-flight request (FastAPI's sync threadpool), and glibc's per-thread malloc arenas kept each thread's peak. The memory stacked until the task hit its limit. The spikes are too short to show in per-minute memory metrics. NER now runs in 100k-char windows for any text over NER_WINDOW_CHARS, instead of only texts over max_length. This reuses the windowing from #9979: pattern and custom recognizers still run over the whole text, and every window's spans are kept. One NER pass at a time per worker (_NER_SLOT). A long text takes it per window, so it interleaves with other requests. Regex-only requests never take it. MALLOC_ARENA_MAX=2 in the image, and /health is async so health checks never queue behind waiting threads. Type of Change Bug fix Testing Reproduced on a box with the exact pinned deps, the real entrypoint and 2 workers. Memory and CPU were capped in proportion to prod (MemoryMax=10G, CPUQuota=200%), with 16 concurrent clients sending 2000-text full-NER batches plus 30% single texts of 300–900KB, for 5 minutes: OOM kills (= Child process died) ok / failed peak memory before 45 18 / 384 10.2GB (limit) after 0 129 / 0 8.0GB Each part alone falls short. At the original load (12 clients, 15% large), windowing alone left 2 OOM kills and the lock alone 9, against 12 before. On the heavy load, windowing plus MALLOC_ARENA_MAX without the lock left 2. Output check on 150k–650k-char texts against the original: no span lost. A few extra spans at window edges, merged into the same mask or masking a cut fragment: the trade-off #9979 accepted. Under that heavy load the slowest single large text took 335s. Before the fix none of them completed. The test-pii-redaction-e2e.ts long-text check (over 1M chars) still goes through the same windowed path. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Presidio workers were being killed by the kernel OOM killer: uvicorn logs Child process died with no Maximum request limit line before it. The trigger is full-NER traffic carrying single t...
X Description: Summary Presidio workers were being killed by the kernel OOM killer: uvicorn logs Child process died with no Maximum request limit line before it. The trigger is full-NER traffic carrying single t...
Opengraph URL: https://github.com/simstudioai/sim/pull/10068
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:4ca925df-7576-0bc4-e344-65544ec93070 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 92CE:71DFA:926A55:CF3E77:6AFB5197 |
| html-safe-nonce | b04bc01723c0290fd0582a2eaaa239fc4b4dc5356a0dc045fa3dfe7df07390f9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkNFOjcxREZBOjkyNkE1NTpDRjNFNzc6NkFGQjUxOTciLCJ2aXNpdG9yX2lkIjoiMTE1MTYyNzEzMjEwNzcwNjc3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 757fccd1eb779049dc9f47277c4aa99406ac860fb1ea14ebfd921d07b2a0564d |
| hovercard-subject-tag | pull_request:5321403393 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/10068/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Presidio workers were being killed by the kernel OOM killer: uvicorn logs Child process died with no Maximum request limit line before it. The trigger is full-NER traffic carrying single t... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width