René's URL Explorer Experiment


Title: fix(sandbox): skip interval ticks while the previous one is still in flight by waleedlatif1 · Pull Request #10063 · simstudioai/sim · GitHub

Open Graph Title: fix(sandbox): skip interval ticks while the previous one is still in flight by waleedlatif1 · Pull Request #10063 · simstudioai/sim

X Title: fix(sandbox): skip interval ticks while the previous one is still in flight by waleedlatif1 · Pull Request #10063 · simstudioai/sim

Description: Summary Task-mode setInterval queued an isolate callback on every Node tick via applyIgnored, whether or not the isolate had run the previous one. While user code ran a synchronous loop, undelivered ticks piled up on the shared worker heap, outside the isolate's memoryLimit, for the whole time budget (120s for doc compile), and the memory stayed held after the execution ended Skip a tick while the previous one is still in flight (browser interval semantics), so each interval holds at most one queued callback — at most 50 per execution under the existing interval cap The isolate-side setInterval wraps the callback so its return value never crosses back to the host now that ticks use apply Follow-up to #9776, which capped timer counts and declined a period floor because zero-delay setTimeout chains reach the same rate. That holds for an idle isolate, but a chain only reschedules after its callback runs, while an interval keeps queueing. This fixes the busy case without changing idle behavior, so no period floor or firing cap Type of Change Bug fix (security) Testing Verified against the real worker process (scratch harness forking isolated-vm-worker.cjs over IPC): Before: 49 × setInterval(f, 1) plus a 15s busy loop grew worker RSS 41 → 325 MB (~9 MB/s while busy), retained after the execution After: flat at ~58 MB; co-tenant latency unchanged vs a no-interval busy baseline Idle 5ms interval still ticks normally; a throwing callback keeps its interval alive; a callback returning a 50 MB string no longer copies it to the host No sandbox bundle (docx, pptxgenjs, pdf-lib, vitest-expect) uses setInterval test-isolated-vm-remote-e2e.ts: new check "keeps a busy task from queuing interval ticks on the shared worker" fails on the staging worker (446 queued ticks), passes after; all 27 checks pass isolated-vm.test.ts + isolated-vm-worker-hardening.test.ts 28/28 bun run lint, block-registry check, check:utils, check:comment-hygiene, check:test-patterns, check:boundaries; full gate left to CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Task-mode setInterval queued an isolate callback on every Node tick via applyIgnored, whether or not the isolate had run the previous one. While user code ran a synchronous loop, undeliver...

X Description: Summary Task-mode setInterval queued an isolate callback on every Node tick via applyIgnored, whether or not the isolate had run the previous one. While user code ran a synchronous loop, undeliver...

Opengraph URL: https://github.com/simstudioai/sim/pull/10063

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fdce0992-f499-2d40-c8d5-a72375aea613
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC3B8:303206:C5B8D8:1167807:6AFB5DAC
html-safe-noncedc27d11c2994041ec850584e6500b12a3e1f4b5cb91aace10bd1d35f8136fecd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDM0I4OjMwMzIwNjpDNUI4RDg6MTE2NzgwNzo2QUZCNURBQyIsInZpc2l0b3JfaWQiOiIxNzEwOTU3MzgxNTgxMjMzNTgwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac094385103eaad8ae82d03ea5bfd45e5c6d28ac09b3b3d2523c9bbeb92b9a9610
hovercard-subject-tagpull_request:5317126752
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/10063/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Task-mode setInterval queued an isolate callback on every Node tick via applyIgnored, whether or not the isolate had run the previous one. While user code ran a synchronous loop, undeliver...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/10063/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10063%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10063%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/10063/files
Reloadhttps://github.com/simstudioai/sim/pull/10063/files
Reloadhttps://github.com/simstudioai/sim/pull/10063/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/ivm-interval-backloghttps://github.com/simstudioai/sim/tree/fix/ivm-interval-backlog
Conversation 5 https://github.com/simstudioai/sim/pull/10063
Commits 1 https://github.com/simstudioai/sim/pull/10063/commits
Checks 81 https://github.com/simstudioai/sim/pull/10063/checks
Files changed https://github.com/simstudioai/sim/pull/10063/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10063/files
fix(sandbox): skip interval ticks while the previous one is still in flight https://github.com/simstudioai/sim/pull/10063/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/10063/files
7663968 fix(sandbox): skip interval ticks while the previous one is still in … waleedlatif1 Nov 14, 2026 https://github.com/simstudioai/sim/pull/10063/commits/76639681315fd73b4fe839f9d93b1ca8dedf3dde
Clear filters https://github.com/simstudioai/sim/pull/10063/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10063/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10063/files
isolated-vm-worker.cjs https://github.com/simstudioai/sim/pull/10063/files#diff-5ec4b6cd442f89061025100935c3d6b324e01b023fa75035cd4f46814667ef29
test-isolated-vm-remote-e2e.ts https://github.com/simstudioai/sim/pull/10063/files#diff-aeec4e99598253f7fe2ece856a04a362e60d283370e4153aec92eaac81409515
apps/sim/lib/execution/isolated-vm-worker.cjshttps://github.com/simstudioai/sim/pull/10063/files#diff-5ec4b6cd442f89061025100935c3d6b324e01b023fa75035cd4f46814667ef29
View file https://github.com/simstudioai/sim/blob/76639681315fd73b4fe839f9d93b1ca8dedf3dde/apps/sim/lib/execution/isolated-vm-worker.cjs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10063/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10063/files#diff-5ec4b6cd442f89061025100935c3d6b324e01b023fa75035cd4f46814667ef29
https://github.com/simstudioai/sim/pull/10063/files#diff-5ec4b6cd442f89061025100935c3d6b324e01b023fa75035cd4f46814667ef29
https://github.com/simstudioai/sim/pull/10063/files#diff-5ec4b6cd442f89061025100935c3d6b324e01b023fa75035cd4f46814667ef29
Please reload this pagehttps://github.com/simstudioai/sim/pull/10063/files
https://github.com/simstudioai/sim/pull/10063/files#diff-5ec4b6cd442f89061025100935c3d6b324e01b023fa75035cd4f46814667ef29
apps/sim/scripts/test-isolated-vm-remote-e2e.tshttps://github.com/simstudioai/sim/pull/10063/files#diff-aeec4e99598253f7fe2ece856a04a362e60d283370e4153aec92eaac81409515
View file https://github.com/simstudioai/sim/blob/76639681315fd73b4fe839f9d93b1ca8dedf3dde/apps/sim/scripts/test-isolated-vm-remote-e2e.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10063/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10063/files#diff-aeec4e99598253f7fe2ece856a04a362e60d283370e4153aec92eaac81409515
https://github.com/simstudioai/sim/pull/10063/files#diff-aeec4e99598253f7fe2ece856a04a362e60d283370e4153aec92eaac81409515
Please reload this pagehttps://github.com/simstudioai/sim/pull/10063/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.