Title: fix(sandbox): skip interval ticks while the previous one is still in flight by waleedlatif1 · Pull Request #10063 · simstudioai/sim · GitHub
Open Graph Title: fix(sandbox): skip interval ticks while the previous one is still in flight by waleedlatif1 · Pull Request #10063 · simstudioai/sim
X Title: fix(sandbox): skip interval ticks while the previous one is still in flight by waleedlatif1 · Pull Request #10063 · simstudioai/sim
Description: Summary Task-mode setInterval queued an isolate callback on every Node tick via applyIgnored, whether or not the isolate had run the previous one. While user code ran a synchronous loop, undelivered ticks piled up on the shared worker heap, outside the isolate's memoryLimit, for the whole time budget (120s for doc compile), and the memory stayed held after the execution ended Skip a tick while the previous one is still in flight (browser interval semantics), so each interval holds at most one queued callback — at most 50 per execution under the existing interval cap The isolate-side setInterval wraps the callback so its return value never crosses back to the host now that ticks use apply Follow-up to #9776, which capped timer counts and declined a period floor because zero-delay setTimeout chains reach the same rate. That holds for an idle isolate, but a chain only reschedules after its callback runs, while an interval keeps queueing. This fixes the busy case without changing idle behavior, so no period floor or firing cap Type of Change Bug fix (security) Testing Verified against the real worker process (scratch harness forking isolated-vm-worker.cjs over IPC): Before: 49 × setInterval(f, 1) plus a 15s busy loop grew worker RSS 41 → 325 MB (~9 MB/s while busy), retained after the execution After: flat at ~58 MB; co-tenant latency unchanged vs a no-interval busy baseline Idle 5ms interval still ticks normally; a throwing callback keeps its interval alive; a callback returning a 50 MB string no longer copies it to the host No sandbox bundle (docx, pptxgenjs, pdf-lib, vitest-expect) uses setInterval test-isolated-vm-remote-e2e.ts: new check "keeps a busy task from queuing interval ticks on the shared worker" fails on the staging worker (446 queued ticks), passes after; all 27 checks pass isolated-vm.test.ts + isolated-vm-worker-hardening.test.ts 28/28 bun run lint, block-registry check, check:utils, check:comment-hygiene, check:test-patterns, check:boundaries; full gate left to CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Task-mode setInterval queued an isolate callback on every Node tick via applyIgnored, whether or not the isolate had run the previous one. While user code ran a synchronous loop, undeliver...
X Description: Summary Task-mode setInterval queued an isolate callback on every Node tick via applyIgnored, whether or not the isolate had run the previous one. While user code ran a synchronous loop, undeliver...
Opengraph URL: https://github.com/simstudioai/sim/pull/10063
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:fdce0992-f499-2d40-c8d5-a72375aea613 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C3B8:303206:C5B8D8:1167807:6AFB5DAC |
| html-safe-nonce | dc27d11c2994041ec850584e6500b12a3e1f4b5cb91aace10bd1d35f8136fecd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDM0I4OjMwMzIwNjpDNUI4RDg6MTE2NzgwNzo2QUZCNURBQyIsInZpc2l0b3JfaWQiOiIxNzEwOTU3MzgxNTgxMjMzNTgwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 094385103eaad8ae82d03ea5bfd45e5c6d28ac09b3b3d2523c9bbeb92b9a9610 |
| hovercard-subject-tag | pull_request:5317126752 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/10063/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Task-mode setInterval queued an isolate callback on every Node tick via applyIgnored, whether or not the isolate had run the previous one. While user code ran a synchronous loop, undeliver... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | ea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ef97164c52cf59bd10558ddec9c4f482763988 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width