René's URL Explorer Experiment


Title: fix(copilot): hold callerless runs to the read grant for server tool writes by waleedlatif1 · Pull Request #10061 · simstudioai/sim · GitHub

Open Graph Title: fix(copilot): hold callerless runs to the read grant for server tool writes by waleedlatif1 · Pull Request #10061 · simstudioai/sim

X Title: fix(copilot): hold callerless runs to the read grant for server tool writes by waleedlatif1 · Pull Request #10061 · simstudioai/sim

Description: Summary An unattributed inbox message runs as the workspace owner. The CLI lane already holds such a callerless run (secretActorUserId === null) to the api:read grant, but server tools dispatched directly by the agent did not, so settings, dashboards, tests, changelog, workspaces and search_sources write actions authorized the owner's live role (e.g. settings inviting an admin member or revoking API keys) The server-tool adapter now runs a callerless run's calls under the same api:read grant, so the router's existing write-scope check refuses any call whose writes(args) is true, on both the streaming and in-band lanes. Keyed on secretActorUserId rather than userPermission, because userPermission never reaches Go's in-band lane changelog declares writes() (its operations already declare api:write; this keeps the router's pre-dispatch check complete) The executor no longer replaces a workspace run's permission with its target's live role when the run names its own workspace as target; only organization chats take the target's role Attributed runs, read-only members and organization chats are unchanged Type of Change Bug fix Testing New project-file-read.integration.ts case (real Postgres): a callerless settings update through the server-tool handler is refused with the scope error and the row is unchanged, reads still work, the attributed write lands. Red on the pre-fix adapter (the write went through), green after; whole file passes (18 tests) New executor test: a capped workspace run naming its own workspace keeps its cap; red on the pre-fix code bunx vitest run lib/mothership/tools lib/mothership/tool-executor lib/mothership/agent-cli (1,003 tests), biome; type-check and check:audits in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary An unattributed inbox message runs as the workspace owner. The CLI lane already holds such a callerless run (secretActorUserId === null) to the api:read grant, but server tools dispatched ...

X Description: Summary An unattributed inbox message runs as the workspace owner. The CLI lane already holds such a callerless run (secretActorUserId === null) to the api:read grant, but server tools dispatched ...

Opengraph URL: https://github.com/simstudioai/sim/pull/10061

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4f8d45a1-ea26-c835-e1cf-73f47b2183d1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF3E:375283:5071A9:709C34:6AFB5E85
html-safe-nonce0608ff143136e51cbe91bb17e52f1770bc4279e6b389802a36c4b5289dd2863f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjNFOjM3NTI4Mzo1MDcxQTk6NzA5QzM0OjZBRkI1RTg1IiwidmlzaXRvcl9pZCI6IjQ3MzExOTI2OTQ5NTk0NjQwNzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbfbc95ec2976d54817a95405b5800c9451612cdaf9428501a81dadad5e9d784e
hovercard-subject-tagpull_request:5316788254
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/10061/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary An unattributed inbox message runs as the workspace owner. The CLI lane already holds such a callerless run (secretActorUserId === null) to the api:read grant, but server tools dispatched ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/10061/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10061%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10061%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/10061/files
Reloadhttps://github.com/simstudioai/sim/pull/10061/files
Reloadhttps://github.com/simstudioai/sim/pull/10061/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/copilot-write-caphttps://github.com/simstudioai/sim/tree/fix/copilot-write-cap
Conversation 10 https://github.com/simstudioai/sim/pull/10061
Commits 2 https://github.com/simstudioai/sim/pull/10061/commits
Checks 82 https://github.com/simstudioai/sim/pull/10061/checks
Files changed https://github.com/simstudioai/sim/pull/10061/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10061/files
fix(copilot): hold callerless runs to the read grant for server tool writes https://github.com/simstudioai/sim/pull/10061/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/10061/files
3475356 fix(copilot): enforce a run's permission cap on server tool writes waleedlatif1 Nov 14, 2026 https://github.com/simstudioai/sim/pull/10061/commits/3475356f09db7b39a96937f9fd7926851a9dae69
8e65da9 fix(copilot): hold callerless runs to the read grant for server tools waleedlatif1 Nov 14, 2026 https://github.com/simstudioai/sim/pull/10061/commits/8e65da90a954c7018acd97e7b27b8942041eb9a2
Clear filters https://github.com/simstudioai/sim/pull/10061/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10061/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10061/files
project-file-read.integration.ts https://github.com/simstudioai/sim/pull/10061/files#diff-ce37481bbf0995d3a9d4597d9487419199758ceaf7d45291d6f29732506e8f00
executor.test.ts https://github.com/simstudioai/sim/pull/10061/files#diff-a3bd6ced317d9e33844ff77440945eb8c7055f58077b69248f9ca4e591cfb5be
executor.ts https://github.com/simstudioai/sim/pull/10061/files#diff-93e846b3df8162e58a726167ae263827cab848376270a73b9dc882dc09757c35
server-tool-adapter.ts https://github.com/simstudioai/sim/pull/10061/files#diff-c55494f51a63024bfe508a8804e4cef57158cbdbbc6ea47b02c70597a732dc65
changelog.ts https://github.com/simstudioai/sim/pull/10061/files#diff-27a38d1303dbfd1e4c40c7da732fd8e54a788e7d9b5c1f33cc247f516ffe9f69
apps/sim/lib/mothership/agent-cli/project-file-read.integration.tshttps://github.com/simstudioai/sim/pull/10061/files#diff-ce37481bbf0995d3a9d4597d9487419199758ceaf7d45291d6f29732506e8f00
View file https://github.com/simstudioai/sim/blob/8e65da90a954c7018acd97e7b27b8942041eb9a2/apps/sim/lib/mothership/agent-cli/project-file-read.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10061/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10061/files#diff-ce37481bbf0995d3a9d4597d9487419199758ceaf7d45291d6f29732506e8f00
https://github.com/simstudioai/sim/pull/10061/files#diff-ce37481bbf0995d3a9d4597d9487419199758ceaf7d45291d6f29732506e8f00
https://github.com/simstudioai/sim/pull/10061/files#diff-ce37481bbf0995d3a9d4597d9487419199758ceaf7d45291d6f29732506e8f00
https://github.com/simstudioai/sim/pull/10061/files#diff-ce37481bbf0995d3a9d4597d9487419199758ceaf7d45291d6f29732506e8f00
apps/sim/lib/mothership/tool-executor/executor.test.tshttps://github.com/simstudioai/sim/pull/10061/files#diff-a3bd6ced317d9e33844ff77440945eb8c7055f58077b69248f9ca4e591cfb5be
View file https://github.com/simstudioai/sim/blob/8e65da90a954c7018acd97e7b27b8942041eb9a2/apps/sim/lib/mothership/tool-executor/executor.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10061/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10061/files#diff-a3bd6ced317d9e33844ff77440945eb8c7055f58077b69248f9ca4e591cfb5be
https://github.com/simstudioai/sim/pull/10061/files#diff-a3bd6ced317d9e33844ff77440945eb8c7055f58077b69248f9ca4e591cfb5be
apps/sim/lib/mothership/tool-executor/executor.tshttps://github.com/simstudioai/sim/pull/10061/files#diff-93e846b3df8162e58a726167ae263827cab848376270a73b9dc882dc09757c35
View file https://github.com/simstudioai/sim/blob/8e65da90a954c7018acd97e7b27b8942041eb9a2/apps/sim/lib/mothership/tool-executor/executor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10061/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10061/files#diff-93e846b3df8162e58a726167ae263827cab848376270a73b9dc882dc09757c35
https://github.com/simstudioai/sim/pull/10061/files#diff-93e846b3df8162e58a726167ae263827cab848376270a73b9dc882dc09757c35
apps/sim/lib/mothership/tools/registry/server-tool-adapter.tshttps://github.com/simstudioai/sim/pull/10061/files#diff-c55494f51a63024bfe508a8804e4cef57158cbdbbc6ea47b02c70597a732dc65
View file https://github.com/simstudioai/sim/blob/8e65da90a954c7018acd97e7b27b8942041eb9a2/apps/sim/lib/mothership/tools/registry/server-tool-adapter.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10061/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10061/files#diff-c55494f51a63024bfe508a8804e4cef57158cbdbbc6ea47b02c70597a732dc65
https://github.com/simstudioai/sim/pull/10061/files#diff-c55494f51a63024bfe508a8804e4cef57158cbdbbc6ea47b02c70597a732dc65
https://github.com/simstudioai/sim/pull/10061/files#diff-c55494f51a63024bfe508a8804e4cef57158cbdbbc6ea47b02c70597a732dc65
https://github.com/simstudioai/sim/pull/10061/files#diff-c55494f51a63024bfe508a8804e4cef57158cbdbbc6ea47b02c70597a732dc65
apps/sim/lib/mothership/tools/server/changelog.tshttps://github.com/simstudioai/sim/pull/10061/files#diff-27a38d1303dbfd1e4c40c7da732fd8e54a788e7d9b5c1f33cc247f516ffe9f69
View file https://github.com/simstudioai/sim/blob/8e65da90a954c7018acd97e7b27b8942041eb9a2/apps/sim/lib/mothership/tools/server/changelog.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10061/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10061/files#diff-27a38d1303dbfd1e4c40c7da732fd8e54a788e7d9b5c1f33cc247f516ffe9f69
https://github.com/simstudioai/sim/pull/10061/files#diff-27a38d1303dbfd1e4c40c7da732fd8e54a788e7d9b5c1f33cc247f516ffe9f69
Please reload this pagehttps://github.com/simstudioai/sim/pull/10061/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.