René's URL Explorer Experiment


Title: fix(sso): refuse SSO callback user writes outside the provider's verified domain by waleedlatif1 · Pull Request #10060 · simstudioai/sim · GitHub

Open Graph Title: fix(sso): refuse SSO callback user writes outside the provider's verified domain by waleedlatif1 · Pull Request #10060 · simstudioai/sim

X Title: fix(sso): refuse SSO callback user writes outside the provider's verified domain by waleedlatif1 · Pull Request #10060 · simstudioai/sim

Description: Summary Better Auth checks an SSO provider's domain only when linking an existing account; just-in-time creation (and overrideUserInfo updates) wrote whatever email the IdP asserted, and Sim's domain check in the admission after-hook ran only once the row was committed databaseHooks.user.create.before / update.before now refuse an SSO callback write unless the provider's domain is verified and the email belongs to it, so the row is never written The provider lookup goes through Better Auth's transaction adapter (getCurrentAdapter), and the refusal carries sso_provisioning_failed as both message and code so create and update both redirect to the SSO page isEmailInSSODomain in @sim/utils/sso-domain is shared with the admission use case so both checks use the same canonical comparison Type of Change Bug fix Testing New lib/auth/sso/callback-email-domain.integration.ts: real OIDC sign-in through auth.handler against PostgreSQL with a local IdP — out-of-domain create refused (no user/account), in-domain create still succeeds, overrideUserInfo cannot rewrite a linked user's email Red→green: removing the create hook, the update hook, or the error code each fails its test Existing integration suites pass: admit-sso-user, lifecycle-audit, provider-concurrency, primary-provider Unit: lib/auth, app/api/auth, ee/sso (733 tests), packages/utils sso-domain biome, check:comment-hygiene, file-names, source-conventions, test-patterns, utils, boundaries, explicit-any, source-text Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Better Auth checks an SSO provider's domain only when linking an existing account; just-in-time creation (and overrideUserInfo updates) wrote whatever email the IdP asserted, and Sim&#...

X Description: Summary Better Auth checks an SSO provider's domain only when linking an existing account; just-in-time creation (and overrideUserInfo updates) wrote whatever email the IdP asserted, and S...

Opengraph URL: https://github.com/simstudioai/sim/pull/10060

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:446fae49-33cb-ac36-60ba-b9f0e753223c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9A3E:1CE55B:B4E5:F4BD:6AFB641C
html-safe-nonce6b869252293b30e26293b25c71232a59fdd01dae4e43223206a9313758e5664f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTNFOjFDRTU1QjpCNEU1OkY0QkQ6NkFGQjY0MUMiLCJ2aXNpdG9yX2lkIjoiNjc2NTYxNTM4MjMxNTI2NDI4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac553839d199bb6ee904167ad175d25c8bce7bb1a2197003abdeacfd35fb2fee16
hovercard-subject-tagpull_request:5316740023
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/10060/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Better Auth checks an SSO provider's domain only when linking an existing account; just-in-time creation (and overrideUserInfo updates) wrote whatever email the IdP asserted, and Sim&#...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/10060/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10060%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10060%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/10060/files
Reloadhttps://github.com/simstudioai/sim/pull/10060/files
Reloadhttps://github.com/simstudioai/sim/pull/10060/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/sso-jit-domain-gatehttps://github.com/simstudioai/sim/tree/fix/sso-jit-domain-gate
Conversation 10 https://github.com/simstudioai/sim/pull/10060
Commits 2 https://github.com/simstudioai/sim/pull/10060/commits
Checks 92 https://github.com/simstudioai/sim/pull/10060/checks
Files changed https://github.com/simstudioai/sim/pull/10060/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10060/files
fix(sso): refuse SSO callback user writes outside the provider's verified domain https://github.com/simstudioai/sim/pull/10060/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/10060/files
c8d4982 fix(sso): refuse SSO callback user writes outside the provider's veri… waleedlatif1 Nov 14, 2026 https://github.com/simstudioai/sim/pull/10060/commits/c8d4982f37e2a2f3e6fa015470b7bd29387e24d2
1f218e7 fix(sso): read the mailbox domain after the last @ when matching an S… waleedlatif1 Nov 14, 2026 https://github.com/simstudioai/sim/pull/10060/commits/1f218e794874fdc6eba197e971aca0faedcbe75c
Clear filters https://github.com/simstudioai/sim/pull/10060/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10060/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10060/files
auth.ts https://github.com/simstudioai/sim/pull/10060/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
constants.ts https://github.com/simstudioai/sim/pull/10060/files#diff-389891c87e220468c74927655483f910e0724387899fb316f05a5be1fd1bace2
admit-sso-user.ts https://github.com/simstudioai/sim/pull/10060/files#diff-ba6ce3c71fc728f66328733dea692363ae9ea2529a2ab4026ed82730386b3dde
callback-email-domain.integration.ts https://github.com/simstudioai/sim/pull/10060/files#diff-30d9c25adadd67d7b096b32f6ffef06b16c7fa1206e89638466e3b43a29f7ced
callback-email-domain.ts https://github.com/simstudioai/sim/pull/10060/files#diff-f31a756463d2b1df273bd518ef162b5a7b59ad21c9c756d10157f993311d576d
sso-domain.test.ts https://github.com/simstudioai/sim/pull/10060/files#diff-49b1e0ab97ec509cc3e2b4d693f1d3edf72b1bc50fdbab162eb29a0f3a24ce47
sso-domain.ts https://github.com/simstudioai/sim/pull/10060/files#diff-299bf2052b01710bb27ad1544aa8602a27742a2ffbd7cfe90999c7024407cd9a
apps/sim/lib/auth/auth.tshttps://github.com/simstudioai/sim/pull/10060/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
View file https://github.com/simstudioai/sim/blob/1f218e794874fdc6eba197e971aca0faedcbe75c/apps/sim/lib/auth/auth.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10060/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10060/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/10060/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/10060/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/10060/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/10060/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/10060/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
apps/sim/lib/auth/constants.tshttps://github.com/simstudioai/sim/pull/10060/files#diff-389891c87e220468c74927655483f910e0724387899fb316f05a5be1fd1bace2
View file https://github.com/simstudioai/sim/blob/1f218e794874fdc6eba197e971aca0faedcbe75c/apps/sim/lib/auth/constants.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10060/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10060/files#diff-389891c87e220468c74927655483f910e0724387899fb316f05a5be1fd1bace2
https://github.com/simstudioai/sim/pull/10060/files#diff-389891c87e220468c74927655483f910e0724387899fb316f05a5be1fd1bace2
apps/sim/lib/auth/sso/application/admit-sso-user.tshttps://github.com/simstudioai/sim/pull/10060/files#diff-ba6ce3c71fc728f66328733dea692363ae9ea2529a2ab4026ed82730386b3dde
View file https://github.com/simstudioai/sim/blob/1f218e794874fdc6eba197e971aca0faedcbe75c/apps/sim/lib/auth/sso/application/admit-sso-user.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10060/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10060/files#diff-ba6ce3c71fc728f66328733dea692363ae9ea2529a2ab4026ed82730386b3dde
https://github.com/simstudioai/sim/pull/10060/files#diff-ba6ce3c71fc728f66328733dea692363ae9ea2529a2ab4026ed82730386b3dde
https://github.com/simstudioai/sim/pull/10060/files#diff-ba6ce3c71fc728f66328733dea692363ae9ea2529a2ab4026ed82730386b3dde
https://github.com/simstudioai/sim/pull/10060/files#diff-ba6ce3c71fc728f66328733dea692363ae9ea2529a2ab4026ed82730386b3dde
apps/sim/lib/auth/sso/callback-email-domain.integration.tshttps://github.com/simstudioai/sim/pull/10060/files#diff-30d9c25adadd67d7b096b32f6ffef06b16c7fa1206e89638466e3b43a29f7ced
View file https://github.com/simstudioai/sim/blob/1f218e794874fdc6eba197e971aca0faedcbe75c/apps/sim/lib/auth/sso/callback-email-domain.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10060/{{ revealButtonHref }}
apps/sim/lib/auth/sso/callback-email-domain.tshttps://github.com/simstudioai/sim/pull/10060/files#diff-f31a756463d2b1df273bd518ef162b5a7b59ad21c9c756d10157f993311d576d
View file https://github.com/simstudioai/sim/blob/1f218e794874fdc6eba197e971aca0faedcbe75c/apps/sim/lib/auth/sso/callback-email-domain.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10060/{{ revealButtonHref }}
packages/utils/src/sso-domain.test.tshttps://github.com/simstudioai/sim/pull/10060/files#diff-49b1e0ab97ec509cc3e2b4d693f1d3edf72b1bc50fdbab162eb29a0f3a24ce47
View file https://github.com/simstudioai/sim/blob/1f218e794874fdc6eba197e971aca0faedcbe75c/packages/utils/src/sso-domain.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10060/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10060/files#diff-49b1e0ab97ec509cc3e2b4d693f1d3edf72b1bc50fdbab162eb29a0f3a24ce47
packages/utils/src/sso-domain.tshttps://github.com/simstudioai/sim/pull/10060/files#diff-299bf2052b01710bb27ad1544aa8602a27742a2ffbd7cfe90999c7024407cd9a
View file https://github.com/simstudioai/sim/blob/1f218e794874fdc6eba197e971aca0faedcbe75c/packages/utils/src/sso-domain.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10060/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10060/files#diff-299bf2052b01710bb27ad1544aa8602a27742a2ffbd7cfe90999c7024407cd9a
Please reload this pagehttps://github.com/simstudioai/sim/pull/10060/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10060/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.